Charcoal HQ

5:00 PM

[ SmokeDetector | MS ] Few unique characters in body, no whitespace in body: asdfdsfsdfsdfsdfsdfsdfsdfsdfsdfsdfsdfsdf by darren sim on stackoverflow.com (@dorukayhan)

Glorfindel

@SmokeDetector v

SmokeDetector

5:10 PM

[ SmokeDetector | MS ] Blacklisted website in answer: How to mention that a specific time is already over? by Scarlet Kleen on ell.stackexchange.com

Glorfindel

@SmokeDetector k

Thomas Ward

!!/rev

SmokeDetector

@ThomasWard 1511719 (Thomas Ward: Remove the 'join' for blacklist item)

Thomas Ward

!!/blacklist-keyword This is a test of the Emergency Broadcast System.

SmokeDetector

@ThomasWard Blacklisted

Thomas Ward

5:21 PM

wtf really

SmokeDetector

CI on 7c507f6 succeeded. Message contains 'autopull', pulling...

[ SmokeDetector ] SmokeDetector started at rev 31089d1 (Thomas Ward: Revert "Auto blacklist of by Thomas Ward --autopull") (running on Undo's EC2)

Thomas Ward

okay i'm tired of this, it looks like changing the blacklist system structure breaks things o.O

SmokeDetector

Restart: API quota is 4418.

Glorfindel

@SmokeDetector f

Thomas Ward

okay so there will be more restarts, because apparently I am derping with code stuff.

(E: Not Enough Coffee)

SmokeDetector

5:25 PM

CI on 61bf830 succeeded.

Glorfindel

!!/coffee

SmokeDetector

@Glorfindel brews coffee for @Glorfindel

Thomas Ward

!!/pull

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 61bf830 (Thomas Ward: Update payload to not have the joins anymore.) (running on Undo's EC2)

Restart: API quota is 4397.

Thomas Ward

WORK DAMN YOU OR I WILL STRIP YOU OF YOUR CODE AND THEN BURN YOUR BYTES INTO NOTHING

>.>

!!/blacklist-keyword This is a test of the Emergency Broadcast System.

SmokeDetector

5:26 PM

@ThomasWard Blacklisted

Thomas Ward

WTF okay i'm pissed now

Jan Dvorak

@ThomasWard Can we have a Will it Burn video of that?

Undo

heh, take a break if it's becoming work :)

Thomas Ward

@Undo well, here's the thing, it's not sending the payload over right

SmokeDetector

CI on 3bb1418 succeeded. Message contains 'autopull', pulling...

[ SmokeDetector ] SmokeDetector started at rev ae2fb4a (Thomas Ward: Revert "Auto blacklist of by Thomas Ward --autopull") (running on Undo's EC2)

Restart: API quota is 4383.

Thomas Ward

5:27 PM

it's sending an empty payload, so either it's not parsing args right, or something else is wonky

well there's the problem

I refactored code

but fatfingered an argument being passed to git handlers

someone shoot me please.

SmokeDetector

[ SmokeDetector | MS ] Link at end of answer: Is there any way of achieving cross-application non-destructive RAW editing? (Maybe xmp files?) by user60046 on photo.stackexchange.com

Thomas Ward

i feel silly since i should have caught this first >.>

SmokeDetector

CI on 966aa4c succeeded.

Thomas Ward

!!/pull

Andy

Might I suggest a test case get added so that we can check for this in the future too

SmokeDetector

5:30 PM

[ SmokeDetector ] SmokeDetector started at rev 966aa4c (Thomas Ward: Actually use correct arguments for passing to GitManager) (running on Undo's EC2)

Restart: API quota is 4362.

Thomas Ward

i can add a test code into gitmanager, set the default for the getArgs to "None" as it should be, and if it's "None" throw a "CODE ERROR: Nothing to blacklist!" response

i have a handful of such test cases in gitmanager already

for coding screwups

(error checking 101: always make sure to catch stupid mistakes)

SmokeDetector

CI on 3b3b3ab succeeded.

Thomas Ward

!!/pull

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 3b3b3ab (Thomas Ward: Sanity Checks for GitManager arguments) (running on Undo's EC2)

Restart: API quota is 4322.

[ SmokeDetector | MS ] Link at end of answer: Serial port reading using Command Prompt BATCH by AKLAIN on stackoverflow.com (@dorukayhan)

Thomas Ward

@JanDvorak lol

!!/blacklist-keyword This is a test of the Emergency Broadcast System

please work?

i think it died

!!/alive

SmokeDetector

5:37 PM

@ThomasWard Of course

Thomas Ward

o.O

Undo

!!/errorlogs 100

SmokeDetector

  File "/home/ubuntu/SmokeDetector/ChatExchange/chatexchange/browser.py", line 224, in _load_user
    user_id, user_name = self.user_id_and_name_from_link(user_link_soup)

  File "/home/ubuntu/SmokeDetector/ChatExchange/chatexchange/browser.py", line 232, in user_id_and_name_from_link
    user_id = int(link_soup['href'].split('/')[-2])


ZeroDivisionError: integer division or modulo by zero
2017-01-16 01:00:25.535700 UTC
  File "/home/ubuntu/SmokeDetector/excepthook.py", line 47, in run_with_except_hook

Andy

buwahahahaha. Sarcastic Smokey is learning on it's own.

2

Thomas Ward

I thought I removed that code already what the heck

Undo

5:38 PM

@ThomasWard ^ Last error there. Also, my timestamps are all wrong.

Thomas Ward

@Undo yeah but that code doesn't exist in master or deploy anymore

or rather it shouldn't

checks git

Undo

Hold on, that was an hour ago

Wrong error

almost exactly an hour ago, which is why it threw me off

Magisch

@Undo @ArtOfCode if (when) you guys make a big meta post about autoflagging, and mention Metasmoke in it, you may want to disable the automatic giving of reviewer groups to everyone

I can see a whole lot of people signing up just because there's a button for it on the dashboard

Thomas Ward

@Undo yeah, i'm confused on what happened, can you see why smokey did nothing?

Undo

heck, just disable signup for a while

that'd be easier

Magisch

5:40 PM

or remove the button

on the dashboard

Undo

Or that, yeah

@ThomasWard Not sure, let me review some code

Magisch

may sound elitist but I don't think like 100 flyby signups would be good for our project at all

Thomas Ward

@Undo thanks, it's odd that it did nothing when I called the command, so unless I totally broke it... shrugs

Undo

@SmokeDetector Huh, looks like homepage bumps also trigger Smokey scans. Good to know.

@SmokeDetector f

ArtOfCode

@Magisch On the other hand, what harm would a bunch of new users do? Might get a few more invalid feedbacks, but we have admin invalidations and user ignores for a reason.

Which reminds me, I should start writing that post

Undo

5:45 PM

I don't want to post that before running it past SE, by the way

Not yet, anyway

Magisch

@ArtOfCode Right now we have kind of a "we're few people and everybody who's here has a very good idea what they're doing and very low invalidation rates, so the risk is very low"

Thomas Ward

back in a moment

Magisch

thing going to alleviate the people accusing us of being a draconic voting ring

ArtOfCode

@Undo Yeah, of course. I'm just thinking it's gonna take a while to write properly, so I may as well start.

Undo

!!/blacklist-keyword This is a test of the Emergency Broadcast System

SmokeDetector

5:46 PM

@Undo Blacklisted This is a test of the Emergency Broadcast System

Undo

seems to be working

!!/blacklist-website This is a test website

SmokeDetector

@Undo Blacklisted This is a test website

CI on 8d9bb40 succeeded. Message contains 'autopull', pulling...

Undo

!!/blacklist-username this is a test username

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev f39500f (SmokeDetector: Auto blacklist of This is a test website by Undo --autopull) (running on Undo's EC2)

Restart: API quota is 4236.

Undo

!!/blacklist-username this is a test username

SmokeDetector

5:48 PM

@Undo Blacklisted this is a test username

Undo

@ThomasWard I have no idea what I did, but it works now

I'm reverting

SmokeDetector

CI on 081b5ba succeeded. Message contains 'autopull', pulling...

[ SmokeDetector ] SmokeDetector started at rev 081b5ba (SmokeDetector: Auto blacklist of this is a test username by Undo --autopull) (running on Undo's EC2)

Restart: API quota is 4226.

Thomas Ward

@Undo test keyword as well

they should all work, Keyword wasn't working

oh hey it's weird

maybe i issued the command before it synced shrugs

Undo

Something like that

Thomas Ward

well, it's working

so I don't have to beat myself :P

that was an interesting little mini hackathon for me :P

and showed me that I really need more coffee

SmokeDetector

5:51 PM

CI on f9bec13 succeeded. Message contains 'autopull', pulling...

[ SmokeDetector ] SmokeDetector started at rev f9bec13 (Undo1: Revert blacklist tests --autopull) (running on Undo's EC2)

Thomas Ward

well, it's working, so I guess all is good.

SmokeDetector

Restart: API quota is 4207.

Undo

yep

dorukayhan

!!/coffee

SmokeDetector

@dorukayhan brews coffee for @dorukayhan

dorukayhan

5:52 PM

@ThomasWard hands the coffee here you have it

Thomas Ward

@Undo i did add a sanity check into the gitmanager - it'll check for things like whether the blacklist type is defined, or if a pattern is defined, and if not fail gracefully

so there's that.

Mithrandir

I've discovered why you are having problems with Smokey :P

Thomas Ward

heh

@Undo we've changed the structure of the blacklist commands, we should probably update the wiki to remove the multiple-regex documentation

(updated the commands wiki page)

SmokeDetector

[ SmokeDetector | MS ] Bad keyword in link text in answer: WIndows7 - suddenly hibernation stop working by user686952 on superuser.com

fp- by Glorfindel

Undo

0

A: Changing a smoke detector battery with a too-short ladder

If you could search for this product on your neighborhood, it would be great that you can borrow it for this purpose. I would suggest you purchase a similar one and keep it in store as you will have to face this problem frequently for other smoke detectors. If your smoke detectors are at the cen...

this answer is terrifying

Mithrandir

6:03 PM

@Undo I'm glad I led you to it. :P

Andy

6:28 PM

@Undo, was there a graph made showing API usage? I seem to recall it being discussed but I don't see such a graph on the MS graphs page.

Every time I see a lifehacks answer linked in a chat room I wonder why the site isn't named "Death Traps"

2

Glorfindel

6:40 PM

@Andy the site should have a permanent banner "don't try this at home".

SmokeDetector

6:57 PM

[ SmokeDetector | MS ] Link at end of answer: Is there any way of achieving cross-application non-destructive RAW editing? (Maybe xmp files?) by user60046 on photo.stackexchange.com

[ SmokeDetector | MS ] Bad keyword in body: ,TOEIC,TOEFL,SAT,GRE Certificates by user67853 on academia.stackexchange.com

ArtOfCode

@Andy metasmoke.charcoal-se.org/smoke_detector/1/statistics

SmokeDetector

7:22 PM

[ SmokeDetector | MS ] Few unique characters in answer, no whitespace in answer, repeating characters in answer: How did "little tsu" become a lengthener? by Nsndjfj on japanese.stackexchange.com

tpu- by Glorfindel

ArtOfCode

7:36 PM

Here's an amusing (potentially NSFW) photoshop job someone sent me today.

Thomas Ward

lol

Magisch

lel

SmokeDetector

7:56 PM

[ SmokeDetector | MS ] Offensive answer detected: What programming language is Stuxnet written in? by Jim on security.stackexchange.com

tpu- by Glorfindel

SmokeDetector

8:11 PM

[ SmokeDetector | MS ] Shortened URL in answer: How to change the colour of row in jquery mobile by a deleted user on stackoverflow.com (@dorukayhan)

naa- by Floern

Undo

8:33 PM

We scan ~100k posts per day

sd f

arda

@ArtOfCode 10/10

Thomas Ward

nice

@Undo still want Smokey on your infra, or do you want me to toss it back up onto Aurora?

Undo

8:49 PM

I'll keep it for now

Thomas Ward

cool, just gonna check every so often :)

goes back to poking servers

jesus some packages take an eternity to install...

SmokeDetector

9:22 PM

CI on 8fa2af5 failed.

Thomas Ward

something about the flake tests

and of course I'll wait an eternity for them to show up

stupid style, and of course I have that shut off because line ending problems

SmokeDetector

CI on 25b8eaf failed.

Thomas Ward

WHY

grrrr

stupid flake8

@ArtOfCode @Undo if we're running flake8 for style checks we should start considering following PEP8 with a 120-line-length limit

or 100-char line length limit

and then actually follow PEP8.

assuming we can agree on an upper bound value

(I use 100 or 120 depending on project/systems)

SmokeDetector

CI on 78b5f46 succeeded.

Thomas Ward

thank you finally

Undo

9:36 PM

@ThomasWard Yeah, we decided a long time ago that it's a little onerous

Thomas Ward

!!/pull

Undo

I'd be happy to revisit it, though

Thomas Ward

@Undo well, PEP8 says 80

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 78b5f46 (Thomas Ward: Fix flake8 tests (again)) (running on Undo's EC2)

Restart: API quota is 2665.

Thomas Ward

but it allows the team to decide a different upper length

ArtOfCode

9:37 PM

@ThomasWard Is that not what flake8 enforces? And if not, what does it enforce?

Thomas Ward

even if we go with 200 as our upper line length, so long as we're all OK with that length PEP8 accepts (though it discourages > 120)

@ArtOfCode currently? enforcing the rest of pep8 style such as blank lines, etc. but not line length restricts

otherwise it'd blow up on many of the lines in chatcommands.py and others

because they're far longer than the char limit

Undo

@ArtOfCode We've disabled it.

Thomas Ward

that too

@Undo we can leave it disabled in flake8 if we really care about it

ArtOfCode

120 is a sane maximum. 80 is just far too restrictive, but more than 120 is impractical for people with SxS windows.

Thomas Ward

i'm more concerned about the rest of the style world

@ArtOfCode This is also my logic

ArtOfCode

9:38 PM

Speaking of Python, I should really do that coursework...

Undo

Python coursework? You ought to be able to do that easy enough

Yeah, it's flake's E501 we've disabled

Been like that since two years ago

Thomas Ward

if we're OK with a line length of 120, and not making it flake8 enforced (so that I can just get my IDE to stop bitching, but capture the rest of the style guidelines we enforce on) then I can do that refactor. And then just fix 120-char-limit as we go along when I fuss with things

i could care less about line length in the build testing

i care about failing to capture stupid style errors like the last two fails I had because I have to disable the inspection on my end to not see a wall of white notification icons

Undo

If we're going to do it, let's go all in

ArtOfCode

@Undo oh, yeah. First year of this course is the "get everyone up to speed" year. Also known as the year in which I can do a minimum of work and get top marks.

Thomas Ward

who all makes the call? you two, or is it more a group collective decision

Undo

9:42 PM

It's easier to stay under 120 lines when you're writing code than when you're looking at code someone else wrote later

just a sec, doing some research

Thomas Ward

no rush, i just wanted the rest of the inspections I really don't care about to go away hence the mini flood of comments

OH by the way did you know the md5 module is deprecated

(there's a new TODO item in there about it)

the proper suggestion is hashlib.md5 nowadays

Undo

@ThomasWard That's just used to obfuscate my name, it's not critical.

ArtOfCode

@ThomasWard most decisions around here are made by some group of people having a discussion, one of them pinging Undo or me, Undo or me telling them that the fire extinguisher isn't locked and that their idea sounds sane, and then it happens.

Thomas Ward

@Undo ACK, but we use it so :P

mind if I refactor to use hashlib.md5 instead?

Undo

Sure, if you're wanting to

Okay, so there are 297 instances of line length >120. That's... a lot.

ArtOfCode

9:44 PM

@ThomasWard Is the API the same? If it is, s/import md5/import hashlib.md5 as md5/

Thomas Ward

@Undo Yes. It is.

@ArtOfCode It's similar, but i'm not doing the change over until i know it would work.

ArtOfCode

@Undo considering how big Smokey is, that's nothing we can't handle. I can do some of 'em tonight

Thomas Ward

it's not identical

Undo

@ArtOfCode yeah, splitting it among a bunch of people should work fine

We'll touch every file, but I don't think we have any outstanding pull requests to worry about conflicting

ArtOfCode

@Undo how did you get that number?

Undo

9:46 PM

Changed tox.ini to:

  1 [flake8]
  2 ignore = F403,E402,F405,N804
  3 exclude = ChatExchange/*,.idea/*,.git/*
  4 max-line-length = 120

(ignore vim line numbers)

Thomas Ward

I can do the line length changes my side if you care or want me to

Undo

And ran flake8 | wc -l

@ThomasWard I can help. It's a noble cause.

Thomas Ward

cool. I'll enable my inspection again. (I call chatcommands.py though xD)

should we have a line length refactor specific branch or is Master OK?

Undo

@ThomasWard Master's okay

Just be careful to not break stuff

I'm taking the stragglers in ws.py first, probably parsing and metasmoke after that

120, right?

Thomas Ward

yep, at most.

@Undo FWIW, one line change for hashlib.md5 vs. the standard md5 library

Undo

9:49 PM

great

SmokeDetector

CI on 8302a66 succeeded.

Thomas Ward

instead of md5.new(commit_author).hexdigest() it's just md5(commit_author).hexdigest() (with the obligatory from hashlib import md5 in place of import md5 above)

ArtOfCode

Also, this dark theme for GH is awesome.

Thomas Ward

>>> import md5
>>> md5.new('ThomasWard').hexdigest()
'3c607525000b6d09255cd5ddbd1a21a2'

^-- old ||| new --v

>>> from hashlib import md5
>>> md5('ThomasWard').hexdigest()
'3c607525000b6d09255cd5ddbd1a21a2'

ArtOfCode

likewise this one for SE chat

Thomas Ward

9:52 PM

pretty much a drop in replacement.

!!/pull

SmokeDetector

@ThomasWard CI build is still pending, wait until the build has finished and then pull again.

Undo

oh gosh, parsing has a bunch of giant regexes

SmokeDetector

[ SmokeDetector | MS ] Link at end of answer: What software can correct pronunciation? by Alex Loube on chinese.stackexchange.com

Thomas Ward

oh

SmokeDetector

CI on 336944f succeeded.

Thomas Ward

9:52 PM

@Undo yes it does

SmokeDetector

CI on b843665 succeeded.

Thomas Ward

chatcommands.py should be done now

SmokeDetector

CI on b242440 succeeded.

Undo

Four-space indents are killing me in metasmoke.py

Maybe it needs to be flatter anyway :P

Thomas Ward

I'mma look at gitmanager now

ArtOfCode

10:02 PM

I'll take findspam

Thomas Ward

we also should probably move the import statements to the top at some of these modules, but that's after-line-length cleanup

(PEP8 complaints on that too)

gitmanager is done

@Undo which are you working on now?

quartata

Is this spring cleaning? :P

SmokeDetector

CI on cfe9ef2 succeeded.

Thomas Ward

@quartata PEP8 line character length enforcement (at 120 chars) cleanup time

I got tired of all the PEP8 issues and started complaining

so we're going through and fixing that

@quartata but yes, spring style cleanup time

can I work on spamhandling?

or is that already on someone's radar

spamhandling.py should be done

SmokeDetector

CI on a2917e9 failed.

Thomas Ward

10:09 PM

wat

what did i do this time

SmokeDetector

CI on 092afba failed.

Thomas Ward

oh that's fixed in my latest commit :)

SmokeDetector

CI on 2cd7c3a succeeded.

arda

neato

Thomas Ward

@ArtOfCode spamhandling.py is now completely non-complaining and line length limited

I think @Undo was working on metasmoke.py?

and you're on findspam.py?

@Undo Fun fact is indentation doesn't have to always line up in every single case, there are cases where it can just wrap to the next line. (IDEs help xD)

ArtOfCode

10:18 PM

PyCharm pro is awesome at code inspections

Thomas Ward

@ArtOfCode guess what I have :)

I have PyCharm Pro.

for $0

for the past two years.

and good up through next year (January) too.

so useful

@ArtOfCode it doesn't have a code inspection for a line break before a binary operator, but that's less of an issue than one might think

now, the only two inspections (other than spell check) that I turn off are whether encoding is defined for every file, and missing/empty docstring warnings.

PEP8 is otherwise being enforced, except for ws.py, because we have fragile code imports there so we don't have all the imports at the beginning.

but i never open that thing 'cause it never really breaks, so I don't have to worry about that file so much

the only thing i opened it for today, otehr than my PEP8 complaining, was to put the rest of the inspection suppressions in.

Which, of course, nobody cares about (they're just comments lol)

ArtOfCode

@ThomasWard likewise. I'm a student, remember

Thomas Ward

indeed

is it just me or is this something we should have done an eternity ago, trimming down line lengths :p

Undo

@ThomasWard Aye

Thomas Ward

@Undo mind if I stab parsing?

wheeee, that should fix PEP8 line length for parsing...

and parsing should now be handled, too. :)

Undo

10:30 PM

Sure

Thomas Ward

so i'm just gonna sit back and relax, and grab something to eat 'cause I'm hungry

(back in a bit)

SmokeDetector

CI on a892a06 succeeded.

CI on 69a6757 succeeded.

Undo

!!/pull

SmokeDetector

[ SmokeDetector ] SmokeDetector started at rev 69a6757 (Undo1: Bring metasmoke line length to under 120) (running on Undo's EC2)

Restart: API quota is 2307.

foo

Undo

Welp, I didn't completely break the metasmoke code

Status pings working okay

Thomas Ward

10:36 PM

something broke

did it?

Undo

@ThomasWard Where?

Thomas Ward

oh wow I just read the page fast nevermind

i saw a restart after a command, thought it blew up

the only thing i won't touch PEP8-wise is ws.py's fragile imports

because PEP8 (not flake8) is actually complaining about the imports not being at the top

but that's not something i care about as much

(line length is more important heh)

!!/alive

SmokeDetector

@ThomasWard Of course

Thomas Ward

!!/gitstatus

SmokeDetector

On branch deploy
Your branch is up-to-date with 'origin/deploy'.
nothing to commit, working directory clean

Thomas Ward

10:39 PM

hopefully you don't mind me throwing a wrench into everything by being picky about pep8 :)

Undo

nah, big refactors are good. There's some chance of seeing something stupid we're doing in some obscure place.

Thomas Ward

yup

but yeah, replacing md5 with hashlib.md5 was quick and painless for the most part

just gotta remember to not fubar the rest when coding :)

@Undo Probably also helps splitting up the work a bit too

so everyone does a little bit

Look at that massive spike in this week's commit count! We've been busy :)

(we were probably due for a huge refactor anyways for some things)

Undo

I'm taking datahandling

SmokeDetector

CI on 086264f succeeded.

Thomas Ward

i'll take apigetpost

and that's done :P

Undo

10:48 PM

Taking bodyfetcher

SmokeDetector

CI on 95d0854 succeeded.

CI on ffde671 succeeded.

CI on 1262b5a succeeded.

ArtOfCode

Man there are a lot of PEP8 things in findspam

Thomas Ward

there's really not much else left but findspam.py

@ArtOfCode yes, there are

SmokeDetector

CI on 7a15942 succeeded.

Thomas Ward

oh, @Undo, I did push another IDE suppression into metasmoke.py something about a potentially uninitialized variable being called

it works so i'm not changing code :)

Undo

10:51 PM

kk

Thomas Ward

if it works and hasn't died yet, it gets a suppress. Otherwise, I don't worry about it :)

Transcript for