Stack Exchange
log in
users (64)
rooms (48)
faq
Sjoerd Job Postmus
general
recent
conversations
The 2nd Monitor
General discussion about
codereview.stackexchange.com
- Welcom...
5
2
Sjoerd Job Postmus
Aug 2, 2016 20:06
ok. Agreed.
Sjoerd Job Postmus
Aug 2, 2016 20:04
@janos: more like, yes, it can parse a file. But... it's not code he would(should?) write in real software, because the "field_a" means nothing.
Sjoerd Job Postmus
Aug 2, 2016 19:53
@janos: if he fixed the "not working" part, it is still somewhat "hypothetical" (fieldnames make no sense). Should that also be fixed before opening?
Sjoerd Job Postmus
Aug 2, 2016 19:49
@N3buchadnezzar: unsure, but I hear a lot of positive talk about numpy and pandas. Haven't used them though.
Sjoerd Job Postmus
Aug 2, 2016 19:48
@janos. Thanks :).
Sjoerd Job Postmus
Aug 2, 2016 19:38
On the other hand, there are some tips I would like to give for that piece of code.
Sjoerd Job Postmus
Aug 2, 2016 19:37
I'm looking at
codereview.stackexchange.com/questions/136699/…
, and I'm not sure what to do. The code seems hypothetical, and I'm quite certain it won't run.
Sjoerd Job Postmus
Apr 2, 2016 00:12
Well, adding examples is one of the things I was happy about.
Sjoerd Job Postmus
Apr 2, 2016 00:11
Yes, I'm happy with the 2k.
Sjoerd Job Postmus
Apr 2, 2016 00:11
(yes, reviews in progess, is what I meant)
Sjoerd Job Postmus
Apr 2, 2016 00:11
Good point, because yes, it does mess up reviews.
Sjoerd Job Postmus
Apr 2, 2016 00:10
Sure, not altered
after
an answer is posted.
Sjoerd Job Postmus
Apr 2, 2016 00:09
? How do you mean, should not be happening?
Sjoerd Job Postmus
Apr 2, 2016 00:08
So it's not like they purposefully changed things after my review.
Sjoerd Job Postmus
Apr 2, 2016 00:08
(or she, btw)
Sjoerd Job Postmus
Apr 2, 2016 00:08
But he made a lot of changes
while
I was reviewing.
Sjoerd Job Postmus
Apr 2, 2016 00:07
I was reviewing revision 4
Sjoerd Job Postmus
Apr 2, 2016 00:03
I thought of a few edge-cases during writing my review. I'll add them as an appendix.
Sjoerd Job Postmus
Apr 2, 2016 00:02
Ok, got it.
Sjoerd Job Postmus
Apr 2, 2016 00:01
It provides an output, and the user probably thinks it is correct.
Sjoerd Job Postmus
Apr 2, 2016 00:01
@Quill
Sjoerd Job Postmus
Apr 2, 2016 00:00
@Edward: That makes sense. Yes, the user thought it works.
Sjoerd Job Postmus
Apr 2, 2016 00:00
It's not 'does not compile'-broken.
Sjoerd Job Postmus
Apr 2, 2016 00:00
Sorry, 'is incorrect'.
Sjoerd Job Postmus
Apr 1, 2016 23:59
does that fall into the 'off-topic' category? Normally I'd think 'yes', but in this case I'm leaning towards 'no'.
Sjoerd Job Postmus
Apr 1, 2016 23:59
the code as supplied by the user was incorrect...
Sjoerd Job Postmus
Apr 1, 2016 23:58
Hi :). Just a question about
codereview.stackexchange.com/questions/124510/…