Charcoal HQ

micsthepick

8:01 AM

count me as confused

!!/unnotify-all-

SmokeDetector

@micsthepick I hit an error while trying to run that command; run !!/errorlogs for details.

micsthepick

!!/errorlogs

SmokeDetector

File "/home/ubuntu/SmokeDetector/chatcommands.py", line 369, in blame2
except requests.excptions.HTTPError:

AttributeError: 'module' object has no attribute 'excptions'
2018-03-15 06:20:00.518555 UTC
File "/home/ubuntu/SmokeDetector/chatcommunicate.py", line 336, in f
result = func(*processed_args)

File "/home/ubuntu/SmokeDetector/chatcommands.py", line 369, in blame2
except requests.excptions.HTTPError:

TypeError: remove_from_notification_list() takes 4 positional arguments but 5 were given

M.A.R.

!!/report chemistry.stackexchange.com/questions/92366/standard-addition

SmokeDetector

[ SmokeDetector | MS ] Manually reported question: Standard Addition by Mychael on chemistry.SE

tpu- by K.Dᴀᴠɪs

micsthepick

8:05 AM

(rude)

K.Dᴀᴠɪs

they show up the same way to MS

micsthepick

@K.Dᴀᴠɪs pardon?

M.A.R.

@K.Dᴀᴠɪs your message seems to be in English

Oh

@K.Dᴀᴠɪs what shows up in what way?

K.Dᴀᴠɪs

tpu for rude and spam. MS doesn't differentiate between the two

FIRE has a button for each, not sure why they don't just combine them into one button tbh.. Edit: probably has something to do with the flagging of the post, so scratch that

micsthepick

I could deal with a button that said spam/rude

SmokeDetector

8:09 AM

[ SmokeDetector | MS ] Bad NS for domain in body, bad keyword in body, bad keyword in title, blacklisted website in body, link at end of body, +2 more: it is a rich property of protein and supplements by Dides19 Virk on superuser.com

tpu- by Glorfindel

M.A.R.

@K.Dᴀᴠɪs no

@K.Dᴀᴠɪs yeah

K.Dᴀᴠɪs

No what?

M.A.R.

FIRE only flags as spam IIRC

We were worried a spam flag on R/A would get declined

K.Dᴀᴠɪs

@M.A.R. Yes you do (recall correctly)... I am just saying that there are two buttons so when you click R/A in FIRE it doesn't cast a spam flag --- but to MS the two buttons have no different meaning

M.A.R.

Pops popped in and said it's OK

micsthepick

8:13 AM

so notification tuples in notifications in globalvars have a True added at the end, is that causing the issue with !!/unnotify-all?

I am 99% certain that's it

M.A.R.

@K.Dᴀᴠɪs that's broken

Shrug

Haven't used FIRE in quite some time

K.Dᴀᴠɪs

@M.A.R. well that's certainly a personal dilemma xD

SmokeDetector

[ SmokeDetector | MS ] URL in title, blacklisted website in body, blacklisted website in title, link following arrow in body, pattern-matching website in body, +3 more: growxlsite.com/cialin-rx by AindNeyer on puzzling.SE (@Mithrandir @micsthepick)

tpu- by K.Dᴀᴠɪs

M.A.R.

How else do you think you noobs beat me to the flag? :p

😋🙄

Magisch

@K.Dᴀᴠɪs FIRE Flags as spam on feedback "spam" too

So if you feedback rude via fire it wont so you can choose the appropriate flag yourself

K.Dᴀᴠɪs

8:16 AM

@Magisch Yes I know. I think there's some miscommunication right now xD

angussidney

@K.Dᴀᴠɪs because people complained

K.Dᴀᴠɪs

@angussidney Well........... That's why there should be a UI to check a box that says "Yes - Flag RA for me" :)

Similar to Advanced Flagging. Pretty customizable in that aspect

SmokeDetector

[ SmokeDetector | MS ] URL-only title, bad NS for domain in body, bad NS for domain in title, bad keyword in body, bad keyword in title, +5 more: www.nutritionfit.org/vidhigra/ by Dieve1939 on askubuntu.com

tpu- by K.Dᴀᴠɪs

micsthepick

@tripleee @angussidney I believe that I have fixed !!/unnotify-all: github.com/Charcoal-SE/SmokeDetector/pull/1748

M.A.R.

@SmokeDetector K

iBug

8:24 AM

@micsthepick I commented on that PR.

micsthepick

@iBug I saw your comment and made a reply

Glorfindel

@K.Dᴀᴠɪs you can probably use a simple Stylish rule to hide the 'rude' button.

SmokeDetector

[ SmokeDetector | MS ] URL in title, bad keyword in body, bad keyword in title, blacklisted website in body, blacklisted website in title, +4 more: www.revivalantiagingcream.com/levira-ageless-facial-serum/ by Rikazuzzz on puzzling.SE (@Mithrandir @micsthepick)

tpu- by Glorfindel

tpu- by K.Dᴀᴠɪs

Glorfindel

Puzzling should be bracing itself for a new spam wave ...

micsthepick

the amount of spam on puzzling lately is puzzling...

M.A.R.

8:26 AM

Why do you miserable people not want the great puzzling users to have better IQ and skin?

SmokeDetector

[ SmokeDetector | MS ] Bad NS for domain in body, bad keyword in body, bad keyword in title, blacklisted website in body, pattern-matching website in body: losing 10 pounds Keto Trim Diet never an easy undertaking. by ahstdhbta on apple.SE

tpu- by K.Dᴀᴠɪs

M.A.R.

@SmokeDetector K

SmokeDetector

[ SmokeDetector | MS ] Bad NS for domain in body, bad NS for domain in title, bad keyword in body, bad keyword in title, blacklisted website in body, +4 more: foreverhealthy786.com/keto-trim-diet/ by user280095 on apple.SE

tpu- by Glorfindel

Glorfindel

@SmokeDetector no pings for me in the two rooms I'd !!/notified. And no exceptions :)

!!/unnotify 38 apple.stackexchange.com-

SmokeDetector

@Glorfindel That configuration doesn't exist.

Glorfindel

8:30 AM

uh, what? Have we switched to another Smokey instance?

!!/notify 38 apple.stackexchange.com-

SmokeDetector

@Glorfindel The given SE site does not exist.

Glorfindel

!!/notify 38 apple.stackexchange.com

SmokeDetector

@Glorfindel That notification configuration is already registered.

Glorfindel

!!/unnotify 38 apple.stackexchange.com

SmokeDetector

@Glorfindel I will no longer ping you if I report a post on apple.stackexchange.com, in room 38 on chat.stackexchange.com

Glorfindel

8:30 AM

!!/unnotify 171 apple.stackexchange.com

SmokeDetector

@Glorfindel I will no longer ping you if I report a post on apple.stackexchange.com, in room 171 on chat.stackexchange.com

JAD

what

he regained his memory :D

Glorfindel

No, but apparently the silent mode doesn't work as described.

micsthepick

@JAD different room id

the id is important

M.A.R.

Smokey just sucks at pinging or not pinging people

SmokeDetector

8:40 AM

[ SmokeDetector | MS ] Potentially bad keyword in answer: Are there any baggage lockers at Amsterdam Zuid Station? by Jorn on travel.SE

tpu- by tripleee

tripleee

@SmokeDetector f

sorry, changed my mind

M.A.R.

@SmokeDetector F

Nog Shine

Yup. It is false

M.A.R.

@tripleee Smokey accepts your apology

Glorfindel

I've mod-flagged that post, though.

micsthepick

8:43 AM

@Glorfindel as spam?

Glorfindel

as potential spam, yes.

metasmoke.erwaysoftware.com/post/100688 they've posted more or less the same thing 2 months ago.

SmokeDetector

[ SmokeDetector | MS ] Bad keyword in body, link following arrow in body, repeated URL at end of long post: Organic India Green Coffee : Lose your body weight up to 16 pounds in a wee by organicindiagreencoffee on astronomy.SE

micsthepick

@tripleee @iBug codeclimate is complaining about that extra argument...

github.com/Charcoal-SE/SmokeDetector/pull/1748

SmokeDetector

tpu- by Glorfindel

tripleee

@micsthepick yeah, just looking at that ... not sure how it picks that up, have you changed everywhere it's referenced?

micsthepick

8:45 AM

no

SmokeDetector

[ SmokeDetector | MS ] Bad NS for domain in body, bad keyword in body, blacklisted website in body, link at end of body, pattern-matching website in body, +1 more: It can bolster in picking up the bulk by Wopen erip on drupal.SE

tpu- by K.Dᴀᴠɪs

tripleee

tripleee$ grep -FnIsr remove_from_notification_list .
./datahandling.py:353:def remove_from_notification_list(user_id, chat_site, room_id, se_site):
./datahandling.py:386:        remove_from_notification_list(*notification)
./chatcommands.py:925:    response = remove_from_notification_list(msg.owner.id, msg._client.host, room_id, se_site)

SmokeDetector

[ SmokeDetector | MS ] Bad NS for domain in body, blacklisted website in body, pattern-matching website in body, repeated URL at end of long post: Cerebral Boost GET A ROBUST SEX DRIVE ONCE AGAIN by venthic45 on stackoverflow.com

micsthepick

so just chatcommands.py

SmokeDetector

tpu- by K.Dᴀᴠɪs

tripleee

8:47 AM

worth a shot, I really don't see how else it would diagnose that

but it seems ass-backwards that it complains about the def

oh it's hardcoded to 4 docs.codeclimate.com/docs/default-analysis-configuration

SmokeDetector

[ SmokeDetector | MS ] Blacklisted website in body, link following arrow in body, potentially bad keyword in body: Male Progress Methods And As Well Products by pplkbhugu on puzzling.SE (@Mithrandir @micsthepick)

tpu- by K.Dᴀᴠɪs

[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, blacklisted website in body, link at end of body, pattern-matching website in body, +2 more: Get Weight Loss Supplement Here by tyku tila on superuser.com

tpu- by K.Dᴀᴠɪs

[ SmokeDetector | MS ] Bad NS for domain in body, blacklisted website in body, potentially bad keyword in body, repeated URL at end of long post: Thoughts produces this unique cocktail by kamzehuna on apple.SE

tpu- by Glorfindel

micsthepick

@tripleee so what do we do?

M.A.R.

BTW, the side effect of requiring two feedbacks is more messages are being posted to the Tavern

SmokeDetector

[ SmokeDetector | MS ] Bad keyword in answer: "Filename too long" error from one computer but not another and not for other users by Jurgen Parker on sharepoint.SE

tpu- by Glorfindel

micsthepick

"Just give it a default value and any name you deem reasonable." He said... "It won't hurt." He said...

SmokeDetector

8:59 AM

[ SmokeDetector | MS ] Bad NS for domain in body, bad keyword in body, blacklisted website in body, pattern-matching website in body, repeated URL at end of long post: goat weed) The best men by user280098 on apple.SE

tpu- by Glorfindel

micsthepick

I'm going for a drive, and I may go straight to bed afterwards

M.A.R.

Most of which are already deleted posts

@micsthepick imagining mics driving through the wall, jumping out of the car to bed

Andrew T.

Well,

in Tavern on the Meta on Meta Stack Exchange Chat, 2 hours ago, by FTP

Smokey is reporting a lot of already-deleted posts here. :/ Is deletion watcher broken again?

rene

Yeah, I needed to clean-up more then usual while I couldn't flag any of those

M.A.R.

@AndrewT. well.

rene

9:01 AM

I guess I better sit here flagging stuff

SmokeDetector

[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, blacklisted website in body, link at end of body, link following arrow in body, +3 more: WHAT ARE THE INGREDIENTS OF EnduraFlex? by Treas 19 on drupal.SE

tpu- by K.Dᴀᴠɪs

[ SmokeDetector | MS ] URL in title, bad NS for domain in body, bad NS for domain in title, bad keyword in body, bad keyword in title, +7 more: maleenhancementdirect.com/phytolast-male-enhancement/ by user83978 on drupal.SE

tpu- by K.Dᴀᴠɪs

[ SmokeDetector | MS ] Bad NS for domain in body, bad keyword in body, blacklisted website in body, pattern-matching website in body: 3. Investigate the elements of by uxkuxww on askubuntu.com

tpu- by Glorfindel

M.A.R.

@rene well, this is my seat.

You should just stand up

Magisch

He's already taken root

rene

I'll take a stand

SmokeDetector

[ SmokeDetector | MS ] URL in title, bad keyword in body, bad keyword in title, blacklisted website in body, blacklisted website in title, +2 more: gronkaffedenmark.com/nutralu-garcinia/ by anniles on graphicdesign.SE

Andrew T.

9:07 AM

Take a seat, please

K.Dᴀᴠɪs

I'd rather stand

SmokeDetector

tpu- by K.Dᴀᴠɪs

Glorfindel

> International Flower Day (IFD) is held annually on the 19th January. The day is about spreading happiness to others by means of a simple flower!

Andrew T.

just realized, deletion watcher is definitely broken since they are not deleted on here either...

Glorfindel

examples?

rene

9:09 AM

the most recent report

M.A.R.

These Taverners are from the future

Where we delete posts in Charcoal

Glorfindel

Ah, wait. I was confused because AIM reports them as deleted.

M.A.R.

Get out, Taverners

You can't change the past

Glorfindel

But I didn't realize Smokey deletes its own messages in other chatrooms (if it's able to).

M.A.R.

@Glorfindel it only does in the tavern

Something about scaring little kittens

Glorfindel

9:11 AM

Eh, wait, it's even more confusing. Smokey deletes its posts in SOCVR as well, but this is a different bug entirely.

The Tavern has a 5 minute timeout before something is posted there.

M.A.R.

I love how everyone is confused but m . . . Wait what?

Oh right. SOCVR too

Haha I'm not confused yet

Andrew T.

I'm confused why you are not confused...

Glorfindel

It's also interesting that this has reason weight 1175 and the same message in the Tavern 981.

Andrew T.

!!/location

SmokeDetector

@AndrewT. Henders/EC2

M.A.R.

9:13 AM

@Glorfindel I'm confused

Glorfindel

@AndrewT. I'm confused why you are confused that MAR isn't confused. That guy is almost never confused.

M.A.R.

Haha you must be confused that I suddenly got confused

Meanwhile, Smokey is confusingly killing the Tavern

Glorfindel

We can give it a timeout there.

Andrew T.

I guess timeout is a good choice until it's fixed

Any opinion, @rene?

since you're a RO

Glorfindel

!!/block 18000 89

SmokeDetector

9:21 AM

Reports blocked for 900 second(s) in room 89 on stackexchange.com.

@Glorfindel I hit an error while trying to run that command; run !!/errorlogs for details.

Glorfindel

!!/errorlogs 50

SmokeDetector

TypeError: remove_from_notification_list() takes 4 positional arguments but 5 were given
2018-03-15 07:30:54.782901 UTC
File "/home/ubuntu/SmokeDetector/chatcommunicate.py", line 336, in f
result = func(*processed_args)

File "/home/ubuntu/SmokeDetector/chatcommands.py", line 911, in unnotify_all
remove_all_from_notification_list(msg.owner.id)

File "/home/ubuntu/SmokeDetector/datahandling.py", line 386, in remove_all_from_notification_list
remove_from_notification_list(*notification)

TypeError: remove_from_notification_list() takes 4 positional arguments but 5 were given

Andrew T.

@SmokeDetector -_-

angussidney

@Glorfindel you need to run it on the right chat server

Glorfindel

in Tavern on the Meta on Meta Stack Exchange Chat, 1 min ago, by SmokeDetector

Reports blocked for 900 second(s) in room 89 on stackexchange.com.

Has that changed, then? I remember Andy blocking from here as well during a TownHall event.

rene

9:23 AM

Do you even know what this software does? Or are you just like me: run everything in production and pretend you know what you are doing.

Magisch

@rene smoke detector? nobody does

rene

@Glorfindel that!

Magisch

[tag:dev-on-prod] and [tag:panic-driven-development]

Glorfindel

We'll see what happens; if it doesn't work, we can run the command from the Tavern as well.

Andrew T.

come on spam, come here~

Glorfindel

9:26 AM

@rene actually, it was in the Tavern:

in Tavern on the Meta on Meta Stack Exchange Chat, Jul 26 '17 at 18:28, by Andy

!!/block 3600 89

rene

hmmm

Andrew T.

hmmm... now what'll happen on the Tavern...

SmokeDetector

[ SmokeDetector | MS ] Bad keyword with email in answer: You have exceeded your daily request quota for this API. Google Places API in Android apps by Mudit Gandhi on stackoverflow.com

rene

@Glorfindel but I also ran it here in this room: chat.stackexchange.com/transcript/11540?m=39984872#39984872

SmokeDetector

fp- by A J

Glorfindel

9:30 AM

OK. But how does Smokey know you're not pointing at this room instead? Does it know from its config files?

rene

@Glorfindel my earlier comment here wasn't meant to be only joking ...

I hope it works with its config files ...

Glorfindel

I don't know either.

I don't know Python. @ArtOfCode forbade me to learn it, to make sure I can't modify my own source code.

rene

Seems a valid reason ...

tripleee

@Glorfindel just import ast and you're halfway there already

Glorfindel

What does import do? Do I need to pay any taxes on the imported goods?

rene

9:38 AM

Only if you're importing from the UK ...

tripleee

it's nominally 22% but if you import stuff which is on the Approved List and it's less than 250 grams and you are at least 18 years of age and do not have a criminal record and can prove that you were born to parents who were born in this country and you do not have unpaid parking ticket then you can fill in form 8210(b)g-117 and submit it to the Customs Registrar by fax (open weekdays 10-14) we will process your request

micsthepick

from UK import *

tripleee

@micsthepick BrexitException

SmokeDetector

[ SmokeDetector | MS ] Blacklisted website in answer: Word 2003 add-in limitations by iMac Technical Support on serverfault.com

tpu- by K.Dᴀᴠɪs

tripleee

!!/blacklist-keyword ropaxin\W?rx

SmokeDetector

9:40 AM

@tripleee Blacklisted ropaxin\W?rx

CI on a72ba15 succeeded. Message contains 'autopull', pulling...

[ SmokeDetector ] SmokeDetector started at rev a72ba15 (SmokeDetector: Auto blacklist of ropaxin\W?rx by tripleee --autopull) (running on Henders/EC2)

Restart: API quota is 11990.

tripleee

@micsthepick I'm not sure really, let's wait for someone who understands that stuff? can we relax the codeclimate check or should we work around it?

I notice Angus set himself as reviewer

SmokeDetector

CI on da090be succeeded. Message contains 'autopull', pulling...

[ SmokeDetector ] SmokeDetector started at rev da090be (tripleee: bad_keywords.txt: generalize to ropaxin without rx --autopull) (running on Henders/EC2)

Restart: API quota is 11976.

[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, blacklisted website in body, link at end of body, pattern-matching website in body: how can work /turmeric-forskolin/? by racheljacksonn on drupal.SE

tpu- by K.Dᴀᴠɪs

angussidney

@tripleee generally we ignore codeclimate

It's caused more issues than it's worth

tripleee

@angussidney oh okay

Glorfindel

@angussidney so we're codeclimate change deniers?

angussidney

9:51 AM

@Glorfindel what do you think [crazed-maniacs] is for? :P

tripleee

can we have [human-rights-is-for-**ssies] too?

angussidney

@tripleee I self-requested a review as I'd like to take a better look at not only that function, but all the related functions, to make sure that it's going to work properly.

rene

which implies it currently doesn't?

angussidney

But it's going to have to wait until tomorrow arvo sorry, I have a maths test tomorrow morning that I have to study for tonight. Sorry for holding it up.

@rene bingo

rene

I love being right ...

angussidney

9:54 AM

You all have my permission to ping and annoy me as much as you like in 22 hours(ish) if I haven't taken a look yet :P

SmokeDetector

[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, blacklisted website in body, link at end of body, pattern-matching website in body: Testosup Xtreme side effects by kimberb on askubuntu.com

tpu- by angussidney

WELZ

@SmokeDetector k

Transcript for