RELOAD!

[Cardshifter/cardshifter.github.io] 5 issue comments.

[Cardshifter/HTML-Client] 7 commits. 1 opened issue. 84 additions. 22 deletions.

[Hosch250/Rubberduck] 5 commits. 3362 additions.

[Hosch250/VSDiagnostics] 1 commit. 38 additions. 1 deletion.

[Vannevelj/VSDiagnostics] 1 opened issue.

[Vannevelj/VSDiagnostics] 5 commits. 3 opened issues. 2 closed issues. 160 additions. 13 deletions.

@Phrancis Do you still need help with this?

It's about a year old.

[Cardshifter/HTML-Client] SirPython pushed commit 6f314ef6 to game-board

@SirPython So much for that, thanks Graphics.SE

I have an answer if you still need it.

I know HTML supports SVG fine. I don't think either JavaFX nor libGDX do though.

Probably would be good to KISS and just stick to PNGs & JPGs

Well, JavaFX (8) supports it‌​.

But with libGDX it seems a little difficult.

Yeah. I'm pretty much ready to forget SVG, it'd be cool but YAGNI.

I thought it would be helpful for different size screens, because no resolution is lost.

Hmm. Looks like libGDX requires you to sign a CLA to be allowed to contribute.

@SirPython I think all said and done, the images will be small enough to where it probably won't matter much

I wasn't really referring to size, but more to distortion.

Ah right

This is about real-life size on the iPad

@Phrancis Is that HearthStone?

Yeah

I should download that to see what it's like.

I think our images will have a different ratio, probably 16:9 or 12:9, to look more like a MtG / YGO physical card

MtG looks about 12:9 to me

YGO looks like a plain square. I don't like the layout as much though, and the print at the bottom is SO TINY

Yeah, we'll definitely need something bigger than that.

Oh, I like Pokemon's card layout the best I think

That looks like 16:9 ratio

They really went all-out with their newer, nicer looking cards

I agree. They seem to follow KISS: there isn't too much information on each card, but it's enough.

Yeah, I like that

Also, the lower one really has a "pop" to it.

In our case, probably would be best to save the full description and flavor for a "zoomed in" or "detail" view of the card (say when you click it)

Almost as if the creatures is leaving the card itself.

Yeah it's gorgeous, wish we had that kind of budget :)

@Phrancis Something like that. Although, a right-click would be easier so it doesn't interfere with the other left-clicking functionalities.

yeah

Does JS support right-click and other keys fairly easiiy?

I think so.

I'll smoke the docs.

Hmm. MDN doesn't say anything about right-clicks.

Nevermind, here it is: developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/…

See this for some cool things about menus: hacks.mozilla.org/2011/11/…

Hey man I started feeling like crap a bit ago, think I'm about ready to pass out in bed

See you tomorrow, then. Hope you feel better tomorrow!

Wife cooked some fresh shrimp from the ocean she got on her trip to SC this weekend, can't stand the smells it's given me a headache and nausea

Didn't sleep well last night either. Today was kind of rough, physically

See you tomorrow

Ooh, I know what you are talking about. Well, a good night's sleep should help you.

Store bought shrimp is bad enough, but this ocean fresh stuff is the worst

gone...

hey

Hi. Just wanted to let you know that I'm back. I am a bit sick though so I will lay quite low for a few more days.

Welcome back @SimonAndréForsberg!

Hope you get well soon

[Zomis/SE-Scripts] Zomis rejected pull request #2: Removed wildcard at end of @match

[Zomis/SE-Scripts] Zomis commented on pull request #2: Removed wildcard at end of @match

[Cardshifter/HTML-Client] danpantry commented on issue #57: Overuse of currentUser

@Duga I'd say that something went wrong there... That pull request makes no sense, maybe it should've been a single commit or something

@skiwi s/something/Malachi/

@Phrancis Downsides with AngularJS:

It's not isomorphic (javascript disabled = no website for you)

And it forces you to use a service like prerender.io (not free) if you want to have it indexed by search engines

AngularJS should be used for web applications, not web sites.

I would not recommend using it for the main project site of the TCG.

If you want to use a framework for a website, React is probably the one you want (or Backbone, but that's more complex); i.e, an isormophic framework

That's not a purists approach, btw - Another big metric for websites is the time it takes to load the page. AngularJS takes quite a while to load because you have to fetch the web page and then wait for Angular to parse itself. There are studies that show the longer the page takes to load, the more viewer retention significantly drops off. I would assume this is important if you want to 'show off' the game so to speak

hello

Simon!

Hello @all

Hey @jacwah

@Phrancis!

hey @Phrancis and @jacwah and @DanPantry

o/

@DanPantry Those are all extremely valid points, thanks so much for sharing... Perhaps it would be wise for me to open an issue on that for discussions?

@SimonAndréForsberg I'm about to leave for work, but I'd love to hear about your trip whenever you get to feeling better

[Zomis/SE-Scripts] Phrancis commented on moderator-tools/ReviewQueueNotification.js of pull request #2: Removed wildcard at end of @match

ttgtw, should be back in a little while

Hey everyone! Welcome back @SimonAndréForsberg !

@Phrancis I think so

Hey

hey @Phrancis! :D

Hey @Phrancis :-)

[Cardshifter/Cardshifter] Zomis commented on issue #337: "Start Local Game" causes NPE

> I believe this is caused by you not having chosen a mod to play with. Related to #299.

[Cardshifter/Cardshifter] Zomis commented on issue #344: Triggered action for a card to eliminate itself / perish

> I thought there was a destroy() effect already... if not, that should be added.

[Cardshifter/Cardshifter] Zomis commented on issue #346: Pass card image paths from server to client

I see Simon is catching up !

[Cardshifter/Cardshifter] Zomis commented on issue #350: NoClassDefFoundError if running tests from a non-clean build

> Thanks for taking the time to investigating this. If you have any clue why those aren't included in the dirty classpath, I'd love to hear about it.

[Cardshifter/Cardshifter] Zomis commented on issue #347: Handle failed login

> Related to another issue with some clients showing the lobby even if the server is down (won't look for it at the moment, or I have just been dreaming this...). Clients should not switch to the lobby screen until they receive the 200 status. If they receive another status, they should just show the provided message to the user.

[Cardshifter/Cardshifter] Zomis commented on issue #352: WebSocket connection close results in StackOverflowError

> I think this is entirely server-related. The issue is probably (without having looked at the code recently) that when the client has disconnected, the server sends this information to all clients (including the client itself), but when sending the info to the client it cannot do that because the socket is closed, so it tries to disconnect the client, and then informs all clients that the client has disconnected (including the client itself), but it cannot send the message to the client becau

[Cardshifter/Cardshifter] Zomis commented on issue #353: Connecting with the HTML client crashes the server connection thread

[Cardshifter/Cardshifter] Zomis closed issue #353: Connecting with the HTML client crashes the server connection thread

[Cardshifter/Cardshifter] Zomis added label invalid to issue #353: Connecting with the HTML client crashes the server connection thread

[Cardshifter/Cardshifter] Zomis commented on issue #354: User name validation

> Don't allow more than one consecutive space, such as some name --> some name

[Cardshifter/Cardshifter] Zomis commented on issue #357: A GetZoneMessage?

> I think ZoneChangeMessage helps reduce the network traffic used by the game. I don't really see a reason for GetZoneMessage. From what I'm hearing, it would be only be used early on in the game because.... well... because why exactly? What is the problem about deciphering ZoneChangeMessages? You need to do that at some point anyway. Or do you intend on sending GetZoneMessage requests after each turn and determine what cards have moved where?

[Cardshifter/Cardshifter] Zomis commented on issue #359: Potential exploit: sending the card information for unknown zones

> As far as I know, CardInfoMessages are only sent for cards in known zones. Please clarify.

[Cardshifter/Cardshifter] Zomis commented on issue #356: Card ids of "unknown" cards are still sent to the opponent

@Phrancis What's the status of the HTML-Client? How much progress has there been during my absence?

Welcome back, @SimonAndréForsberg!

hi and thanks

@SimonAndréForsberg github.com/Cardshifter/HTML-Client/milestones

So far, the client only needs to be able to do one more thing: be able to correctly handle sending action messages, and receiving usable action messages.

@Duga I'll try to find the point in the server log that I am referring to.

@SirPython And, it has only been tested on Mythos.

[Cardshifter/Cardshifter] SirPython commented on issue #359: Potential exploit: sending the card information for unknown zones

> My bad. (1), I meant to say ZoneMessages, and (2) I now know that the ZoneMessages entities properties only shows the ID of the card, no actual information.

[Cardshifter/Cardshifter] SirPython commented on issue #357: A GetZoneMessage?

> @Zomis "Or do you intend on sending GetZoneMessage requests after each turn and determine what cards have moved where?" Yes, that was the intention: simply update all the zones after every... never mind. Thinking about it again, it seems too overkill.

good to see ya @SimonAndréForsberg

hi @bazola

hope your trip was good and sorry you are not feeling well

[Cardshifter/Cardshifter] Zomis commented on issue #359: Potential exploit: sending the card information for unknown zones

> sounds then that this is a duplicate of #356

[Cardshifter/Cardshifter] Zomis closed issue #359: Potential exploit: sending the card information for unknown zones

[Cardshifter/Cardshifter] Zomis added label duplicate to issue #359: Potential exploit: sending the card information for unknown zones

[Cardshifter/Cardshifter] Zomis commented on issue #357: A GetZoneMessage?

> My point exactly.

[Cardshifter/Cardshifter] Zomis closed issue #357: A GetZoneMessage?

[Cardshifter/Cardshifter] Zomis added label wontfix to issue #357: A GetZoneMessage?

@jacwah In your IDE, setup the run config to use extra-resources as the working-directory. then it will be fine

monking

hey @DanPantry

It feels so good at work to actually know a bit about most technologies ;)

WebSockets, ORM, MVC, etc.

@skiwi it does, doesn't it! :P

I tend to learn all the new tech so I'm ahead of the curve

Ahead of the curve! ahaha at my place there is still a lot of COBOL and some Java 4, so being ahead of the curve here is not a big problem!

Was looking at Sails ORM and it does really resemble Groovy's GORM a lot

@Marc-Andre Ouch... lol

Also installed a JSON formatting extension on my browser today...

Why hadn't I done that earlier?!

The thought of such thing existing never even occured to me

[Cardshifter/Cardshifter] jacwah commented on issue #347: Handle failed login

> I think that on top of the changes to the client's handling of status code, the server should close the connection if the login attempt fails. It should at least not start to send lobby data as you can see in the logs above.

@Marc-Andre That code is probably older than me.

@skiwi What, like, prettyprint?

@DanPantry Just something that formats it and gives you the option to hide/show things

so yes ;D

[Cardshifter/Cardshifter] jacwah commented on issue #353: Connecting with the HTML client crashes the server connection thread

[Cardshifter/Cardshifter] danpantry commented on issue #353: Connecting with the HTML client crashes the server connection thread

> Would it be worth having a version check handshake to prevent this BTW? Notwithstanding @Jacwah's comment

@DanPantry There is code from the 80's so yeah.

unity is really not too bad! ive already got a prototype of an open world game with all of my models spawning, and i have already made powerups that you can pick up that make your character move faster and jump higher, and i already have them randomly spawning above the buildings when the world is created :)

Unity is awesome! :D

[Zomis/SE-Scripts] malachi26 commented on pull request #2: Removed wildcard at end of @match

> there were some things that I didn't want to merge with your code Zomis. I apologize, I don't have a good grasp on using github just yet. I agree with your conclusion. I am guessing that github automatically grabbed some changes from after I submitted the merge request but before you guys checked it out?????

@Lokkij MonoDevelop, shivers...

You can use Visual Studio with it just fine

[Zomis/SE-Scripts] skiwi2 commented on pull request #2: Removed wildcard at end of @match

[Cardshifter/Cardshifter] Zomis commented on issue #347: Handle failed login

> Agreed. At the moment, it sends the lobby data because of the querymessage that it gets. Closing the connection will solve that.

Some interesting stuff up here

youtube.com/user/java/videos

Wish I had time right now to look at that JavaFX for mobile

[Zomis/Duga] Vannevelj opened issue #95: Something caused the "build" message to not contain a link

[Zomis/Duga] Vannevelj opened issue #96: Some build messages contain "???"

[Cardshifter/Cardshifter] Zomis commented on issue #353: Connecting with the HTML client crashes the server connection thread

[Zomis/Duga] Zomis commented on issue #95: Something caused the "build" message to not contain a link

> Could you provide the JSON request that was sent to Duga for this? Should be available in the github webhook settings (you'll just need to find the right ones)

[Zomis/Duga] Zomis commented on issue #96: Some build messages contain "???"

> Could you provide the JSON request that was sent to Duga for this? Should be available in the github webhook settings (you'll just need to find the right ones)

[Zomis/Duga] Vannevelj commented on issue #96: Some build messages contain "???"

[Zomis/Duga] Vannevelj commented on issue #95: Something caused the "build" message to not contain a link

Hello

[Zomis/Duga] Zomis commented on issue #96: Some build messages contain "???"

> The chat message is about a build event, the provided JSON request is about a pull-request event. Please provide the JSON request that caused that particular chat message.

[Zomis/Duga] Zomis commented on issue #95: Something caused the "build" message to not contain a link

@skiwi im gonna try to give it a watch

[Cardshifter/Cardshifter] Zomis commented on pull request #360: Allow multiple creature types for one entity

@SimonAndréForsberg I solved it since then and added it to the build/run guide :)

@jacwah good, thanks.

haven't completely read the chat transcript yet

[Cardshifter/Cardshifter] jacwah commented on issue #353: Connecting with the HTML client crashes the server connection thread

> @Zomis So the snapshots are not based off the develop branch? If that's the case, it's the reason for this confusion.

@SimonAndréForsberg That would be quite a feat!

[Cardshifter/Cardshifter] Zomis commented on issue #353: Connecting with the HTML client crashes the server connection thread

> The snapshots are based on whatever commit I run gradlew snapshot from.

[Zomis/Duga] Vannevelj commented on issue #96: Some build messages contain "???"

@Duga Lol well obviously, but usually projects build snapshots/nightly builds from their development branch @SimonAndréForsberg

[Zomis/Duga] Vannevelj commented on issue #96: Some build messages contain "???"

@jacwah true that. but this is not anything that is done automatic. you have a point though that it would be preferred to make snapshots from develop

I think that snapshots should at least include the commit hash their made from somewhere

@jacwah I have considered that, yes. I'm planning on adding that.

That would help if a similar issue crops up in the future :)

s/if/when/

could you make it a github issue just so that we/I don't forget it?

[Zomis/Duga] Vannevelj opened issue #97: Non-mergeable pull request has an empty build url

[Zomis/Duga] Zomis commented on issue #97: Non-mergeable pull request has an empty build url

@SimonAndréForsberg Sure

[Zomis/Duga] Vannevelj commented on issue #97: Non-mergeable pull request has an empty build url

> That makes sense.

[Zomis/Duga] Vannevelj opened issue #98: Link to PR on AppVeyor build message

[Zomis/Duga] Zomis commented on issue #98: Link to PR on AppVeyor build message

> Could you show an example of the JSON data that is sent to Duga? If the JSON contains the required information, the answer is yes. Otherwise no.

[Cardshifter/Cardshifter] Zomis commented on cardshifter-core/src/main/java/com/cardshifter/core/username/UserName.java of pull request #358: Add user name validation

Phew busy day in here today!

You know it's really funny that here we are talking about lists, sets, etc.

And in Qt/QML all I have is a dumb Javascript array :|

Just one of them? ^ :)

Howyamean?

Like... you have only one, so you keep having to ... jokes aren't as funny after you try to explain them :|

[Zomis/Duga] Vannevelj commented on issue #98: Link to PR on AppVeyor build message

[Cardshifter/Cardshifter] Zomis commented on cardshifter-core/src/test/java/com/cardshifter/core/UserNameTest.java of pull request #358: Add user name validation

@Phrancis I don't get it

Don't worry, I don't either

~goes back to his tables...~

a = singular. you have only one array.

And in Qt/QML all I have is dumb Javascript arrays :|

Oh...

Ooooooooooooooooooooooooooooooohh

Well, QML is not that bad ;)

[Zomis/Duga] Zomis commented on issue #98: Link to PR on AppVeyor build message

[Cardshifter/Cardshifter] jacwah opened issue #361: Include commit hash in snapshots

[Cardshifter/Cardshifter] Zomis commented on issue #361: Include commit hash in snapshots

> There are gradle plugins that can be used to interact with git. Should be possible to use that to find out what the current branch and commit SHA is.

Monk*!

@SirPython Hey!

Hey, @jacwah!

How are you?

I'm good! Fixing everything @Simon has commented on :)

How are you?

I'm good as well! Fixing the code before SimonAndréForsberg comments on it :)

the game just got a lot more fun :)

[Cardshifter/Cardshifter] jacwah synchronized pull request #358: Add user name validation

@SimonAndréForsberg Thanks for the comment about parameterized tests! I didn't know about them and they're really handy. Updated code above ^

[Cardshifter/Cardshifter] build for commit cde2bb64 on ???: The Travis CI build passed

shouldiblamecaching.com

@jacwah I was just having some problems connecting to an SE site, too.

It's working now, huh

[Cardshifter/HTML-Client] SirPython commented on issue #57: Overuse of currentUser

Loki Astari vs. Simon André Forsberg: 2985 diff. Year: -2791. Quarter: -1195. Month: +105. Week: +30. Day: +20.

200_success vs. rolfl: 3449 diff. Year: +2702. Quarter: +3036. Month: +457. Week: +240. Day: +110.

Mat's Mug vs. Simon André Forsberg: 1281 diff. Year: +2171. Quarter: +667. Month: +945. Week: +218. Day: +135.

200_success vs. janos: 15528 diff. Year: -4072. Quarter: -1151. Month: -337. Week: +146. Day: -29.

[Cardshifter/HTML-Client] SirPython created branch controller-refactoring