The 2nd Monitor

Duga

00:13

REFRESH! There are 7047 unanswered questions (90.8886 answered)

pacmaninbw

02:36

@Phroggie The question is specifically asking if the code implements C++ move Semantics correctly, which is asking about a generic best practise. In addition it is clear through commented ellipses that there is code missing from each of the classes.

Why exactly do I need to keep justifying myself to you. Do you really want me off the site that badly?

Phroggie

GBP are "what are the best practices around X" questions. Asking if something follows best practices isn't a GBP, the question like the one being discussed can be example/hypo/stub.

@pacmaninbw You perform a moderator duty of notifying users the question are off-topic. I'm doing the duty of ensuring people aren't providing misinformation. When you incorrectly say UWYA is MRC and EHS is GBP then you're espousing misinformation.

Duga

03:21

Not an answer: I would not recommend if this is production code for maintainability and possibility of future bugs. This would fail our code review process from our senior developers. — snj 59 secs ago

Captain Obvious

04:10

0

Q: Mergesort but with arraysize instead of arraysize - 1

So i have a problem with MergeSort Algorithm. However, it is different from the conventional algorithm where the array is from 0 to n-1. In my main, there is a driver const int n = 10, and an array that allocates n elements ( a[n]). Then, it will call mergesort, but the parameters are a,0,n where...

Heslacher

04:43

Monking

Captain Obvious

06:06

0

Q: Unable to backtrack with bruteforce approach

Below is the problem, tried, for getting hands-on with recursion: Alice has an even number of N beads, and each bead has a number from 1 to N painted on it. She would like to make a necklace out of all the beads, with a special requirement: any two beads next to each other on the necklace must s...

algorithm recursion go

Duga

10:37

You might want to check out Code Review then. — InSync 37 secs ago

The_AH

10:53

I want a review about my .zprofile, which tags should I put on it?

The_AH

11:10

nvm.

Captain Obvious

11:32

0

Q: My ~/.zprofile (paths, configuration and env variables)

This is my .zprofile, it recently got nuked so I remade it. I made it clearer and better then my previous .zprofile and then I heard about this site so I want to know how can I improve this code. # Setting PATH for Python 3.11 export PATH="/Library/Frameworks/Python.framework/Versions/3.11/bin:$PATH

zsh

Duga

11:53

Also this question would fit the codereview stackexchange instead of stackoverflow. — Dylan KAS 14 secs ago

Captain Obvious

12:42

0

Q: Is it okay to intentionally use switch cases without break?

I came across a piece of code that I thought was cool; but (to me), but at the same time it feels like using a side effect to achieve something and I am not sure if that's a good practice. switch(suffix) { case 'd': milliSeconds *= 24; case 'h': milliSeconds *= 60; case 'm': milliSeconds...

javascript

Duga

14:42

If your code works, but you wish to improve it, you should probably be asking on codereview.stackexchange.com — Chris 23 secs ago

Toby Speight

15:34

@CaptainObvious I've edited this to make it a review request. It seems that this code is maintained by OP, so I cast an undelete vote. There's definitely stuff that's reviewable (not just the fallthrough - there's also no checking whether regex match was successful or not).

Phroggie

@TobySpeight Undeleted

Nice edit

Duga

15:50

possible answer invalidation by Toby Speight on question by LocustHorde: codereview.stackexchange.com/posts/287447/revisions

The_AH

@Toby Speight Thanks for the awesome answer!

Phroggie

@Duga lol no

The_AH

Because of the awesome answers that I got for my first question.

Is it okay if I ask a second question for a review for a bit bigger project?

Phroggie

@The_AH You can. You can even ask follow up questions on code you have already posted.

The_AH

That is very flexible.

Unlike a lot of other SE sites.

Phroggie

16:01

43

Q: How to post a follow-up question?

Sometimes I stumble upon follow-up questions, where code is being posted again after having gone through a review (or two). Examples of possible sets of follow up questions: Find missing numbers - Find even more missing numbers - Even more missing numbers Binary search tree - Another binary s...

discussion faq site-policy asking-questions iterative-review

@The_AH Our barrier for duplicates is very low. I can only remember seeing a handful. We also have 200 fizzbuzz questions...

The_AH

@Phroggie Wow.

skiwi

Monking

The_AH

Bonking.

Phroggie

Jun 27 at 14:57, by Vogel612

@Peilonrayz pretty sure you want to avoid that one...

The_AH

Okay, how about...

Zonking.

Phroggie

16:16

:)

The_AH

So my question will be about Pylect.

It's a Python terminal I made.

That I use infrequently.

Phroggie

Sounds cool. Ping me if you post the question, I may post an answer

The_AH

Okay!

@Phroggie codereview.stackexchange.com/questions/287450/a-python-terminal

0

Q: A Python terminal

This is the code for Pylect, a Python terminal I worked on a while ago which also caused my Desktop to get destroyed because of bad code. I use it infrequently but I would like a review for the code since this is a bit larger project that has span multiple months so there is some unclear bad code...

python python-3.x console authentication

Captain Obvious

16:34

0

Q: A Python terminal

This is the code for Pylect, a Python terminal I worked on a while ago which also caused my Desktop to get destroyed because of bad code. I use it infrequently but I would like a review for the code since this is a bit larger project that has span multiple months so there is some unclear bad code...

python python-3.x console authentication

Sᴀᴍ Onᴇᴌᴀ

16:45

Monking

Jun 26 at 17:25, by Peilonrayz

The_AH

Oh.

So zonking is the best!

ZONK

Duga

17:12

If the code works and you're looking for advice on improving it, Code Review is the appropriate place. But see codereview.meta.stackexchange.com/questions/5777/… first. — Barmar 21 secs ago

Duga

17:35

One goal of doing PR is to be able to do code review and as a consequence, to fix things found during the review, new commits should be pushed and so PR include it (because a PR is based on a branch) — Philippe 20 secs ago

Code review is off-topic for SO - it is very likely on-topic for Code Review, but make sure to read codereview.meta.stackexchange.com/questions/5777/… — Alexei Levenkov 38 secs ago

Phroggie

@The_AH I've posted an answer. As the bottom of my answer says, I think you should try to take all the advice you get and apply the advice to .pylect.py. Then after a couple of days a 2nd post would likely be well received.

Mast

17:56

2 answers, but 0 votes on the question.

May 26, 2014 at 16:59, by Mat's Mug

guys no pressure, but VOTE LIKE IT'S THE ONLY WAY TO BREATHE

The_AH

@Phroggie I see that's answer by Peilonrayz which you are and Phroggie is a sock/bot, it would been less confusing if you 1. posted that answer as Phroggie or 2. posted in chat as Peilonrayz. I recommend 2.

@Mast It normally takes days to get some votes, right?

I am going to wait for a few more answers because the project is big.

3 answers should be fine.

Mast

@The_AH Today, yes. Wasn't always like that.

Oct 7, 2015 at 17:44, by Simon Forsberg

Damn you people vote quickly. One of these days I'll probably get reputation for an answer that I haven't posted yet...

Phroggie

@The_AH The reason why I'm talking as Phroggie has kinda gone. I'll change to 2 at some point.

Mast

@Phroggie I thought you had practical reasons for that, did one of your systems die?

Phroggie

@Mast I have some concerns over the quality of the question.

Mast

18:03

@Phroggie It was worth answering, yet not a vote in either direction?

Is there anything at this point in time that can be done to increase the quality without invalidating answers?

Sᴀᴍ Onᴇᴌᴀ

@Mast while obviously the OPs of the answers likely didn't need it, an expanded description likely would not hurt...

Mast

Is that something you could still add @The_AH ?

The_AH

@Mast I have commented about that.

Also why are you guys giving me so much reputation?

@Mast Oh wait sorry.

Misunderstood.

I will add that.

Sᴀᴍ Onᴇᴌᴀ

please just add text but make no modifications to the code, since doing so could invalidate the answers

Mast

^^

Sᴀᴍ Onᴇᴌᴀ

18:14

@The_AH As you may know from puzzling or other SE sites "......users who consistently provide useful content accrue reputation and are granted more privileges on the site" - From Why is voting important?

Phroggie

@Mast I have posted a comment on the question. I do believe the only issue I have with the question is non-code related so AI is of no concern.

Mast

I'll probably go on a voting spree once the question is edited.

The_AH

@SᴀᴍOnᴇᴌᴀ In this case what does useful content define because how is that question useful like except for me nobody will care about that question?

Mast

I've only cast some 18k votes yet, what's a couple more.

The_AH

...

I have cast a few on Puzzling.

Mast

18:20

@The_AH Once you post it online, a "nobody will care about that question" mindset will hurt your question.

The_AH

@Mast But then what does useful mean?

I have made a comment on the question, here is it rephrased for y'all: I made the code so I am not sure about which parts of the code doesn't make sense so I would like to be given parts of the code which don't make sense as in "why are you even doing X?".

Mast

@The_AH For the reviewers. You want answers, right? So think about what reviewers need to properly identify what's the goal of your program and the issues with your code.

85

Q: How to get the best value out of Code Review - Asking Questions

I have a project I am working on, and I would like some, or all of it reviewed, how can I ask for this review on Code Review in a way that produces the best possible value? This is not about a question being on-topic, or off topic. Rather, this is about making on-topic questions great questions...

discussion faq asking-questions

^ FAQ on asking questions.

It's a great read.

The_AH

@Mast Oh.

Mast

Reviewers are your audience.

Well, and passers-by. But reviewers are your prime audience.

The_AH

So could anybody answer this question: I made the code so I am not sure about which parts of the code doesn't make sense so I would like to be given parts of the code which don't make sense as in "why are you even doing X?".

Mast

18:31

@The_AH You haven't told us what it's doing and why you wrote it.

As a reviewer, one of the thoughts that go through my mind is 'WTF am I looking at'.

The_AH

@Mast I mean if you read through it what pieces of code confuse you to why they are doing X more then others?

Mast

And "You're doing X, but why?"

@The_AH Description of the program should be clear without having to decipher the code.

The_AH

So "This is a terminal" should be expanded into "This is a terminal with x features and y fun features and z options and here's how you do option a, option b, option c..."?

Mast

That would help.

What prompted you for those features?

Why was a normal terminal insufficient?

The_AH

@Mast You could say that for any of my personal tools.

Mast

18:37

'just for fun' is an acceptable answer, but leads to different answers than when your tool fills an actual need.

The_AH

That's also why I created my own database manager.

Phroggie

Saying "for fun" is a deflection of the question. What purpose does/did the code serve? Why did you go with the design choices you made? Why are you playing with sys so much?

The_AH

1. To act as a terminal.

2. Because they were the first that came to my mind.

3. Because I want useful information to be added to sys.

Mast

18:54

Useful information added to sys, what's useful to you?

Don't forget to add all that to the question, not just post it here.

The_AH

Useful to me is information about Pylect and more easily accessing crucial information then calling tons of functions.

Mast

Posting good questions on CR takes some getting used to.

The_AH

Hmm.

Mast

I mean, you got lucky that your question got answered in a day. Some questions take days, weeks, months or years to get answered. For a first question, you can get away with much more than you'll get away with on a second/third/fourth question.

Reviewing a question is sometimes a lot of work. There are answers I've spent 12+ hours on. So putting in a bit of effort on the question is expected.

Sᴀᴍ Onᴇᴌᴀ

@Mast ditto

The_AH

19:01

@Mast WHAT.

Examples please.

Mast

7

A: Speech Recognition Part 3: Training the Neural Network

First things first: you can get far better results by fine-tuning the arguments. Yes, it goes over 52% at times and I'm sure it can go even higher. Let's take a look at what colours are caused by what. ORE1X4 default settings EAPX5J Epoch 200 instead of 100 6DHKQJ Dropout 0.9 i...

The simulations alone took 12 hours already.

Not to mention figuring out what to simulate, how to project the simulations and everything else that went into it.

The_AH

Woah.

Mast

If my memory serves me correctly, it took most of a weekend to get that answered.

The_AH

That's wow.

Mast

@The_AH This well-received question was answered over a year after it was posted:

70

Q: Printing binary trees

After writing this answer, I was inspired to try to design a more elegant solution to the problem of printing binary trees. And what better tool with which to seek elegance than Clojure? Overall design The solution I ended up with involved creating, merging, and printing what I'm going to call ...

tree formatting clojure ascii-art

Sᴀᴍ Onᴇᴌᴀ

19:14

@The_AH I worked on this answer over the course of a few days - at least ~6 hours

8

A: Vue - It's the Royal Game of Ur

warning: cheesy meme with bad pun below - if you don't like those, then please skip it... Question responses Do I have too many / too few components? I am aiming to make several other games in Vue so I like to make things re-useable. I think the current components are divided well. The existin...

Sᴀᴍ Onᴇᴌᴀ

21:03

"Thanks, Santa!"

Transcript for