« first day (2670 days earlier)      last day (1645 days later) » 

00:00
RELOAD! There are 6946 unanswered questions (89.7824% answered)
00:32
Please read about what's on-topic in the help center. Code review is off-topic, but you might want to check out our sister site Code Review. Please make sure to read its on-topic page, take its tour, and read its How to Ask page before posting there. — Chris 47 secs ago
@CaptainObvious Wouldn't mind if someone corrected any grammar mistakes I made in the answer.
 
1 hour later…
01:42
-1
Q: Can I say that the code I provided is early/static binding in c++

BilalMohibI wanted to confirm that my code is implementing the concept of static/early binding in c++ or not.Because I know if we don't use the keyword virtual its early/static binding but still I am not clear so please confirm me that my code is implementing the concept of early/Static binding in c++ or n...

02:40
Please don't do try { ... } catch { }. If I were to code review a developer's work I'd recommend letting them go for that kind of thing. — Enigmativity 58 secs ago
02:58
0
Q: Angularjs and Angular 8 hybrid and execute code micronization get Error: Can't resolve all parameters for xxx-service

Jiang WenI have a difficult case which was organized from an old angularjs and angular8, besides it's was also limited in the extensive refactoring to resolve in code of micronization.And the code of angularjs cannot be changed. In the end I choose the library ngx-planet that is closest to my situation, b...

03:48
0
Q: C# One type to represent multiple types (including generics)

DanielOur monolithic WinForm application is getting a face lift. One current challenge that we are restructuring how we setup events. I rolled my own event manager class to handle the subscriptions and unsubscriptions to prevent leaks whenever developers write code. I ran into several challenges with...

04:12
Monking
05:34
Monking
 
1 hour later…
06:43
0
Q: Cannot find function implementation in the code

user4838962In OpenVDB C++ repository, there is this condition inside VolumeToMesh.h: if (ijk[0] > origin[0] && ijk[1] > origin[1] && ijk[2] > origin[2]) { constructPolygons(invertSurfaceOrientation, flags, refFlags, offsets, ijk, *signleafPt, *idxLeafPt, mesher); // 1st function: implementation ...

07:11
@CaptainObvious Broken
Monking
07:33
0
Q: A compile-time morse code translator

user222866In the past I created a compile-time base64 converter which I enjoyed doing as a challenge. As a result I wanted to do the challenge again causing me to create a compile-time Morse code translator. here is the code: #include <iostream> #include <numeric> namespace morse { template<std::size_t N

07:59
I’m voting to close this question because it belongs to CodeReview — e2-e4 42 secs ago
Post the question here instead codereview.stackexchange.comalotropico 19 secs ago
Or, you know, look at how others have done it before asking a low-effort question...
Hello, welcome! You should delete this and post the question here -> codereview.stackexchange.com It's appropriate in CodeReview, not in Stackoverflow. I prefer Plato, but I'll give it a pass ;) — alotropico 34 secs ago
08:38
@alotropico Nope. It's not appropriate for CodeReview, as it doesn't work as intended. — Zeta 28 secs ago
08:48
0
Q: Winforms form send data to MySQL

LV98I have created an application to send data to MySQL. On top of that, I am attaching a file and storing into a folder. Also, If trying to attach an excel sheet - another form opens, giving you the option to select which excel sheet you'd like to submit. I'd like to hear some reviews on the code an...

0
Q: Egg size Prompt Box

MyOldCookieSo I am currently doing an Assignment where I have to make a code that when someone opens the page, they input the weight of an egg and it comes back with what "size" it is. I got the code working and I sent it to my teacher for feedback. However, she came back with telling me I should make the c...

09:05
possible answer invalidation by Kerry Perret on question by Kerry Perret: codereview.stackexchange.com/posts/248004/revisions
@Duga Rolled back
09:35
possible answer invalidation by Aryan Parekh on question by Aryan Parekh: codereview.stackexchange.com/posts/248387/revisions
09:55
@Duga Additional explanation was added.
-1
Q: CSS grid page is not responsive, everything is overflowing

swebdevI've started web development and I've made this "Tribute page" project for Freecodecamp website, Even though I've used Display grid, page is not responsive at all, text overflows when screen size is reduced, and image gets too small, Please check it from link and point out my mistakes. Project li...

10:45
You have a lot of typos and syntax problems, go to Code review siteEle just now
11:07
@Ele Any and all syntax errors are off-topic on Code Review, as the code has to be working. — Peilonrayz 34 secs ago
11:19
0
Q: Orchestrating an unknown number of goroutines

Javier García ManzanoI recently wrote a piece of code to parallelise some code with goroutines and I was wondering if I could get some feedback. It looks overly complex... but I'm not sure how I could make it simpler. It's self contained, so you can just copy-paste it into the Go Playground and run it. Here's a link ...

 
1 hour later…
12:47
@Mast Thanks for the edit.
I guess I needed some duct tape. :)
@Duga No problem, author added a picture of a chessboard.
13:20
possible answer invalidation by TmSmth on question by TmSmth: codereview.stackexchange.com/posts/247777/revisions
@Duga @Peilonrayz handled it.
13:50
possible answer invalidation by Stephen Rauch on question by Cluelesshint: codereview.stackexchange.com/posts/248382/revisions
@Duga Fine
14:14
-1
Q: 'private' class parameter

anthoI would like to know if using a 'private' class parameter is a bad python practice? class test: def __init__(self, name, dogs, _private=None): if _private is not None: if isinstance(_private, 'what i want'): k = _private else: ra...

This might be better suited for the CodeReview site. — tobias_k 36 secs ago
If we are to do a code review on the code posted, there's a whole of other issues too. The core problem is using the wrong tool (GPIO) for the desired task (PWM) and doing so in a busy-wait loop instead of letting the hardware handle it without CPU involvement. — Lundin 57 secs ago
@Itison I'm betting you already knew (and realize it's seven years later), but it appears there's an "Open Code Review in Team Explorer" link at the top of the display that will show the comments. Tedious and bad UI, yes, but at least they're still there, somewhere... — ruffin 24 secs ago
14:51
Monking
@CaptainObvious @Mast you edited the post instead of voting to close - is it not CNWAI/TTBOAK?
15:11
@SᴀᴍOnᴇᴌᴀ I agree, the code is broken because the calculate function isn't virtual and can't be overwritten in the base class.
The base class might be better as an abstract base class.
Just a suggestion that might go against some rules, but I think we need to get emma over 3000 rep so she can review close votes as well. She regularly reviews in first posts.
@SᴀᴍOnᴇᴌᴀ I don't know, I didn't test it.
@pacmaninbw Not all of those reviews are good and that account has been getting plenty of rep lately by blasting the site with multiple questions a day.
Yes, and I don't up vote all those questions either.
@SᴀᴍOnᴇᴌᴀ It's definitely a poor question, won't disagree with you on that.
but I haven't stated my view on it :)
15:20
I can smell it right through the monitor.
LOL
@Mast I need to get one of those monitors with the odor attachment.
@pacmaninbw It's still an experimental feature. Very secret. Shhhhh.
@pacmaninbw Pretty sure she just robo-reviews the upvote button.
15:24
@Mast @Peilonrayz @SᴀᴍOnᴇᴌᴀ Okay, I retract my suggestion.
However, that is what @Rolfi suggested in the Meta on "No Action Necessary"
We used to have a vote problem.
We don't have a vote problem anymore.
some of those posts should not be up-voted though
Except for bad questions still getting upvotes.
@pacmaninbw Sorry I've forgot the meta post. Could you link it?
15:26
Some questions are simply bad but aren't close worthy since they technically don't violate the rules.
@Peilonrayz @SᴀᴍOnᴇᴌᴀ can, I followed his link.
32
Q: First Post Review Queue — what is it? Why is it a bad idea to click "No Action Needed"?

rolflWhen you pass 500 reputation you gain access to the Review Queues. One of them is the "First Post" queue. What is this queue, what purpose does it serve, and how should I process items in that queue?

@pacmaninbw He suggested leaving comments there too. How often do you see a comment of her?
I happen to know there are exactly 0 comments of her.
Now, not everyone has to comment, but when you're in the queues a lot, it sure is appreciated.
3
@SᴀᴍOnᴇᴌᴀ Ah ty. I don't think she's following that in the slightest, well maybe not using NAA but...
Too much roboing going on.
like a robot-take-over
2
Yea, and I'm all out of ideas on how to tackle this.
There's only so many ways you can do this that won't result in a witch-hunt.
I've thought about scraping the history pages and putting some statistics on that. But that's a) likely to be misinterpreted or b) will end up in a fight or c) nothing will happen since who's reading meta nowadays anyway?
15:40
@Mast What's your reasoning for (a)? The other two I understand, but that one I don't understand.
I might have been a been a victim of a witch hunt early on, @janos told me to stop using "No Action Needed", but it did improve my reviewing in the queues.
@Peilonrayz The problem with statistics is that unless you're good with statistics, you can explain them multiple ways.
@pacmaninbw @rolfl had to teach me a thing or two before I did a decent job.
I've considered suggesting that meta be shown to anyone who starts reviewing in that queue but don't have a good idea for how that should be implemented
2
@Mast Actually if you are very good with statistics you can prove anything you want to by picking the correct statistics (ignoring some facts)
15:43
Monking
M o n k i n g
@pacmaninbw Well, that too.
If you're backwards enough, you can prove anything with any statistic whatsoever.
'prove'
Facebook is full of it.
Heck, the White House is...
Actually I think of it as if you're slimey enough.
And yes the White House does...
Anyway, that's the major reason I haven't done that.
Combined with the other reasons...
I'm out of ideas.
@SᴀᴍOnᴇᴌᴀ Feel free to try it.
@Mast Yes, you can get it wrong (intentionally or not) but if you're getting a known-non-robo as a robo then the doubt should start to seep in
15:48
Could we post a link in the stats and history pages for that queue?
@pacmaninbw stats page? I only know of the history page
Oh nvm. I found it, why the leader board is called stats idk
@Peilonrayz Yes, that page.
Other related stats, but not per user: 10k+
15:52
As @SᴀᴍOnᴇᴌᴀ indicated this question reeks. It needs 1 VTC.
@pacmaninbw I don't understand why it's off-topic. If you / someone wants to explain it to me then I may VTC it. Or we could wait for someone else to come along
^ Agreed
my sentiments exactly
45 mins ago, by pacmaninbw
@SᴀᴍOnᴇᴌᴀ I agree, the code is broken because the calculate function isn't virtual and can't be overwritten in the base class.
Does that mean the code couldn't have worked @pacmaninbw ?
15:57
@Mast If that's a "couldn't have worked" as in "can't compile" I'd close. If it's a it's not working to spec it's on-topic IMO
It means that any of the sub classes could not override the function in the base class.
Left a comment, least I could do.
It also seems to have affected the assignment to the variables in the base class since the user used the this pointer.
I ran the code on onlinegdb and only saw a warning but no error
(similar to the link by our "greek named user")
@SᴀᴍOnᴇᴌᴀ Thanks, I'm not going to close. Someone doing something that works but is wrong = on-topic IMO.
16:00
Actually it causes hard to trace bugs
because the wrong function is called.
@Mast Thanks Mast.
Back to my mental blocks (er bugs) my unit test found in my lexical analyzer.
Almost forgot that there's a follow feature now was about to ask for a ping
Haven't tried it yet.
My favourite part is having my profile filled with deleted posts, but otherwise it's, "eh". Better than nothing
16:09
for following a user?
No a post
This question might be a better fit for codereview.stackexchange.com - but read this before posting there. — Matthew Watson 31 secs ago
ah interesting
I often forget to review posts that I bookmark
163
Q: The Follow Questions and Answers feature is now live across the Network

Yaakov EllisWe are happy to announce that the previously announced follow question and answer feature is now live across the Network, including Stack Overflow, all Stack Exchange sites, and all Meta sites. (International Stack Overflow sites will have it turned on in a day or two once we have translations al...

16:45
0
Q: refactor method using generic method or design pattern

Remon Shehattapreface: I have a part of my code that is repeated more than once and I want to create a generic method or follow a design pattern to make the code cleaner. this following class represents data record for an employee. records denotes the data and it's in JSON format. I parse the records data depe...

17:10
0
Q: C++ Crypto: Part 1- Hash

Martin YorkLooking around for modern Crypto libraries. Could not find anything good. I know I probably did this all wrong so work with me here. There will be four different reviews for four structures that build on each other: Hashing Hashed Key Password Key Salted Challenge Response This is the hashing c...

0
Q: C++ Crypto: Part 2- HMAC

Martin YorkLooking around for modern Crypto libraries. Could not find anything good. I know I probably did this all wrong so work with me here. There will be four different reviews for four structures that build on each other: Hashing Hashed Key Password Key Salted Challenge Response This review is for an...

0
Q: C++ Crypto:Part 3-

Martin YorkLooking around for modern Crypto libraries. Could not find anything good. I know I probably did this all wrong so work with me here. There will be four different reviews for four structures that build on each other: Hashing Hashed Key Password Key Salted Challenge Response This review is for an...

0
Q: C++ Crypto: Part 4- Scram

Martin YorkLooking around for modern Crypto libraries. Could not find anything good. I know I probably did this all wrong so work with me here. There will be four different reviews for four structures that build on each other: Hashing Hashed Key Password Key Salted Challenge Response This is an implementa...

17:22
Holy Carp
darn - jsPerf.com appears to be out of service :/
0
Q: I want to most efficiently use array values and variables in a WordPress template while abiding by PHP/WordPress best practices and standards

thenomadicmannIs it better to validate and put an array value into a variable at the top of a file or to check the array value directly right before output in the file? I work at a WordPress shop and we have a function that some devs commonly use to check the value of indexes in an array of custom field values...

17:58
I think we may need to help @loki out.
@CaptainObvious ^^ all 4 Parts
@SᴀᴍOnᴇᴌᴀ @Peilonrayz ^^
@pacmaninbw help out in what way(s)?
I've just suggested he add a link to the RFC that he's trying to meet. Other small odds and end like that and maybe copy the link to all 4 questions.
He doesn't ask questions all that often.
and he doesn't participate in the queues.
@pacmaninbw Not a fan of pretty much any of the situation - spamming the site with low quality questions. Probs better if I leave it now that I've posted two, less controversial, comments
But he provides good C++ answers
it looks like he linked all four of the questions together
> I know I probably did this all wrong so work with me here. There will be four different reviews for four structures that build on each other:
18:06
Otherwise it will be a carpload of code.
I'm not fond of part 1 myself since it is only a header file.
Questions with a lot of code rarely get good reviews because it is too complex and takes too much time.
but they are the ones that really need reviews.
18:25
0
Q: Manipulating floating-point numbers in different types of strings

Ștefan DumitrescuI have a .txt file which I use to store some data about some payment methods. Based on different types of methods, not all the rows look identically. For example, we have: cash CashFundName 15454.02554 for a cash fund; card MyCardName 08 2023 54545.4545 for a card; ticket ThePaymentTicketName res...

@pacmaninbw Yes, his answers are better than his questions.
If you have specific concerns about the questions, drop a list and I'll attempt to fix them.
18:50
-1
Q: Breadth First Search for Knight Moves

FaijiuyI am doing the Knight move Problem for my class. My codes (Python 3) are like this. But when I run, I get this error. I think the values are not going in the list. What should I do? Help me!!! My error: Traceback (most recent call last): File "C:/Users/Faijiuy/Documents/Python Scripts/Knight Mov...

0
Q: Javascript / Go Plug-and-Play Server-side WebRTC support

CoupcoupI normally program in a linux vm and decided to do some machine learning with my webcam when I realized the vm didn't have access to my camera hardware. That kicked-off a mini project to create a plug-and-play module to access the webcam in a browser and redirect through a Go backend so I could w...

19:13
maybe you can post this on code reviewsamkart 46 secs ago
@samkart The code doesn't have a DataFrame, so this is just asking for code - which is off-topic on Code Review. — Peilonrayz 32 secs ago
@CaptainObvious One more VTC.
Pick a reason.
19:40
@Mast That should have been authorship
@pacmaninbw Howcome?
No code.
The "code not inline in the question" reason?
19:58
You might be interested in codereview.stackexchange.comAndreas 21 secs ago
20:40
@Mast I've done what I think I can to improve them.
If you have working solution but you are looking for potential ways to optimize it then such question is better suited for codereview.stackexchange.comPshemo 13 secs ago
20:56
"The below code exhibits the correct behavior" - then this question is more suitable for CodeReview instead. — Remy Lebeau 10 secs ago
@Duga nice- it looks like the OP read through the CR on-topic page :)
> Just so it's out there, this question didn't qualify for code review from how I understood the questions they discourage.
@RemyLebeau That was not my understanding after reading this page: codereview.stackexchange.com/help/dont-ask since it seems to fall under "What is the best practice regarding X?" — sweenish 7 secs ago
@sweenish read codereview.stackexchange.com/help/on-topic instead: "If you have a working piece of code from your project and are looking for open-ended feedback in the following areas: - Application of best practices and design pattern usage, ... then you are in the right place!" — Remy Lebeau 53 secs ago
@RemyLebeau It does seem a better fit for CodeReview. I will close and move it there. In the minute or so before I close it out, the two pages should probably make stronger distinctions, since my case seems to fit both sides as currently explained. — sweenish 5 secs ago
21:21
0
Q: Are there C++ Standard Library functions/classes I'm missing out on?

sweenishThe setup is that I have a vector of a class, and I need to sort it by the quantity of a data member value, not the value itself. The below code exhibits the correct behavior, and part of that behavior is "stable" sorting where the order of elements should be preserved when possible. Between the ...

0
Q: Erlang: Seeking advice on BEST practices with ETS table manager

Nolan RobidouxI wrote a some what "simple" module to retain ETS tables should the owner crash. I think it's small enough for review; big enough to make enough mistakes. Honestly I'm a hobbyist programmer aiming for production code. I will take any criticism to get me closer. More logging? Use of spec()? Anythi...

-1
Q: Understanding pointer to array

Sahiba AroraI'm trying to understand pointer to array and hence experimenting with various things. When I run the following code: #include <stdio.h> void test(char *[]); int main() { char *b[6]; char a[5][5]; int i,j; int number=1; for(i=0;i<5;i++) for(j=0;j<5;j++) ...

21:42
@CaptainObvious valid comment:
Title changed. There are too many help pages based around asking questions, and the edges of those pages are fuzzy and overlap slightly. — sweenish 8 mins ago
 
2 hours later…
23:29
I'm not sure if best practices are a good fit on Stack Overflow, but I suspect either Software Engineering or Code Review might be a decent option. — Booga Roo 19 secs ago
23:51
0
Q: Early Stages of floating point class template in C++

Francis CuglerI'm currently designing a class template to represent scientific notation or a floating-point number system. There are currently 4 distinct types: BIN, DEC, OCT, & HEX. This could easily be expanded by the user. This class utilizes some of the power of C++17 or greater such as scoped-enums, lambd...

0
Q: Mixing controlled/uncontrolled behaviour with `getDerivedStateFromProps`

maulerosI have a component that displays a bunch of selectable options in a single row. It takes a pageSize prop from the parent component due to responsiveness requirements. If the pageSize prop ever changes, I need to reset the currentPage (currently active page), which is held in state, to 0. class Op...


« first day (2670 days earlier)      last day (1645 days later) »