« first day (1920 days earlier)      last day (2392 days later) » 

00:00
RELOAD! There are 5478 unanswered questions (89.9492% answered)
0
Q: Generic Single Linked List Using Smart Pointers Follow up

SnorrlaxxxI am extending this post following from here. I made some of the changes that I could make in the previous post. Although, I have not been successful in creating iterators for my class. The reason for the new post is to see if there is any additional changes I need to make to my code. As well as...

00:31
so i have been realizing over the past couple of days that the code i posted for code review is pretty crappy and it's broken. however, i believe i have fixed the code. should i edit the question to put in the new code? answer my own question and start a new question with the updated code? close the original question and ask a new question? burn everything with fire? =)
advice would be appreciated. thanks!
 
1 hour later…
01:35
@heather I haven't looked at the question, but you can edit the fixed code in if you have not received any answers. If you've gotten answers then you'll need a new question.
 
1 hour later…
02:45
@202_accepted no answers, so i'll edit. thanks
 
1 hour later…
04:58
Either way, I feel like this question would be more fitting for code review since it's pretty opinion-based — kingdaro 50 secs ago
Monking
Monking
0
Q: My Short Java Program Has An Interface Named "Human" with two classes that implement it. Any small tweaks that I can apply to it for improvement?

nate(This is my first question here sorry for any small errors with my post - some advice on creating better questions would be appreciated too.) In Advance, 'Helloworld' class executes all of the methods, 'Human' is the interface, and 'Nate' & 'Ryan' are two classes that implement the 'Human' inter...

05:36
0
Q: Best practices for an upvote/counter in Javascript

cpkLooking to improve building UI in pure ES6. This is the pattern I have adopted and has worked fairly well. This code increments the count, sets a data attribute to toggle the button, and issues a POST to the server with the vote payload object. import axios from "axios"; class Vote { constr...

Performance issues of a working code are in the scope of code review. — scopchanov 31 secs ago
possible answer invalidation by esote on question by Snorrlaxxx: codereview.stackexchange.com/posts/201042/revisions
06:04
A solution is mention in this answer. — chux 32 secs ago
06:31
You can try code review. Be aware that you are expected to post working code with specific question. — Guy 28 secs ago
0
Q: Is this Code Correct?

Cate Z.I'm not sure if this question is in the right forum, but I'll migrate it if it's not. I'm making a website about coffee types, and I want to make the website with a mega menu, such as: Infused Drip or filtered French press or cafetière Cold brew And so on. Some of the categories don't need ...

06:54
Monking
07:47
Monking
08:06
Monking
08:36
Monking
09:14
Monking
10:03
I'm voting to close this question as off-topic because because it is not about solving a problem, try instead codereview.stackexchange.comAnders K. 56 secs ago
10:16
@AndersK. High-level design reviews are off-topic at Code Review. — Mast 13 secs ago
 
1 hour later…
11:36
This is probably more suitable for code review stackexchange; you should probably translate the variables into English: some of them could obviously be grouped in classes, but not understanding what they are precisely makes it more difficult. — Reblochon Masque 1 min ago
0
Q: Resource cache based on Stroustrup 22.2.4

TheoI recently read "The C++ programming language" chapter 22 and I thought the example given in chapter 22.2.4 was quite interesting. I thought it should be possible to make this system caching, so it could be used as a resource cache. It's unlike most other approaches I found on the net, and I got ...

0
Q: Find the longest acsending subarray from a given array

RamakrishnaI have following task, form a given array, i want the longest ascending array. I will give you an example int[] a = {19,12,13,1,2,3,4,5,14,23,24,25,26,31,32}; will return array of {1,2,3,4,5} - that is the largest sequence of ascending numbers in the given array. Below is the sample code: int[]...

This question appears to be off-topic because it is a code review request. This might be better suited to the Code Review Stack Exchange site. Before posting there be sure to read their FAQ to ensure that your question meets their guidelines. — John Conde 31 secs ago
@JohnConde No its not a code review request! i just wrote my code for better description in order to ask my questions about preventing CSRF attacks. — Ali Khedmati 56 secs ago
possible answer invalidation by Jam on question by Jam: codereview.stackexchange.com/posts/201012/revisions
11:53
@Duga 4 seconds.
that's what I call race-condition
And now we both removed it, again at the same time.
I'll put mine back.
I can just undelete mine
you need to repost ;)=
Still had what I snipped out under Ctrl V.
Edit FTW.
Welcome to Code Review, where the moderation is faster than the caching can handle.
5
0
Q: Should I add the "fetch_group" method to my user class or should I create a separate class for group

Kar19I have a table of users, where each user has a group (or multiple groups) he/she is part of. Currently I'm handling the users group via a Users class: <?php /** * * User (class) Model: Handles users (not system users). * */ class User{ /*================================= = Va...

12:01
@CaptainObvious nope
You're asking two different questions here (which makes it too broad). The first one is definitely asking for a code review (on-topic questions are code review are If you have a working piece of code from your project and are looking for open-ended feedback in the following areas … Security issues … Correctness in unanticipated cases). Your second question is on-topic for SO (if it were a question of its own) but suggests that you haven't learned the fundamental basics of what a CSRF attack actually is). — Quentin 59 secs ago
12:23
@heather Works for me. :)
0
Q: Simplify variable initializations by using an unordered map

Håkon HæglandI am trying to clean up and simplify parts of a large C++ code that others have written. In one method, there is a pattern where numerous variable names are declared using the same initializer function. Here is a simplified example: #include <iostream> int initialize( int param ) { return p...

welp ... working around my borked kdewallet is getting annoying ...
12:38
@Duga RBA, possibly incoming.
@Vogel612 Hwhat?
hmm .. okay so I maybe fixed it, apparently
export, delete, import => fixed
at least now I know how to encrypt files with gpg manually :)
@CaptainObvious Example code.
@Vogel612 Heh, that sounds an awful lot like my workflow in one of the configuration programs I use.
if I'm unlucky this will not work anymore after restart and I may possibly need to reenter all my browser passwords.
Editing often goes awry and one of the parts can actually be exported/imported. Doing so and editing in between is faster and more fool proof than editing in the editor specially built-in for it.
12:41
youch
0
Q: Front end for system ordering

Richard NeumannI am developing a microservice that enables business partners to order systems for common customers: /* ordering.js - Terminal ordering JavaScript library. (C) 2017 HOMEINFO - Digitale Informationssysteme GmbH This library is free software: you can redistribute it and/or modify it unde...

0
Q: A C macro and a C++ function with the same logic, but different performance

cartoonistI am porting a C library which heavily uses macros to C++ using templates. There is a function which gets the next character from a file. It uses a buffer and when the buffer is completely used, it reloads the buffer by calling __read function. My re-implementation is quite identical to the origi...

13:02
0
Q: Disassembler for intel 8080 v2

StudAs many suggestions were given for the code I posted here, I decided to show you the new version for review. I Removed the OpenCatalog class, Disassembler now has the responsibility for handling the catalog of OpCode that is now stored in an std::map. OpCode is now a struct and AssemblyLine han...

0
Q: Correct Callback for each item

NepsterI have added a correct question callback for different type of question like radio,checkbox and descriptive.. QuestionListActivity.class (it shows the list of questions to attempt) public class QuestionListActivity extends AppCompatActivity { private Context mContext; private List<Ques...

possible answer invalidation by Ramakrishna on question by Ramakrishna: codereview.stackexchange.com/posts/201064/revisions
@Duga Simple spelling fix but invalidates Josay's answer
13:33
@Mast The real code consists of hundreds of files and objects, so some simplification was necessary for this question... I am not sure how to proceed with this. I agree that the optimal would be to take the whole code base into consideration when considering this question.. and I suspect that it needs a refactorization from a more global point of view. But since the code is too large for me to grasp at the current point, my approach was to do it in this stepwise/incremental fashion... — Håkon Hægland 35 mins ago
Anyone familiar enough with Software Engineering.SE to take an educated guess whether it would fit there?
nope
as in: yes, familiar enough, no it doesn't fit
Monday morning comes again
Prove it
Still Friday for me
@Vogel612 Thanks
Can anyone put in the final vote to hammer it down then?
@Malachi Hah, it's almost end of the afternoon here.
13:48
0
Q: CSRF preventing php

Ali KhedmatiFor preventing CSRF attacks in PHP,i tried something like this: for each page that contains forms(whether its a post or get),at the beginning i use this: <?php session_start(); if(!isset($_SESSION['token'])){ $_SESSION['token']= strong 32 charachters random string } ?> And for ...

Why I make my charts collapsible you ask?
Because they get yay wide and it isn't even closed to finished.
14:05
@Mast lucky you, I still have to go through the morning, but you have already made it past
@Malachi If you fly up here in the morning and go back at the end of the afternoon, you get 2 afternoons instead of a morning and an afternoon.
3
Worth it?
I would get twice the amount of sleep as well, because I am sure I would sleep on the plane....lol
so I might say yes, if the airfare were free
Details, details...
@Mast Worth it.
Greetings, Programs.
14:20
possible answer invalidation by ktb on question by ktb: codereview.stackexchange.com/posts/201037/revisions
0
Q: Bash delete folder if not present in other folder

t Bookimaging a folder structure like: Peter |- Cats |- Mini |- Maunz |- Tippsi |– Dogs |- Brutus Eva |- animals |- Mini |- Brutus I´d like to delete all subfolders in Peter/*/ if they not present in Eva/animals/ (Maunz and Brutus) This is what I have so far. It´s working but it...

14:33
@Duga Should probably be rollbacked
0
Q: Best Way To Represent Time difference in SQL Server, given that 24 hours is a possibility

JayI am creating a table to represent Service Level Agreements for applications. I started by creating a schema with two time columns SLA_Start, and SLA_End. However, A lot of SLA's run the entire day. There is only one Midnight. For Instance, There's not really a way to represent 00:00 Monday to ...

14:52
0
Q: Algorithm problem and php organisation

k.amProblem: We are interested in triangles that have integer length sides, all of which are between minLength and maxLength, inclusive. How many such triangles are there? Two triangles differ if they have a different collection of side lengths, ignoring order. Triangles with side lengths {2,3,4} a...

Monking!
15:30
I'm voting to close this question as off-topic because it's not directly related to programming, but code reviewing by specific entities. — iBug just now
15:40
3
Q: Python Output Class

AndrewI have the following python output class that I'm planning to use across a number of modules in a terminal application: from colorclass import Color from colorclass import disable_all_colors, enable_all_colors, is_enabled from time import gmtime, strftime class OutputHelper(object): def __i...

15:56
I think this type of question could be made at codereview.stackexchange.com. — Felipe Augusto 52 secs ago
16:20
possible answer invalidation by Felix on question by Felix: codereview.stackexchange.com/posts/201011/revisions
possible answer invalidation by Toby Speight on question by k.am: codereview.stackexchange.com/posts/201083/revisions
@Duga AFAICT that is not an invalidation
@Duga this one touches the code and removes a needless header...
not sure whether to revert the change to the code
0
Q: Looping over 2 arrays of objects, discarding 1 set and adding another

Kyle TI am implimenting a tag/category system and working on adding updated. Bascially, you can tag certain content, go back later and change those tags. If someone goes back and changes the tags I only want to removed the tags they removed and add the tags they added, leaving the ones that are the s...

posted on August 06, 2018 by CommitStrip

Sure. Explain why this code works. Imagine this is part of a code review and that you're showing this to a tech lead or your superior. Do you believe it's clear and concise as to what's going on such that anyone at a glance can glean the same value? From the looks of it I'm not as convinced that it is, since you've given us code that you say works with no evidence as to why it works yet. — Makoto 27 secs ago
16:49
for code optimization go to codereview.stackexchange.combaptistemm 1 min ago
17:01
0
Q: Subscribe to Event form one service to another

hyperNIn my architecture I have service layer, and for my question two relevant classes in this layer: UserManagementService EmailSenderService In first service there is method: UnsubscribeUser which unsubscribes the user from a mailing list, and after user is successfully unsubscribed it dispatche...

17:46
argh.
OSGi breaks in really peculiar ways
18:14
at least it only took 45 minutes to diagnose why a random dependency was breaking
18:44
You're better off asking on codereview.stackexchange.com instead of here. — Mad Physicist 37 secs ago
ugh... welcome to JAVA development:
19:30
Also, if you want to ask for general comments on non-working code (like this), better to use CodeReview.SEsmci 8 secs ago
0
Q: Optimizing Python loop with Numba for live load analysis

marillionI have written some code that computes flexural moments imposed by different trucks for a bridge with 300 ft length. Truck data are contained in two lists: ax_list and sp_list, which are the axle weights and axle spacings, respectively. There is nothing much to the code, however, this needs to b...

19:55
0
Q: Searching through a TreeView by expanding found results and collapsing others

Toby SmithI have a WPF TreeView which is populated with many child controls. All of them with children themselves are TreeViewItems and all without children are Checkboxes. Currently it has about 1,600 Checkbox children and sub-children. I also have a Textbox which is used to search through the tree by mat...

0
Q: Code Jam2018's 'Waffle Choppers'

Eugene YarmashMy Python3 code for the problem is as follows: from itertools import chain, combinations def main(): T = int(input()) # the number of test cases for case in range(1, T+1): R, C, H, V = map(int, input().split()) # rows, columns, horizontal cuts, vertical cuts waffle ...

What is strFreeLegalFee? Is it some embedded XML, or what? As it is, without concrete details showing a complete Minimal, Complete, and Verifiable example, we can't really comment. And even then this might be a better fit for codereview.stackexchange.comdbc 18 secs ago
20:11
0
Q: Iteration over "zipped" tuples (for_each_in_tuples)

EvgenyI want to implement for_each_in_tuples that takes a functor and one or more tuples of the same size and applies this functor to i'th elements of each tuple for i = 0, ..., size - 1. Example: #include <iostream> #include <tuple> std::tuple t1(1, 2.2, false); std::tuple t2(3.3, 'a', 888); std::...

20:40
@RMunroe LOL. I love it, who is writing the script?
I want a part in it!
I'm voting to close this question as off-topic because this question is working and should therefore be posted on code review. — Andreas 10 secs ago
0
Q: How can I make my Snake game code more readable?

AjeshI have started to code Snake in C++. I am finding it hard to make progress on this project because the code is quite messy. How can I improve the structure of my program? main.cpp: #include <iostream> #include "Game.h" #define FRAMERATE 500 int main(void) { Game game; int count = 0; ...

I'm sinking literally eons into effing OSGi dependency troubleshooting and cleaning
that's so damn ridiculous
There has to be a better way
ya. rewriting the whole project while rewriting the whole project
it's such a royal pain in the backside
20:46
Might be more suited for Code ReviewForeverZer0 just now
20:58
0
Q: Rust OpenGL Chunk class

genfyNew to rust, so I'm not completely familiar with all of its fancy features, but I guess this is a good place to have people tell me what features I should be using. It's a chunk(?) class, not for a voxel game though for rendering chunks of a tilemap. Anyway, here we go: use gl; use std::o...

 
1 hour later…
22:12
If you have a new question, then post a new question. If you want working code reviewed, post it at codereview.stackexchange.com — klutt 1 min ago
22:33
0
Q: Grid drawing code in Ruby - is there a way to calculate the right symbols to use?

Mikey T.K.I have the following function whose job it is to output ASCII grids to stdout. It will be called by another function whose job it is to determine the right "type" of grid box to draw based on its position (i.e., you'd draw a box on the top right of a grid using different characters than the bott...

By the way, once you have a working code the right place for this type of question seems to be codereview.stackexchange.comxdze2 25 secs ago
 
1 hour later…
23:45
If your code is functional and your question not specific, you might want to share your code on codereview.stackexchange.com for improvement suggestions. — Learning is a mess 1 min ago
I see, wasn't aware of that. It doesn't allow me to post immediately, need to wait 40 mins. But, does that mean I shouldn't post code review questions on this forum? — Crypticlight 24 secs ago

« first day (1920 days earlier)      last day (2392 days later) »