Recent changes to a compiler projects create ambiguous use of the "Abstract" word in class names.
Particularly, we have class AbstractTypeData which inherits from TypeData and handles abstract classes.
We also have a few abstract classes, called AbstractTestFinder and AbstractTestWorker. We cre...
"is anyone aware of a simpler solution that I might have overlooked?" is a request for code review, which is off-topic for Stack Overflow, which is tasked with helping debug broken code. Instead, for working code you should ask on Code Review. — the Tin Man47 secs ago
I'm voting to close this question as off-topic because it is about code review, and should be on Code Review. — the Tin Man49 secs ago
I'm a C# developer looking to learn more about Python and how to think in a more functional programming manner.
I have the following which takes a series of grades and returns the average:
grades = [100, 100, 90, 40, 80, 100, 85, 70, 90, 65, 90, 85, 50.5]
def grades_sum(scores):
total = 0
...
Me and my brother were watching television tonight, and he asked me a question that was somewhat along the lines of this:
What would happen if the Earth was made of matter, and the moon was made of antimatter?
I tried to answer this, saying a few things about how atoms attract, and such, bu...
Why is the gravitational force always attractive? Is there another way to explain this without the curvature of space time?
PS: If the simple answer to this question is that mass makes space-time curve in a concave fashion, I can rephrase the question as why does mass make space-time always cur...
I made several classes using ChucK : Strongly-timed, Concurrent, and On-the-fly
Music Programming Language and would like a review. I broke down the logic into a number of classes, all of which are shown below.
This is pretty new to me, and I would appreciate any and all constructive criticism...
I used Quicktime + Soundflower for the screen capture including the computer audio. I used iMovie to assemble it and do the voice-over and background music
I have understood that design patterns are just some things to be followed but not needed to be . Uhm I have a question as to can this code be done better , it basically is supposed to be somewhat of a bridge pattern for a specific calculator costs as though it should be implemented by an interfa...
Please fix your code blocks (needs 4 spaces), and while you're at it a more meaningful title that tells us what your code is doing would be useful, too; showing us your actual, real code (or your real code really says //logic here//?) would also help you get reviews, instead of downvotes. — Mat's Mug ♦20 secs ago
making a CRUD app that can work off CSV files and switch to a database storage, would be an excellent way to get some real abstraction principles in action
when you write a function that does something, you're abstracting its implementation behind an identifier: that function's name takes the place of the implementation.
when you call WriteToFile(filename), you don't care about the inner workings
Dependency Injection simply means whoever is going to need to use that IWriter abstraction, is going to tell whoever instantiates it that, well, it needs to use an IWriter - and it does that by declaring an IWriter constructor parameter
private IKernel _kernel;
public void Start()
{
_kernel = new StandardKernel();
_kernel.Bind<IWriter>().To<ConcreteImplementationOfIWriter>();
var service = _kernel.Get<Service>();
//...
}
the container is just some kind of "mapping" between interfaces and their implementations
And I seem to understand this a bit clearer. So DI is like a socket and the socket is the interface and we can connect different connections to that socket meaning different instances of an interface by using dependency injection right. I mean I don't explain it will but the whole socket thing explains it completely
Well you are actually passing in a Interface as the parameter but when a new instance is made of that class with the DI the new instance reference is the dependency to inject
I had it fixed at one point, but until all the DockableToolwindowPresenter implementations are rewritten, Excel is going to crash on exit ..at least it does in debug mode.
What is the proper use for decltype in type abstraction?
For example, for member types, I prefer to define their type in the class as their type (int, std::string, some class), and then use decltype on all methods that interact with that data. e.g. For a user class with an email attribute, I'd...
Ok this is what I wrote before and people are mad about: I am amateurly making an operating system. For what I'm doing, I couldn't use GRUB as my bootloader so I need to know how to turn assembly into something a computer can understand with no bootloader?
Edit 1: Let me try again. I need to kno...
On sites where I either have 10k rep or am a moderator, I'll sometimes see a clearly-bad post -- incoherent, not even remotely an answer, etc -- that's already been deleted. So yay for the immediate problem being fixed, but not all deleted posts get downvoted first, and sometimes deleted posts g...
When I click on the submit form I get directed to a blank page. Once I click on the submit button, I should stay on the same page and they only difference is I should see a thank you message.
<?php
if ($_SERVER['REQUEST_METHOD'] == "POST") {
$firstName = $_POST['inputFirstName'];
$lastName = $...
I think this site needs a lot more work for it to become a good open-source code review platform. Otherwise, it will be blind-sided by something else soon enough!
My biggest bug bears are:
No sane way to integrate with jsfiddle/jsbin.
Dialog is really really hard.
No integration of linting t...
I think this site needs a lot more work for it to become a good open-source code review platform.
Funny you mention, out of the 112 questions I have asked on this site, 26 are tagged rubberduck - an open-source project... and I'm not done yet.
I've seen a number of alternatives, and honestl...
I meant a good code review platform for open source code. Stack Snipper IIUC is for running code on the page. That's kinda useless. You need HTML/JS/CSS. You need history. In my opinion the iterations must be captured somehow. Each discussion, each refinement needs to be displayed as a story. Not buried in a chat. Code review is a lot about linting. Would be nice if there way a straight forward way of extracting a code snippet (raw URL) to be posted to an external linting tool. — Kai Hendry6 mins ago
I don't understand. On one hand you're saying you want jsfiddle integration, on the other you're saying running the code is useless. Color me confused. — Mat's Mug ♦4 mins ago
I am trying to store same letter to same node. For example: Like say I have person, people is sent to put into a node. This will create two node. I want to some thing like
P: Person People
see Person and people are on same node
But if I run this code it broke in VS
void Tree::insert(TreeNode *&
No, if the code works, but you think it can/should be optimized, repost the working code on codereview and ask for help there. — Lasse V. Karlsen46 secs ago
@soegaard I wrote a first cut of a define-sequence-syntax version. I'm a total noob at this, though, so I welcome any critique you have! (Actually, I should post this to Code Review Stack Exchange and see what feedback I get. :-P) — Chris Jester-Young ♦39 secs ago
in-iterate is a sequence generator that takes a function and an initial value, and the return value of invoking the function on the current value is used as the subsequent value. For example, (in-iterate add1 0) returns the sequence (0 1 2 3 4 ...).
Recently, soegaard challenged me to write a de...
From this question and some help I created a thread safe logging class on which the name of the log file is same as the current date (short date) when the log entry was added. e.g. If I create ten entries today say they will all get written to log file named "07.10.2015.txt". I want to use this c...
I have a Spring/Hibernate application with the following domain class (irrelevant code stripped for brevity):
@Entity
@Data
public class Program implements Serializable {
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
private Long tid;
@Column
@Convert(converter = Prog...
I'm currently looking for a way to do both automated and human code-reviews.
My ideal flow would be the following:
Developers code features separate from the validated-code
When developer is ready, he/she marks feature as complete in our issue-tracker
Developer checks-in the code
An automated...
Unfortunately this question is off-topic for CodeReview - it might be better suited on Programmers. May I suggest that you also look into a linter, possibly, depending on your language? If you're using C#, StyleCop and Resharper will do this for you. Remember to also treat all warnings as errors :-) — A Red Herring10 secs ago
Unfortunately this question is off-topic for CodeReview - it might be better suited on Programmers (don't cross-post it - if it is a good fit, one of our moderators will migrate for you. They're all asleep now, though..) May I suggest that you also look into a linter, possibly, depending on your language? If you're using C#, StyleCop and Resharper will do this for you. Remember to also treat all warnings as errors :-) — A Red Herring51 secs ago
Recent changes to a compiler projects create ambiguous use of the "Abstract" word in class names.
Particularly, we have class AbstractTypeData which inherits from TypeData and handles abstract classes.
We also have a few abstract classes, called AbstractTestFinder and AbstractTestWorker. We cre...
I'm a C# developer looking to learn more about Python and how to think in a more functional programming manner.
I have the following which takes a series of grades and returns the average:
grades = [100, 100, 90, 40, 80, 100, 85, 70, 90, 65, 90, 85, 50.5]
def grades_sum(scores):
total = 0
...
Me and my brother were watching television tonight, and he asked me a question that was somewhat along the lines of this:
What would happen if the Earth was made of matter, and the moon was made of antimatter?
I tried to answer this, saying a few things about how atoms attract, and such, bu...
I made several classes using ChucK : Strongly-timed, Concurrent, and On-the-fly
Music Programming Language and would like a review. I broke down the logic into a number of classes, all of which are shown below.
This is pretty new to me, and I would appreciate any and all constructive criticism...
When I click on the submit form I get directed to a blank page. Once I click on the submit button, I should stay on the same page and they only difference is I should see a thank you message.
<?php
if ($_SERVER['REQUEST_METHOD'] == "POST") {
$firstName = $_POST['inputFirstName'];
$lastName = $...
I think this site needs a lot more work for it to become a good open-source code review platform. Otherwise, it will be blind-sided by something else soon enough!
My biggest bug bears are:
No sane way to integrate with jsfiddle/jsbin.
Dialog is really really hard.
No integration of linting t...
I think this site needs a lot more work for it to become a good open-source code review platform.
Funny you mention, out of the 112 questions I have asked on this site, 26 are tagged rubberduck - an open-source project... and I'm not done yet.
I've seen a number of alternatives, and honestl...
I am trying to store same letter to same node. For example: Like say I have person, people is sent to put into a node. This will create two node. I want to some thing like
P: Person People
see Person and people are on same node
But if I run this code it broke in VS
void Tree::insert(TreeNode *&
I have a Spring/Hibernate application with the following domain class (irrelevant code stripped for brevity):
@Entity
@Data
public class Program implements Serializable {
@Id
@GeneratedValue(strategy = GenerationType.AUTO)
private Long tid;
@Column
@Convert(converter = Prog...
I'm currently looking for a way to do both automated and human code-reviews.
My ideal flow would be the following:
Developers code features separate from the validated-code
When developer is ready, he/she marks feature as complete in our issue-tracker
Developer checks-in the code
An automated...
