@IntensifierDescriptorMan I've learnt far more about "good" in the past 2 weeks of being on CR than a whole year of googling "how to program VBA well" and reading SO answers.
@IsmaelMiguel Yeah, but there's always going to be some ass that comes along and says "Well, that's not the right way to do it! Your're supposed to do it [way user does it].", and then another downvote.
Whether I upvote is basically a result of the balance between what I like in the review and what annoys me. It's « sad » but I'm more likely to upvote a small answer about the algorithm rather than a long review which includes the algorithm part but adds a ton of comments on the style.
That said, I probably wrote such comments about the past in my reviews, but I try to refrain these days.
Except when I review Python. There's an official style guide.
SELECT MAX(epi_id)
FROM #ClientEpisodes
WHERE (
epi_lastname LIKE '%'+ "exceptions".THVSPI_PATIENTNAMELAST +'%'
OR "exceptions".THVSPI_PATIENTNAMELAST LIKE '%'+ epi_lastname +'%'
)
Ugh, wish there was a way to make this thing faster
> (3703 row(s) affected) Routine (4) completed in 63 seconds.
I'm using this the below.
IF EXISTS(SELECT 1 FROM TABLE_NAME WHERE COL_A = 'A' AND COL_B = 'B' AND COL_C = 10)
BEGIN
UPDATE TABLE_NAME
SET COL_D = 'D' COL_E = 'E'
WHERE COL_A = 'A' AND COL_B = 'B' AND COL_C = 10 AND COL_C > 15
END
ELSE
BEGIN
INSERT I...
I know this part seems odd COL_C = 10 AND COL_C > 15. What I'm trying to do is to check if an entry exists. If yes then update it only if that certain column is above 15 (static value). If not insert the entry.
But if my SQL is correct, that's not how his function can work.
@KRyan #pragma once does not offer so many advantages. Name conflicts are orthogonal. That means that you didn't use namespaces properly and you should feel bad about it :( Also, from a speed point of view, GCC at least recognizes include guards and is able to make proper optimizations too. — Morwenn3 mins ago
@Phrancis that's the idea: any foo < 15 is not supposed to get updated
Fair enough, I've retracted my downvote. As for the column names, more realistic ones would help avoiding to come off as "example code", which is outside the scope of this site. — Mat's Mug ♦1 min ago
@Mat'sMug Oh I see. I will change them then. No big deal. — alkis20 secs ago
roomba'd
once OP edited the column names into the post, the question could use an edit to put the top two snippets in quote blocks
The following is a function that that takes an area as an input and outputs some resulting calculations.
I thought an object was useful for creating multiple instances with different custom properties overwriting the defaults to make comparisons easy.
The getter and the setters are there so w...
I mentioned it in the DBA room, I think this might actually be one of those where specific performance optimization concerns might be a better fit there, but I'll let them decide that
my undelete vote would be binding. OP edited their post and almost immediately the 4th and 5th close votes came in. I proceeded to edit, but when I finished OP had deleted the post.
The question is hypothetical, and his comment about the column names, even if I am generous and let that go for the table TABLE_NAME too...... is not enough to give it meaningful context.
it's still too hypothetical for it to make sense.
no way to even guess which columns are string, integers, etc.
IF EXISTS(SELECT 1 FROM TABLE_NAME WHERE COL_A = ? AND COL_B = ? AND COL_C = ?)
BEGIN
UPDATE TABLE_NAME
SET COL_D = ? COL_E = ?
WHERE COL_A = ? AND COL_B = ? AND COL_C = ? AND COL_C > 15
END
ELSE
BEGIN
INSERT INTO TABLE_NAME
(COL_A, COL_B, COL_C, COL_D, COL_E)
VALUES
(?, ?, ?, ?, ?)
END
someone would have started to review it and then OP would have said something like I am doing it because, blah blah blah, and someone would say, we didn't know because, blah blah blah
I've been experimenting with the bitcoinj library and would like some critical feedback. Specifically code correctness, code smells, overall structure, and my usage of futures.
The application leverages the bitcoinj library to generate vanity bitcoin addresses. A vanity address is simply a bitco...
@rolfl what I meant with "you're right", is that there's not enough context indeed - we'd need the table structure and a little bit more info about what it's used for and what it contains, because a composite clustered index over two strings and an integer can't be great; there has to be a reason why the clustered index isn't just a plain integer.
It’s been 7 years and 10,000,000+ Questions since Stack Overflow was launched. The amount of good that has been done for the field - all the developers helped, all the person-hours saved, all the beginners who grew into professionals - is hard to overstate. I cannot express how proud I am of what...
@200_success sounds like a ...reboot.. that will probably end up with tons of blog-post-size-markdown-formatted-with-MathJax-and-shiny-diagrams-and-piecharts posts.
Angular is not exactly a MVC framework, it's a MVW - Model-View-Whatever. You can find an explanation here.
The application has a good structure:
Services to retrieve data from server
Controller to access the services and provide the view model
Html for presentation
A good solution to work ...
I could make out some parts that could be improved.
Good that you have used docstring for the class. You could do the same for the methods. In general, the code could have more comments where things are not obvious. Right now there are hardly any comments.
Python programmers prefer functions_na...
The title is a joke on how some people take a lot of selifes pictures
Recently, in The 2nd Monitor, there was a brief discussion on selfie answers, starting with this post.
At one point, a user said this:
I don't know how many selfies I have :s
I immediately thought: this is the perfect o...
This isn't anything huge or anything,
you can actually get rid of
Dim plaintext As String
This variable is only used to return a value, and you don't need to assign the value to this variable before you return it. it can be returned directly from inside the using statements.
right here
...
He said when the guy I talked to on the phone gave them the report of the call, apparently the guy said I was qualified for most Senior-Level .NET/C# positions...lol
I guess between the Skills Assessment tests they gave me (which my recruiter said I blew out of the water) and the results from that phone call, the recruiter found like six or seven other jobs that he thinks I'm qualified for as well.
The only thing he says is hurting me right now is my lack of on-the-books experience.
@Phrancis - FYI, you've used two constants for the OwnerUserID on your query, which is fine, but you have not actually indicated that there's a join on the OwnerUserId between the tables in th inner-join syntax... Question.OwenerUserId = Answer.OwnerUserID. These hints can help a lot with performance too.
@Malachi Whoops! I apologize; I used very bad wording. You did fine in that top section. I actually meant to say "The points after that point where..."
@Mat'sMug Odd. I have several levels of classes (Form : Framework.Windows.Forms.Form, Framework.Windows.Forms.Form : ContainerControl, ContainerControl : ScrollableControl, ScrollableControl : Control) and it won't automatically recognize properties from Control in a <see> tag.
@Mast Well, he was saying if I can get a couple technical references (project managers I worked for, basically) he can fill the lack of experience in, provided they have good references.
@Mat'sMug Right, but you would think that because Form eventually inherits down to a Control, that the Control is not needed on Control.Size.
@Mast Indeed. I'm actually quite excited about it now.
This recruiting company has contracts all over the U.S. as well, so if I want to move in the future they can probably get me a contract in the area I want to move to. (Provided I do well with them.)
Is it good that I stored the posts in tables, or is it unnecessary?
I would say that it is unnecessary.
Instead of using those temporary tables, you can run a SELECT with a JOIN directly on the Posts table.
Additionally, using the ParentId condition, your @QuestionId and @AnswerId is not n...
I'm voting to close this question as too broad because from a Stack Overflow point of view, that is what it is. If you want feedback about any and all aspects of your code, you should post it at Code Review — Simon André Forsbergjust now
I'm not often the one to point fingers at someone else, but look at SmokeDetector in Tavern on The Meta
it has its' own room, and posts frequently there, but some in main chat
I think a lot of what BB posts is a toy, but I believe it can geniunely be refined
How or what BigBrother will be once refined is what I'm yet to understand
Watching stars is, well, pointless. But, innapropriate words are a bit better, and I think if it watched and was able to tell you how many stars you posted, or directly 'who starred xyz_id post', that might be a bit more helpful
I'm sure BB can be useful. And I'm aware that Stack Exchange doesn't have a limit of how much an account can post (besides the ordinary throttling mechanism, which I'm sure you are aware of). I just think that the format for how/what BB does can be improved.
@Quill yes. that might be a bit more helpful.
I feel like it needs refinement, and a more clear "mission". What should it do and what should it not do? (and why?)
This is horrendous.
I'm using lodash's templating engine for this table. Here's the template for an individual record's row. I've got 5 different table and record-types and a view and edit mode for each row:
<script id="individual-template" type="text/template">
<div class="individual<%= type...
@FrankN.Stein for the record. Code Review is not intended for broken code. As such this question is horribly off-topic for codereview — Vogel61219 secs ago
@SirPython I do that. Except they're still all off-topic, contain no description of their problems, and are most likely written by people thinking that SE is a help forum.
Some of them also look like they're written by 8-year-olds.
I think I might write a post on Meta.Gaming.SE tonight asking for action on these posts.
Have a rule not to commit to (say) master except via pull requests. Then code review, test run has to pass etc (perhaps including automated checks of this kind of thing) before merging to master. — Croad Langshan24 secs ago
I'm using this the below.
IF EXISTS(SELECT 1 FROM TABLE_NAME WHERE COL_A = 'A' AND COL_B = 'B' AND COL_C = 10)
BEGIN
UPDATE TABLE_NAME
SET COL_D = 'D' COL_E = 'E'
WHERE COL_A = 'A' AND COL_B = 'B' AND COL_C = 10 AND COL_C > 15
END
ELSE
BEGIN
INSERT I...
The following is a function that that takes an area as an input and outputs some resulting calculations.
I thought an object was useful for creating multiple instances with different custom properties overwriting the defaults to make comparisons easy.
The getter and the setters are there so w...
Angular is not exactly a MVC framework, it's a MVW - Model-View-Whatever. You can find an explanation here.
The application has a good structure:
Services to retrieve data from server
Controller to access the services and provide the view model
Html for presentation
A good solution to work ...
I could make out some parts that could be improved.
Good that you have used docstring for the class. You could do the same for the methods. In general, the code could have more comments where things are not obvious. Right now there are hardly any comments.
Python programmers prefer functions_na...
The title is a joke on how some people take a lot of selifes pictures
Recently, in The 2nd Monitor, there was a brief discussion on selfie answers, starting with this post.
At one point, a user said this:
I don't know how many selfies I have :s
I immediately thought: this is the perfect o...
This isn't anything huge or anything,
you can actually get rid of
Dim plaintext As String
This variable is only used to return a value, and you don't need to assign the value to this variable before you return it. it can be returned directly from inside the using statements.
right here
...
Is it good that I stored the posts in tables, or is it unnecessary?
I would say that it is unnecessary.
Instead of using those temporary tables, you can run a SELECT with a JOIN directly on the Posts table.
Additionally, using the ParentId condition, your @QuestionId and @AnswerId is not n...
This is horrendous.
I'm using lodash's templating engine for this table. Here's the template for an individual record's row. I've got 5 different table and record-types and a view and edit mode for each row:
<script id="individual-template" type="text/template">
<div class="individual<%= type...
