The 2nd Monitor

RoboSanta

21:00

0

A: Small generic path search framework in Java

Utils Statically importing these methods is questionable - it makes it harder to read code without consulting the list of imports. Triple Don't do this. Use a real class that contains the data you need. Maybe DirectedGraph would be a good name. choose() Should be named better - selectRandomN...

Malachi

what are we talking about here?

Hosch250

> The compiler won't like this because it will be looking for another item in the array,

It likes it perfectly fine.

And it doesn't violate any standards that I'm aware of.

EBrown

Violate all the standards!

Morwenn

@EBrown That was my answer to a question on SO.

EBrown

@Morwenn Seems valid.

Morwenn

21:03

find good coding guidelines and to try to violate them all

EBrown

> You just have to remember that var[3] and 3[var] are equivalent.

Really?

Morwenn

Depends on the language, but yes.

Vogel612

in c++ they are

Dan Pantry

dirty C++ pointer magic

Vogel612

in java that's illegal

Morwenn

21:04

In C and C++, arr[3] is a shorthand for *(arr + 3) so it also works the other way around. It isn't true for an overloaded operator[] but it at least works with pointers and thus built-in strings and arrays.

Mat's Mug

it's illegal, period. C++ is in fact *C<<[1]++

Vogel612

but it's perfectly valid to declare public static void main(final String args [])

EBrown

Nifty.

Morwenn

It would probably have been illegal C++ too if they didn't try to be backward-compatible with C.

Therefore n["abcdefghijklmnopqrstuvwxyz"] will give you the nth letter in the alphabet.

Mat's Mug

that's pretty cool actually

Phrancis

21:10

Pimping a ReallyGoodAnswer™ on DBA

Morwenn

Eh, that means that before coming to Code Review, I actually mastered "how to write bad code".

5

Dan Pantry

@Morwenn Don't feel too bad.

We have a contractor in work right now with 17 years of experience in C# who didn't know how switch worked... or how to use regular expressions to extract things within quotation marks from within XML. Or how to use XML parsing libraries to do it either.

Morwenn

But did he know pattern matching?

Dan Pantry

Today I taught him how to use a regular expression to extract something from the equotation marks from something like this:

<Node Content="FooBar"></Node>

Now, granted, you wouldn't usually use Regex for parsing HTML, but he only wanted that specific attribute so it was the simplest solution.

Compared to what he was trying to do, which was use string.indexOf to get the first quotation mark, and then find the next one and substring it.

The only problem is he couldn't work out how to get the next quotation mark because it was all one big contiguous string

Morwenn

x)

Dan Pantry

21:15

17 years of experience and is a contractor

Duga

I'm voting to close this question as off-topic because this belongs on Code Review, rather than being a specific question about software development. — Jeff Bowman 11 secs ago

Dan Pantry

He also asked our tech lead if his name was common in China

Captain Obvious

0

Q: Caesar Cipher Encryptor in Ruby using ASCII

As the title says, I have built a Caesar Cipher in Ruby that utilizes ASCII for the encryption. I am not sure whether or not this was the best way to go about the task but this way made the most sense to me. My code is below. Please give me any feedback that comes to mind. Thanks puts 'Please en...

Dan Pantry

...our tech lead is vietnamese

Morwenn

How did he even mistook one for the other? The two languages have like nothing in common.

Dan Pantry

21:17

Well our lead wasn't speaking vietnamese or chinese at the time

He just went off of how he looked

Which.. is arguably worse

2

Morwenn

You either admit you don't know shit or simply totally ignore one's origins, but never go for random guesses.

Dan Pantry

It was lucky our lead took it as a joke

that sort of thing is grounds for dismissal in the UK

Mast

@DanPantry No, you don't parse HTML with regex.

Dan Pantry

@Mast I said that :-)

Except he wasn't trying to parse HTML, he was just trying to extract a string from an XML doc

It was either crank out the XDocument API or use something like grep to do it

Duga

Since you have working code, this question is not appropriate for SO, but is for Code Review. There you will get both an analysis of your existing code and suggestions for improving it. — Cary Swoveland 27 secs ago

Dan Pantry

21:21

in this instance regex would have resulted in less lines of code... and given the contractor hadn't used that API straight away, it would mean that he would have had to learn that as well

Mast

@Duga What he will get is up to us, not to some random SO use who thinks he knows what we should and shouldn't.

Vogel612

@Mast shhhh.

Mast

I've never understood the obsession with lines of code. Readability over code length...

Vogel612

don't tell them we just decide at random what to tell them and what to laugh about here :)

5

EBrown

@Mast That.

@Vogel612 Someone should tell him.

Duga

21:29

No, I think your code doesn't work correct. If cell at (0,0) is 0 your code will create a matrix - step by step- that ends in a matrix with all cells are 0. Right? So this isn't a question of codereview or refactoring. It's a question of, why does the algorithm not work correct. ;-) — dev.null 11 secs ago

Mast

Just when you think you wrote some kind of decent code, Janos comes by and shows you a way better way of doing things.

5

Dan Pantry

I'm off to bed. I will leave you with the happiest lizard in the world.

i.imgur.com/yIux55f.webm

Ismael Miguel

21:49

Greetings

Quill

@Mast To beginners, saying 'I've written 100 lines' (by adding empty ones) is better than saying 'I've written 50 lines'

Maybe not just beginners

Morwenn

@Mast Spaces everywhere. Many lines. Much great code. Wow.

Ismael Miguel

I hate doge

Quill

-1

A: MySQL JOIN to JSON array

This is not vastly different but you might think its a little easier to read and follow and probably therefore debug. // get all the posts and their photos $st = $db->prepare ('SELECT * FROM `posts` ' . 'LEFT JOIN `photos` ON `photo_post` = `post_id`'); $st->execute (); // i...

You have presented an alternative solution, but haven't reviewed the code. Please explain your reasoning (how your solution works and how it improves upon the original) so that the author can learn from your thought process. — Quill 2 mins ago

I did, i.e. easier to read, follow, debug — RiggsFolly 1 min ago

That is an observation of your rewritten code, not a review of the author's existing code. — Quill 1 min ago

Morwenn

@IsmaelMiguel Doge hates you too, you meanie ><

Duga

21:56

I'm voting to close this question as off-topic because it belongs on Code Review. — the Tin Man just now

Mast

@Quill No, it's not. It's a terrible practice.

Ismael Miguel

@Morwenn angrywoman.gif

"I ATE YOUR DOGE, TASTE WAS GOOD"

Quill

@Mast What's not? Exaggerating the amount of work you did?

Mast

@Quill Measuring productivity/progress in Lines of Code.

Quill

@Mast Oh, it's a terrible practice

I'm most certainly condemning it

Mast

22:01

TTGTB

Quill

Is it a good enough point to allow the OP to make the decision on downvoting this answer? — RiggsFolly 4 mins ago

A) I don't give the author permission to downvote B) I downvoted it, lol, I obviously had a problem with it

@Quill Ok I think I am getting the hang of this site now. Thanks for the gentle push in the right direction — RiggsFolly 2 mins ago

Simon André Forsberg

22:17

in other news: rumors say that SO's gonna reach 10 million questions today

Hosch250

That so?

Shall I go ask one, or flag one, or something?

BTW, that GIF is driving me nuts.

Mast

They need 750 more.

Can easily be done in 24h.

Last chance to make a prediction:

53

Q: Let's predict the date of the ten millionth question on Stack Overflow

You know, if someone were to post "Predict the date of the 10th million question on SO" and ping me with a link, I'd endorse it with an offer of a swag box to the person that came the closest :) So, when will it happen? Rules: The question must last (not be deleted) during the entire day t...

discussion 10m-questions-milestone

But I think I was heading for bed...

/wave

Hosch250

> | 2015-08-19 | Dom |

> | 2015-08-20 | Jeremy Banks♦ |

We have 7 more hours (my time) for Dom to win. Otherwise, it is Jeremy Banks.

UTC, Jeremy Banks will win I think - just 1:30 more hours.

Duga

Optimizing working code is off topic on here. This site is for fixing broken code. You can try codereview.stackexchange for optimizing code. — deathismyfriend 1 min ago

codereview.stackexchange.com seems to be a better place for this. — Eser 51 secs ago

Captain Obvious

22:36

0

Q: Two sum algorithm variant - Optimization

I need to compute the number of target values t in the interval [-10000,10000] (inclusive) such that there are distinct numbers x,y in the input file that satisfy x+y=t. I have the code which does work and would like to optimize it to run it faster. public static int Calculate(int start, int fin...

c# algorithm data-structures

Duga

I'm voting to close this question as off-topic because this is advised to post in codereview.stackexchange.com — PushCode just now

Malachi

lol (And don't disemvowel)

6

lol

2

Quill

23:01

@IsmaelMiguel, you can use --- instead of <hr> to format line breaks

Ismael Miguel

@Quill I know

I'm used to <hr>

Phrancis

monking

Ismael Miguel

Greetings

Quill

hello

Why does tag:c#.net exist?

Malachi

because people that code C# are smarter than people that code VB

we already know whether we are coding for the .NET framework or not

RubberDuck

23:07

Lol

4

Malachi

what do you think @RubberDuck? you code in both languages don't you?

Phrancis

> Did I just miss a lol-fest?

Malachi

almost

Phrancis

lol

4

Quill

lol

4

Malachi

23:09

lol

Ismael Miguel

lol

4

RubberDuck

Yes @Malachi often in the same solution, which leads to lots of VB#

What do I think about what though?

Malachi

lol

4

Phrancis

@Mat'sMug After looking into that thing more, apparently that GUID is added into that field in the order record by design, and there is a job that runs overnight that assigns actual proper IDs then, and at that point the customer interface picks it up and can send it back to the supplier to be fulfilled (or something much like that). The guy I talked to did mention EDI so you were right on that account.

Also, this seems pointless

		DECLARE @mappedId varchar(50)
		SELECT @mappedId = Convert(varchar(50), NewId())

Malachi

17 mins ago, by Malachi

because people that code C# are smarter than people that code VB

RubberDuck

23:32

I don't think we're smarter. I just think VB people haven't seen the light yet. They can't see sharp yet.

6

Malachi

@RubberDuck you know why Java programmers need glasses?

because they don't C#

Quill

I can't see the review of my suggested tag edit, is that normal?

Ismael Miguel

@Quill codereview.stackexchange.com/review/suggested-edits/43004

It's pending. You can see here: codereview.stackexchange.com/users/62429/…

Quill

On the tag page, the hyperlink bringing me there is blocked

On a normal post edit:

Ismael Miguel

I think it is a bug

Quill

23:43

0

Q: Unable to view tag edit review

When submitting a question / answer edit (below reputation requirement for instant), you get a response box like this: However, when you edit a tag, you get: Notice the lack of the hyperlink, bringing you to the review. Both tag edits and post edits hit the Suggested Edits queue, so then w...

feature-request bug tags suggested-edits

Ismael Miguel

You forgot to mention that the edit is visible on the all actions' tab

Quill

except I can't see that on sites where my rep is too low anyway

Ismael Miguel

really?

Quill

oh, I can see my edits

but the page should still provide me with a hyperlink

Ismael Miguel

... That's what I said...

You can see the edit on your profile page, on the "all actions" tab

Quill

23:52

@IsmaelMiguel yeah, I didn't think you could (I was wrong), anyway:

2 mins ago, by Quill

but the page should still provide me with a hyperlink

Ismael Miguel

I know, and that's why I upvoted the question

Quill

ty

Ismael Miguel

You're welcome

It's a small bug that needs to be sorted

I just wish they would fix the bug on IE

Quill

It feels so slow around here lately, maybe I'm just missing the action while I'm asleep

Hosch250

@IsmaelMiguel Too late.

If it is fixed, it will be in Edge.

(I don't like Edge, I like IceDragon, with IE second.)

But then, I'm not a web developer.

Ismael Miguel

23:56

@Hosch250 The bug affects IE9-11 but not IE8 and probably it will afect Edge as well.

@Quill It has been quite energetic here

In the wrong way

Hosch250

What bug?

Ismael Miguel

When you edit a comment, THE WHOLE ENTIRE FUCKING PAGE WON'T DO ANY FUCKING THING

Sorry the wording

But I can't stress those words enough

The page craps out

Hosch250

Oh, that. Just CTRL-F5.

Ismael Miguel

Doesn't scroll

That's a refresh...

Hosch250

Yeah, I've experience that - and not just on IE.

Ismael Miguel

23:58

F5 works too

Well

You may want to update on the meta

Quill

@IsmaelMiguel there's usually a stream of duga, interesting new posts, and ~~discussion on how C# is better than Java~~ post related site business

Hosch250

I won't, because I'm only 98% sure on that last statement.

I might be remembering wrong.

I do know that it only happens when you edit twice in a row, though.

Ismael Miguel

13

Q: Bug: Stack Overflow not clickable anymore when saving comment edit with enter

Occurs on IE11 EDGE mode win8.1 (My pc). User Ismael Miguel notified me that this problem also happens on versions IE9 to 11 from Vista to 8.1, but not on IE8. Still occurs on IE Edge WIN 10 PRO. Time to take a look at it. The problem: When you edit your comment and save it using enter it keep...

bug internet-explorer

Transcript for