The 2nd Monitor

Morwenn

11:01

By the way:

1

I was just wondering is there a better way to implement a binary search than I am in my code? My function is taking 2 two lists - first_booth_voters and second_booth_voters with second_booth_voters being sorted and first_booth_voters not sorted. I feel like I am making an unnecessary amount of co...

Why was the indentation edit rejected?

Vogel612

cuz python

and we don't edit for correctness / indentation of code

Quill

9 mins ago, by Quill

no thanks

Heslacher

@Quill Skips aren't public. You can click on the link at the bottom of the history page "my review history" to see yours including skips. So I guess mods can see those too.

Vogel612

editing for correctness is bound to be guesswork

and editing indentation in languages that don't depend on it for scope and "working" is removing a point to review

Quill

^ that exactly

Morwenn

11:04

While I agree on the principle, that one is just too obvious.

Vogel612

@Morwenn that was the second edit doing that on the post

the first one was rejected too

Heslacher

Anybody knows Cachè object script from intersystems ?

Vogel612

actually we should close and have OP edit

and they actually were able to get indentation right on SO... what the..

Ismael Miguel

I rejected both edits

The message is clear enough:

1st edit:

> Whitespace and indentation are part of the review. Editing those will change the answers. In case of Python, it changes the code scope as well

2nd edit:

> Changing the whitespace will change the reviewers' answers. Also, Python relies on whitespace for scope. The O.P. was informed already.

The user isn't registered and has been over 1 hour since the used dropped this code here and left

He is unregistered

There's a probability that it was a hit-and-run

Morwenn

IMO, we're in a case where OP couldn't mean anything else and just got confused by SO's indentation quirks. Moreover, there are no answers to invalidate yet.

Ismael Miguel

11:11

Still, it changes the code

And it is just a guessing game

You can argue that it is easy to spot that there's indentation missing and it's trivial to know where

Which I agree

But what if his intention is different?

What if he wanted to write something else?

In my opinion, the procedure was stupid but the right thing:

reject code edits and warn the O.P.

Vogel612

@Morwenn the SO post found by ... alexwl.. whatever.. Has the indentation right, so that's not it

Ismael Miguel

Honestly, I'm against any code change

Morwenn

@Vogel612 I looked at it. The indentation isn't right either.

Vogel612

@IsmaelMiguel unless question is closed as borken and OP fixes it

Morwenn

I sometimes do code changes. Generally, it's adding obvious comments where they are missing are adding obvious Python indentation when it's clear that the problem comes from a bad SO formatting.

Ismael Miguel

11:18

@Vogel612 The O.P. is an exception, obviously. That is perfectly acceptable. But only if it doesn't invalidate any answer.

I do code changes as well

Vogel612

@Morwenn but not if you have to indent more than one level

because then you begin making assumptions

Ismael Miguel

But once there's an answer, whatever freaking bug/mistake there is, I just swallow it up

Morwenn

@Vogel612 That one is obvious, especially with the SO question linked. I would be more concerned with the fact that the algorithm may not work.

Captain Obvious

0

Q: New thread each time a message received?

My application needs to listen for incoming messages on three sonicmq topics. I have requirement : Everytime a message is received, i should wait for 5 seconds and then start the processing. Also i should be able to receive other message(s) on the same topic(s) while a message processing is wai...

java multithreading spring jms

Morwenn

Ok, I voted to close anyway since the code is broken independently from the indentation.

Captain Obvious

11:34

0

Q: Program that prints all the combination of two numbers that add/subtracts to zero

the program should input a number and print out the possible combinations that equal to zero. Numbers should be in order when printed ex. Input: 3 Output: 1 + 2 - 3 = 0 Input: 4 Output: 1 - 2 - 3 + 4 = 0 Input: 7 Output: 1 - 2 + 3 + 4 - 5 + 6 - 7 = 0 1 + 2 - 3 + 4 - 5 - 6 + 7 = 0 ...

java c#

Ismael Miguel

@CaptainObvious Request to write code

RubberDuck

@Donald.McLean just heard The Cure on the radio and all I could think was "But it's only Wednesday". =;)-

3

@CaptainObvious September came early this year.

Vogel612

@IsmaelMiguel we're getting more of these, right?

Captain Obvious

0

Q: How to make a PHP Router class, SOLID and gain performance

I made a simple routing class that I like to get reviews for, mostly because I do not know how to make it SOLID, since I even made this class separate from the http response, request ... for the sake of SRP. All this class does is route-specifi, that seems like SOLID enough to me, but what do I...

php oop design-patterns http framework

Donald.McLean

@RubberDuck LOL

Ismael Miguel

11:43

@Vogel612 Sadly, yes we are

Quill

@RubberDuck september?

Vogel612

@Quill in two weeks it's september

Quill

Yeah, but I don't get the joke

Ismael Miguel

Please, @CaptainObvious, explain the joke

Was the September challenge already defined?

-2

Q: Program that prints all the combination of two numbers that add/subtracts to zero

the program should input a number and print out the possible combinations that equal to zero. Numbers should be in order when printed ex. Input: 3 Output: 1 + 2 - 3 = 0 Input: 4 Output: 1 - 2 - 3 + 4 = 0 Input: 7 Output: 1 - 2 + 3 + 4 - 5 + 6 - 7 = 0 1 + 2 - 3 + 4 - 5 - 6 + 7 = 0 ...

java c#

Anyone want to hammer that?

Vogel612

@Quill urbandictionary.com/define.php?term=Eternal+September

Quill

11:48

@Vogel612 oh, right, they call that 'summer' on 4chan

Vogel612

yea, because for 4chan it happens in summer

Duga

offtopik. Move to code review. — Alexei Kaigorodov 37 secs ago

Vogel612

no school -> influx of new anons to /b/

Duga

@Trengot: you should not post broken code on codereview.SE. It is likely (90%+) that the given implementation is broken unless tests prove otherwise. — J.F. Sebastian 39 secs ago

@J.F.Sebastian Sadly, you are late. The question was asked and closed as broken. — Ismael Miguel 41 secs ago

Mast

@Quill In the past, the effect was more obvious. It's more of a legacy joke now since many people have internet at home now.

@IsmaelMiguel It will be defined on the first of September.

Ismael Miguel

11:57

@Mast I hope it isn't the boring a$$ chess thing.

Mast

@IsmaelMiguel Feel free to add suggestions or re-state old suggestions.

Ismael Miguel

The suggestion I want is already there, but tied with the chess thing

RubberDuck

Eternal September

In Usenet slang, Eternal September (or the September that never ended) began in September 1993, the month that Internet service provider America Online began offering Usenet access to its tens of thousands, and later millions, of users. Before then, Usenet was largely restricted to colleges and universities. Every year in September, a large number of incoming freshmen would acquire access to Usenet for the first time, and would take some time to become accustomed to Usenet's standards of conduct and "netiquette". But, after a month or so, these new users would either learn to comply with the networks...

Mast

@RubberDuck Funny, urban states it was 1994 instead of 1993.

Ismael Miguel

@Mast I had to double-read the first word. Quickly looking, it looked to start with a P

Anyway, time to go home and eat, and hope I don't feel bad again

Ismael Miguel

12:27

I'm back

nhgrif

12:38

It may not be September quite yet, but school is back in session.

Dan Pantry

monkeroni

RMunroe

Yes, it took a lot of work to make the cards and pieces, but it's worth it--the players are way more thorough than the tax prep people ever were.

11

Ismael Miguel

Yeah, another burnt pizza to the count

nhgrif

Cooking pizza is far from difficult.

3

Ismael Miguel

Yeah

EBrown

12:53

@nhgrif Indeed. The package pretty much tells you exactly how to do it.

Ismael Miguel

@EBrown There's no "package". It isn't a frozen pizza

EBrown

"Preheat oven to 400F", "Remove pizza from box, cardboard and wrap", "Cook pizza for 22-25 minutes".

Ethan Bierlein

@IsmaelMiguel What, are you making a pizza from scratch?

Ismael Miguel

No idea what is 400ºF

@EthanBierlein Nope. Supermarket pizza. But it isn't frozen.

Quill

@IsmaelMiguel 204celsius

Duga

12:56

Yes, it is better for the variable names to be clear. For more guidance you can submit working code to the Code Review site — ChipsLetten 13 secs ago

Ismael Miguel

@Quill I think mine was around that temperature

EBrown

Well my instructions were the Digiorno instructions, if that is not what pizza you have I cannot be held liable.

3

Ismael Miguel

pingodoce.pt/pt/produtos/a-casa/pizzas

That's the kind of pizza I have

I bought there, but the pizza isn't listed there

Ethan Bierlein

@IsmaelMiguel Now I'm hungry

Ismael Miguel

@EthanBierlein I'm hungry as well. But I won't be in a while

Vogel612

12:58

burnt pizza is still pizza?

Ismael Miguel

Yup

It was in the over only for 30 minutes

It's burnt, but still edible

EBrown

Why do I have three tasks waiting for resources on my SQL server...

Ismael Miguel

Windows server?

Mast

@IsmaelMiguel Why am I not surprised you burned another pizza ^^

2

Malachi

@Heslacher I see

Ismael Miguel

13:01

@Mast Because history repeats itself and I'm bound to either burn myself or burn my pizza

EBrown

I wonder if the backup is running right now...

Ismael Miguel

Today, it was both

skiwi

Is there a term for compression backups in the following case? I've been making backups of some folders like once every month for the past years, but it uses Times x Storage amount of data; I want a setup that looks more like Git though

EBrown

@skiwi Are you thinking Differential or Incremental?

skiwi

@EBrown Most likely yes :)

Ismael Miguel

13:03

@skiwi LOL

skiwi

I want to change a bunch of full backups into a differentia backup then

EBrown

@skiwi Yes.

Ismael Miguel

He asked if you want to store the differences or if you want to store the changes files

EBrown

Usually you do a full backup on a regular schedule, then you setup either a differential or an incremental backup that runs more frequently.

burian.vlastimil

Hello, could someone help me, give me upvote or something? I would like to set a bounty +50 on a question. But I'm missing 4 points, arrrgh :(

skiwi

13:05

Hmmm okay

burian.vlastimil

I guess not

EBrown

@burian.vlastimil You can pimp it here.

skiwi

The case here is that I have say 60 full backups, I want to turn those into a single full backup and then 59 differential backups

Ismael Miguel

And please, don't ask to ask if you can ask

Ethan Bierlein

@burian.vlastimil You're welcome ;-)

EBrown

13:06

@skiwi I'm not sure if you can do that, I've never converted an existing backup schema like that.

burian.vlastimil

Thank you very much

skiwi

@EBrown Hmm... I'll need to figure something out then

Vogel612

@skiwi actually it should be simple..

EBrown

@skiwi It all depends on your backup utility.

Vogel612

since you can generate a diff from full backup to full backup rather simplistically it should be fine

it shouldn't be hard to convert from the one strategy to the other

it can take some time though...

skiwi

13:10

@EBrown No backup utility ;) Did them all manually?

It's Dropbox backups, so they should be relatively safe anyway

burian.vlastimil

I don't want to bother you, but I cannot fiigure out how to place the bounty, it tells me "question eligible for bounty in 2 days", I translated it probably wrong, I thought I can place the bounty today and tomorrow, but I think it means that I cannot right now,.. ?

EBrown

It means you cannot place a bounty until the 2 days have expired.

Ismael Miguel

@burian.vlastimil You have to wait 2 days

burian.vlastimil

oh

EBrown

Questions cannot be bountied until 2 days after they have been asked.

burian.vlastimil

13:15

ok, I will wait

Vogel612

@burian.vlastimil wait wat.

Mast

@burian.vlastimil I can't find your CR account. Do you have one?

Vogel612

your network account does not list a codereview account...

burian.vlastimil

I dont know what that is

so I dont have any I guess

Vogel612

you have an account with 99 reputation on Unix & Linux

burian.vlastimil

13:17

yes

Mast

This is the Code Review chat.

Vogel612

as well as one with a single rep on Stack Overflow, Ask Ubuntu, Information Security and Super User

Malachi

@Heslacher I changed my answer

Heslacher

I voted your answer

Malachi

@RubberDuck, you undeleted your answer? isn't that cheating? :)

thank you @Heslacher. who do you think we can bump out of the top 8?

Heslacher

13:20

Janos ;-)

2

Malachi

you smoked me yesterday.....

burian.vlastimil

what is it I should do, do you need of me to do anything right now? I am quite tired

Malachi

but I did get XNA running on my machine last night. so it will be Game coding FTW!

Vogel612

@burian.vlastimil no we're just a little confused why you came to this chatroom :) rest well

Heslacher

@Malachi I am just happy that I will keep trusted user privilegs

burian.vlastimil

13:21

have a nice day! all of you

nhgrif

@EBrown Some of them specify leaving the pizza on the cardboard.

EBrown

@nhgrif The ones I get don't. (I've never actually seen one specify such.)

Malachi

@Heslacher agreed! we might make it to that new privilege before they get it implemented

nhgrif

@EBrown I think the Great Value brand thick crust pizzas specify this. It's pretty rare, but I have seen it.

EBrown

@nhgrif Well that's nifty. The instructions I provided are the ones I memorized from the Digiorno pizzas...lol

Mast

13:22

@Malachi You probably will.

nhgrif

I mean, they also all say "for X minutes or until..." with some reference or description of the color of the cheese or the crust.

Also... 22-25 minutes is pretty long. I've seen some specify 12-14 minutes.

And also, in a real pizza oven, it takes like 7.5 minutes.

Mast

@nhgrif Depends on how hot you put it.

EBrown

I usually get Jacks (which is 18-20) or Digiornos (which is 22-25).

Mast

The thin pizzas are usually prepared in a hotter oven, so the time goes down to around 12 min.

The thicker ones are done lower so they need 25

nhgrif

Right.

Mast

13:26

A real pizza oven (the expensive ones at least) have the air flow set-up for pizzas so they can go on a higher temperature with the same result, shortening the necessary time.

nhgrif

But either way... I don't see how you burn multiple pizzas. Just use the scientific method.

If the last one burned, cook the next one for shorter time or on a lower heat or both.

Vogel612

do a binary search on the time necessary, eh?

Mast

@IsmaelMiguel This is what, the 11th you burned?

nhgrif

Also, start keeping a closer eye on it.

Ismael Miguel

@Mast Arond that.

nhgrif

13:27

You can tell just by looking whether or not it's ready.

Ismael Miguel

@nhgrif I know that

I just forget the pizza

nhgrif

well don't do that.

Ismael Miguel

And either sit on it or let it burn in the oven

nhgrif

actually, if you sit in the same room as the oven, the instant you start smelling it is usually the exact same instant it's ready to come out of the oven.

EBrown

Something tells me I don't need a Size and Scale parameter on this Camera class...

Mast

13:28

Ismael Miguel

The kitchen is a little far from me

@Mast What a nice idea!

Back in 2009, I made a clock that would alarm me after a set time

Mast

I made one in my first year of my EE bachelor. Of-course, we built our own clock, own division and made it unnecessary bloated, but it worked. Not worth it for regular use though.

nhgrif

Size and scale are different metrics...

Mast

Buy one of those eggs, they cost next to nothing.

Ismael Miguel

They cost a lot

Duga

13:31

@Quill - Indeed. I had not intended to suggest that Code Review could solve the primary problem here, but there might be some worthwhile suggestions about using arrays, specifying vertices, etc. — James McLeod 15 secs ago

Ismael Miguel

As much as 1-2.5 pizzas

nhgrif

Well, you've burned 11...

Ismael Miguel

But ate 10 of those

nhgrif

So by the time you don't burn 3, it has paid for itself.

Ismael Miguel

Your logic is correct

Mast

13:32

@IsmaelMiguel With your cooking skills, you get the value of the timer back in no-time.

Ismael Miguel

@Mast I don't cook. I just throw it in the over, turn some knobs and done

Today I even went as far as burning my fingers in the glass :/

Mast

@IsmaelMiguel Exactly.

Ismael Miguel

But anyway, time to go to work

Mast

@IsmaelMiguel I hope you got your computer a long distance from the kitchen, in case you burn the whole thing down.

Ismael Miguel

I'll be back in 20-40 minutes

@Mast It is actually around 10m away

(meters, not minutes)

Anyway, BRB

RubberDuck

13:37

Cheating @Malachi? Nonsense. Heck, those are two of my most under loved answers.

I posted the second one separate because OP seemed to question its validity. I figured it was best to let people vote on them separately.

Malachi

which one is the second one? the Enum one?

EBrown

@nhgrif Yeah, but I think Size is supposed to represent Scale in some manner, on this class.

nhgrif

That doesn't make sense.

EBrown

How so?

nhgrif

Size and scale are different things.

EBrown

13:41

Size represents the viewable area, Scale represents the factor to increase/shrink it...I suppose they could be left separate.

nhgrif

Yes, they are separate.

EBrown

I'm not sure what I was thinking here.

I don't actually think I need the Size property.

nhgrif

I don't know what you're doing, so I can't say.

EBrown

Well this class is supposed to be a class that can follow an object and represent the offset where things should be rendered.

nhgrif

Then you probably need both, I'm thinking.

Consider iOS development.

EBrown

13:42

I'm not sure what I would need Size for, though.

Malachi

@Heslacher I just want to get out of 13th place

nhgrif

The iPad comes in two variants, retina and non-retina.

Heslacher

@Malachi Should I downvote some of your answers ?

Malachi

LOL......Not Funny

:P

nhgrif

All iPads have a "size" of 768x1024

All though the retinas have a scale of 2x versus the non-retina.

Retina renders 4 pixels in place of 1 in non-retina.

Importantly, also, the iPad and iPad mini both have the same size. 768x1024. But they have different scales. One has a smaller screen... but they both render the same amount of pixels.

For an image to have the same physical size on a retina versus non-retina iPad, the retina version must be rendered with twice the length and width as the non-retina. (Fortunately, this is handled basically automatically for iOS devs, but the point remains the same.)

Vogel612

13:48

hmm.. interesting... I'm still on page one with rep for this month??

EBrown

@nhgrif That makes sense.

I suppose I'll leave them both for the moment then.

skiwi

When you do a git revert of a commit 10 commits back, then it just reverts that single commit, right?

nhgrif

@skiwi Yes, I believe so.

EBrown

Damnit, now I haven't the foggiest on what a good Summary for a Camera class would be.

Captain Obvious

0

Q: Computer guesses the user's number

After the feedback for my last script, I realized I should be using functions and trying to adhere to the style guide. I tried to do that here, though still very beginner. The rounding in Python confused me a bit, and originally the program got stuck for some numbers when the range narrowed down...

python beginner python3

0

Q: Reviewing a moderately-sized spreadsheet project for readability, robustness, re-usability and scalability

N.B. Apologies if this question is too broad / otherwise off-topic. I had a look around CR Meta before posting and would've asked for a review of my question before posting it but I don't have the rep to ask meta questions yet, so here we are. What I'd love is to know somebody who could show me ...

vba excel

nhgrif

13:51

@skiwi If you want to roll back everything to a specific commit, I'm not sure what the git command would be or look like, but Source Tree has a...

reset <branch> to <commit>

skiwi

@nhgrif That's git reset I believe

EBrown

Does anyone have any comments on whether the pending edit to this answer is appropriate?

It came up in the queue, but I'm not convinced it's acceptable. (I'm not convinced it's not, either, which is why I ask.)

Vogel612

@skiwi you can give a commit range / list to git reset

Malachi

@EBrown what are you creating? just the wrapper for XNA Framework?

EBrown

@Malachi Yeah, it's a Camera that may be used to help determine where rendering for 2D work should take place.

So that you don't need to render that which is outside the Camera, etc.

Vogel612

13:56

@EBrown I'd say yes, it's an edit that significantly improves the illustration and makes the answer much clearer without subverting the original author's intent

nhgrif

It's not a valid edit.

Those get rolled back on SO non-stop.

Vogel612

it makes a true, but not really good answer into a very good one

nhgrif

The editor is welcome to post their own answer.

Vogel612

it's just a clarification

not a wholely different approach

HMM...

@nhgrif was that really necessary??

nhgrif

yes. It was an invalid edit.

Vogel612

13:58

I don't think so

I think that the rollback was not justified

I don't want to start a rollback war

nhgrif

It's an invalid edit, @Vogel612

Edits like that are always declined on SO.

Vogel612

with what reasoning?

nhgrif

In this case, I don't see any reason for CR to be different.

Vogel612

@nhgrif that's not really a valid reason to decline an edit

nhgrif

That's not the OP's answer.

Vogel612

13:59

"because they are always declined"

nhgrif

The reason given on SO is "attempt to reply"

Which makes sense.

Transcript for