« first day (797 days earlier)      last day (3519 days later) » 

23:06
hello there
:) All worthy candidates so it was hard to choose
wow, an actual good question for code review
I must be dreaming
@EthanBierlein Thanks for the accept :)
23:10
0
Q: Connect 4 (glorified tic-tac-toe) implementation

InBetweenI'm posting here my implementation of the game Connect 4. It's obviously a pretty trivial game and code but I'm primarily interested in any advice concerning improvements to the code structure: types, dependencies and coupling, concerns, etc. I'm interested in attacking more complicated games bu...

@Phrancis You're welcome!
trying to work out whether I should use unix pipelines or something else in my project to communicate between services
well, not between
Martijn Pieters took a break from SO to come vote here :)
Meh
@CaptainObvious Well, I was going to try and answer that, but the code is written in spanish.
@ethan olé
23:16
@EthanBierlein Eh, there's always Google Translate :)
I've answered a complicated SQL question where every table, alias etc. was in German. Man that was a challenge. But I think in the end I got an accept!
Is there any chance you could translate the code to English? A lot of reviewers are English and your question is also phrased in English. Some context might be lost via google translate. I appreciate this is a lot of work so if not we'll just have to wait until someone fluent in Spanish comes along :-) — Dan Pantry 24 secs ago
Is that a fair thing to ask? I don't want to sound bigoted
That's pushing it a bit IMO
Alright, my bad then
We want to include mandatory code reviews in the gated commits. I know I can do this (without git-flow) buy using pull requests from my feature branch to the development branch, but then I can't use the nice tooling. — user1489609 16 secs ago
bad @duga
23:21
I think Jeroen knows some Spanish... and several of us know French so it's not that hard to follow along
If we take the position that naming matters, then translation ruins that aspect of the review.
Example:
7
A: From sounds (Hz and seconds) to musical theory

200_successThe examples you included with nearly every procedure are very helpful. Nevertheless, this is a large library of about 100 procedures, which makes it hard to learn. Some simplifying strategies include: Writing a synopsis or demo. A couple of interesting use cases, written as comments or unit...

    public class Program
    {
        static void Main(string[] args)
        {
            var juego = Juego.CrearJuegoConsola(NivelesDificultad.Dificil, ColoresJugador.Rojo, false);
            juego.Jugar();
        }
    }

    // roughly translated
    public class Program
    {
        static void Main(string[] args)
        {
            var game = Game.CreateGameConsole(DifficultyLevels.Difficult, PlayerColors.Red, false);
            game.Play();
        }
    }
DifficultyLevels and PlayerColors
Oh, nice catch
0
Q: Two groups of Buttons but with same class name

I'll-Be-BackI have two groups of two buttons (status). If you click on Complete or On Hold it will change the background color of the button. I am using same class name for all the buttons but each group of buttons have data attribute data-section='Park One' and data-section='Park Two' See working example: ...

23:34
2
A: Selecting Employee details from a complicated schema

PhrancisPlease keep in mind that I do not speak German, so I used Google Translate. Excuse me if some of the terms are unclear or mistranslated. Comments As written, your English comments are not helpful. -- Add the parameters for the stored procedure here -- declare my intern parameters ...

That ^^ was a PITA to work out lol
0
Q: Swift: For Loop with Index to Functional

user1107173Trying to simply my code below: for (index, point) in enumerate(self.points){ let pointButton = UIButton() pointButton.frame = point.bounds self.view.addSubview(pointButton) } Is there a better way to accomplish this through .map .filter or .reduce ?

My opinion of that question at the time:
Dec 9 '14 at 20:37, by 200_success
@Phrancis German is not the problem. I've reviewed code in Hungarian, Italian, Polish, and Russian (well, it was originally in Russian) and never complained about a language barrier.
Dec 9 '14 at 20:37, by 200_success
That question would have been uninteresting even if had been written in English.
@200_success I tend to agree on both accounts, it wasn't particularly interesting to review
(most SQL isn't, TBH - I need to find a better gig ;)

« first day (797 days earlier)      last day (3519 days later) »