public static int numDivisorsFast(long number) {
if (number <= 0) {
throw new IllegalArgumentException("number must be positive: " + number);
}
int divisors = 1;
long lastNum = 0;
int lastCount = 0;
while (number != 1) {
if (number % 2 == 0) {
lastCount++;
number /= 2;
continue;
}
for (long i = 3; i <= number; i += 2) {
if (number % i == 0) {
I think I'm going to do Fibonacci though. It's simple enough and a common enough problem that most people have done at some point (even non-programmers).
or well... depends on what you mean by factoring.... I did write a method to get the prime numbers for a method, but that was waaaay too slow of an approach. This calculates the number of divisors in a quite quick way
I may also want to demonstrate a case where it's important to add comments because you refactored from more readable to less readable for the sake of speed
@Corbin way too much code for GCD as well. but without proper variable names, it is definitely hard to tell what it is without running it (and perhaps it would be hard to figure it out even then)
@Mat'sMug for the record: @Duga was right. It was reload. Perhaps a few minutes early, depends on your watch :) within two weeks though, I'll have to adjust the time for @Duga's postings with one hour I think.
@rolfl yes, I use that. I think.... my brother helped me set that up. I think I even got a cronjob doing it. I'm blaming @Mat'sMug's watch (until later when I will realize that indeed @Duga's time was off by a few minutes)
This is their example function
[GTMagBarDevice sharedDevice].delegate = self;
I tried rewriting it in swift like this
GTMagBarDevice.sharedDevice().delegate = self;
But I am receiving an error "type view controller does not conform to protocol GTMagBarDeviceDelegate"
Any ideas?
For some reason I can't ask any more questions on my account, I must have done something wrong? But I have one more question i'll post here just incase you have the answer — user203404725 mins ago
@Thilo Code Review is NOT for seeking explanations of code written by other people, which is primarily what this question appears to be. — nhgrif36 secs ago
GTMagBarDevice.sharedDevice().delegate = self; I am getting an error with this ... "type view controller does not conform to protocol GTMagBarDeviceDelegate", any ideas? — user203404724 mins ago
When a post only contains a link to off-site code and you have already told the OP to paste the full code but they have done nothing, are you allowed to go to the link, copy the code, and paste it on to their post for them?
Just had a rather encouraging customer service experience. I thought calling AT&T to change my mobile rate plan after I just paid today was going to be a PITA. Was pretty painless.
But also, specifically, here... we don't actually want the entire code base. We want the OP to pick a pretty focused section of code to review ideally.
Some questions link to the code they want reviewed, which is against site policy. Should one edit the code into the question in these cases?
The problem I see is that all content on StackExchange is cc-wiki, which may not correspond to the wishes of the author. This is probably fine when the c...
Past, present and future: Past - two glasses of port. Present - two'nd monitor. Future - move two logical colums on a linux volume group to a 2nd physical volume....
> Alternately, install a localized version of Candy Crush, lock out all other features of the computer, and give it to the Furher. Then, when he's so addicted to the game that he isn't paying attention anymore...you win! (kidding, of course)
The biggest advantage I see being given here is simply processing power. You have a machine that can run calculations at a speed that would beggar imagination for someone living in that era.
In relation to the Artillery mentioned in another answer. Generally, an artillerist would consult his ran...
Here is another way to think about the question. Suppose that the response is handled by ignoring the response entirely, i.e., we do $.get(url, function(response) { /* do nothing */ }). In other words, imagine the code just does a $.get() and then ignores the response. Is that safe, or is it unsafe? (For $.getJSON(), the answer is "unsafe", even when the code entirely ignores the response, as explained at the other question. But what about for $.get()?) Note that this is a question about code review, not about what some random user viewing the source of a page would do. — D.W.48 secs ago
Your concept is flawed in a few different ways.
One of the ways it is flawed is because you assume that someone calling the async method will actually call "get()" on the Future. This is not certain. Many times, with async systems, it is convenient to submit&forget a task especially if you don't...
document.querySelector
While it is a great function to use, you are using in the wrong situations.
For every time you use it, you are getting an array of elements with a class that you passed in to the function. Why not just use document.getElementsByClassName?
Sure, it takes a little bit long...
Let me rephrase the question yet another way. Suppose I'm doing code review to check Javascript for XSS vulnerabilities, and I see $.get(url, f); in the code. Suppose I know that url can be completely controlled by the attacker. What do I need to check, to verify whether this is safe (free of XSS bugs)? I already know that I need to check the code of f to see whether it handles the response safely, because if f is careless it could introduce a XSS bug. My question is: is that the only risk I need to check for? Or is this code pattern always unsafe, regardless of how f is coded? — D.W.1 min ago
Your concept is flawed in a few different ways.
One of the ways it is flawed is because you assume that someone calling the async method will actually call "get()" on the Future. This is not certain. Many times, with async systems, it is convenient to submit&forget a task especially if you don't...
I always thought that, when a question was answered, it would get put back on top of the feed. But, from a recent post of mine, I discovered that that is not true. What does it take for a post to be put back on top of the feed?
namespace NotSystemAndOthersThingsThatIHaveNoPracticalUseFor
I couldn't possibly imagine a worse namespace.
Why not use something both simpler and more descriptive?
namespace RationalMath
> This is not an answer. This might make sense as a comment, but it's not an answer. For this to make sense as an acceptable Code Review answer, you'd need to explain the reason and demonstrate a fix.
Project Euler 12 - Highly divisible triangular number
The sequence of triangle numbers is generated by adding the natural numbers. So the 7th triangle number would be \$1 + 2 + 3 + 4 + 5 + 6 + 7 = 28\$. The first ten terms would be: \$1, 3, 6, 10, 15, 21, 28, 36, 45, 55, ...\$
(...) 28 i...
You should rethrow any InterruptedException, they are meant to shutdown the current thread or in the case of Task.call signal cancelation of the task.
I would change execute synchronous to just creating the Task and calling it without messing with the executor:
@Override
public DataResponse exe...
@Phrancis Nope. I got that number from one of my earlier runs, where I had a method running that did an actual prime factorization. It seemed like an interesting prime factorization to test with, so I asked WolframAlpha how many divisors that number had, and I was happy to find out that my new approach that I just had come up with seemed correct!
Thanks, but that kind of thing is not likely to appear in normal code, so this doesn't really answer the question of what checks I need to do when I see $.get(url) during a code review for XSS. Or, to put it another way, it sounds like you are saying the answer is "$.get() is unsafe if the code handles the response unsafely by <this crazy thing involving global variables>". OK, fine. But what if the code doesn't do that crazy thing? Is the code safe in that case? — D.W.6 secs ago
Project Euler 12 - Highly divisible triangular number
The sequence of triangle numbers is generated by adding the natural numbers. So the 7th triangle number would be \$1 + 2 + 3 + 4 + 5 + 6 + 7 = 28\$. The first ten terms would be: \$1, 3, 6, 10, 15, 21, 28, 36, 45, 55, ...\$
(...) 28 i...
Name: Overly long acronyms
Originator: Simon André Forsberg
Cultural Height: The 2nd Monitor
Background: IWNPFETTOLAI (I will not provide further explantion than this overly long acronym itself)
If you haven't hired anyone by next summer, and I can persuade my parents to let me come over, I'm interested in doing an internship for you, if you don't mind someone with little knowledge of .NET ( :( )
This is their example function
[GTMagBarDevice sharedDevice].delegate = self;
I tried rewriting it in swift like this
GTMagBarDevice.sharedDevice().delegate = self;
But I am receiving an error "type view controller does not conform to protocol GTMagBarDeviceDelegate"
Any ideas?
Some questions link to the code they want reviewed, which is against site policy. Should one edit the code into the question in these cases?
The problem I see is that all content on StackExchange is cc-wiki, which may not correspond to the wishes of the author. This is probably fine when the c...
document.querySelector
While it is a great function to use, you are using in the wrong situations.
For every time you use it, you are getting an array of elements with a class that you passed in to the function. Why not just use document.getElementsByClassName?
Sure, it takes a little bit long...
namespace NotSystemAndOthersThingsThatIHaveNoPracticalUseFor
I couldn't possibly imagine a worse namespace.
Why not use something both simpler and more descriptive?
namespace RationalMath
Project Euler 12 - Highly divisible triangular number
The sequence of triangle numbers is generated by adding the natural numbers. So the 7th triangle number would be \$1 + 2 + 3 + 4 + 5 + 6 + 7 = 28\$. The first ten terms would be: \$1, 3, 6, 10, 15, 21, 28, 36, 45, 55, ...\$
(...) 28 i...
You should rethrow any InterruptedException, they are meant to shutdown the current thread or in the case of Task.call signal cancelation of the task.
I would change execute synchronous to just creating the Task and calling it without messing with the executor:
@Override
public DataResponse exe...
Name: Overly long acronyms
Originator: Simon André Forsberg
Cultural Height: The 2nd Monitor
Background: IWNPFETTOLAI (I will not provide further explantion than this overly long acronym itself)
