This script is a total of 99 lines. Of that, 49 lines are insulting, annoying, and ironic self-congratulating comments.
In general, comments are good. They help any future maintainer (including yourself when it's been 6 months since the last time you looked at the script) to understand what ...
I have a class like this:
class myClass {
public static function load()
{
return new self();
}
public function myMethod1 ()
{
return 'content';
}
public function myMethod2 ($content)
{
return 'modified '.$content;
}
}
Somewhere i...
What is a Zombie? Why are Code Reviewers so violent and talking about killing Zombies all the time? And what ammo are they talking about? What is a TS? What does RSA mean?
And what other Code Review-specific memes are there?
(As the number of memes grows and grows, and Malachi's wish to vote fo...
In effort to be more effective and productive with terminals I have started building a bash script. It is for handling the bash history of concurrently running terminals, archiving old commands, and dynamically loading bash history profiles.
Most current development is going to be found at http...
I'm working on the OSCP, and Information Security certificate based around penetration testing. CLI-based tools seem to be the core of most pen-testing assignments, so I'd like to build a tool aiding in command/switch searching.
The goal of the program will to (eventually) load command line arg...
I have a class in C# that uses Random object to get a list of numbers randomized from an array of 1-25. Now what i need is improve this method to use RNGCryptoServiceProvider because for the application is not enough Random object.
My question is that i know that RNGCryptoServiceProvider is slowe...
First of all,
you've got to give different names to bashory and bastory...
I was very confused while reading the code,
at first I thought it was a typo,
it took me a while to realize they are different things.
To avoid confusion,
it would be better to give them distinctly different names.
In m...
You are the victim of branch prediction fail.
What is Branch Prediction?
Consider a railroad junction:
Image by Mecanismo, via Wikimedia Commons. Used under the CC-By-SA 3.0 license.
Now for the sake of argument, suppose this is back in the 1800s - before long distance or radio communicati...
VBA's 'Collection' is.... lacking, so, I've been working on a better Collection object that implements many of the features of C#'s Enumerable. This is very much inspired by this question and a follow up to Sorting a Collection and More imitation of Enumerable.
I'm concerned that the API is inco...
With the SDL library, I'm creating an SDL_Surface* at w and h dimensions.
SDL_Color is a struct with 4 unsigned char fields: a, r, g and b for alpha, red, green and blue. c1 is the origin color, c2 the destination color, and c the color of the pixel at position (i,j).
That gradient works fine, ...
VBA's 'Collection' is.... lacking, so, I've been working on a better Collection object that implements many of the features of C#'s Enumerable. This is very much inspired by this question and a follow up to Sorting a Collection and More imitation of Enumerable.
I'm concerned that the API is inco...
If we list all the natural numbers below 10 that are multiples of 3 or
5, we get 3, 5, 6 and 9. The sum of these multiples is 23.
Find the sum of all the multiples of 3 or 5 below 1000.
My solution:
#include <stdio.h>
#define TOP_LIMIT 1000
float sum_of_series(float start_from,float...
I'm trying to create a light system, with the midpoint algorithm and Bresenham Line Algorithm. I'm trying to redraw all the time (1 option) or redraw when I need to. When the circles are too big it becomes a bit laggy.
function Light(x, y, range)
{
this.CordX = x;
this.CordY = y;
th...
I wrote some code in Flask for site menu:
def menu(parent_id=0, menutree=None):
menutree = menutree or []
cur = g.db.execute('select id, parent, alias, title, ord from static where parent="'+ str(parent_id) +'" and ord>0 order by ord')
fetch = cur.fetchall()
if not fetch:
...
Code Review - Discussion about help v…
The following code works and it prints out only True as it is suppose to, for all the different cases:
class User(object):
def __init__(self, key):
self.key = key
def is_ok(user_dbs, self_db):
count = len(user_dbs)
if not self_db:
return not count
return (count != 1 or self_db.k...
I created a database with simple stored procedures to delete, insert, select, and update records in the database's three tables. All of them work except my delete statements. I get a "Procedure or function has too many arguments" message when I try it. I tried deleting the one parameter it had an...
I'm trying to do the Reverse Groups Challenge on Codeeval. My logic is function but when I try to submit my solution is says that timed out at 10 seconds. How can I improve the speed here?
File.open(ARGV.first).readlines.each do |line|
values, k = line.split(';')
k = k.to_i
values = valu...
I am trying to convert hex to rgb, and rgb to hex. My current code doesn't seem optimal, and there is an issue with 0's in the hexadecimal. What do you think about the overall quality of this code? Can you think of a more efficient way of converting?
$scope.$watch('hex', function() {
var r...
It is a good practice to prefix Boolean variables with "is" or "has" like isValid or hasCredits.
But how about methods which return a Boolean variable? Should they also start with "is"?
Like this one:
boolean isValidPayload = isValidPayload(request);
Or should methods be named after action...
I am working on my Tritium website (hosted on Github: feel free to fork and send pull requests), and now am looking for a review of it. If you are looking to critique the design of the website, please visit the sister question over on Graphic Design.
Here is what I would like reviewed:
Orga...
I have a simple Model class that represents a calculator.
Here is it's header file:
@class MMCalculator;
@protocol MMCalculatorDelegate <NSObject>
@required - (void)mmCalculator:(MMCalculator *)mmCalulatorFinishedCalculatingValues;
@end
@interface MMCalculator : NSObject
@property (nonatom...