I am not certain whether you have the wrong site, or whether you just forgot to copy in your code..... Did you miss a step when you put together this question? Code Review is for reviewing working code, not for helping to write it from scratch.... — rolfl ♦ 14 secs ago
I am creating a converter for use in a Windows 8 XAML app (MVVM). As you can see in the code below, the converter is used to convert a bool into one of two strings from a language resource file. My question is, is it better to create one instance of ResourceLoader for the converter class or sho...
Few notes.
First, you don't want to copy data in the loop. Call memset()/memcpy() instead. You need some very serious reason to not use standard library. Here is some example code:
dataSize = sizeof(*wptr) * data->numberOfChannels * framesToCalc;
if (!inputBuffer)
memset(wptr, dataSize, 0)...
I somehow acquired the idea that I should reduce the number of trips to the database as much as possible and so I use a lot of very long queries.
For example, I had a function that does this:
$shelf = get_shelves($shop_id)
foreach($shelf)
{
$weight = get_weight($shelf);
}
Everytime a use...
7
As others have pointed out the most obvious improvements already, I would like to talk about Java 8. Maybe you cannot use it yet, but I would recommend looking into it and this answer should proivde useful for anyone reading this.
My main focus point here will be designing the code such that it ...
Recently, I wrote a Sudoku solver in C++. My program is very hard and was solved in a few seconds. In my opinion, this is slow.
#include <iostream>
#include <conio.h>
#include <stdlib.h>
#include <time.h>
using namespace std;
int tab_in[9][9] = {{0,0,0,0,0,0,0,1,0},
{4,0,0...
0
private void log(MethodExecutionArgs args, string message, LogLevel level)
{
var calling_ip = ((System.Web.Services.WebService)args.Instance).Context.Request.UserHostAddress;
string method = args.Method.Name;
LogEventInfo logInfo = new LogEventInfo(leve...
I find myself frequently trying to build up Seq's based on some conditionals, but the code I end up with feels verbose and clunky. An example:
def generateSeq(foo: Option[String]) = {
Map("bar" -> "baz") ++ ( if (foo.isDefined) {
Map("foo" -> foo.get)
} else {
Nil
} )
}
I...
Approach:
Your algorithm is way too complicated for the task.
Consider following pseudocode:
foreach element in array
difference is Abs(element - k)
if difference less or equal to currentSmallestDifference
currentSmallestDifference = difference
keep index
return array[index]...
Please verify security from SQL injection attacks.
homepage.php
<html>
<head>
</head>
<body>
<ul id="list">
<li><h3><a href="search.php?name=women-top">tops</a></h3></li>
<li><h3><a href="#">suits</a></h3></li>
<li><h3><a href="#">jeans</a></h3></li>
...
I have defined some DataTemplates are similar. The templates are like that:
<DataTemplate x:Key="DefaultCellTemplate">
<TextBlock Text="{Binding Value}">
<i:Interaction.Behaviors>
<beh:AddErrorButtonAdornerToControlsBehavior
DoOnButtonClick="{Binding ...
I’m trying to improve my code’s "signal to noise ratio", hence would appreciate any tips on improving this, what appears to be smelly code. Perhaps there could also be potential performance improvements to be made here:
public class PricingInfoDto
{
[DataMember]
public decimal ListPrice ...
The teaching tag was recently created. There are now three questions carrying the tag.
Its intended purpose is described in its tag wiki:
Much like the [beginner] tag, this tag should call out that extra care
should be taken reviewing the code. Your code review might impact how
students...0
The Community♦ user on Code Review meta has had a strange behaviour recently:
First of all, it has 5 reputation instead of 1.
Thirty minutes ago, it felt that it was a good idea to update 91 questions at once. Right now, the "active questions" page is totally meaningless since there are only ol...
11
0
I have implemented quickly the quick sort algorithm in JavaScript using prototype based style.
The code is rather little ( http://jsfiddle.net/b8mfY/ ):
<script>
"use strict";
var Sort = function( inputArray ) {
this.arrayTest = undefined;
this.init( inputArray );
};
Sort.prototype.in...
Background
I'm using ms-exchange 2013 in my environment, and have a separate siem box which analyze logs produced by different systems (i.e exchange). The logs for exchange are internally stored and can however be extracted such as
Get-MailboxAuditLog -Identity test-mailbox-1 -LogonTypes
...
Community has been doing mass-updates of posts changing links that used to point to meta.stackoverflow.com, and replacing them with links to meta.stackexchange.com
The effect, for example, can be seen in Community's activity: Migration of MSO links to MSE links
10
As others have pointed out the most obvious improvements already, I would like to talk about Java 8. Maybe you cannot use it yet, but I would recommend looking into it and this answer should proivde useful for anyone reading this.
My main focus point here will be designing the code such that it ...
0
Inspired by this question on StackOverflow I've attempted to code such animation, mostly to get some more practice with async, promises and Q.js. Here's what I got:
(Live demo)
function addOutput(s) {
$('<div>').text(s).appendTo(wnd);
//return Q.defer().promise;
return Q.delay(100).then(f...
0
8
6
Lets say we have following construct:
var something = {
1: "one thing",
2: "second thing",
3: "third thing"
};
and we access somewhere in code to these attributes as:
var output = something[1] + " " + something[2]; // output wold be: "one thing second thing"
I guess this is kind...
