The 2nd Monitor

Marc-Andre

18:01

Ok so it was obsolete. Thanks a lto

18:16

@Mat'sMug Just because a review focuses on high-level architecture stuff doesn't mean that it's necessarily belong on Programmers, does it? I mean... as long as a question provides actual working code and that code wants feedback, it's CR. Doesn't matter if it's about reviewing formatting and stuff, or reviewing higher-level design, does it?

@davidkennedy85 About decoupling, I'd say that the most important thing is to decouple your model from your view. For example, I'm making a game and I'd want to make that game for both Android and Java Swing and Google Web Toolkit, so it's important that I don't couple my game logic code to my Android views.

rolfl

Welcome home, Simon ;-0

2

Simon André Forsberg

Thanks, @rolfl

rolfl

BTW, isn't that what I said too .... ?

2 hours ago, by rolfl

Hmmm ... I would agree.... except for the fact it has a lot of code....
You just happened to focus mostly on the design in your review (because that is what struck you as most significant).

Jamal

@rolfl: Can you tell by the request of the Snake game question that it should be reopened? It still sounds like the OP is reporting a problem.

Mat's Mug

@SimonAndréForsberg it's fine, because there's code to review - if it were just the high-level stuff, then I'd flag for migration. Instead I posted an answer ;)

Simon André Forsberg

18:20

Yes, I just wanted to emphasize that focusing mostly on the design in the review is not a bad thing.

rolfl

@Jamal every question on CR has problems.... his problem is that it blinks....

which is likely because it has a bad double-buffer, or something.

If his game is playable, but ugly, well, that's our job, right?

2

Jamal

Since he says it's playable, then it should be okay. I just wasn't entirely clear on all of that.

rolfl

He has code, it compiles, works, produces a moving snake, I presume, and he wants to make it better.

Simon André Forsberg

@davidkennedy85 To make the decoupling, you can use interfaces. Let the game model receive some kind of callback interface for when it's game state is changing, in which case the view should update. (The view is what implements the callback interface). It's OK for the view to know about the model, but the model should not know about the view -- all the model can know is that it has an interface to report "events" too. (I have to admit I haven't looked at your question though)

rolfl

@SimonAndréForsberg - Make it so!

Simon André Forsberg

18:23

Make it what?

rolfl

►

Simon André Forsberg

Oh. I get it. Haven't watched enough Star Trek.

rolfl

Meh, he ruined it by adding junk at the end.

davidkennedy85

@SimonAndréForsberg thanks, but you should probably watch more Star Trek

Simon André Forsberg

There are so many things I should watch :)

kleinfreund

18:43

Simon, I agree with them. :)

Jamal

Monkey Meta question incoming!

(and also an off-topic one)

syb0rg

I am one reputation point from tying my Stack Overflow reputation, 2 points away from my Code Review account being my highest rep account on Stack Exchange.

Stack Exchange

0

Q: Move a red square around a canvas? The square will not appear or move!

This javascript code should me a rectangle around the screen with the arrow keys. It is not doing that and I am not certain as to why that is the case. Is there something that I have missed that has to happen on the onload of the body. I am not certain as to way this is not working. Code: <html>...

0

Q: PHP: how can I improve this code?

The following PHP does exactly what I need it to do but, as a complete PHP novice, I am wondering what can be improved here? $theurl='./section-1.html'; function getbody1($filename) { $file = file_get_contents($filename); $bodypattern = ".*"; $bodyendpattern = ".*"; $thecontainer = "id=\...

php

rolfl

@syb0rg sorry, mate, can't help, DVLR.

syb0rg

Of course, if someone wanted to mess with me, they could upvote a few question on my SO account...

Simon André Forsberg

18:50

Ho ho ho.

4

Marc-Andre

@syb0rg congrats goal achieved!

Mat's Mug

C# has major differences between versions, and yet there's only one C# tag. When a question uses version-specifics, there's a tag for it: take linq, task-parallel-library and async-await as examples. — Mat's Mug 8 secs ago

Stack Exchange

5

Q: The [java-8] tag, here to stay?

Recently the java-8 tag was created to apply to Java8 specific questions. There is no doubt that the questions are, in fact, Java8 questions. The meta question though, is: Should java-8 exist, and if it should, what should it be, a full tag, or a synonym to java?

discussion tags

Simon André Forsberg

@Mat'sMug Does that agree or disagree with the monkey?

@StackExchange Can't you see that we're talking about that already?

Mat's Mug

hmm.. reading it again, I think it belongs as an answer

0

A: The [java-8] tag, here to stay?

NO, it shouldn't exist, not even be a synonym! c# has major differences between versions, too. And yet, the only C# tag we have is c#. How do we address this? C# 2.0 introduced generics. Enter the generics tag. C# 3.0 introduced linq. Enter the linq tag. C# 4.0 introduced the Task Parallel Li...

^^ there

rolfl

18:59

That answer has my +1 ... hmmm... how did that happen?

Mat's Mug

@rolfl edit your post, so I can retract my vote ;)

rolfl

No!. ;;;;))))

How do you deal with people creating it anyway if it is not a synonym?

Simon André Forsberg

@SimonAndréForsberg you only wish you could tag a question with both [Java] and [Linq] ;p — Mat's Mug 20 secs ago

Mat's Mug

point them to that meta discussion?

Simon André Forsberg

If only comments could be starred :)

Mat's Mug

19:02

LMFTFY...done

davidkennedy85

Do I edit posts too much :s

Mat's Mug

@SimonAndréForsberg synony mozi sizing?

rolfl

@davidkennedy85 - if they get auto-converted to CW, then yes ... ;-)

davidkennedy85

Huh?

Simon André Forsberg

synonymizing? synonymozising? synonymize? My Firefox can't spell anything.

Mat's Mug

19:03

Community Wiki - a question gets wikified after like 10 edits or so

Simon André Forsberg

@davidkennedy85 After a post has been edited 10 times, the... what the mug said.

davidkennedy85

Oh

I'll try to avoid that then

rolfl

It is a trap you have to be careful of....

Any upvotes after it is a CW do not count to your reputation

Simon André Forsberg

Normally though, you don't need to worry about that. The only one who has to worry about that is probably @Jamal. And some edit-happy question askers.

davidkennedy85

I just hope people aren't offended when I fix their obvious second-language spelling mistakes and stuff

Simon André Forsberg

19:05

I think you should continue your editing, @Jamal needs some competition.

davidkennedy85

Hah

Jamal

What we need is more editors cleaning up noise. I can't be the only one doing that. But I understand that this is the case for pretty much every site.

Mat's Mug

@davidkennedy85 careful though @Jamal is at Olympic editor level - I mean, you actually do get a "medal" for it: codereview.stackexchange.com/help/badges/33/copy-editor

Jamal

Regarding the CW, I can lift the status myself, but I would have to determine if the situation warrants lifting it. I shouldn't do it for everyone. For instance, one of my own questions turned CW, but I don't believe it warrants removal of the status (I'd prefer to have another mod remove it anway).

Simon André Forsberg

@Jamal When I see a post that needs editing, I also clean up the noise. However, I don't edit a post just to clean up the noise.

rolfl

19:08

@Jamal - in David's case the edits are far from CW status.... he's making edits to different posts, not many edits to one post ... phew!

Mat's Mug

BTW welcome to Meta-CR, @skiwi! Feel free to join us in The 2nd Monitor anytime! — Mat's Mug 26 secs ago

davidkennedy85

@rolfl that's not entirely true

I've edited this one at least twice

Mat's Mug

wikifying someone else's answer wouldn't be nice though ;)

Simon André Forsberg

@davidkennedy85 If you're worried about wikifying a post you can check it's revision history. When it's close to 10 you might want to avoid it :)

But generally, I wouldn't worry about it.

Mat's Mug

I like how wikify sounds like liquify with a funny accent

rolfl

19:14

@davidkennedy85 - FYI:

457

Q: What are "Community Wiki" posts?

Some questions and answers are marked Community Wiki and are owned by a Community Wiki user. Why have Community Wiki posts? How do Community Wiki posts work? How does a post become a Community Wiki post? How can the Community Wiki status be removed from a post? Return to FAQ Index

support faq community-wiki posts

Jamal

There's also a risk of it happening with an edit war, but I don't think I've seen a serious one here before. If that ever happens, a mod can lock the post to prevent further edits.

Mat's Mug

yeah, we wage our wars with vote guns, not edit guns..

davidkennedy85

Meme detected

No wait that's for answer guns

rolfl

David ... here in the 2nd monitor, we kill zombies with ammo

If you have not heard, CodeReview was reviewed as part of it's beta-site status. The review was interesting.... and the community response was more interesting....

Mat's Mug

what's the meme for "I'm out of stars"?

davidkennedy85

19:18

Yeah I was around for that

TS?

Simon André Forsberg

@Mat'sMug I believe "pulling a @Malachi"

Yeah, TS works also :)

Mat's Mug

I pulled a @Malachi again :)

rolfl

David... here's the response....

data.stackexchange.com/codereview/query/161411/…

Simon André Forsberg

Next coding challenge: Make a quiz for the CR memes?

davidkennedy85

Is anyone else uncomfortable with the idea of a sex Q&A?

Mat's Mug

19:19

@SimonAndréForsberg TS ..dang it @david TS too!

rolfl

David, we have a member @Malachi, who's a committer to it ... ;-)

Simon André Forsberg

@davidkennedy85 Everyone except @Malachi...

rolfl

Careful what you say ... ;-)

davidkennedy85

haha

rolfl

It gets ..... uncomfortable ... ;-)

Jamal

19:21

If I were to follow it, it would only be... for science. :-P

davidkennedy85

Q: How do I find a suitable mate? A: Attend Star Trek conventions.

lol @Jamal got unstarred

rolfl

(saving my stars, apparently).

Jamal

Science is not good enough for you? Shame...

jk

rolfl

Not when compared to trekkie-mates.

My wife is a trekkie ... I'm just a part trekkie ... (7-of-9 cough cough )

davidkennedy85

I can't imagine being married to someone as obsessed with sci-fi as I am. It would just be too weird.

7 of 9?

rolfl

19:24

Hmmm... not a voyager fan?

Mat's Mug

kleinfreund

Unimatrix 001?

rolfl

Naah... for some reason I prefer her with 'bling'.

Simon André Forsberg

@rolfl or @Mat'sMug How did you activate that auto-comment-thingy?

Mat's Mug

downloaded something on Google Play, can't remember what exactly

Simon André Forsberg

19:32

Writing nice comments like this one takes time, it'd be nice to have a little more... automatic way of doing it:

Welcome to Code Review! Unfortunately it seems like you have misunderstood the concept of our site. We don't fix non-working code, we improve code quality of already working code. We can help in making code more "beautiful". When you manage to fix your problem, you can come back here and edit your question with the fixed version and we can help you beautify it :) — Simon André Forsberg 51 secs ago

Although writing the comments manually perhaps makes them more personal, more welcoming. I don't want to become a robot (no offense, @syb0rg), but a little help on the way wouldn't hurt.

Mat's Mug

216

Q: AutoReviewComments - Pro-forma comments for SE

No more re-typing the same comments over and over! This script adds a little 'auto' link next to all comments boxes. When you click the link, you see a popup with 6 configurable auto-comments (canned responses), which you can easily click to insert. This script was inspired by answers to thi...

script

Chrome link: chrome.google.com/webstore/detail/…

Simon André Forsberg

Firefox link: Install Greasemonkey first :)

Mat's Mug

Hello @skiwi!

skiwi

Hey, just got an invite to join here

And dang the sound for the notification was loud :P

rolfl

Heym wasn't me ;-)

Mat's Mug

19:39

(ding!)

rolfl

skiwi, you can turn off the ding.

(I do).

Mat's Mug

BTW welcome to Meta-CR, @skiwi! Feel free to join us in The 2nd Monitor anytime! — Mat's Mug 29 mins ago

skiwi

First chatroom where people are actually active, so far...

Mat's Mug

^^ my fault! :)

rolfl

There's a little speaker icon on the top-right of your screen).

skiwi

19:40

Yeah, found it already :)

Mat's Mug

@skiwi what do you mean, first chatroom?

skiwi

I've joined I think the java chatroom at stackoverflow, but barely anyone talks there

This reminds me more in my youngster days when IRC was still popular and everyone was playing text-based browser games

Simon André Forsberg

Those SO chatrooms are too crowded. And not very welcoming.

Mat's Mug

oh. CR is different in so many ways from SO :)

Simon André Forsberg

I dropped by the Android chat-room once, wasn't at all like CR's :)

Marc-Andre

19:41

Or empty !

Stack Exchange

0

Q: Better implementation of Excel's SUMIFS using pandas, the Python Data Analysis Library

I've implemented Excel's SUMIFS function in pandas using the following code. Is there a better—more Pythonic—implementation? from pandas import Series, DataFrame import pandas as pd df = pd.read_csv('data.csv') # pandas equivalent of Excel's SUMIFS function df.groupby('PROJECT').sum().ix['A001']...

python excel

Simon André Forsberg

Yes, or empty ^^

skiwi

automatic notifications?

i saw that StackExchange coming by, from CR I presume

Mat's Mug

@StackExchange should this be tagged with reinventing-the-wheel?

Simon André Forsberg

Like the chat room on the AI.SE private beta. Wasn't much that was said there. It was helpful when I asked a SE employer about the on-topicness of my question though, so that was nice.

davidkennedy85

19:43

@skiwi you know people still chat on IRC right?

Simon André Forsberg

@skiwi (DING!) Yes, it's just our little @StackExchange bot puppet we have here. It's normally quite nice. But slow. And it still won't give us notifications about new answers!

davidkennedy85

The glory days don't have to be over

rolfl

I do regularly IRC still

davidkennedy85

When I had a RasPi I used it almost exclusively for IRC chatting /shame

skiwi

I know there's still people, sadly not much market for text-based browser (mafia for example) games though

davidkennedy85

19:45

Is that a roguelike?

Simon André Forsberg

@rolfl All those times I have seen that icon but never even wondering what it was, never even trying it out!

rolfl

@SimonAndréForsberg ding! Dong! .... Duh!

Simon André Forsberg

@rolfl I still have the sound active, I like the sound :) Now at least I know how to turn it off, which will be helpful for some times.

skiwi

Just wondering, what kind of jobs do you people have? If that is appropiate to ask, I'm myself a Bachelor student in Software Science.

rolfl

Jobs ... ? We just get paid for our hobbies .... ;-)

davidkennedy85

19:46

Apparently all i do is make games

Simon André Forsberg

I'm currently a computer programmer in Java. Not sure for how long I actually will work though. Will try to search for jobs after that.

davidkennedy85

I get paid for something else though, not sure what exactly...

Mat's Mug

I work as a full-time programmer for a tiny little shop that builds doors & windows. Spend my days debugging the VB6 crap my predecessors have put together.

Simon André Forsberg

@davidkennedy85 Make games is exactly what I would like to do.

skiwi

sounds cool all :) And agreed it should be more of a hobby

davidkennedy85

19:48

Get a job at a ~~small~~ slow dev company

rolfl

@Mat'sMug you guys keep calling me, but I just replaced them all... bastards!

And my ducts are clean too!

skiwi

A few weeks ago I was experimenting with OpenGL 4, however uni is a little more busy, so got less time for it

Simon André Forsberg

Getting paid for doing what we like to do isn't that bad. I'd love to work as a programmer (for now, at least)

skiwi

Then Project Euler caught my attention :P

Mat's Mug

@rolfl lol I'll ask the marketing dept. to leave the monkey alone :)

davidkennedy85

19:48

Wait how do I strikethrough

Mat's Mug

--- (triple "-" on both ends)

skiwi

[s]strikefail[/s]

Simon André Forsberg

@davidkennedy85 ---like this---

davidkennedy85

Because you can get a job on a small team and be miserable

Mat's Mug

^^ that's me!

I'm a team with ...my mug.

davidkennedy85

19:49

There

I spend most days waiting for work to get approved

Simon André Forsberg

At first I didn't like very much my job, because of the gigantic code crap. Now I have sneaked in several important refactorings, and am writing a lot of entirely new parts that the project is quite enjoyable :)

davidkennedy85

There's actually a ton of work to do but it's up to management to allow us to work

Mat's Mug

Actually I spend most of my days ~~wasting my time~~ chatting here

davidkennedy85

Haha

Simon André Forsberg

I can see why you enjoy making games. You're allowed to do anything then :)

davidkennedy85

19:52

Well, as of this moment I'm waiting for a team mate to finish a program so I can add features to it. SCRUM fail.

Mat's Mug

^^TS

skiwi

Should I be happy or sad that I barely know about SCRUM/AGILE yet?

davidkennedy85

Depends, many employers will want you to know it

But we use it here and it sucks so I dunno

It's great if it's done right

skiwi

if

Simon André Forsberg

(removed) <-- Dead baby unicorn

davidkennedy85

19:54

And it's easier said than done to do it right

That's why some people get paid lots of money to do nothing but SCRUM management

@Simon :D

Mat's Mug

@davidkennedy85 if you're waiting for a colleague, it's actually a SOLID & DI/IoC fail. You should be coding against interfaces, and if you did that... you wouldn't be waiting for some implementation ;)

skiwi

ah I see

davidkennedy85

@Mat it's more like waiting for a new VS project

Simon André Forsberg

I studied some Agile development for a web-development education on University once. Worst - course - ever.

Mat's Mug

Done AGILE/SCRUM before, was nice.

skiwi

19:57

Back to breaking my head on the 9th Euler Problem, without bruteforcing it

davidkennedy85

@skiwi if I had any advice for you it would be to find a place with a nice work environment

Because if they have that everything else doesn't matter that much

Mat's Mug

yeah, like, one where you don't have to beg for a ReSharper license to code your C#.

skiwi

Okay, I see @da

davidkennedy85

lol

skiwi

@davidkennedy85 *

davidkennedy85

19:58

I had to buy my own ReSharper license :(

skiwi

I have some parttime job once per week on my own project inside a company, the company itself seems nice though

Simon André Forsberg

@davidkennedy85 Congratulations, you just wrote the famous 2nd monitor auto-star message.

Mat's Mug

lol

2

Simon André Forsberg

@Mat'sMug Not you too!

davidkennedy85

lol

Aw

Stack Exchange

20:00

-3

Q: Use Case For Importing Files

I'm creating an application that allows an actor to import JPEG files. The system extracts metadata from the file including GPS coordinates, displays them on a map and inserts the import into a database using SQL. All these steps occur if the actor clicks a button labeled 'import'. Is this too mu...

image

amon

@davidkennedy85 I'm sorry, but you reached your lolcap.

2

Simon André Forsberg

@davidkennedy85 Sorry, I'm out of stars. That's what happens when you try to abuse the auto-starring.

Mat's Mug

another cap!

Simon André Forsberg

Lol, someone apparently have no clue about what CR is about:

2

It's a use case from requirements capture. Why would there be code? — programmingEnthusiast 41 secs ago

skiwi

well... atleast the's a programming enthusiast

syb0rg

20:01

Hello @skiwi

skiwi

hey @syb0rg

syb0rg

Wow, someone went to town on my SO account.. :/

Mat's Mug

Santa?

Must be a monkey. Same happened to me when my CR account was just on the verge of beating my SO account.

;)

hey a got a checkmark for my only answer of the day!

200_success

@skiwi Did you create the java-8 tag?

syb0rg

@SimonAndréForsberg None taken ~~inferior being~~ human friend.

davidkennedy85

20:04

Ok, I have to leave now so I don't spend my entire day ~~doing nothing~~ chatting with you amazing people

skiwi

Yeah, I did a few days ago

syb0rg

Holy moly, thanks Santa!

skiwi

@davidkennedy85 And that is when I realised that it is not evening for everyone here :P

Mat's Mug

@davidkennedy85 later!

syb0rg

@davidkennedy85 Bye!

Marc-Andre

20:06

Santa is generous today ! :D

200_success

@skiwi I believe there was consensus against the java-8 tag in the chat room previously.

Simon André Forsberg

Yes, very generous. My net reputation gain on CR today is.... -1.

rolfl

@Mat'sMug I'll hold you to that ... ;-)

@200_success yeah, but skiwi was not here then... ;-)

And meta is the right place for the discussion.

200_success

@rolfl Shall we have that Meta discussion, or was the consensus on chat strong enough?

Mat's Mug

5

Q: The [java-8] tag, here to stay?

Recently the java-8 tag was created to apply to Java8 specific questions. There is no doubt that the questions are, in fact, Java8 questions. The meta question though, is: Should java-8 exist, and if it should, what should it be, a full tag, or a synonym to java?

discussion tags

Simon André Forsberg

20:15

Seems like there is some consensus on meta also.

syb0rg

@200_success We are having a discussion on Meta ^^^

@Mat'sMug beat me to it

Jamal

A robot... beaten by a mug? Wut?

200_success

@syb0rg Thanks.

Marc-Andre

There is an error in the javadoc of Path docs.oracle.com/javase/7/docs/api/java/nio/file/… the return phrase should be true if this path ends with the given path; otherwise false. That copy paste error!

Mat's Mug

Burninate that tag! +1 — konijn 21 secs ago

Simon André Forsberg

20:24

@Marc-Andre I don't see the error...? It looks correct to me.

Marc-Andre

The second endsWith the one with the String parameter

Stack Exchange

0

Q: How should I store a list of groups of webpages with metadata?

I'm programming an entity-based web crawler, where I need to collect webpages on different people. Right now I'm iterating through a List of EntityWebpageBundles (a class I created with a label field for the name of the entity and list field for the list of WebpageObjects associated with the enti...

java optimization performance data-structures

Marc-Andre

@Mat'sMug 122 !!!! I'm close! I would never though that I would be so happy to try to earn the daily cap!

Mat's Mug

@Marc-Andre have you posted another answer yet?

Marc-Andre

@Mat'sMug Not yet but when I'll return at home, I'll do one for sure

Mat's Mug

20:32

You're 21 points short of the 500 milestone!

Marc-Andre

Yeah it's a big big day for me today :D

Thanks Santa !

And now I have 509 ! :D

syb0rg

@Marc-Andre Someone looks like they are going to rep-cap!

Simon André Forsberg

@Marc-Andre Santa thinks that you need more answers. Unfortunately, there are limits to what Santa can give.

Jamal

Sadly, you're one of the only users below 500 rep who actually flags to close. It would be nice if more could do that, which could indicate further participation and understanding of the site.

Marc-Andre

@syb0rg I hope so :D Will be my first cap ever !

Mat's Mug

20:39

@Jamal we just need more newcomers to hit the 2nd monitor then!

Marc-Andre

@SimonAndréForsberg Will add more soon!

I'm starting to be more and more active!

Jamal

@Mat'sMug: It was with flagging to close that I was able to get Deputy early. :-)

skiwi

Is a question on CR getting upvotes an indication that the code seems correct?

Marc-Andre

@Jamal On SO I'm flagging a lot stuffs! It helps to better understand what is on-topic and what's not!

Jamal

@Marc-Andre There is plenty of things to flag there. I'm surprised I haven't yet reached 1000 helpful flags (but I'm close).

Simon André Forsberg

20:47

@skiwi seems to be correct, yes. Not 100% guaranteed.

Mat's Mug

Depends. What do you upvote a question for, @skiwi?

6

Q: Question Voting Tooltip Discussion

Question Downvote Tooltip Recently I downvoted a question that was just dumping code on reviewers without any effort to put readers in context or anything whatsoever. There's a tooltip on the downvote button that is very useful on most Stack Exchange Q&A sites: Downvote tooltip Howev...

discussion feature-request user-interface voting

(yes, there's ~~an app~~ a meta post for that!)

skiwi

It was happening on a question of mine, not one I did upvote for

Mat's Mug

Everybody has their reasons for up/down voting. I'll upvote a question that's nicely formatted and provides enough context for reviewers to ..review the code. I'll downvote a question that dumps code on reviewers without any further context.

3

rolfl

@skiwi - upvoting a question typically means "good code, well presented, shows effort to make it easy to review".

Simon André Forsberg

Upvoting a question could also mean "horrible code, this really needs to be reviewed"

Mat's Mug

20:52

Answers, well... I have a happy voting trigger reputation preceding me... (previous name was "lol.upvote" ;)

I also upvote a question that I answer (if I'm not out of votes!) - if I can answer it, it's because the OP was nice enough to give me something ...reviewable.

skiwi

okay, I understand

rolfl

@Mat'sMug - the burninate request for c# ??? I agree..... Burninate with fury!

Mat's Mug

@rolfl that was for csharp o.O

skiwi

what... stackoverflow in maintenance, what must I do now :P just kidding

appereantly my code isn't too efficient, been running for 10 mins on max cpu already...
for (int c = 0; c < 1000; c++) {
for (int b = 0; b < c; b++) {
for (int a = 0; a < b; a++) {
triplets.add(new Triplet(a, b, c));
}
}
}

rolfl

@skiwi - People will tend to upvote questins that:
- are easy to follow
- present the problem well
- tickle their passion
I downvote questions that:
- the asker is 'demanding' rather than 'asking'
- does not give any background

@skiwi - variable names!!! UGLY!

skiwi

21:00

not ugly at all :o

rolfl

What is triplets ?

skiwi

projecteuler.net/problem=9 , they also use a, b, c there ;)

ah triplets is just a List<Triplet> , appereantly this problem is too hard to stupidly bruteforce

rolfl

You should take advantage of the fact that a + b + c == 1000

skiwi

I find it a bit hard to reason with because of 3 variables

Simon André Forsberg

@skiwi Whenever you have performance issues, the monkey is your friend!

rolfl

21:02

inside the inner loop... put:

if (a + b + c == 1000) {
    triplets.add(new Triplet);
}

skiwi

What's the monkey? haven't heard of that before

Simon André Forsberg

Couldn't this problem be solved with a Newton Equation solver?
a^2 + b^2 = c^2
a + b + c = 1000

@rolfl is "the monkey"

Mat's Mug

^^ TS

skiwi

aah i see :

rolfl

you can also make it faster by limiting the inner a loop....

skiwi

21:04

hm, i might have solved it

rolfl

get rid of for (int a = 0; a < b; a++) {

Simon André Forsberg

One of the variables don't even need to be looped, it can be calculated instead.

skiwi

sorry if I'm not allowed to post this much code here...

public void run() {
    List<Triplet> triplets = new ArrayList<>();
    for (int c = 0; c < 1000; c++) {
        for (int b = 0; b < c; b++) {
            int a = 1000 - c - b;
            if (0 <= a && a < b) {
                triplets.add(new Triplet(a, b, c));
            }
        }
    }

    result = triplets.stream()
            .filter(Triplet::isPythagorean)
            .mapToInt(Triplet::product)
            .max().getAsInt();
}

rolfl

replace with a = 1000 - (b + c);

Simon André Forsberg

bingo :)

1000 - (b + c) === 1000 - c - b

skiwi

21:05

I already had a guts feeling that 1000 * 1000 * 1000 iterations and storage in a list would not be such a good idea...

rolfl

Monkey see time... monkey go home.

Simon André Forsberg

And now you have confirmed that feeling :)

skiwi

Reading the problem solutions page... Some people solved it in Assembly

that is pretty hardcore

rolfl

Lost rep today ...: 55

@skiwi - Jamal is the asm guy... ;-)

skiwi

losing rep.. that many bad questions?

rolfl

21:09

data.stackexchange.com/codereview/query/164174/…

skiwi

I don't quite get hwo to read it as of now

and first time I see the data.SE site, quite itneresting

Mat's Mug

@skiwi check this out:

15

Q: Stack Exchange Data Explorer is up. What now, Wonderland?

If you didn't know already, the Stack Exchange Data Explorer (SEDE) now includes Code Review and all public StackExchange beta sites. Bookmark: http://data.stackexchange.com/codereview/queries This is our most powerful available tool to tap into our site's data and fetch everything we need ...

discussion beta-progress data-explorer

off-topic, but @syb0rg @Jamal Where can I find DllMain in a decompiled source code?

skiwi

I'll take a look

for some reason I appeared as john.doe when I logged in with Google account, which I do for all sites

Simon André Forsberg

@skiwi The Data explorer is separated. I was also a doe for a while

Mat's Mug

SEDE has its own authentication, separate from rest of SE. You need to edit your profile there. ...what he says ^^^

skiwi

21:14

okay

ha... That Jon Skeet comparison :P for stackoverflow

Jamal

@Mat'sMug: I have no idea.

Mat's Mug

looks like it's the entry point for a C/C++ dll

I'm getting a LoaderLock was detected error, and I'm about to email our dear 3rd-party ERP supplier to tell'em that they F'd up and that their code is the reason for our deadlocking ;)

skiwi

ha data.stackexchange.com/stackoverflow/query/886/… , this one completely missed its purpose :P

and data.stackexchange.com/stackoverflow/query/1919/… is quite awesome and creepy that we can see that much at the same time

Mat's Mug

funny that vb6 is on top and android is at the bottom ;)

Stack Exchange

0

Q: JavaScript bottom-up tree transformer aimed for performance

function transform(tree,fn){ var root = tree, node = tree, child, parent, is_node, dir; root.dir = 0; while(true) { is_node = typeof(node)==="object"; dir = is_node ? node.dir : 2; if (dir < 2) child = node[di...

javascript algorithm tree

Stack Exchange

21:37

0

Q: An Either Monad in Java

Interested in a review of this code, in particular the (hopefully monadic) bind. I actually put this to good use. It was a nice complement to Guava's Optional, and shorter than: Optional.fromNullable(x).or(y); And I threw in a bind method, which I think lifts it up into monad space. One qu...

java monads

0

Q: Is this a good use of Async in F#?

I've hacked together some code to read the content from a sequence of files: let fileContents = [ "filename1"; "filename2"; "etc" ] |> Seq.map(fun file -> async { use fs = new FileStream(file, FileMode.Open, FileAccess.Read, FileShare.Read) let data = Array.create(int fs...

asynchronous f# concurrency

0

Q: Cookie encryption library

Recently I needed to save session state in cookies, instead of server side. I looked around and didn't see anything similar, so I decided to write something to handle the encryption, decryption, and validation of the cookies. I wanted some opinions before/if I release it on packagist. Any feed...

php cryptography

Mat's Mug

AFC / stack-and-drive

syb0rg

21:52

@Mat'sMug I'm not completely sure either.

Stack Exchange

22:56

0

Q: Euclid's Algorithm

Hey guys I have a problem with this program for class. It's a Euclid Algorithm problem and I'm stumped on why I keep getting an output of 0 for the GCD. I'm not sure where the problem lies so I'm going to post the whole program code. Here is my code: #include <iostream> using namespace std; int...

c++ algorithm

Marc-Andre

Thanks all! First reputation cap ever!

3

Transcript for