The 2nd Monitor

6:00 PM

So if I'm reading this Java to C# thing right C# mostly has the good parts of Java, added some more and dropped the bad parts?

EBrown

}))));

Hosch250

@skiwi Exactly.

EBrown

The downsides of LINQ.

Hosch250

@EBrown That means you are abusing Linq.

EBrown

Not at all.

Just nesting some things nicely.

Hosch250

6:01 PM

Either split that into a few queries assigned to variables, or use outright loops.

It is almost impossible to debug when you do that.

EBrown

Why? It's just a nested string.Join and .Select.

J Hache

@syb0rg I'm not sure. Depends on how I'd ask it. I have an interface but I can't get it to work. Might be a better question for StackOF then CR.

Hosch250

No, it is a select nested in a join nested in a select nested in a join.

skiwi

Someone called the brace police?

EBrown

Yes, which is perfectly acceptable.

skiwi

6:02 PM

fn strike_out_multiples(&mut self, number: usize) {
    match self.prime_slice.first_number_in_range_with_divisor(number) {
        None => return,
        Some(mut val) => {
            while val <= self.prime_slice.last_number() {
                self.prime_slice.set_is_prime(val, false);
                val += number;
            }
        }
    }
}

Hosch250

My opinion is that you should only nest to two levels at the very most.

EBrown

Where is @Mat'sMug or @RubberDuck?

syb0rg

@JHache Perhaps

Hosch250

@EBrown Compilable doesn't mean acceptable.

Mat's Mug

what's up?

N3buchadnezzar

6:03 PM

Just saw game of thrones. I can finally be on the internet again (no spoilers pls)

EBrown

14 mins ago, by EBrown

result += string.Join(RowDelimiter, items
    .Select(item =>
        string.Join(ColumnDelimiter, properties
            .Select(property =>
            {
                var value = property.Info.GetValue(item)?.ToString();
                validateCharacters(value, ColumnDelimiter, "property value");
                validateCharacters(value, RowDelimiter, "property value");
                return value;
            }))));

Can you weigh in on that?

Mat's Mug

looks like a job for a StringBuilder

skiwi

decimal looks pretty cool in C#

Hosch250

I say it is nested too deeply to be easily modifiable, or debuggable. Readability isn't too bad in this case, but could be improved.

skiwi

@Mat'sMug I put on some new glasses

Hosch250

6:04 PM

@skiwi It is.

N3buchadnezzar

@Mat'sMug Bob the StringBuilder

3

EBrown

@Mat'sMug I was using one, but I was told on a CR review to use LINQ.

Michael Brandon Morris

@N3buchadnezzar Back at it again with the star-worthy messages.

Hosch250

@EBrown That is A) personal opinion, and B) not always good advice.

Mat's Mug

Linqaholism threatens us all

8

ardaozkal

6:06 PM

stringbuilder is you what you should use

Hosch250

I use Linq, and love it, but just be sure to use it correctly.

J Hache

I don't know if you guys have seen my question, but if one of you is good with ASP.NET, I'd really appreciate you checking this out:codereview.stackexchange.com/questions/132765/…

N3buchadnezzar

@MichaelBrandonMorris Sorry.. I can not help it, I am addicted to bad puns and word play.

6

Hosch250

@JHache Well, I was using it recently--not sure if I'm any good at it.

skiwi

You could probably still find a way to use StringBuilder in LINQ code :P

ardaozkal

6:06 PM

I see why people run out of stars this quick in this room.

6

EBrown

foreach (var item in items)
{
    var row = new ExtendedStringBuilder();

    foreach (var property in properties)
    {
        var value = property.Info.GetValue(item)?.ToString();

        validateCharacters(value, ColumnDelimiter, "property value");
        validateCharacters(value, RowDelimiter, "property value");

        if (row.BeenAppended)
        {
            row += ColumnDelimiter;
        }

        row += value;
    }

    result += RowDelimiter;
    result += row;
}

That's the non-LINQ version.

J Hache

@Hosch250 have you dealt with controllers doing too many things? I'm currently trying to refactor to have better seperation of concerns.

Dan Lyons

@skiwi you could use a StringBuilder inside an LINQ .Aggregate method, but that would create a paradox that would destroy the universe

Hosch250

@JHache No, I started with a pretty clean project.

Mat's Mug

you extended StringBuilder with a += operator?

Hosch250

6:08 PM

@EBrown I'd say use the Linq version, but split some of the queries apart and assign them to variables.

EBrown

@Mat'sMug And a few other things.

Mat's Mug

virtual whack

EBrown

5

Q: An extension to the StringBuilder

This is another pretty basic class I wrote for a library as I hate the way the default StringBuilder in .NET works. Essentially, I wanted to have the + operator, as well as implicit conversions to strings. (Rather than needing .ToString() all the time.) It's pretty small and simple, so there ma...

J Hache

@Hosch250 I was following the Contoso University tutorial and ran with that for my application. Now I regret it

skiwi

@ardaozkal I'm already out of stars :/

N3buchadnezzar

6:08 PM

Is there some consesus on whether to comment on the code OP posted. versus writing a better solution?

Hosch250

@JHache You have to be careful with tutorials.

EBrown

Now it has a HasBeenAppended which indicates whether or not any Append method has been called.

Hosch250

But, I know how that goes--I did the same type of stuff just two years ago.

EBrown

It's implicitly convertible to a string as well.

Mat's Mug

mkay

Hosch250

6:09 PM

@EBrown You could probably make a NuGet package of that.

ardaozkal

@skiwi I run out of stars only in this room and Maid Cafe. I guess I mostly star devhumor and japanese drawings.

J Hache

@Hosch250 trials and tribulations of a new junior developer tasked with building a prototype

skiwi

Java really seems old...

EBrown

@Hosch250 No idea how.

skiwi

The argument is often backwards compatibility, does C# have backward incompatibility at times?

Michael Brandon Morris

6:10 PM

@Mat'sMug You seem disturbed my friend.

ardaozkal

@skiwi it matters

Do you mean older devices or frameworks?

N3buchadnezzar

@ardaozkal Would you star japanese devhumor drawings?

skiwi

I think language evolution is more important than 99.9% backward compatibility

ardaozkal

@N3buchadnezzar I'd star twice.

Mat's Mug

@MichaelBrandonMorris yeah.. I like my StringBuilder vanilla-flavored.

EBrown

6:12 PM

@Mat'sMug Why?

Mat's Mug

because... if it needed additional members, they'd be in the BCL by now.

EBrown

"Use StringBuilder!" "But I don't know how!" "Well the ExtendedStringBuilder can be used just like a string." "Oh cool, that's easy."

N3buchadnezzar

Why would you ever want the vanilla taste? It does not taste bad but there are so many different flavours to try.

EBrown

@Mat'sMug Bull.

Look at NodaTime.

Captain Obvious

0

Q: Optimizing time and space complexity of recursive solution on string manipulation

Task is basically: Given a string, compute recursively a new string where all the lowercase 'x' chars have been moved to the end of the string. endX("xxre") → "rexx" endX("xxhixx") → "hixxxx" endX("xhixhix") → "hihixxx" Here's the initial idea I've had: public String endX(String str) { Arr...

java strings recursion

skiwi

6:13 PM

Reading about value and reference types I like Rust even more though, the complexity of Rust makes it a lot easier than the simplificity of Java and C#

EBrown

The BCL needs all those extra features, instead Jon Skeet had to implement them.

Mat's Mug

I never needed NodaTime. I'm sure it's great. Say, did Jon Skeet extend the StringBuilder?

EBrown

@Mat'sMug Why would he? He never needed it.

I did.

skiwi

When Jon Skeet wants to build a string he just tells the pieces to assemble themselves.

EBrown

You're invalidating my extension of the StringBuilder because I'm not "Jon Skeet?" That's nice of you.

N3buchadnezzar

6:15 PM

Skeetman, bopido

Mat's Mug

@EBrown looking at the code now... it's not too bad actually.

It's even pretty good

EBrown

@Mat'sMug There's no "fluff," it's just designed to make life slightly easier.

All it does is wrap the StringBuilder with a few convenience methods.

Now you don't have to remember to call sb.ToString() (or esb.ToString()).

Mat's Mug

it just comes as a surprise when you come across it in code. it blurs the line between += string concatenations and StringBuilder usage when you're glancing at the code

EBrown

Just implicitly convert it.

The += is not mandatory.

Mat's Mug

I saw that

EBrown

6:18 PM

You can strip out the operator + methods and it's just a normal StringBuilder.

Except for the conversion at that point, really.

And I just today added a HasBeenAppended method which indicates if the ExtendedStringBuilder only contains the initial string/buffer, or some Append method has been called on it.

Mat's Mug

IDK, IMO there's a reason the BCL StringBuilder doesn't implicitly convert to a string

@EBrown I'd make that IsDirty

EBrown

@Mat'sMug Yeah, it was written in .NET 1.1.

skiwi

C# supports goto statements?

EBrown

@Mat'sMug Why? Not sure what IsDirty would symbolize.

Mat's Mug

@skiwi sigh yes

EBrown