The 2nd Monitor

Simon André Forsberg

21:02

@skiwi unless you want to edit 513 questions manually, yes.

Legato

@Jamal You work quickly. :]

Simon André Forsberg

Is this how the ns* tags were dealt with? — nhgrif 1 min ago

@rolfl I had a feeling he would say that ^^

Duga

21:21

@Rootix Thanks to you, we got the answer. They are TRNG. Someone in code review gave me enough knowledge to get the answers. Here is the answer, which probably will be deleted or downvoted. So here is the answer again. — ncomputers.org 41 secs ago

maaartinus

@Duga Something to downvote.

Vogel612

soo... that post now has a selfie answer by OP..

which is most probably at least blatantly wrong

and at worst a copy of the text on a product site...

maaartinus

Yes, showing a exceptionally deep misunderstanding.

Simon André Forsberg

That answer should not be deleted.

Vogel612

down and delvoted from my site..

maaartinus

21:25

It's where the reality loses to one's believe.

@SimonAndréForsberg Why not?

Vogel612

@SimonAndréForsberg It isn't reviewing the code..

Simon André Forsberg

To anyone who might want to delete this answer: Being wrong and being an answer are two different things. There is no real reason to delete this answer. — Simon André Forsberg 14 secs ago

maaartinus

It sort of is. I'd probably keep it and downvote it to minus infinity.

Simon André Forsberg

@Vogel612 Does this answer review the code?

5

A: Generating random numbers from thread timing in C++

A true random number generator (TRNG) is a source of bits such that each bit has a probability of exactly 1/2 of being 1. Your code is obviously not a TRNG since its bias will heavily depend on the timing of operations. A pseudo-random number generator (PRNG) is a deterministic algorithm that pr...

Vogel612

yes.

What you have here is a source of entropy: a bit stream which is not fully deterministic.

Simon André Forsberg

21:28

@Vogel612 it's not a product site, it is his own blog or homepage.

Vogel612

The transformation (out, tmp) → (outBase+tmp, tmpBase+num) has cycles; if you fall into them you'll emit repetitions for a while until the scheduler hits.

maaartinus

^^ and it's new.

Vogel612

which is still spam without disclaimer..

On the programming side, you should initialize all variables.

maaartinus

It's no spam. It's just a backup in case it gets deleted here.

Vogel612

damn > not working on my keyboard right now, so I can't quote

Simon André Forsberg

21:30

@Vogel612 I don't think that's spam.

> These codes generate true random numbers because:

They implement a linear congruential generator, which generate pseudo-random numbers.
Unpredictable data races upgrades the pseudo-randomness into true-randomness.
CPU time jitter upgrades the pseudo-randomness into true-randomness.

Jamal

@Vogel612 Yeah, it doesn't even link to the correct site (the OP's). Lots of site promotion, too.

Simon André Forsberg

that's what the OP says ^^ How's that different from Gilles' answer?

Vogel612

All in all, you seem to be trying to generate random numbers by flailing around in the dark. That doesn't work.

Gilles is actually referring to the code

OP is spouting marketing slogans

maaartinus

philzimmermann.com/EN/essays/SnakeOil.html

Simon André Forsberg

I see nothing wrong with adding references to an answer. References is not spam.

Vogel612

21:31

aside from the fact that the references come from Gilles answer

Jamal

@SimonAndréForsberg They delete it, because they want to avoid the spread of knowledge. The answer is here. — ncomputers.org 1 min ago

Ethan Bierlein

@Jamal What...

Jamal

I hope the OP didn't post that code just to have the opportunity to post that page. I have already sent a warning about question quality but haven't heard a response yet.

maaartinus

I guess, he didn't (there was a discussion on SO and he seemed to be really interested). However, after getting a valuable answer, he claims his BS.

I'd say: Do not delete, downvote and ask everyone to downvote too.

What's the lowest score here?

Simon André Forsberg

@Jamal I doubt that he did that. I sincerely think he just wants an answer, and of course he wants his code to actually be a TRNG.

The page given in your comment should've already been included in this post with the entire answer text blockquoted. This isn't much of a code review anyway since it wasn't specifically written for this code. — Jamal ♦ 2 mins ago

@Jamal Any reason for that guideline? ^^

I disagree with that suggestion to post the answer as a blockquote anyway.

Jamal

21:41

But it was given verbatim from another website.

Simon André Forsberg

@maaartinus People can vote as they want to. No need to ask everyone to downvote.

@Jamal his own website

How do you know he didn't copy his own answer from Stack Exchange to his own website?

Is he not allowed to publish his thoughts, as-is, on both Stack Exchange and his own website?

Jamal

> Release date: 2015-06-18

Simon André Forsberg

okay, but still his own website

Btw, @Vogel612, even if it isn't "a Code Review", whatever that is, it is still a direct answer to his concern about the code being a TRNG. As such, it is an answer.

Vogel612

under the assertion that they can actually assess correctly whether that is a TRNG or not. In the light of the comments on Gilles' answer and the drama they produce I take the "easy way out" and say.. they don't.

maaartinus

@SimonAndréForsberg Sure... but everyone who sees it will do. At least I hope. +++ What I meant was not "ask everyone to downvote" but rather "ask everyone to have a look at it".

As this is exceptional. Worth seeing.

Phrancis

21:46

WTF

Ethan Bierlein

@Phrancis I think it makes writing SELECT statements harder, honestly.

Simon André Forsberg

@maaartinus that is totally ok to do.

@Phrancis How can that title typo not have been Jamalized?

Vogel612

aaaand ... Ethan did it

Jamal

@SimonAndréForsberg I agree with you: Good people wants to prevent the spreading of wrong knowledge. Bad powerfull people pays to avoid the spreading of good knowledge to preserve their power on good people based on their ignorance and lies. I was also naive until I found the truth :D — ncomputers.org 53 secs ago

maaartinus

@EthanBierlein LINQ for PHP? roflcopter

Phrancis

21:50

$this.query = "SELECT ? FROM ? WHERE ? ? ?"

Make your little PDO thing then. And bam you're done.

Vogel612

@Phrancis when I last checked, prepared statmementds didn't work that way, right?

Simon André Forsberg

@Jamal No offense against Russians, but suddenly that guy sounds Russian...

Phrancis

@Vogel612 Well, I made one in Groovy the other day and it worked basically that way.

Jamal

It's too chatty, anyway. I do get the feeling that he doesn't understand this site.

Vogel612

@Phrancis I tried that with java PreparedStatement and it failed miserably, because the column names need to be known before preparing the statemnt

Phrancis

21:53

Ahh

That'd be like making dynamic-SQL but with prepared statements eh?

Simon André Forsberg

the table name too I believe

Phrancis

Well, in any event, I'm just going to step away from that one

maaartinus

You can simply use positional arguments. What I did was

`queryFactory.query("SELECT a, b FROM t WHERE c=?', c)`.

It's about as short as using String.format. I've cached the prepared statement, but I haven't measured the performance.

Vogel612

@Phrancis that one doesn't show up on the frontpage anyways, give it another week and it'll get auto-cleaned

Phrancis

22:11

True

And, DVLR :D

Ethan Bierlein

Monkevening.

Captain Obvious

22:26

0

Q: Sufficient implementation of subset sum for 45 min interview

Provided I am still preparing, and I don't fully have my head wrapped around the dynamic programming approach (Geeks for Geeks). If I provided the implementation below in an interview, and explained that there was a dynamic solution that could speed the solution up for a small N and S would my te...

Phrancis

@EthanBierlein Hello!

Ethan Bierlein

!olleH sicnarhP@

Wow. The 2nd Monitor has a ton of room owners...

Malachi

Someone talking about me?

Ethan Bierlein

Nope.

Simon André Forsberg

Help! There was a meta question a while ago about a lot of points in answers being repeated a lot across different questions. Anyone knows which one I am talking about?

Ethan Bierlein

22:39

I saw one a couple of months ago, but alas, I have forgotten it's name as well.

Malachi

You said room owner and poof here I am

Ethan Bierlein

@Malachi Are you just magical like that?

Malachi

Sometimes

Time to get back on the bike though

Simon André Forsberg

I think this was the one I thought of:

12

Q: My reviews feel like a broken record

I don't know how bad it is for other languages, but for CSS reviews, I feel like I keep pointing out the same mistakes every time: Lack of shorthand Failure to use more semantic HTML5 elements when they're appropriate (eg. section vs div) Unsemantic class names Some of these things I would ex...

discussion

Phrancis

@Malachi Don't stack-n-bike !

Duga

22:52

The codereview link was mine; it's been replaced with rawkit (also by me and a friend). — Sam Whited 7 secs ago

Phrancis

Enough for now. Have fun with this, if you want, and make your own lists! data.stackexchange.com/codereview/query/330823/…

Phrancis

23:04

0

A: Stack Exchange Data Explorer is up. What now, Wonderland?

Categorized lists of tags I took the top 500 tags and (with the help of a few fellow contributors) made some loosely categorized CREATE TABLE statements that you can drop into your SEDE queries and JOIN to the Tags table. Example usage: CREATE TABLE #DatabaseTags (Name VARCHAR(100)); GO INSER...

Duga

IMHO this question would be more appropriate for Code Review Stack Exchange. — Robin Krahl 9 secs ago

This question could be suitable for Code Review, as long as (a) your code works as intended, (b) your code is real code, rather than example code, and (c) your code is included in the body of the question. If you wish for a peer review to improve all aspects of your code, please post it on Code Review and delete your question here on Stack Overflow. — Phrancis 9 secs ago

Legato

Are the dimensions of things considered "magic numbers?"

Ethan Bierlein

Probably not... Not sure though...

Phrancis

@Legato it-depends

In a heavily graphical setting, like libGDX, I wouldn't say so. But... well, context helps

Legato

Right, I should elaborate. Say I'm setting the size of a scene, and that's literally only used once, and will only ever be used once---is it still considered good practice to make final variables for that?

Phrancis

23:11

If it's literally only once, nah

Hosch250

@Legato Maybe a separate variable in a tight scope.

You'll should leave comment otherwise.

(And maybe also not-otherwise.)

Phrancis

Yeah, comment should suffice

Legato

Hm.

final int SCENE_HEIGHT = 75;
final int SCENE_WIDTH = 200;
Scene scene = new Scene(layout, SCENE_WIDTH, SCENE_HEIGHT);

vs.
Scene scene = new Scene(layout, 200, 75);

I'll go with the former if it's what's more conventional, I'm just confused about where to draw the line sometimes.

Phrancis

Former is probably preferable, from a standards standpoint

Hosch250

The second looks fine, but you should include a comment.

Captain Obvious

23:16

0

Q: Android SQLite code feedback

I have been through a few sqlite tutorials and wrote this code on my own to reinforce the principles. The tutorials I went through varied widely in a few areas so this is what I came up with as a combination of everything. Other than the two classes I have listed below, All I have is one activi...

java android sqlite

Simon André Forsberg

@Legato IMO, it's not necessary to extract those constants

@Hosch250 why the need for a comment? The constructor for Scene specifies that it is height and width?

Hosch250

Not that kind of comment.

A comment saying why the magic numbers 200 and 75.

Legato

Gratitude for the input @SimonAndréForsberg

Simon André Forsberg

@Hosch250 isn't that clear, given the Scene constructor?

Hosch250

Not really.

Why 200 and not 300?

Legato

23:23

Because 200 and 75 are the height and width I chose? Isn't most code arguably arbitrarily chosen? I feel like I could comment "This fits nicely/isn't too large" or something, but couldn't you just say why not 199 and 73?
Apologies if any of this comes off confrontational, because I really appreciate your input.

Hosch250

No, not confrontational.

Legato

Awesome, thanks again.

My first tag was jamalized earlier. :P

I can't spell raspberry, apparently.

Transcript for