The 2nd Monitor

10:04 PM

Bugs Considered Harmful. O RLY?

naming

@Mast YA RLY

I HAZ A BOOK ITZ "Bugz Conzid3r3d h4rmful"

Mast

This shall pass.

nhgrif

What are the two different logos?

Captain Obvious

0

Q: Porting ProcMonDebugOutput from C# to VBA

I'm basically ported this file. I don't have a 64 bit version of office to test this on, but I think I used all the LongPtrs right. I'm more concerned about am I doing the API signatures "right". Option Explicit ' Win32 API Constants Private Const GENERIC_WRITE As Long = &H40000000 Private Con...

0

Q: Generating Position

I'm written the following code to calculate position of an object following a trapezoidal motion profile: program ideone; VAR Pos : Real; Vel : Real; Acc : Real; Demand : Real; Max_Vel : Real; AccDist : Real; DecelPoint : Real; Error : Real; begin Pos:=0; Vel:=0; Acc:=5; Demand:=150; Max_Vel:=1...

physics pascal

Duga

If you want your code reviewed for performance, http://codereview.stackexchange.com/ is a good way to get that done — Shreyas Chavan 53 secs ago

Mast

10:10 PM

@Vogel612 I mean, it's like saying islands are surrounded by water.

YES! It's part of the definition!

Morons...

Vogel612

@Mast kinda surprising for management, you know?

Mast

@Vogel612 A moronic statement by management surprises you? What?

Vogel612

no not really.. I was saying that the obvious is surprising to management

Mast

Anyway, it's probably a bad attempt at a Dijkstra joke, but still, it's bad.

@Vogel612 Oh, in that case the whole thing must be written for managers.

Captain Obvious

0

Q: Python program to check if point is at land or at sea

I have written a program that divides an geographical area up in cells with size 0.001 degrees longitude by 0.001 degrees latitude, and check every cell whether it's a land area or a sea area. I've done this to effectively to get all the sea area of that area. This is probably insane from a GIS s...

python geospatial

Mast

10:17 PM

@CaptainObvious Please review my code, call me an insane idiot and help me to get it better.

2

Gold.

Ethan Bierlein

Hey

@CaptainObvious Pascal?! Wow

Mast

@EthanBierlein Nothing wrong with Pascal ^^

I've written some automation scripts in SCAR a while back, the syntax is Pascal-like.

Ethan Bierlein

I'm not saying anything is wrong with Pascal, I'm just surprised to see a question with it.

Mast

True, we don't get them a lot.

It's a shame though, it's a very easy language to learn.

Duga

@Robᵩ Good question! In this particular case, I'd say it fits about evenly on both sites. This is a specific enough question to be on-topic on Stack Overflow, I believe. For future reference, you might want to read A Guide to Code Review for Stack Overflow users — Simon André Forsberg 20 secs ago

Simon André Forsberg

10:23 PM

@Mast One of the first languages I learned! (or the first, if you consider it "the same" as Delphi). Definitely nothing wrong with Pascal.

I should perhaps get my Pascal skills up and running again, it's been quite a while now...

Mast

What would be an ideal problem to solve with Pascal?

Simon André Forsberg

Sudoku solver. Always Sudoku solver!

Mast

I've done crazier things than writing a FizzBuzz already in Pascal, so that's out.

Sudoku seems nice. You want to brute-force it or do it the 'human' way?

Simon André Forsberg

@Mast I guess the availability of free compilers might be an issue... Delphi is proprietary software, although FreePascal works..

Mast

ideone :)

Simon André Forsberg

10:26 PM

@Mast This way:

35

Q: SudokuSharp Solver with advanced features

Even though it's the first time I'm writing something this "big", it feels like I know C# quite good. It's been nice to learn LINQ also and I am very impressed by the features, and perhaps I have overused it here (if it's possible to do that). SudokuFactory: Contains static methods to create so...

c# linq weekend-challenge sudoku

Mast

Can handle fpc and gpc, Lord knows what the difference is...

@SimonAndréForsberg I've seen that one before. Extensive.

FreeMan

@SimonAndréForsberg What version of Delphi are they up to? I used 5 or 6, I think it was. a long, long time ago...

Mast

C# fun: SudokuBoard board = SudokuFactory.ClassicWith3x3BoxesAndHyperRegions();

Simon André Forsberg

@Mast feel free to only make it work for a classic 9x9 board. (but really, the same concepts apply for all other boards as well)

Mast

I've made an attempt at solving it in Python once, didn't go very well for some reason.

Simon André Forsberg

10:29 PM

@FreeMan I started with Delphi 3. That continued until Delphi 8 or 9 I think. Then they started using years, like Delphi 2004 and Delphi 2005 and stuff. Now I think they're calling them "Delphi XE" or something

Mast

Was a while back, had a tendency to focus on the wrong problems first back then.

Captain Obvious

0

Q: First Graph Adjacency List

First time implementing a adjacency list. Is the use of exceptions correct? If anyone could test/read the code and give some advice on improvments I would appreciate it. #include <iostream> #include <vector> #include <exception> #include <list> class VertexInvalidArg : public std::invalid_argum...

c++ linked-list graph

Mast

@CaptainObvious I've tried it, but to be honest I'm not sure what it should be doing. The output is mainly a bunch of floating point Position:150.00

Duga

This one is really strange. You sure it's still LINQ to Entites and not LINQ to Objects? The link to codereview.se doesn't say it's LINQ to Entites. — MarcinJuraszek 57 secs ago

Mast

What is a 'trapezoidal motion' anyway, I'd expect a X and Y coordinate instead of just a position. Or a RE and IM if it's a phasor.

Simon André Forsberg

10:42 PM

@Mast honestly, good question. I mean... it's a bad question. I mean.... you're question is good, that question is bad because it doesn't really explain things, and the OP seems to want an answer to "Is this correct?".

Mast

I think he wants this:

Don't mind my paint skillz.

Simon André Forsberg

you could add a comment and link to that image and ask if that's what he wants.

Mast

Meh, why not. Posting.

Simon André Forsberg

I'm not quite sure how the output has to do with it though... is it like a "connect-the-dots" kind of thing? Maybe if you draw a point for each output line, it will be that kind of motion?

Mast

If you connect the dots, above is pretty much along the lines of what you'd get.

In which case he has an algorithm flaw.

Simon André Forsberg

10:46 PM

but if the above is what you'd get, and that's what he wants, then all is fine, isn't it?

Mast

Yes.

Problem is, I'm not sure that's what he wants.

Simon André Forsberg

ah, ok

Mast

The amount of context is, well, what context...

We're told it does something with a trapezoidal motion.

Now, I've googled that term and since the math part of my brain shuts down around midnight, I couldn't know for sure.

Now I just hope he realizes the 'this' in my comment is a hyperlink.

Mat's Mug

Huh, how did I get +30 on that old KTurtle answer?!

Mast

@Mat'sMug Thank Santa.

@nhgrif We've been sorting that out. Turns out it works as intended. — Mast 11 secs ago

nhgrif

10:52 PM

Then the question should be edited to reflect that.

Mast

Indeed.

nhgrif

And until it is, it should be on hold.

Duga

Please concentrate on one question per question. The first part, about "Can my code be written more efficiently?" is a good question for Code Review. For the second part, about creating a load/save game method, I'd recommend google for "load and save files java" and try to implement something and then ask on Stack Overflow if you bump into specific problems. For the last part, about the directory where the file will be held, you should be able to find that out while working on the general loading and saving. — Simon André Forsberg 59 secs ago

Mast

@Duga @SimonAndréForsberg Flagged as too broad.

@nhgrif Advised him to revise the question. We'll see what happens.

I haven't reviewed a Pascal question yet and this one seems do-able for me.

nhgrif

> Is the following code accurately calculating position?

He can't really ask that question.

Mast

10:59 PM

Well, the current situation is good enough to say what the curve is, but nothing else.

Simon André Forsberg

I must say that in the last week that I've been a moderator, I have noticed how good the Code Review community is. It's often not too many things to moderate. Sure, @nhgrif and @rolfl go bananas on each other every once in a while, but it's just because you both want what you think is best for the site. I know I can safely go to bed and knowing that the community can take care of any situations that may pop up.

nhgrif

I just flagged 2 comments.

rolfl

You thinK?

nhgrif

they're resolved.

rolfl

No you didn't.

hehehe

Mast

11:00 PM

@nhgrif How long did that take, a minute?

nhgrif

Simon André Forsberg

@rolfl think what?

nhgrif

I don't know. I wasn't paying attention to how quickly they were resolved. I was doing other things.

rolfl

@SimonAndréForsberg You think it's safe to leave two monkeys in a room with just one banana?

5

Simon André Forsberg

I'd better get more bananas...

3

rolfl

11:02 PM

@Simon - Code Review is a different experience now, for each of us....

thoughts? Good thing for you still?

Simon André Forsberg

@nhgrif 13 mins ago comment flag: not constructive 7 mins ago Simon André Forsberg♦

rolfl

By now you should be pretty settled, and in the routine.

I have disabled all mail notifications from the exchange, and no noisy alerts, or popups.

I am finally getting used to that......

Simon André Forsberg

@rolfl I do have several thoughts, but for now only one: Sleep!

Vogel612

^^ that sounds like a reasonable idea

rolfl

Night!

nhgrif

11:05 PM

Did we get more bananas?

I'd suggest we create monkeyscript... but there's no need. swift-is-magic

Mast

@rolfl How does it feel, being a peasant on CR?

rolfl

@Mast Don't know, you tell me....

4

.... ba-dum-tish!

Mast

Let me rephrase that...

How does it feel to no longer carry the heavy burden of being a moderator for such a beautiful site?

rolfl

Mixed... to be honest. For a number of reasons. It's complicated.

I was struggling with a bunch of things before the elections, so while a lot of CR was great to do, it was having consequences in other ways, and creating stress in my life.

so, there's a big part of me that's relieved.

but I am missing a lot of the stuff too, the "friends" in the support community, etc. is a big part.

Mast

But the stress went down as expected?

rolfl

11:17 PM

Still working on it, and catching up on stuff. Next week I am on holiday out-of-country..... that'll help.

Quill

@Mast A better question would be ... how many times rolfl's been asked that :P

rolfl

I am also trying to get a new "balance" for things.... I am doing about 1/5 the time I was doing.

@Quill That's true, but I have not really answered it too much, till now.

Quill

@rolfl I noticed

Mast

Take your time. You've spend years as a moderator on this site.

Years.

Don't underestimate the impact that has/had.

rolfl

Thanks, that's sweet, but I was a mod for.... 500 days, and a member for 650 ... ;-)

hardly "years".

Quill

11:22 PM

Well, 500/365 > 1, so ... :P

rolfl

Most folk on the site are unaware that the site's history is so messed up.

SirPython

@rolfl What was so messed up about it?

Duga

Please post your code where you having an issue and if you are looking to optimize your code you should use Code Review instead. — Codermonk 14 secs ago

rolfl

the site from 2010 through 2013 is nothing like the 2014 and later

Quill

@rolfl Ignorance is bliss?

@SirPython Sort meta posts by oldest and you'll see

rolfl

11:23 PM

in a sense....

Quill

@Duga Completely unrelated to getting a code review ...

rolfl

@SirPython Have a look at this: data.stackexchange.com/codereview/query/161411/…

nhgrif

@Quill return 500/365 == 1; // true (integer division)

Hosch250

@Mat'sMug @Malachi linked it.

Quill

@nhgrif yes, at an integer level

nhgrif

11:26 PM

Early 2014 is when I joined, so it makes complete sense that that's when the site got better.

rolfl

@nhgrif hehehe.....

this is why I do Code Review:

This is wonderful, thank you. This is exactly what I was hoping for: a mixture of API, code structure, and problem solving advice. — DavidS 1 min ago

Mast

@rolfl What changed? It can't be just the zombie hunt...

rolfl

@Mast Mat's mug, jamal, malachi, Simon, and others. That's what changed

Mast

Jamal became moderator somewhere at the end of '13, right?

rolfl

It all came down to a handful of people, killing zombies, and making a difference.

@Mast malachi and others noticed a distinct lack of moderation and enthusiasm, and spawned and impromptu election.

2

Mast

11:30 PM

Yea, I read a meta like that.

Hosch250

I joined just before the spike in 2015.

rolfl

12

Q: Code Review is in need of a new moderator

I know that we are a beta site, but from the looks of it, they only choose moderator pro-tems 2 weeks into a beta site. I think we need to follow the path set forth for nomination of a new moderator, if nothing else to show that we are a growing site and have enough active users to become a full...

discussion status-completed beta-progress moderators

Mast

Jamal posting a question, a moderator asking him if he'd like to become a moderator and not too long later the whole thing was done.

rolfl

@Mast I have seen the moderator chat room.... and I can tell you that it was "unfrozen" pretty much each time it was used.

Flags were unhandled for days.

Mast

@rolfl That's awful.

rolfl

11:31 PM

Jamal, poor fool, ended up single-handedly carrying the site and cleaning it up at the same time, for 6 months or so.

Duga

There are many corrections that needs to be made here. For a better solution, I would recommend you post this on codereview.stackexchange.com — Renae Lider 37 secs ago

rolfl

The rest of us had fun flagging things, and making him work as we killed zombies.

Finally, when he was at cracking strain, he implored the CM's to get new mods.

Mast

@rolfl That sounds both great and awful at the same time.

@nhgrif Better?

0

Q: Generating Position

I'm written the following code to calculate the position of a motor during each timestep, the result of which will be compared with feedback from a quadrature encoder and subjected to a PID algorithm. The trajectory will follow a trapezoidal profile. i.e. Accelerate to a maximum velocity, coast a...

physics pascal

Hosch250

> •Um

rolfl

As I say, there's the old Code Review, and the new one. A large part of the problem with graduating Code Review is/was the fact that the old nombers made the site look horrible and dragged things down, and the new numbers were too "new" to call it a trend.

Duga

11:34 PM

If you'd like to move it over to codereview, flag this question and ask a moderator to do it for you. — Renae Lider 48 secs ago

nhgrif

> Is the following code calculating the exact position? If not, how can accuracy be improved.

I think that question needs to be changed just to "How can the accuracy of this calculation be improved?" perhaps

Mast

@nhgrif Just what I thought.

Feel free to join us in the chat of that question if you feel like it.

Quill

If you hadn't nominated yourself, I would have nominated you! You're just about everywhere, you're always respectful in every single post of yours that I've seen, you've got a sense of humor and you're more than just obviously addicted to this site. I'm sure you'd do great with the almighty moderator powers and wouldn't suddenly turn into an evil overlord j@ck#$$ with an inflated head. Wow this almost feels like an election page.. I hope it gets some attention from SE :) — Mat's Mug ♦ Oct 26 '13 at 0:59

And, he tags back with @retailcoder ;-)

rolfl

here's another interesting graph: data.stackexchange.com/codereview/query/170999/…

Mat's Mug

Those were the days...

</lurks>

Mast

11:37 PM

@rolfl Avg Walking Zombie Age in Weeks Now that's appropriate naming at it's best.

But over 150?

Zombies over 150 weeks?

That can't be right...

rolfl

@Mast Wrong red line

Mast

@rolfl Oh.

rolfl

150 is how many answers are given in each week, on questions that are less than 24 hours old when answered.

Mast

Slightly under 50. Is better, but still...

It's average. It never should've gotten above 20 IMHO.

rolfl

What it really means, is that most of the zombies are old, and are getting older ;-)

Phrancis

11:39 PM

MONKING

rolfl

the newer zombies are getting answered first.

Mast

Indeed.

SirPython

@Phrancis Hello, Phrancis!

rolfl

MONKING too

Hosch250

The only thing I have to say here is that XKCD about Lisp parenthesis: codereview.stackexchange.com/questions/87075/…

Mast

11:40 PM

@nhgrif Fixed.

Hosch250

It looks clean and clear to me otherwise.

Mast

I've just received word that the Emperor has dissolved the MIT computer science program permanently.

That one?

Hosch250

Yep.

Mast

I'm good with XKCDs.

XKCDs are good.

Good with good.

Phrancis

Good.

Mat's Mug

11:46 PM

Good God

2

nhgrif

0

Q: Do you have to speak the language to answer the question?

I frequently read in chat users saying things about not being able to answer this question or that because they don't know the language used in the question. Is this true? What knowledge level is required of a language before I should consider myself capable of answering it?

discussion answers

rolfl

My activity on-site: data.stackexchange.com/codereview/query/339177/…

nhgrif

0

A: Creating an array of objects for dictionaries

var DrugArray:[Drug] = [] var drugs:[String] = [] for i in array { if contains(drugs, i["drugName"]! as String){ continue } else{ drugs.append(i["drugName"]!) DrugArray.append(Drug(name: i["drugName"]!)) ...

rolfl

Jamal's: data.stackexchange.com/codereview/query/339177/…

Captain Obvious

0

Q: Downloading data using HttpClient

I'm working on a class to download some data from an external server and feed it into my data model. I'm new to both HttpClient and async methods in C#, so I'm not sure of a few things. Is my placement of new SearchResultSet() reasonable? It's a little contrived, true, but I'm trying to get a...

c# async-await

Stack Exchange

11:51 PM

0

Q: Do you have to speak the language to answer the question?

I frequently read in chat users saying things about not being able to answer this question or that because they don't know the language used in the question. Is this true? What knowledge level is required of a language before I should consider myself capable of answering it?

discussion answers

rolfl

Hmmm, can't be right.

Mast

@nhgrif Do note your answer is generic.

It doesn't hold for every language.

Hosch250

Killed a zombie

Mast

I do not want to see you writing VHDL answers if you do not understand how VHDL works.

Hosch250

Maybe it will bump it so someone can provide a better answer.

nhgrif

11:54 PM

@Mast Perhaps. I don't know. I've never seen VHDL. But VHDL is more likely an exception than even remotely a rule.

Phrancis

Would you please elaborate on how this is an improvement? The educational value of this answer, as it is, seems pretty low. I would encourage you to read some other answers on the site to get a better grasp of what kind of answers make good Code Reviews. — Phrancis 17 secs ago

@nhgrif ^^ Is this appropriate? The answer seems like a code dump, and they even said it's not functional...

nhgrif

They don't mean "this doesn't function"

Quill

@nhgrif all things considered, the php answer is absolutely hilarious

nhgrif

They mean it doesn't perfectly match functional programming paradigms

@Mast How many VHDL questions are there?

Meanwhile, what percentage of questions on the site are from a C-based language?

Phrancis

@nhgrif Ah, ok. Still seem to be pretty low quality (to me)

nhgrif

11:57 PM

I agree. It's just a code dump.

Mast

@nhgrif One without answer because it got recently unlocked. 6 total I think.

nhgrif

I'm not concerned about the 6 exceptions. (There are probably some other exceptions too)

Mast

Oh, 5, I think we lost one.

nhgrif

The two most popular tags are Java & C#.

If you can comment on Java whitespace, variable names, etc., you can comment on the same for C#.

rolfl

Fixed... Jamal's contributions: data.stackexchange.com/codereview/query/339177/…

Mast

11:58 PM

@nhgrif I always have to look twice before I spot the difference between those two, that's how similar they are.

nhgrif

C++ is 5th. C is 12th.

Mat's Mug

@nhgrif agreed. Except knowing what framework you're up against kinda helps improving OP's code

Transcript for