Well looking at this as a code review of the code you posted i can recommend a couple of things;
Security
The major flaw at the moment is the possibility for SQL injection. You put the $_GET values directly into the query without validation or escaping.
PHP.net has a page on SQL injection: h...
I managed to simplify a pair of your functions:
countDelta
countDelta = map (\(x:xs) -> (length xs + 1, x))
In fact most of the logic in your countDelta was just reinventing map, so actually using map makes it much easier.
ShowTuples
(You named it printTuples but it does not print the tupl...
Division is (on some CPU's) double the execution time of multiplication.
@Caridorc Exactly.
Similarly if (x == 1) { /* ... */ } else if (x == 2) { /* ... */ } is often technically slower than switch (x) { case 1: /* ... */ break; case 2: /* ... */ break; } when there are many conditions.
@Malachi Like, I have 1 year of a Maths degree, which is currently paused while I'm working, and honestly, I learn far more, far faster, and far more valuable things in my current job than I ever did at Uni.
I got an Electronics Engineering degree. My current project has little to do with electronics and in my spare time I program in more languages than I care to count.
I learned C, C++ and VHDL in college, the rest is self taught.
I've always been something of a polyglot. I'm interested in systems and figuring out how they work. That's led me into Maths and Statistics and Finance and Economics and Politics and Sociology and Psychology and Anthropology and Computer Science and Programming
IIRC, I considered doing about 12 different degree subjects
I wrote this to scrape album review data from AOTY into a spreadsheet. Check it out and let me know what I could've done better.
Option Explicit
Const classAlbum As String = "listLargeTitle"
Const classScore As String = "listScoreContainer"
Const classRating As String = "listScoreValueContainer...
And just to make it better, the string is kept as comma-separated values all the way into what the method does with it, instead of say putting them into a list at the beginning. And as I found out, if the string has no values, fatal error on the application.
I'm writing in VB.NET, using VS Community 2013. I don't know much about this language. I have managed to make my code work, but I suspect it is possible to improve the code a lot.
I am using the asynchronous read functions of TcpClient, and whenever a newline character is received, the handle_...
I have a helper extension method that I use for path string validation. It looks as below. It's purpose is to work with network paths as well, so in case a network resource is not available, I do not want my applications to freeze, hence the specified timeout etc.
public static bool IsExistingFi...
I'm not convinced that your special case
getSequenceLogic [x] = printTuples [(1,0)]
is justified. If [100, 103] is to be summarized as "1x3", then don't think that [100] should be "1x0". I would consider an empty string to be a reasonable summary of [100].
When possible, you want to avo...
I tried to write a foolproof code for the first part of the first problem on adventofcode, and I was hoping for some feedback.
function findEndFloor(floors, upFloorSymbol, downFloorSymbol) {
if (typeof floors !== 'string')
throw 'parameter 1 is expected to be a string';
if (typeof upF...
To celebrate our first graduated Christmas (and because we feel like it), some regulars in The 2nd Monitor thought it would be a good idea to make a Secret Santa between members of Code Review!
The rules are quite simple :
You will send an email to secret-santa@lambdaexpression.io to register...
> MACINTOSH: Most Applications Crash; If Not, The Operating System Hangs
> Windows 95 is a 32 bit extension for a 16 bit patch to an 8 bit operating system originally coded for a 4 bit microprocessor by a 2 bit company that can't stand 1 bit of competition.
On marriage: Isn't this like merging two entirely different code bases? I mean it basically takes 20ish years automatically working out the merge conflicts.
Well looking at this as a code review of the code you posted i can recommend a couple of things;
Security
The major flaw at the moment is the possibility for SQL injection. You put the $_GET values directly into the query without validation or escaping.
PHP.net has a page on SQL injection: h...
var elem = document.getElementById('item1'),
// var elem2 = document.getElementById('item2'),
checkBox = document.getElementById('check1');
checkBox.checked = false;
checkBox.onchange = function() {
// elem.style.display = this.checked ? 'block' : 'block';
...
I managed to simplify a pair of your functions:
countDelta
countDelta = map (\(x:xs) -> (length xs + 1, x))
In fact most of the logic in your countDelta was just reinventing map, so actually using map makes it much easier.
ShowTuples
(You named it printTuples but it does not print the tupl...
I wrote this to scrape album review data from AOTY into a spreadsheet. Check it out and let me know what I could've done better.
Option Explicit
Const classAlbum As String = "listLargeTitle"
Const classScore As String = "listScoreContainer"
Const classRating As String = "listScoreValueContainer...
I'm not convinced that your special case
getSequenceLogic [x] = printTuples [(1,0)]
is justified. If [100, 103] is to be summarized as "1x3", then don't think that [100] should be "1x0". I would consider an empty string to be a reasonable summary of [100].
When possible, you want to avo...
I tried to write a foolproof code for the first part of the first problem on adventofcode, and I was hoping for some feedback.
function findEndFloor(floors, upFloorSymbol, downFloorSymbol) {
if (typeof floors !== 'string')
throw 'parameter 1 is expected to be a string';
if (typeof upF...
To celebrate our first graduated Christmas (and because we feel like it), some regulars in The 2nd Monitor thought it would be a good idea to make a Secret Santa between members of Code Review!
The rules are quite simple :
You will send an email to secret-santa@lambdaexpression.io to register...