The 2nd Monitor

rolfl

11:00 PM

@Mat'sMug - I think there's a difference.

Mat's Mug

if it needs to be changed, then it's a design review because the code isn't doing what it's supposed to be doing

rolfl

@nhgrif is claiming that the CoreData 'model' represents both the design, and the implementation

nhgrif

> What's the difference between reviewing the data model that someone wrote by hand with their keyboard to map these Family and Person classes versus reviewing the data model that someone built with CoreData? And in answering this question, keep in mind everything we've already reviewed in this post: CoreData is not a database schema; CoreData is not a UML; CoreData is an actual data model implementation.

With CoreData you're building the implementation of the Person class...

Mat's Mug

@rolfl and it is - but it's a "Model", not a working program that does something with it.

nhgrif

Just like with an Interface builder you're building the implementation of a lot of UI code.

class Person; isn't a working program that does something either.

But is perfectly reviewable...

Phrancis

11:01 PM

TTQW

rolfl

@Mat's, it's a concept of what is the source code for your implementation....

nhgrif

If it were posted as code and not as a screenshot of how you created it in the CoreData designer.

Mat's Mug

later @Phrancis

Stack Exchange

Sorry about the IIS default page that some were seeing - a new web server snuck into the load balancer early. Should be fixed.

Tweeted by StackStatus on January 28, 2015 at 10:48 PM

nhgrif

The CoreData screenshots that have been posted are part of the compiled code!

Mat's Mug

11:02 PM

well yeah, it's reviewable to a certain extent - naming, code formatting... and that's all I can think of.

rolfl

If programmers using CoreData share their 'programs' or components of their programs, by 'sharing' the CoreData components, and not the text-based source code, then the source code is the CoreData model.

If the best representation of that model is a picture.....

Mat's Mug

the CoreData model generates the code

rolfl

Yes... and people have been telling me that Lombok is Java, right?

Mat's Mug

that's a different thing

rolfl

how so?

In Lombok you add a few annotations and the impelmentation if the class is generated.

In CoreData you move some boxes and draw some lines, and the implementation of the class is generated.

At elast, with CoreData, they have the decency to call it CoreData, and not C, or whatever ;-)

Mat's Mug

11:04 PM

but that implementation is just a frakkin type that does nothing

nhgrif

Types that do nothing are reviewable...

"do nothing"

Mat's Mug

fine, they'll get my downvote.

nhgrif

It doesn't make the CoreData question a good question.

If I thought it was a good question, I probably would've posted an answer sometime in the last 4 months...

Mat's Mug

what's there to review on a Person class, or a screenshot of a tool that generates that Person class?

(besides the naming?)

nhgrif

Do you have properties to represent everything you need?

rolfl

11:07 PM

That's my point too, in the meta post I gave.

Mat's Mug

> I'd rename Sex to Gender

@nhgrif only OP knows that

nhgrif

You can even do a performance review...

If you have a string to represent first name and a string to represent last name and a string to represent full name

rolfl

But, there's a second aspect that concerns me in that question...

Hosch250

@Mat'sMug What type does the compile use when you set var v = 0;?

nhgrif

You can improve your memory performance by getting rid of the full name string and replacing it with a computed property.

Mat's Mug

11:08 PM

@Hosch250 int

Hosch250

Would that be a double or an int?

OK, thanks.

Because I just had that for a double.

Mat's Mug

you can use compiler hints to determine the type, like 0d and 0f

Hosch250

OK.

Easier to remember double and float.

rolfl

or 0.0 for double, and 0 for int.... right?

Mat's Mug

yeah

Hosch250

11:09 PM

That would make sense.

nhgrif

Are the datatypes you're using the right kind? Are you using int64 where int16 would suffice?

Mat's Mug

@nhgrif right

rolfl

^^^ technically, @nhgrif - the image he gave was not enough information for that.

nhgrif

I know.

Mat's Mug

still, I find it makes pretty shallow posts. @rolfl but the generated code does

rolfl

11:10 PM

OK, so I think I am on the same page as you, @nhgrif.

nhgrif

That's why I showed you the other screenshot that I would've included. But he included the .h files which makes the other screenshot I posted unnecessary.

Mat's Mug

I'm putting them in the same box as the one-liners and other "poor questions" - on-topic, auto-downvote-unless-exceptional.

nhgrif

Yep.

rolfl

I understand that, for people who use CoreData, that they consider the CoreData 'graphical interface' to represent the actual 'source code'. You 'compile' the application from the CoreData representation.

Mat's Mug

I think we also need to agree that screenshot-only is off-topic.

nhgrif

11:11 PM

But... if I personally am asking a question that involves usage of CoreData-created-objects, I'm probably including just the CoreData big picture screenshot, then the actual questionable code.

Mat's Mug

be it only for our blind users

the screenshot makes nice-to-have context, especially for larger models

nhgrif

Because from the screenshot, the objects can be derived easily if you know CoreData.

Mat's Mug

but screenshot-only goes with link-only: questions must include the code to be reviewed

nhgrif

Right.

rolfl

OK, Personally, and probably from a moderator perspective, I am "happy" to concede that screenshots of the CoreData interface essentially is 'source code'.

nhgrif

11:13 PM

But realize this...

If you're the type of person who is going to do a UML...

You still do a UML before you start your Xcode project and build the CoreData.

Mat's Mug

......so, what?

nhgrif

Emphasizing that CoreData <> UML

Mat's Mug

indeed. for me CoreData[IOS] == EntityFrameworkDesigner[Windows]

rolfl

OK, I want to move this debate in a different direction, to the next level....

Mat's Mug

I thought it was over...

nhgrif

11:15 PM

No.

rolfl

Nope, I want to look at the next line in the actual question:

nhgrif

We just got enough XP to level up, that's all.

2

rolfl

> Overall, what do you think of my database schema? Is it sufficient to handle a simple test-taking app?

nhgrif

"database schema" is a misnomer there.

rolfl

I guessed that, now.

Mat's Mug

11:16 PM

that can be a comment @nhgrif - like I said, it's playing with words. the thing boils down to a db model.

rolfl

No, it's not a DB model....

nhgrif

Would you call a UML a database schema?

rolfl

it's an object relationship model.

Mat's Mug

^^

fine

rolfl

Those objects also happen to be fully-generated classes in the application, with relationships and references.

So, @nhgrif - here, he's presented his code, that encompasses a whole implelmentation, but is only asking to have the design reviewed, right?

Instead of saying: this is the problem I need to solve, and this is the solution I have....

he's saying: I don't know if I have solved it, and I have not really tested it, because I don't know if I should go further.

Malachi

11:20 PM

14

Q: Site graduated! New design launched

As you can see the new design just went live. Which means this site has been officially launched! Congratulations! Thank you for your valuable design feedback. If you see any CSS/styling bugs, please start a new post and tag it with "design" and "bug." We have also updated site's Twitter profil...

Who is next?

Mat's Mug

@Malachi man that totally freaked me out - I thought it was a meta-CR post!!!

rolfl

15

Q: Tracking Graduation Progress

The following information relates to sites that are in the process of, or recently have, gradudated. Announcement is when the site was notified that graduation was going to happen. DesignMeta ... many times, sites are contacted to say *"Hey, we have started looking at the colors for the site, a...

discussion beta-progress

nhgrif

This specific question seems like it could be off-topic--I still haven't completely decided how I feel about this specific question.

But... I have stated before, if you haven't tested your code, then it can't possibly be working to the best of your knowledge.

Mat's Mug

^^

nhgrif

Schrodinger's Code: Until you've tested it, it's neither working nor broken. At CodeReview, we require code that is working, not code that is not-broken.

3

rolfl

11:21 PM

If I give some Java code and say "I need to sort some intgers, does this code sort the data right"?

nhgrif

That question has to be off-topic here AND on StackOverflow.

It can't be anything but unclear what you're asking.

rolfl

Using his words:

> Overall, what do you think of my database schema? Is it sufficient to handle a simple test-taking app?

> Overall, what do you think of my design? Is it sufficient to handle sorting some integers in an array?

Mat's Mug

I think the provided answer speaks for itself

0

A: Core Data model for test-taking iOS app

Test_Questions and User_Answers are not necessary since they do not hold any attribution and are one-to-one relationships with Test and User, respectively. It is always suspect when you have a plural table name. However, the model fails to support the ability of a User to take multiple Tests. To...

I lean on the off-topic side of the fence.

nhgrif

The "to handle" makes it more borderline, however.

rolfl

I have tio run..... back in 15 minutes (with my son).

nhgrif

11:24 PM

Because I could write a sorting algorithm that sorts an array of 2 integers... and it works perfectly for arrays of 2 integers. And I could easily post a question saying "This works in the scenarios I've tested, but is it sufficient to handle any other scenarios?" and that seems perfectly on-topic.

Well, not perfectly... but I think you get the point.

So with this question, we have to ask... to what degree has the user himself tested what he's sharing?

Mat's Mug

TTQW here, bbl

nhgrif

My gut says not at all.

Simon André Forsberg

should we have a "not tested enough" close reason?

nhgrif

No.

The broken code and pseudocode close reasons cover it well enough, I think.

Simon André Forsberg

and "not tested enough" is a very grey area

nhgrif

11:27 PM

Yes, and if questions asking for a design review are off-topic, then that close reason could be added

And that covers some other "not tested enough" scenarios.

Simon André Forsberg

we don't get that many design review questions

Malachi

prepare for UpVotes!

0

Q: Site Launched, who is next?

Movies and TV is now a Full Fledged Site! Congratulations to them. Now we all want to know what the order of the Remaining sites are...right? Who's Next?

discussion beta-sites graduating-sites

Hosch250

Incoming question.

Captain Obvious

0

Q: Square Root Calculator

I have now written a simple square root calculator using the division method: static void Main(string[] args) { double num, sqrt = 0; int currentDecimal = 0, decimalAccuracyLevel, intAccuracyLevel = 5; do { Console.WriteLine("Enter your number: "); } while (!double...

c# mathematics

Hosch250

Kind of basic.

Uh-oh.

My SQRT-calc brought CR down!

Back up.

Alexis King

11:35 PM

Hmm. What should I do if the code I'm trying to review has compiler errors in non-trivial ways?

This is the code in question:

6

Q: Reading, writing, and copying files

Originally, I created a program that echoes files or strings to output. This is a modification of that same program and goes a step further. It does work (in both Linux and Windows), but I can NOT guarantee that it is bug free or that it is even fully compatible with both OS's. This program writ...

beginner c file io

nhgrif

VTC?

Alexis King

It could be because I'm trying to compile it on OS X, but the OP says it's for Linux/Windows.

That said, most code that works on Linux and Windows works on OS X.

Maybe I should spin up a Linux VM and try to compile it there.

nhgrif

Someone who has Windows or Linux can try compiling it.

What are the errors though?

Things like missing libraries?

Alexis King

No, mostly redefinition of symbols.

Hosch250

Nasty defines?

Alexis King

11:37 PM

No, enums with things like read and write as enum elements.

Unprefixed.

Hosch250

Oh.

nhgrif

I would say if it compiles on Windows/Linux, then write a review pointing out the problem of how he's caused this problem for OS X... or if it doesn't compile on Windows/Linux, then it needs to be closed.

Hosch250

I passed another user, and 1 point away from a fourth user today.

Simon André Forsberg

TTGTB

Hosch250

See you.

nhgrif

11:45 PM

9

Q: Will we ever be able to view the past?

By analogy with the sun, whose light is apparently reaching us in 8 minutes, it means that we are only viewing the sun 8 minutes ago when we look up at it. However, what if we were eventually able to build powerful machines that could view light from say hundreds/thousands of years ago, wouldn't ...

visible-light soft-question

The answer to that question is yes...

Not today's past, but we could see into the future's past.

Hosch250

We are living the future's past right now.

nhgrif

Right.

But imagine, a mirror in space 100 light years away.

If you looked at that mirror, you'd see whatever was happening 200 years ago.

Hosch250

No, 200 light years ago.

nhgrif

.... that's what I said...

Hosch250

You said 200 years.

However if we need to install the mirror, installing mirror 100 lightyears from Earth is going to take at least 100 lightyears, so we can't ever watch our actions from before we decide to install it. And we didn't do it yet, so we won't be able to view actions that are already past. — Jan Hudec 4 hours ago

nhgrif

11:48 PM

Oh, no... that's right.

a light year is a distance.

Hosch250

Yeah.

nhgrif

It would take the light 100 light years to reach the mirror

err

It would take the light 100 years to reach the mirror

And another 100 years to make it back to you

So it'd take 200 years (and the light will have traveled 200 light years)

Hosch250

Oh, yeah.

Confusing.

The best part is that light travels faster in space than it does here, so unless a light year is defined at a particular gravity, we don't know how long a light year is.

At least, if I remember my physics correctly.

Alexis King

Alright, so it does compile on Linux.

nhgrif

That's not true @Hosch250...

Light travels in a sort of weird way but it doesn't travel faster in different mediums...

Alexis King

11:56 PM

No, it travels faster in a vacuum, IIRC.

(But only by a tiny bit.)