What I would like to do is have a method call like:
Database.Modify.InsertOrUpdate<ADDRESS>(address,
() =>
{
var result = ctx.ADDRESS.Where(o => o.JURIDICAL_ADDRESS == "Y")
.OrderByDescending(o => o.ID)
.FirstOrDefault();
return (result != null ? result.ID : 0);
},
() => ...
Need Code review on my Abstract Factory pattern written in Java.
Please suggest me any changes
Find the two enums AnimalType.java and DietType.java below.
package com.patterns.abstractfactory.three;
public enum AnimalType {
TERRESTRIAL("\nLeave on land and breath with lungs.\n"), AQUATIC("\n...
I've previously posted a (quite popular I must add) question about how to simplify a query to count votes with a distribution system (Complex query to count votes with a redistribution system). One of the contributors, @200_success, pointed out that it calculated the surplus redistribution based ...
I'm pretty new to web development with JS and was wondering if anyone can tell me how I can improve my code. I just feel like when it comes to maintainability my code would be very difficult to update. Can someone advice on some best practices or maybe how they do it?
Javascript
Here is a typic...
I have been struggling with a regular expression involving path names. Immediately, this is a bit troublesome, owing to the embedded / in the pattern, but braces to the rescue.
First the convention I have imposed:
Every path in the set looks like:
/ifmxdev/files/file.0123
but that top dire...
I'd like to amend my previous proposal to abolish refactoring and refactor. Instead, I propose to make them both synonyms of code-smell.
Since this Meta question was first raised, there have been three refactoring-related questions that I'm aware of:
Possible improvements to Risk board game?
...
It might be naive from, but aren't the aim of a code review to find out if there is a way to refactor the code in order to have it improved?
If this tag doesn't apply to all question, when should I use of the [refactoring] tag?
Guys,
Actually, I don't want to ask a question, I want to share my parser for Oracle alert log...
I've had a lot of headache with alert log monitoring... Grep for errors doesn't give much info, you should to go to machine and look for error and timestamp, and additional strings (e.g., when job ...
The code itself is generally pretty clean looking, but I think it suffers in a few areas:
InsertOrUpdate screams: "one method that is concerned with two distinct things". I see InsertOrUpdate as an anti-pattern.
Coupling between Console/Output writing and persistence logic is too tight.
The use...
Proposal: Design Review
I think the graphic design community will support the proposal for the equivalent of what Code Review is to Stack Overflow. On the same basis that Code Review was founded, Design Review will be the Code Review equivalent for Graphic Design.
Why is Design Review a good id...
It's a string problem I have been making on hacker rank. It is executing fine on all test cases except the last two. These last two test case are declaring it "Terminated due to time out".
C programs are allowed 2 seconds on this site And somehow my program is taking a fraction beyond 2 seconds...
It looks from the data as if you do not need the numbers to be random, only unique.
A solution is to take the numbers from 1 to 1,000,000 but output them in base 29 using the allowed characters.
private static readonly char[] Values = {
'B', 'C', 'D', 'F', 'G', 'H', 'J', 'K', 'L', 'M', ...
Give meaningful class names to your classes, e.g. "relative" does not seem to describe anything about the data type of the object. A more meaningful name could have been "RankFinder" in the context of your problem.
Always stick to Hungarian notation while naming your classes and functions. http:...
I did some javascript code:
app.get('/offers/', function(req, res){
var funcGetOffers = utils.funcGetOffers;
var options = {top_sort: true};
funcGetOffers(function(offers){
res.render('offers', { offers:offers });
}, options);
});
app.get('/api/get_offers', function(...
Is there any improvement that can be done to the code?
Yes. The other answers do have very good points, but I don't want to repeat them. I only could add that renaming your i variable to n would match the task description better.
Is there any optimization?
You don't need any loop at al...
in your checkRelativePrime method you have
static boolean checkRelativePrime(int a, int b) {
int i = 2;
while (a > 1) {
if (a % i == 0) {
{
if (b % i == 0)
return false;
}
a = a / i;
} else
...
As part of an Academic project I wrote the following code, according to the algorithm(verbal). when I checked the rest of the article I notice that the efficiency should be O(n^2) -and I wrote O(n).
I know that I didn't finish and that there is much to do I'm putting my code and article here and ...
I tried to write a list in a text file and then ran:
os.system("gnome-terminal -e 'bash -c \"cat /tmp/test.txt; exec bash\"'")
This works, but I want to get the same result without creating a text file, I mean, running print (list) directly in an entirely new terminal window and there get the ...
I have a website I am building which essentially is a question and answer site for my profession. I have a general structure question. On the site, users can post threads, responses, follow questions, promote other users etc....all the usual stuff you's expect.
My question is how does one deal ...
During our internal code review process, my following code raises some eyebrows.
public class MySuperUtil {
public static List<Long> updateAndSubtract(List<Long> first, List<Long> second) {
List<Long> updated = updatePlaceholdersWithLargestIds(second, first);
Collection<?> difference...
I have a small project for which I would like to ask for a code review soon. However, it integrates multiple languages (specifically, Python + jQuery and the rest of the browser stack).
Can such a project be posted for review?
If so, how should it be done? One question or several?
Can I ask spe...
