ugh. fed up. I was given shit this morning, for spending time to make the code more readable and easier to maintain while implementing a small change in a 800-liner procedure. I'm preparing my C.V. tonight, this job doesn't deserve me.
oh, lol. nothing much going on, I'm just fed up with my job/boss/company-that-doesn't-give-a-damn-about-code-quality-and-thinks-writing-quality-code-is-a-waste-of-time. Having "pretty" code isn't a priority, I was told. Had to bite my tongue.
maybe you need to lower your standards, GOTOS are beautiful too!... stop the media from impressing young programmers with their perfect unattainable standardof beauty. Spagetti code programmers shouldn't feel bad because they are too lazy to take care of their bodies... wait wat
It's beyond just "form". They're opening a db connection (never closing it), then entering a loop that gets files from the file system (across a network), then grabbing some data from the database (using yet another db connection), then parsing some XML from the files, looping through the content, calling 3rd-party API to generate a document in the ERP app, grabbing some more data from the database (did I mention concatenated SQL strings?)... nested recordsets, reused variables...
but they don't get what "cost of maintenance" means
that code base is far uglier than the ugliest piece of code on this site, it actually can compete with codecrap.com...
...and there's no performance issue unless a user says so, so bring them nested recordsets with concatenated string parameters running in a tight loop, who cares, it works!
@rolfl I got into it because I worked at the same place for 10+ years (1990 through 2000), evolving/maintaining the same code-base (with up to 20 other developers); there the code had to be good enough to ship, and maintainable enough to evolve and ship again.
You can't return from finally. You will get compiler error:
Control cannot leave the body of a finally clause
If target class implements IDisposable then I would do next:
using (stuff s = new stuff())
{
return stuff;
}
or
using (stuff s = new stuff())
{
try
{
// do...
@Corbin “unclear what you're asking” is still there. But I severly miss “this question shows no effin' effort at all” (although it probably used a tamer wording)
I'm trying to pull a report that will give me the Daily Sum of all credit card purchases for a set range of dates. Right now I have the following report which gives me the sum of all credit card transactions for the dates I set as one lump sum. Basically I want the report to look like this:
3/...
stackoverflow.com/questions/22669152/… is what was making me lament the new messages. It's completely clear what he's asking; it's just stupid if he's even glanced at the documentation. :/
@Vogel612 Don't worry, I'm still at SE at home :) It's just that now I don't have any work for a while, so I can't be pretending-to-work
@rolfl It's Batik 1.7. And it only happens under Linux weirdly enough. Perhaps I'll file a bug with them next time I'll be working (probably in April some time)
Now when I'm not working I can learn Ruby and Scala :)
@rolfl Yes, for a while. I'm working externally so it's not a full-time never-ending job. I've been working when I'm needed. I will try to write a CV and look for a better job.
Someone who writes functional code that is pretty (maintainable), under pressure from management to deliver.
It is very rare that you get the opportunity to go back and fix things, and, even when you do get the opportunity, the rewrite is normally 'tainted' by being compatible with what is already 'out there'.... so you have to reproduce bad behaviour.
Public Function pfNzSq(ByVal pstrToFormat As Variant) As String
pfNzSq = pstrToFormat
pfNzSq = Replace(pfNzSq, "'", "''")
pfNzSq = pfNz(pfNzSq)
End Function
Public Function pfNz(ByVal pstrToFormat As Variant) As String
On Error GoTo Err_Process
If IsNull(pstrToFormat) Or pstrToFormat = Empty Then
pstrToFormat = ""
End If
pfNz = pstrToFormat
Exit_Process:
Exit Function
Err_Process:
Resume Exit_Process
Resume
End Function
I'd probably kill the moron that wrote this if I saw him ^^^^
pfNz is called 301 times.
My version:
Public Function Coalesce(ByVal value As Variant, Optional ByVal value_when_null As Variant = 0) As Variant
Dim return_value As Variant
On Error Resume Next 'supress error handling
If IsNull(value) Or (TypeName(value) = "String" And value = vbNullString) Then
return_value = value_when_null
Else
return_value = value
End If
Err.Clear 'clear any errors that might have occurred
On Error GoTo 0 'reinstate error handling
Coalesce = return_value
End Function
I had to look up some other solutions online because I could not figure it out on my own, which kinda sucks. I really wish I came up with it completely on my own but that didnt happen :(. Nevertheless please review my prime number program and let me know if there are any improvements I should mak...
I have been searching for about an hour on how to do this in Excel.
I have an Excel file that was created from an old system and I am pulling information from a SQL Server Database, I will be inputting the information back into the SQL Server Database and would like the Dates to match.
I have...
From perusing your code a few times:
Custom event abuse
While it's very cool to have custom events, I would simply remove this extra layer of logic. It does not make sense to call $(networkInfo).trigger('selectNetworkRanges'); if you could just call selectNetworkRanges(). I understand that you ...
what do you think about the following class? Do you think it is a good approach to solve the authorization problem? I'm looking for a very simple design pattern. Thanks.
http://www.soloproyectos.com/downloads/auth/class.php
Here's an example of use:
http://www.soloproyectos.com/downloads/auth/...
Public Function GetIsWorkingDay(ByVal StrDate As Date) As Boolean
'2014.01.30 GB : Redmine 71, validate that the date is a working day.
Dim strQry As String
Dim rs As ADODB.Recordset
strQry = "select IsWorkingDay from Schedule where Date = '" & StrDate & "' "
Set rs = GetAdoRecordset(strQry)
If rs!IsWorkingDay <> 1 Then
MsgBox ("La date sélectionnée n'est pas un jour ouvrable")
GetIsWorkingDay = False
Else
GetIsWorkingDay = True
End If
rs.Close
VB6. StrDate is a Date, not a String. the comment belongs in the commit log, the parameter is concatenated into the query (and this function is called in a loop, obviously), and you can't use it just to validate a given date, because there's also UI logic in there!
...and the implicit conversion from Date to String is culture-dependant and WILL FAIL (on the SQL side!) if the user's regional settings aren't the expected ones...
I've written a small library of objects for parsing of Valve Map Files (VMF). These files are always generated and exported from either the Hammer World Editor, or a Source engine built in map making program like the PTI in Portal 2. So I can trust them to always look roughly like the following, ...
See, no-one gets generalist (and there are a number of people (including me) who would qualify, otherwise) until all of the top 40-most-popular tags have at least 200 questions.
Now, it is a whole lot simpler to make sure that qualifying questions are tagged appropriately (which should be done anyway), than to wait for new questions to come in.
Can someone review my implementation on JSFiddle and give me some pointers making my code cleaner and robust.
I've been working on this in JsFiddle. I am attempting to get a nice clean graph implementation for workflow design. For instance, we have input and output nodes and processes in betwe...
Linux
I think you would want to use a Linux based OS for Developing Android applications seeing as how Android is a Linux Based OS, it's open source, it's free, and can run on a partition next to windows, and I think Mac Os as well (don't quote me on that though). it's been a while since I ope...
In conclusion, after reading the other answers, I think that the consensus about flagging as "not an answer" is, more or less:
Flag link-only answers; for example:
There's an interesting implementation at http://example.com
Do not flag short answers, even if they contains a link, provided ...
his whole answer doesn't make sense without the link, and probably doesn't make send with the link, I haven't tried to read it. the point is that it's not complete, it doesn't form a complete thought/sentence
Right now this is being discussed if this is an answer or not because of how borderline it is. If you expand this answer a bit (perhaps show an example of its usage), that would remove the controversy over this post. — syb0rg21 secs ago
Fast Time conversion
I'm trying to write a very fast time-to-string and string-to-time function.
I noticed that on low CPU mobile devices this function has, even if minimal, impact on the performance of the overall canvas animation.
Milliseconds to Time string (HH:MM:SS.mss)
In this function:...
Fast Time conversion
I'm trying to write a very fast time-to-string and string-to-time function.
I noticed that on low CPU mobile devices this function has, even if minimal, impact on the performance of the overall canvas animation.
Milliseconds to Time string (HH:MM:SS.mss)
In this function:...
I had to look up some other solutions online because I could not figure it out on my own, which kinda sucks. I really wish I came up with it completely on my own but that didn't happen. Nevertheless, please review my prime number program and let me know if there are any improvements I should make...
I'm creating an unordered-list element in Backbone via underscore templating.
I've got the following:
<ul id="FrontRack" style="
background-image: url({%= data.get('racks').at(0).get('imageUrls')[0] %});
height:{%= data.get('racks').at(0).get('pixelHeight') %}px;
width:{...
Fast Time conversion
I'm trying to write a very fast time-to-string and string-to-time function.
I noticed that on low CPU mobile devices this function has, even if minimal, impact on the performance of the overall canvas animation.
IMPORTANT
Performance
Short code
ms2TimeString (4 updates...
There are two ways i can see of integrating Edge Animate With External JQuery
Something happens within Adobe edge and triggers something to happen externally or vice versa.....
1: When an action is performed (mouseUp MouseOver... etc...) we can initiate some external Jquery
For example:
When ...
Yeah, I see what's going on here. The OP is trying to respond to konijn within the question, instead of using the comments section. I wish another moderator were here to help me with this. I'm this close to doing a lock.
@Malachi I'll be going to class soon, so I can't spend too much time on this. I'm trying to get it to a good revision, and to make sure the OP isn't trying to respond to answers directly within the question.
I been working on getting the SocketAsyncEventArgs to work the way I want it to work. Now I was wondering is this going to work how it should work?
/// <summary>
/// The settings to use with this ServerSocket.
/// </summary>
ServerSocketSettings Settings;
/// <summary>
/// The buffer manager fo...
@Malachi Okay, I've decided to lock it for now. My last comment there:
On second thought, I'll go ahead and lock this post as is. Anyone wishing to help with this can join a chatroom with the OP. When a consensus has been reached, either ping me in chat or raise a flag. — Jamal ♦1 min ago
@Jamal @konijn answer was based on revision #11 (based on time-stamps and confirmed by reviewing konijn's answer to verify that it matches the code in revision 11).
How about getting your code reviewed by someone else before your boss gets to it? A second set of eyes is a good thing, and, if you get to choose those eyes, even better.
Perhaps he is right, and you do need to improve your code, and getting help is a good thing.
Not only will this improve your...
I'm trying to write a regular expression to check names for invalid entries. Basically i'm trying to eliminate people entering random junk as their name. I know i cant completely eliminate it but i'm trying to make it a little harder at the very least. Here is what i have so far. It works fine i'...
@Jamal So you/one could rollback to #18 on the basis that that was the last pre-vandalized version. Or copy/paste code from version #18 to the top of the latest version and mark it as the "original code" which konijn reviewed.
I'm trying to write a very fast time-to-string and string-to-time function.
I noticed that on low CPU mobile devices this function has, even if minimal, impact on the performance of the overall canvas animation.
**Milliseconds to Time string (HH:MM:SS.mss)**
In this function: is there a shorter & faster way to pad the numbers?
function ms2TimeString(a,ms,s,m,h){// time(ms) return ms=a%1e3|0, s=a/1e3%60|0, m=a/6e4%60|0, h=a/36e5%24|0, (h>0?(h<10?'0'+h:h)+':':'')+ //display hours only if necessary
@Jamal Personally I don't care a fig for anything after and including the **DEMO** line. I only (theoretically and on priniciple) care to preserve the lines above that, because that's the question which konijn reviewed.
I've had my say: a) konijn reviewed version #11; b) edits 12..18 were to later "commentary" parts of the post which I don't care about c) edit #19 deleted the original code d) therefore copy/paste the top lines (from the top of the post down to the ***DEMO*** line) of any of version 11..18 to the top of the current question: in order to restore the original code and not invalidate konijn's answer.
@ChrisW I'll see what konijn has to say, just to be sure. As the monkey has said, this doesn't have to be rushed. I've also raised a moderator flag in case the others can weigh in (or just unlock the post if needed).
I have written the following C code for calculating the Shannon Entropy of a distribution of 8-bit ints. But obviously this is very inefficient for small arrays and won't work with say 32-bit integers, because that would require literally gigabytes of memory. I am not very experienced in C and do...
@Jamal The OP's current post is well-formatted and understandable i.e. harmless if you read it. Only problem IMO is the vandalism of the original code. In one comment he wrote,
why should i not answer to comments ? btw you just told me to remove all the updates...but if you want i could add the first versions of the functions at the bottom.but you should not delete valid descriptions & explainations of my code. — cocco1 hour ago
... which is fine, except that our convention is to put the "first versions of the functions" at the top not at the bottom.
I'm writing a bash script to handle the PPA's on Ubuntu & derivatives. I was wondering how to know if I'm handling this the right way.
So, the script works (flawlessly), but I posted it to a blog and got this feedback :
The way you wrote you script is the one we all use when we begin : we ...
Exactly. I also must've missed that part of his comment. Still, if he was actually "responding" to the answer in the post, then that part should be removed. I've already mentioned that updated code should be concise so that others can follow.
@syb0rg He may have his own reasons, and he's not obligated to share them upon deletion. He can always request a private chat with a moderator if needed.
@Jamal I know. Looking at his other SE profiles, I wonder if he just wanted to delete one of his other profiles and changed the "About Me" section for all of them.
@Jamal The updated code is concise: 2 functions, of 8 lines and 5 lines of code. The wall of text is a line-by-line (and expression-by-expression) commentary on those 13 lines.
@Jamal IMO copy the top lines (from the top-of-post **Fast Time conversion** line down to but not including the ***DEMO*** line) of any of versions #11 though #18 (for example codereview.stackexchange.com/revisions/… which is version 18), and paste them to the top of the current post, and draw a --- line under them.
Meme: Jamalized
Originator: Jamal ♦ (actually, apparently me)
Cultural Height: All over CR (see this chat transcript search)
Background: Jamal being a frantic editor. And he's fast. So fast, we're all waiting for the day he will edit a bad question title before it's even posted. You never know...
You can't return from finally. You will get compiler error:
Control cannot leave the body of a finally clause
If target class implements IDisposable then I would do next:
using (stuff s = new stuff())
{
return stuff;
}
or
using (stuff s = new stuff())
{
try
{
// do...
I'm trying to pull a report that will give me the Daily Sum of all credit card purchases for a set range of dates. Right now I have the following report which gives me the sum of all credit card transactions for the dates I set as one lump sum. Basically I want the report to look like this:
3/...
I have been searching for about an hour on how to do this in Excel.
I have an Excel file that was created from an old system and I am pulling information from a SQL Server Database, I will be inputting the information back into the SQL Server Database and would like the Dates to match.
I have...
what do you think about the following class? Do you think it is a good approach to solve the authorization problem? I'm looking for a very simple design pattern. Thanks.
http://www.soloproyectos.com/downloads/auth/class.php
Here's an example of use:
http://www.soloproyectos.com/downloads/auth/...
For what it's worth, clojure.contrib.string/partition does this exactly.
Can someone review my implementation on JSFiddle and give me some pointers making my code cleaner and robust.
I've been working on this in JsFiddle. I am attempting to get a nice clean graph implementation for workflow design. For instance, we have input and output nodes and processes in betwe...
In conclusion, after reading the other answers, I think that the consensus about flagging as "not an answer" is, more or less:
Flag link-only answers; for example:
There's an interesting implementation at http://example.com
Do not flag short answers, even if they contains a link, provided ...
Fast Time conversion
I'm trying to write a very fast time-to-string and string-to-time function.
I noticed that on low CPU mobile devices this function has, even if minimal, impact on the performance of the overall canvas animation.
Milliseconds to Time string (HH:MM:SS.mss)
In this function:...
I'm creating an unordered-list element in Backbone via underscore templating.
I've got the following:
<ul id="FrontRack" style="
background-image: url({%= data.get('racks').at(0).get('imageUrls')[0] %});
height:{%= data.get('racks').at(0).get('pixelHeight') %}px;
width:{...
There are two ways i can see of integrating Edge Animate With External JQuery
Something happens within Adobe edge and triggers something to happen externally or vice versa.....
1: When an action is performed (mouseUp MouseOver... etc...) we can initiate some external Jquery
For example:
When ...
What belongs here vs what belongs on StackOverflow
I been working on getting the SocketAsyncEventArgs to work the way I want it to work. Now I was wondering is this going to work how it should work?
/// <summary>
/// The settings to use with this ServerSocket.
/// </summary>
ServerSocketSettings Settings;
/// <summary>
/// The buffer manager fo...
How about getting your code reviewed by someone else before your boss gets to it? A second set of eyes is a good thing, and, if you get to choose those eyes, even better.
Perhaps he is right, and you do need to improve your code, and getting help is a good thing.
Not only will this improve your...
I'm writing a bash script to handle the PPA's on Ubuntu & derivatives. I was wondering how to know if I'm handling this the right way.
So, the script works (flawlessly), but I posted it to a blog and got this feedback :
The way you wrote you script is the one we all use when we begin : we ...
Meme: Jamalized
Originator: Jamal ♦ (actually, apparently me)
Cultural Height: All over CR (see this chat transcript search)
Background: Jamal being a frantic editor. And he's fast. So fast, we're all waiting for the day he will edit a bad question title before it's even posted. You never know...
