cv-pls python Sketchy / hypothetical codereview.stackexchange.com/q/207104

cv-pls vba Not working codereview.stackexchange.com/q/207123

@Vogel612 I VTCd that quesiton because usually there is/was no problem with closing other questions alike that were lacking context (unknown types/variables etc) - but I see that it's been VTCd by other members again too and got closed after all again so the first few votes were not the only the only one who thought it's not that good

@SimonForsberg I'm looking over the auto comments, and it seems like we're missing comments for the ownership of code and explanation of code close reason. How would I go about adding it?

@Peilonrayz Post an answer on the question with the comment, then we can add it to the main answer with all the comments

Ok, will do. Also, what do you think of changing the names so that if it's offtopic it would be renamed from say "Question contains no code at all / a link to code" to "Authorship > Question contains no code at all / a link to code", so that it's easier to know which close reason links to which comment?

@Peilonrayz the name of the comment? Sure, good idea

although is that one really under "Authorship"?

I'm pretty sure it is:

> Authorship of code: Since Code Review is a community where programmers improve their skills through peer review, we require that the code be posted by an author or maintainer of the code, that the code be embedded directly, and that the poster know why the code is written the way it is.

ah, right

cv-pls javascript Request for new functionality Javascript filter not filtering by selection only - DanielS‎ - 2018-11-01 18:15:00Z

@TobySpeight I'll close-hammer it if you comment.

On the brink between being reopened and staying close (4/3): codereview.stackexchange.com/review/reopen/106366 According to codereview.meta.stackexchange.com/q/8781/31562 it should probably stay closed.

@TobySpeight ^^ that being said, whether or not it is a good answer I leave up to the general public to decide.

People are sometimes a bit too trigger-happy with flagging answers for "Not an answer"

If it's an attempt at answering, then it is an answer.

Recommended reading for everyone ^^

@SimonForsberg Comment added

@Peilonrayz Question closed

Beaten to it! Thanks everyone

@SimonForsberg On first reading, it looked like borderline spam: "Use this/my library!". On reflection, I did jump the gun, and it's just a low-quality attempt at answering.

@TobySpeight Yeah I totally understand. I was considering converting it to a comment for a bit.

@Graipher Mast's last answer (30% achieved, when 92% is expected, can't be considered "working") convinces me - not yet ready for review.

^^ s/answer/comment/

cv-pls c Code not implemented or not working as intended: A code to generate list of ordered pairs of numbers and find the maximum value of binary operations - Nehal Samee‎ - 2018-11-07 12:01:51Z

@Peilonrayz hammered

cv-pls java Code not implemented or not working as intended: How to find the area of two squares - java - Cameron Young‎ - 2018-11-07 12:20:12Z

@Peilonrayz hammered

Asks for advice on code yet to be written: codereview.stackexchange.com/questions/207136/…

@BCdotWEB self-deleted

cv-pls python Code not implemented or not working as intended: Using List Method. Please Help me To Solve this thank you - Christian Rae Bandales‎ - 2018-11-07 14:35:06Z

cv-pls java Code not implemented or not working as intended: Hi I need Help Please Help in Java Swing Thanks in Advance - Sanju M‎ - 2018-11-07 14:31:22Z

@Peilonrayz Good job with the comments lately. Keep it up. Just a small note: If a question doesn't fit anywhere on SE (like these two last questions), recommending other Stack Exchange sites just risks the OP to have another bad experience, on Stack Overflow or Software Engineers or whereever.

@SimonForsberg I'm using the auto comments, maybe we should remove those sentences from them?

@Peilonrayz Hmm, yeah perhaps we should...

Another option is to adapt the comment to the situation

Or maybe we could find a way to improve the comment so that Stack Overflow and Software Engineers are described properly, but that's difficult I imagine.

I'm not a fan of adapting, I used to write custom messages all the time. It burnt me out, and most of the time I'd write something that the OP seemed to not care about. The rest of the time the OP then started arguing with me.

@Peilonrayz I understand. I often start from one of the auto-comments and then adapt it in some variations.

cv-pls python Code not implemented or not working as intended: Generating prime numbers indefinitely using generator - p.shreyas shetty‎ - 2018-11-07 15:51:49Z

No comment, no hammer. (At least not from me)

@SimonForsberg Commented (sorry)

And hammered

And the guy mixed up n and N it seems.

Does hammering not add a comment the same way that voting does, then? Or do you just feel that the standard comment isn't adequate?

@TobySpeight The "standard comment" is not a comment but a close reason. I think it's polite to add the auto-comment, especially for newcomers.

Okay, thanks

cv-pls array Authorship of code: To find number of sub sequences of an array having median lying in that sub sequence - Aditya Navphule‎ - 2018-11-07 16:04:29Z

delete-pls Duplicate post subsequences containing median

@200_success close as duplicate first pls

I can't reopen and reclose anymore. You can.

Oh, now I see that it's the one @TobySpeight mentioned that is the original. I thought you wanted the one you linked to to be deleted

Done.

I'd like to schedule a soon room meeting about how to adapt the original SOCVR FAQ for our particular needs regarding CR. What would be your preferred daytime (UTC) in case you're interested to subscribe?

I can also provide a GIT repo for maintaining an initial clone of the FAQ.

cv-pls android Authorship of code: Animations and RecyclerView Android App Written In Kotlin - knittledan‎ - 2018-11-07 17:53:18Z

@πάνταῥεῖ Where's the comment?

@SimonForsberg OK, so wee deem it required now?

@πάνταῥεῖ For me to hammer it it is.

It clearly says "New contributor", and right now the question has one downvote. Do you see any reason to not add a comment explaining what's wrong with the question?

@SimonForsberg Fine, I've put one.

And hammered.

my 2 cents is if you find something wrong with the question enough to post it in a close review room, you should probably comment why the post needs work so OP is aware :p

(consider that an extra review of suggested protocol, since you asked for input from me :P)

Well, the room isn't primarily meant to ask mods for hammering questions of topic, but to gain attention for community regulars to review close worthy (or reopen worthy) questions. I've mentioned earlier that I have had bad experience with leaving comments explaining DV/CVs at questions at SO. Repeating close reasons doesn't add any information. The diamond mods should see our requests here to ease their workload a bit, and shifting it to the community IMO. @Simon @Thomas

right but i'm not a CR diamond mod ;)

my opinion is me as a community member

not as a diamond moderator with the power of the Great Ones to smite posts :P

if i were a newbie, i'd prefer to know why i'm getting downvotes or close votes, so the comments would be appreciated :)

@ThomasWard OK

'tis how we learn how sites work ;)

(I went through that back when I started on Ask Ubuntu, it's how I learned how the site worked and behaved, and now I know the policies like the back of my hand AND have since been elected as a moderator, so I mean...)

@πάνταῥεῖ I thought the room was meant for closing questions quickly?

also from a point of view of a moderator who sees all the meta posts: people keep asking "Why did I get downvoted?" or similar on Meta, the comments would help explain such things but some users don't write them, which leads to the "Why downvoted!?!?" questoins.

(so yeah, comments.)

@ThomasWard Some of them achieve this kind of advise quite badly, and there are others lurking to flag suchlike comments as rude or unfriendly. That's what I experienced at SO at least. I almost stopped to provide any comments without factual information at SO and pointing to rules completely. Even the initially good intentions of the idownvotedbecau.se failed at SO. Thus I am just cautious.

@SimonForsberg Sure but the room shouldn't ask for mod help explicitly.

@πάνταῥεῖ CR is not SO. But a rude comment is a rude comment, no matter if it's canned our not.

@πάνταῥεῖ No one has asked me to use my hammer.

@SimonForsberg I know that, and that's why we urgently need to adapt our policies here initially derived from the SOCVR.

@πάνταῥεῖ might be good to parent that to the CodeReviewCommunity org

github.com/CodeReviewCommunity

that thing's been semi-inactive for a while. Poke me if you need folks to have an invite

@Vogel612 I'd appreciate to use a different GitHub repo rather using my pesonal one.

@πάνταῥεῖ yeah the wording can be tricky, then there're users who consider any criticism to be rudeness directed towards them

and cause problems

that's when diamonds (such as @Vogel612 here) step in

FTR: whenever I saw a rude-flag on an auto-comment, that flag was declined

or CMs if it's bad enough :P

@Vogel612 typically same behavior I do with autocomment flag reviews on Ask Ubuntu :P

I actually needed to do that twice for one person, but...

mmmm, peppermint hot cocoa... slurps the tasty beverage

@πάνταῥεῖ you should have received an invite

@Vogel612 Gotta check my inbox(es).

PSA: If you want to contribute to the github repo for the faq, please shoot me a message with your GH username

aight. with that I'm back to ripping other people's ages old code to shreds

~heavy sigh

@Vogel612 It's right there at my profile, but well github.com/makulik :D

@Vogel612 I logged in with my GitHub account, but can't see the invitation. I'm probably too dumb to manage all that information channels I've setup in the past :3

@πάνταῥεῖ My best time is 1300, Monday to Friday. Could possibly make other times within a window of 1030-1830 on weekdays; weekends are right out (better places to be, AFK).

@TobySpeight That fully falls into my working hours, when I actually try to stay away from the SE network rather than doing work related searches. I'd prefer a weekend summoning.

@πάνταῥεῖ I don't know how to "fix" that...

soo ... you probably have to get your information channels under control :)

@Vogel612 What's the URL of the dialog shown above? (I am approaching that from a SW dev's view now)

try this one

@Vogel612 Ah, that's just a new one setup. :D

I'll just use it, fine!

you should have complete write access there

and if you don't yet have, try going to the team page in the org

the invite should be displayed for accepting somewhere around there

That clarifies a lot: i.sstatic.net/Z8Bzb.png

@πάνταῥεῖ this should still allow you to clone the repo, actually...

I'm somewhat confused why it doesn't do that yet...

@Vogel612 Sure.

can you easily get the URL? If not: HTTPS or SSH?

@πάνταῥεῖ Opposite to me, then - 1300 is my lunch break, but I could create a block elsewhen in my working day. Doing SE when away from work would be harder - I have more limited access (and time) away from the office. No one time will please everyone, so pick a time that suits you and the most others; if I have to miss it, then I'll catch up later.

Heading home now...

My primary problem now is to get the original markup that sets up the SOCVR FAQ as a starting point at that repo. I am pretty dumb with doing such stuff, while it might to turn out an easy task.

@TobySpeight OK, I noticed you'd prefer working days rather than weekends. But my primary question was how to synch our different UTC times at best. So weekends generally seem to be a better choice. Some late owls might easier attend such event at WE rather than regular working days.

cv-pls php Lacks concrete context: Factory pattern with or without reflection - Jaroslav Klimčík‎ - 2018-11-07 19:05:54Z

@Vogel612 I was able to get that GiHub URL. Ty.

@Vogel612 Well, wait. I get a 404 now :-/ HTTPS used.

your invitation is still pending

So it's an invitation for a team, right?

and with it the organization, yes.

@Vogel612 OK, me stuoopid. I've checked my primary information channel (primary eMail address) now, and confirmed. Please forgive my ignorance ;)

oh lol

@Vogel612 So that repo is just a fresh setup for this particular room, or was that already proposed way earlier by you?

cv-pls haskell Code not implemented or not working as intended: Haskell - simple expression tree - Lumon‎ - 2018-11-07 19:29:07Z

fresh setup

@Vogel612 Cool, ty (I was probably confused about the acronym). I've gotta get the markup for that FAQ initially though, to push something we can start with. Thanks for your support anyways.

Borderline stuff: codereview.stackexchange.com/questions/207171/… Trying to promote an answer with an already closed question. Not much fitting the required Q&A format.

@200_success codereview.stackexchange.com/a/207172/52802

@200_success So how should we questions about not working code finally here?

The author insisted that the code worked correctly, even after I posted a comment hinting at the buggy Sin function. So, I posted an answer and deleted the comment.

@πάνταῥεῖ I'm not quite sure what I should think about this one... looks legit, doesn't it?

The random alphanumeric question also looks fine to me.

@t3chb0t That's why I said I am not sure.

@πάνταῥεῖ oops, sorry... I missed the words before the link - I'm sometimes reading faster then light ;-]

@t3chb0t We carefully need to distinguish established requests from mere discussions here.

cv-pls php Unclear Installing Composer for PHP in Debians (Ubuntu 18.04) - JohnDoea‎ - 2018-11-07 20:24:05Z

^Don't know how a comment could improve.

yeah, I'm not sure about that one too... it seems to be fine but I have a bad feeling...

cv-pls c++ Code not implemented or not working as intended: C++ Use a while loop to read two ints and then prints them - Liam Nichol‎ - 2018-11-07 20:58:25Z