SE Code Review Close Questions room

Peilonrayz

09:30

cv-pls swift Code not implemented or not working as intended: Integrate Google Map in Swift - jkgfjm‎ - 2018-11-06 06:28:14Z

Peilonrayz

10:16

python This may be off-topic, it's got CV but I don't know enough about nn and ml. Simple Python Neural Network - hlapointe‎ - 2018-11-06 03:59:49Z

t3chb0t

@Peilonrayz I gave it a CV because OP didn't provide any description

Peilonrayz

Makes sense I guess, thanks for adding a comment

Toby Speight

11:20

cv-pls c++ Lacks concrete context, attracting code-dump answers Elegantly exclude part of an operation from the last iteration in a loop - Kerndog73‎ - 2018-11-06 07:15:46Z

t3chb0t

and it already has five answers... unbelievable :-]

t3chb0t

11:50

cv-pls c# OP not willing to provide more context :( codereview.stackexchange.com/questions/207054/…

ok, how are you doing the trick with the link to the question so that it shows its title?

Toby Speight

@t3chb0t UserScript - github.com/SO-Close-Vote-Reviewers/UserScripts

Requires GreaseMonkey or similar

When you first use it, you need to point it at this room (before that, it's pointing at "Stack Exchange room", whatever that is).

t3chb0t

I see, you're cheating - thx ;-)

Toby Speight

12:26

@t3chb0t Not cheating - simply lazy. It's an important skill in software development!

Simon Forsberg

13:52

@Mast Why is it important to close those questions fast exactly? They do stay on the site even if you close them btw.

200_success

14:25

@SimonForsberg Closing sooner prevents people from answering bad questions and making the mess harder to clean up.

10

reopen-pls Clarfied that the author does not believe the code to be broken codereview.stackexchange.com/q/206798/9357

Toby Speight

14:36

cv-pls python Code not implemented or not working as intended: EOFError: Ran out of input, what does it mean? - Shun Lushiko‎ - 2018-11-06 14:32:39Z

Simon Forsberg

17:12

@200_success How does the mess become harder to cleanup? Delete the entire question - done.

200_success

What SE policy allows you to delete questions with upvoted/accepted answers?

Simon Forsberg

I can understand that you want to close questions sooner, but I disagree that those two questions that @Mast mentioned were "littering the site" that bad.

@200_success Not self-delete, but mod-delete. Although if it's answered and closed I don't see a big point in deleting it.

200_success

Furthermore, we don't allow the code to be modified once answered.

Umm… you should probably review the rules.

Simon Forsberg

@200_success Yes, that can indeed become messy.

@Mast That's not a comment, that's a close reason. What is the point in copy-pasting the exact words that show up in the close reason?

@πάνταῥεῖ How do you define "success"? What's successful to you? What would your dream outcome be of all this?

Also, FYI:

Personally I see nothing wrong with this question and I have reopened it (after it having previously gotten some reopen votes) — Simon Forsberg ♦ 22 mins ago

Mast

@SimonForsberg It can take hours before a question gets closed. In the meantime, OP has the chance to fix it.

I don't like closing questions. I prefer OP fixing them.

They can only do that after we've told them something's wrong.

Most simply have never seen the help center.

Simon Forsberg

17:20

@Mast And how do you think they will feel about that comment once the question is closed and they see that you are using the exact same words in the comment as exist in the close reason?

πάντα ῥεῖ

cv-pls c++ Code not implemented or not working as intended: determine how many years he has served the company so far? - jade‎ - 2018-11-06 16:47:22Z

Mast

@SimonForsberg I don't know. This isn't Feeling Review, so that's outside of my scope of expertise. Feel free to enlighten me.

πάντα ῥεῖ

@SimonForsberg Success in the sense to get rid of stuff like the above quickly.

Mast

@πάνταῥεῖ Such terrible questions don't deserve a comment, but heck, let's leave some anyway. They're cheap.

t3chb0t

@SimonForsberg I disagree, the code lacks context, is incomplete and the variables are not initialized; it's useful only to the OP, I as a c++ beginner couldn't learn anything from it because I'm not able to deduce their types... it's a guessing game

you should have waited with reopening it

This item is no longer reviewable.
alecxe reviewed this 2 hours ago: Reopen
Stephen Rauch reviewed this 3 hours ago: Leave Closed
Sᴀᴍ Onᴇᴌᴀ reviewed this 3 hours ago: Leave Closed

Simon Forsberg

17:24

@Mast I just want you to think about it. It's not Feeling Review, but people who post code here do have reasons. Personally, if it would happen to me I think I would feel disappointed that someone just copy-pasted the close-reason. Once the question is closed, such a comment doesn't add any value at all or any additional information to the OP.

t3chb0t

it doesn't look like everybody was of the same opinion

Simon Forsberg

@t3chb0t It had two reopen votes. When in doubt I prefer to lean on the site of keeping it open. Feel free to add a new close vote and/or start a discussion on meta if you disagree.

@t3chb0t What about a C++ expert?

Mast

@SimonForsberg My experience with leaving tailored comments is it takes a lot of time and on most questions it's not worth it.

Simon Forsberg

@Mast Worth it to who?

Mast

@SimonForsberg Toby knows his C++ and he left a comment.

t3chb0t

17:26

@SimonForsberg I thought this website is for everyone and not private consulting :-\

Mast

@SimonForsberg The world. Asking questions is a privilege, not a right.

If anyone asks why a question got closed and they don't understand, I'm quite willing to help out. Absolutely. Done plenty of times in the past.

Posts can be re-opened.

t3chb0t

@SimonForsberg if I could vote again I would have already done that...

Mast

But a question that doesn't fit the rules, doesn't belong.

Either it's made to fit the rules, or it goes.

We can't become the next SO.

Simon Forsberg

@Mast Toby also didn't reply to this comment, but might have been the person who upvoted it:

@TobySpeight It's OK. I'm sorry for saying that. The problem is that I was looking for advice about a pattern that is repeated multiple times in different contexts. That's why I wrote code to print a vector. This question is off-topic. — Kerndog73 5 hours ago

Peilonrayz

@TobySpeight Please can the people that down-voted the answers on that question because they're off-topic rather than because they are bad please vote on the merit of those questions, now that it has been re-opened.

Simon Forsberg

17:28

@t3chb0t Sure it's for everyone, but that doesn't mean that everyone has to get something out from reading any question.

Mast

@SimonForsberg If OP states the question is off-topic, I can't understand why you thought to re-open it anyway.

Simon Forsberg

@Mast A privilege that requires 1 reputation.

23 hours ago, by Mast

Just hope we don't make it worse trying to make it better.

Mast

@SimonForsberg If you got a better idea, there's meta.

Simon Forsberg

@Mast I believe that was a typo.

t3chb0t

@SimonForsberg this is exactly how it should work - questions should be comprihensible to any casual reader and contain enough information for them to make their own research - with this one however, this is not possible

Mast

17:30

It's sad this room is necessary and it's not my weapon of choice. But we got to do something.

Simon Forsberg

@Mast ... or what?

Mast

Too many lousy questions that shouldn't be here stay around, so it's harder on the reviewers to find the answer-worthy questions. I want to make it easier on the reviewers, always have, that's why we hunt down what needs fixing and hope OP fixes it.

We can help OP fixing it.

But they will have to put in the effort.

t3chb0t

@SimonForsberg or will have a nice website with a bunch of useless crap

Mast

Stack Overflow is failing.

I will do what has to be done to make sure CR does not follow the same route, regardless of whether it's the popular thing to do.

We have to uphold the rules, the only quality we can enforce, to prevent the floodgates of crap washing the site away.

πάντα ῥεῖ

cv-pls java Code not implemented or not working as intended: Bluetooth button - محمد الفواز‎ - 2018-11-06 17:33:51Z

Mast

17:35

And again, if OP wants to fix their question, sure, we can help. We've done it before. We close questions, we don't delete them.

@πάνταῥεῖ Yay, more crap.

Oh, I forgot, sarcasm is illegal nowadays.

Booooo, more crap.

πάντα ῥεῖ

@Simon I agree with @Mast. At SO we've seen that evolving amount of VLQ questions over years and with increasing popularity of the site. That's why we engage here to prevent the same for CR.

cv-pls assembly Code not implemented or not working as intended: Greatest Common Divisor (GCD) in MIPS32 assembly code - Dio Tsolakou‎ - 2018-11-06 17:37:15Z

Toby Speight

There does seem to be a flood of completely off-topic "fix it for me" questions at the moment. I guess that in many places, it's the point in the academic year when the first exercises are falling due. Please let's do what we can to welcome the good questions, improve the borderline questions, and expunge the unsalvageable ones.

But we only need to draw attention here to things that might attract answers before they reach site standard.

The rest should be fine through the standard queue mechanism

πάντα ῥεῖ

17:52

@TobySpeight Yes, as mentioned we see that pattern for years at SO. Always starting in late september, and another peak at february.

Mast

@πάνταῥεῖ September is eternal.

Toby Speight

@SimonForsberg I disagree - Elegantly exclude part of an operation from the last iteration in a loop lacks some of the basic essentials for a question (and explicitly says in the text words to the effect of "my real code is different). But I don't want to get into a revert war, so I'll just duck out of this one now.

Mast

^^ Agreed.

Toby Speight

I think there's a quite good question behind it, and I'd love for it to be allowed to escape from its cocoon and fly like the butterfly it wants to be.

Mast

We don't close questions because we dislike questions. We close crap to give the rest a chance.

Some questions are beyond hope. Others can be repaired, but often aren't.

If anyone has a suggestion on how to improve the latter, sure, go for it. Until then, we do what we must.

Simon Forsberg

18:10

@Mast Can you tell me what's off-topic about this question? codereview.stackexchange.com/q/206981/31562

πάντα ῥεῖ

@SimonForsberg Could you upload and ink a screenshot for us mere mortal < 10k users here please.

Simon Forsberg

@πάνταῥεῖ

πάντα ῥεῖ

@SimonForsberg I'd have preferred a non one box, but well.

Simon Forsberg

@πάνταῥεῖ I don't. I use the built-in upload image functionality, that's it.

Now, do you see anything off-topic about that question?

πάντα ῥεῖ

@SimonForsberg Looks like lacks concrete context for me, also the OP didn't explain what specifically they want to have improved with their code. Probably homework.

Simon Forsberg

18:20

@πάνταῥεῖ How is it lacks concrete context?

The title has the request for improvement

πάντα ῥεῖ

Concrete context means how this code should be used in a real world application IMO, correct me if I am wrong.

Simon Forsberg

For some values of "real world application"

Is a programming challenge a "real world application"?

πάντα ῥεῖ

These kind of titles is too common for CR IMO, nearly every question wants that.

Simon Forsberg

Yes, I'm not saying it's a good title.

πάντα ῥεῖ

This looks borderline for me: codereview.stackexchange.com/questions/207091/…

Mast

18:26

@SimonForsberg Insufficient explanation of the goal.

Simon Forsberg

> Given an array A, with dimension N, 1<=N<=100000, A[N] within range of [-100000, 100000]. At first there is a pointer at position K (in the beginning K=0), and M=A[K], and we say the pointer will jump to position A[K+M], and call this a "jump of a pawn`. If at any moment, the pointer jumps out of the array, we must return the steps of jumps it takes. If it will never jump out, return -1.

How is that not sufficient?

Mast

I'm not blind, thank you.

Simon Forsberg

Didn't say you were.

Mast

@SimonForsberg Terse at least. I've read it a couple of times before VTC and read it even more times now, and the block of text is finally making some sense.

We have an array, and the pointer will jump. If it jumps out, tell how it got out. It will jump to a position equal to the old + whatever value is in the current position.

If it doesn't jump out, -1.

If it does, return amount of steps required.

Worthy of a downvote? Definitely. Worthy of a VTC? You got me in doubt now.

How much is sufficient.

No explanation about the approach, at least. It's not exactly self-explanatory code.

Simon Forsberg

@Mast Sounds like my job here is done.

@Mast True, but that doesn't make it off-topic.

200_success

18:45

cv-please python Fails simple test runs codereview.stackexchange.com/q/207084/9357

Mast

@SimonForsberg Depends on how you explain the rules, I'd say. It's grey area IMO, and in that area mistakes and judgement calls are made.

@SimonForsberg To quote mighty monkey:

> Please don't be offended that we put your question on hold.

(source)

Simon Forsberg

@Mast I didn't say that was what they might be offended by.

Mast

@200_success OP probably barely tested the code. Funny enough that's another grey area for close-reason territory.

I agree that specific question has code so bad I'm hard pressed to come up with a test case which would pass, so closing it seems appropriate. The code is absolutely not ready for review.

But had OP provided such test-case, I couldn't see a reason to close it based on our current rules.

200_success

Depends on how blatantly broken it is. The Al Gore mail question yesterday failed on the given test case, so I considered it off-topic. The Connect 4 post that I asked to reopen earlier actually fails to detect diagonal wins, but appears to work for horizontal and vertical wins, so I consider it passable. This Hangman seems not to work for any word, so off-topic.

Mast

@TobySpeight About this:

Your edit invalidated an answer, which is against the question-and-answer nature of this site. See What should I do when someone answers my question?. — Toby Speight 3 hours ago

Feel free to roll back invalidating edits.

Mast

19:12

@SimonForsberg We should probably revisit the ML meta, shouldn't we? Get something conclusive on the table.

If we don't, it's simple. Not reaching the accuracy is like failing test-cases.

I think there's some leeway in there, but we need consensus on it.

70/100 is something different than 30/92.

Simon Forsberg

@Mast Can you link the ML meta?

Mast

@SimonForsberg Sure

Simon Forsberg

19:30

0

A: Announcement: New chat room CRCQR

The progress so far... This room has been ongoing for a little more than two days now. In this time, there's been 24 requests to close and 1 request to reopen. Some questions had comments that were just copy-paste of the close reason. I consider this not being helpful because of a few reasons: ...

If some of you down-voted this question I would like you to revisit those votes:

2

Q: Excel VBA to download from IE Database Stops Responding

first time using Code Review, although I have been active on StackOverflow, hope I'm in the right place. I am putting together Excel VBA code that using information from various columns on a worksheet to search for a document on a company intranet site, and save the document as a PDF, then move ...

The question got Mathieu-approved.

Mast

19:51

@SimonForsberg I know, I specifically asked for the VBA guys to check it.

After which it got closed and re-opened.

Toby Speight

20:07

@Mast I usually do roll back such edits, but this one was slightly problematic as I'd asked if it was correct before the answer was posted (when it might have been okay to correct it).

Mast

20:21

@TobySpeight I'll leave that your call.

Simon Forsberg

20:40

@Mast Sure, people should read the help center. But no effort in the world is going to make that happen.

Mast

@SimonForsberg Providing a link to it is a good start I'd say. Because most new users don't even know the help exists.

@SimonForsberg On this:

Relevant discussion on Meta about Machine Learning questions — Simon Forsberg ♦ 1 hour ago

Simon Forsberg

People should read the terms of conditions of services and programs they install as well, but that won't happen.

Mast

Did you notice I'm linking to that exact same question 3 comments higher

@SimonForsberg That's up to whoever has to clean up that mess. This one is ours to do.

πάντα ῥεῖ

@200_success Thank you for that useful material, I think someone already noticed us earlier. I appreciate your participation a lot here BTW.

@SimonForsberg Avoid one-boxing please.

For Meta references it's OK BTW

200_success

When I was a moderator, my philosophy was to close questions swiftly, with the hope that they could be fixed and reopened as soon as possible. I hope that this initiative helps the community to do the same.

πάντα ῥεῖ

20:54

@200_success Sure, I know that you've been moderating at CR. That's why I appreciate to see you here of course.

Peilonrayz

@πάνταῥεῖ I think one-boxing when requesting something people may overlook should be fine.

πάντα ῥεῖ

@Peilonrayz I believe we should soon have a room meeting how the SOCVR FAQ could be adapted for our particular intends.

Peilonrayz

That makes sense, we're still in an infancy atm

πάντα ῥεῖ

@SimonForsberg I believe it's a bit too early to judge about a progress. On the other hand I probably announced the room a bit too early here also. Though I wanted to address a broader audience to make them aware of. Just give us a little bit more time to improve everything. — πάντα ῥεῖ 1 min ago

@rene who's one of the major initiators of the SOCVR made me aware of those things in the early days of that room was setup.

in SO Close Vote Reviewers on Stack Overflow Chat, yesterday, by rene

@πάνταῥεῖ a meta post, chat events, boilerplate comments you can leave under relevant meta posts (when they happen, so don't go commenting back to the future), write relevant meta answers where you mention the room, add a link to it in your about me, keep the room alive with either discussion or relevant meta posts. See how this room struggled in its early 6 to 8 weeks./months.

in SO Close Vote Reviewers on Stack Overflow Chat, yesterday, by rene

see for examples: https://meta.stackoverflow.com/search?q=socvr+user%3A578411+is%3Aa

@200_success If you're willing, I'd like to add you to the list of ROs here to support moderation.

200_success

21:21

Sure, I'm OK with that.

Simon Forsberg

@Mast Sorry, no, I did not realize that.

Feeds

πάντα ῥεῖ has added 200_success to the list of this room's owners.

πάντα ῥεῖ

@200_success ty, you're very welcome.

πάντα ῥεῖ

21:44

cv-pls html Code not implemented or not working as intended: HTML/CSS simple site - gjfgj12‎ - 2018-11-06 21:40:02Z

cv-pls python Code not implemented or not working as intended: Taking a single max value from a txt file - paweljvn‎ - 2018-11-06 21:47:30Z

Feeds

22:04

πάντα ῥεῖ has added an event to this room's schedule.

πάντα ῥεῖ

Hopefully I am sober enough to attend that room meeting at the upcoming saturday ;-)

Borderline asking for code not yet written: document-root centralized phpmyadmin

Vogel612

Lemme poke my head in here to also drop a note re: comments on Simon's answer:

πάντα ῥεῖ

Welcome @Vogel612! Attention is appreciated!

Vogel612

in The 2nd Monitor, 11 mins ago, by Vogel612

Folks: small mod note here. Comments are not a chatroom. The sheer volume of comments suggests that we should discuss this answer somewhere that's more suited to discussion. Thanks! — Vogel612 ♦ 3 mins ago

@πάνταῥεῖ Care what you wish for :)

Attention isn't necessarily Aufmerksamkeit in the good sense

πάντα ῥεῖ

@Vogel612 Ty, appreciation expressed again!

Vogel612

22:15

@t3chb0t Code Review is not a site only for beginners. If you as someone not familiar with a language do not understand what the question is about, you should not VTC

πάντα ῥεῖ

@Vogel612 Well, I am aware CM mods and Network wide mods where made aufmerksam. I still believe that everything here is all within the policies and rules, and their asses are safe ;-)

Vogel612

IIUC you actually poked sleeping beasts on twitter, soo ...

πάντα ῥεῖ

@Vogel612 Though authors of code should be expected that they know what exactly they're doing.

Vogel612

@πάνταῥεῖ which was not really in doubt with the particular question that the discussion was about

πάντα ῥεῖ

@Vogel612 @Shog9's response was pretty cool as always IMO.

I am not raising calls for torches and forks, just installing a better forum (and yes for that cases it is) to better moderate possibly off-topic questions at the SE Code Review Q&A repository.

@Vogel612 Appreciate to see you here joining the discussion of course. May be you have some gifts to leave for my already poor Meta announcement.

Vogel612

22:26

I already dropped a mod note on one of the answers. I'll stay out of the discussion, at least for now

πάντα ῥεῖ

23:11

cv-pls python-3.x Code not implemented or not working as intended: rearranging words to create palindrome python - khaled siam‎ - 2018-11-06 23:11:18Z

200_success

23:28

cv-pls c++ Attempt to generalize concrete question to apply to hypothetical situations (with edit war) codereview.stackexchange.com/q/207035

Transcript for

SE Code Review Close Questions room