^ After editing and fixing the code issues, it seems the question lacks concrete context for review at all now.

cv-pls No code to review: codereview.stackexchange.com/questions/206944/…

cv-pls Just a braze faced Write the code for me request: codereview.stackexchange.com/questions/206945/…

Those last two questions are prime examples of why it's important to close crap fast. No point in leaving those littering the site.

Because that's what it is, garbage.

Distracting garbage.

@Makyen What's the problem with one-boxing everything?

Oneboxes are incredibly readable. A question is always presented in the same format if one-boxed, making setting-up the rest of the protocol a lot less hassle and easier for others to post a request in the correct format.

@Mast Personally, I find oneboxes a pain in the rear, and not very readable. They take up huge amounts of space in the transcript without giving enough information to really make a choice, in many/most cases. It gives the title, which is something that can be obtained from just the URL without much effort. Oneboxes carry no additional information in the listing (e.g. why was this post mentioned here; what type of request is being made? why is the request being made, etc.).

Which can be solved with 2 messages, which is ugly too. Thing is, you got to mention the title otherwise it's hard to see whether the request has already been made.

If I just put in a link to a random question, codereview.stackexchange.com/questions/206909/… that's a lot different from just one-boxing it.

There's 3 things essential: URL, title and reason why. The SOCVR method is a PITA for users without userscript and honestly, inconsistently used over there.

@Mast It's used very consistently, largely because there are userscripts available, and because the minimum required format really isn't that onerous (request-tag reason URL).

@Mast With, or without, titles, there will be duplicates.

@Makyen With titles that's going to be a lot less. A lot. I'd say that's worth it. If we make this room stupidly hard to use, it won't be used.

@Mast I agree that titles are helpful (that's why there's a userscript which adds them to bare URLs). However, requiring people to include the title A) makes it more difficult for non-userscript users and/or B) requires multiple chat messages per request (the oneboxing you like).

Oh, and just to be clear: SOCVR's Request Generator should work as-is for generating (SOCVR style) requests here. The other userscripts (Archiver (if desired) and Unclosed Request Review script (stock and beta version)), should be able to be modified with not that much difficulty.

Oh? I'll have to give that a try later today.

One way or another, questions will be closed.

We can't afford to leave the crap laying around.

There's also a request generator bookmarklet which can generate the request text for those who are unable to run userscripts. The bookmarklet doesn't actually post the requests, as doing so requires the cross-site capabilities available to userscripts. But, it copies it to the clipboard, so the user just has to go to chat and paste it.

The request generator userscript has some things which are set on a per site basis. There are some single character substitutions, which make entering request reasons (close reasons) easier. In addition, the default chat room destination for requests can be defined per-site (the user can change it to whatever room they like). It would be trivial for me to add an entry for CR with this room as the default to which to send requests, if that would be helpful.

Is there any documentation on what this SOCVR format is? Could we add a link to the room description?

@Peilonrayz SOCVR has a (long) FAQ. The portion describing the basic format is here. The minimum is what's expected of people that are formatting it by hand.

The Request Generator userscript (and bookmarklet) expand on the basic format to provide additional information.

@Makyen Thanks, the 'tags' make sense I guess, and the minimum format is easy-enough

cv-pls java Code doesn't work as intended SQL nested queries in Spring - Deepak Mishra‎ - 2018-11-05 10:08:41Z

@Peilonrayz Cool to see you participating here o/

@πάνταῥεῖ I normally close via the 2nd the way Mast outlined above. But don't do queues because I don't get notifications >:(

Welcome to the clean-up room @Peilonrayz :-)

People, don't forget to leave a comment on a bad question so others can easily identify why/whether it's bad. Two standard comments I often use:

**Code not implemented or not working as intended:** Code Review is a community where programmers peer-review your working code to address issues such as security, maintainability, performance, and scalability. We require that the code be working correctly, to the best of the author's knowledge, before proceeding with a review. Please take a look at the [help/on-topic].

**Lacks concrete context:** Code Review requires concrete code from a project, with sufficient context for reviewers to understand how that code is used. Pseudocode, stub code, hypothetical code, obfuscated code, and generic best practices are outside the scope of this site. Please take a look at the [help/on-topic].

More frequent comments here.

@Mast Thanks :)

cv-pls Not working as intended: codereview.stackexchange.com/questions/206972/…

cv-pls Code not implemented: codereview.stackexchange.com/questions/206977/…

cv-pls OP has no clue why the code is written the way it is (Authorship) Intro to OOP C++ - why const used with getter function and not setter?

cv-pls Lack of context Find Longest Subsequence of 1 and Right shift a list

@Mast I've cv-ed as unclear, but authorship of code is probably the better close reason.

**Authorship of code:** Since Code Review is a community where programmers improve their skills through peer review, we require that the code be posted by an author or maintainer of the code, that the code be embedded directly, and **that the poster know why the code is written the way it is.**

@πάνταῥεῖ What I see is Code not implemented: codereview.stackexchange.com/… and that makes it difficult to detect quickly if there is already a close-vote request for a certain question. Would it be better to always include the title (in the form [title](link))?

@MartinR At SO I am using a script that formats the requests like this. TBH I was just too lazy to format this manually. But you're right it's better to use requests formatted like so.

I'll ask @Makyen if he's willing to extend his script to send cv requests to this room.

cv-pls: Lacks concrete context: Am I solving this as efficiently as possible?

@πάνταῥεῖ It's not as simple as changing the target?

@Mast Maybe, I'll have to try that next time.

Active on domain and target chatroom, I'd figure.

@Mast The script would also need to be adapted for the CR specific close reasons.

@πάνταῥεῖ I tried on my one earlier, it said I wasn't logged into this chat room or something. So I copied it manually

cv-pls python Code not implemented or not working as intended: Python RPG Text Game how to overwrite save files - Shun Lushiko‎ - 2018-11-05 16:48:53Z

Don't forget to comment, people.

@Mast The reason why I usually don't comment on my close votes is because I've had very bad experience with that. Many people seemed to flag my comments as rude or unkind.

@πάνταῥεῖ This is CR, not SO. If you don't want to risk it anyway, stick to relatively standard comments.

I've left thousands of comments and we got a different community here.

@Mast OK I'll stick to your canned comments.

cv-pls Code not working as intended: Permutations Cycles-CodeChef

@πάνταῥεῖ The request generator should work as-is, with just changing the target room for the site (once; user-settable). There will be changes desirable to pick up the off-topic close reasons (although it already accurately determines those for CR, based on the contents of the CV/flag dialog); making a this the default target chat room for CR (so new users don't need to manually change that, once), and defining single character substitutions for close reasons when editing the reason text.

All of those are are contained in a data structure, which is specifically intended to make it easy to add additional site/room pairs. I'll add CR and this room.

@Makyen Ty. Is setting the target room settings stored site specific, such I can use the script for CR and SO at the same time?

It is site-specific.

Cool, ty again :)

np.

The Archiver (if desired) will partially work with it's next update (which should have been pushed out a few days ago), but if you want to actively use it, then a room-group (i.e. target room(s) where you want to move messages) should be defined. Having it work fully (i.e. automatic checking for completed requests, as opposed to the manual move-list and other features) will take a bit more work, but is planned.

Having the beta version of the Unclosed Request Review script work fully (giving semi-live in-line question status in chat) will take some more work, but is also planned.

It seems this room starts to work out quite well. I believe we'll soon need some of the other tools (clean up fulfilled requests, etc), and of course ROs who do the moderation.

Currently the only RO is me :-/

The CVRequestArchiver is what we ROs use to clean up completed requests and more easily move messages manually. You will need to specify/create the rooms you want to be moving things to, but the next version will have a couple default trash rooms for chat.SE.

You will need to decide if you want a room that is dedicated to your completed requests. SOCVR uses one to make it easier to be accountable to Meta (i.e. someone wanting to figure out what happened doesn't need to sift through trash from other rooms too).

@Makyen What's the purpose of the archiver though?

I mean, sure, we could split this room up into a couple. One to meta the room, one to archive the room, and one to do the actual messages/requests.

It keeps things clear. But is that it's only purpose?

It also adds complexity. Somebody will have to maintain it.

@Mast As mentioned, we need more ROs (I thought of you BTW ;) )

@πάνταῥεῖ You know you can change that, right? I'd actually encourage you to change that. If @Peilonrayz is up for it, add him.

I'm available as well.

I'm already RO in The 2nd and The Nth.

I have to figure how to add you. I am not very experienced in chat room management.

I am currently writing an announcement of this room at Meta CR

@Mast If you're getting a lot of requests, it moves the completed requests to another room so that people don't spend time clicking on them once they are complete. That solution works for everyone, even if they don't have userscripts.

The Unclosed Request Review script allows people to see a list of requests which are not complete and sort on various criteria, including if they have visited the question, or not. It also shows question status in-line in chat and transcripts, allowing people to choose to click based on that status (e.g. # close-votes/closed). It will, eventually, include question preview/review/voting, but that portion is only partially coded at this point.

@Makyen Sounds good indeed.

@Makyen So, serious magic. Is that currently working at SOCVR?

@Makyen Since you are very experienced with all that, would you mind if I add you to the ROs list?

@Mast The portion about "question preview/review/voting" is not working (well, actually the preview's functional, but hasn't been released). The part with in-chat semi-live status is functional and in beta (soon to be the released version). You can find a link the the beta version here, with some pics/gifs showing what it does in this message.

cv-pls c Code not implemented or not working as intended: Float type when inputed… Gives a different output - Sidharth Shambu‎ - 2018-11-05 17:16:26Z

@Mast Would you mind @Peilonrayz?

@πάνταῥεῖ I'm willing, but I'm not able to commit large amounts of time to actually being present. I also have relatively little experience on CR, so would mostly stay in an advisor capacity.

@Makyen I believe you're a good advisor. So I'll add you.

@Makyen We'll be doing the heavy lifting. It's a CR room, we can't expect non-CR-regulars to help with that except in advisory position.

OK. I'm fine with that.

Currently, this room is a kind-of beta. We'll sort out how it works later, well, later.

Eventually we'll need a couple of regulars in here. Get a bit of round-the-clock presence too.

t3chbot and FreezePhoenix might be interested. Couple others. Heck, even if they're just lurking and helping to close crap, that's fine.

Ah, you already went to meta.

Announcement: New chat room CRCQR

@πάνταῥεῖ I could give it a go, like I don't really know what it'd entail. But I'd probably do bits and pieces here and there.

@Peilonrayz So I'll add you.

Sure :)

ROs at the SOCVR are elected meanwhile, in a similar process as site mods are. For now I'll take the freedom to add users here based on their willingness and my judgement of their aptitude.

@πάνταῥεῖ To be more accurate, the RO process in SOCVR is more like a job interview. The current RO team announces that they are looking for one or more additional ROs. People then indicate their desire to be an RO and write-up a short bit on why they would be a good fit. The current ROs then decide on who to add from among those who indicated interest.

cv-pls c++ Authorship of code: how does const protect object data when used with getter functions? - Adam G‎ - 2018-11-05 18:16:51Z

^ Same author asked that today already. If he doesn't know what const does he's probably not the author of that code.

Sweet, I got the script working

Me too :) Works like a charm.

I was getting this error, turns out allowing cookies seems to fix it

@Donald.McLean @ThomasWard I hope you notice we're acting here with regards to all policies and rules of the site.

@Mast sure, I'm interested ;-) it should be easier to discuss close matters here rather than in comments @πάνταῥεῖ thx for the invitation, I didn't know about this new room

@t3chb0t Hope so.

we'll see, I like experiments

It's better than sitting on our hands and seeing the site go to shit. Got to do something before we hit the same crap as SO.

Just hope we don't make it worse trying to make it better.

@t3chb0t It's pretty new (established yesterday), that's the reason I've announced it at Meta CR recently. I'd like to add you at the list of ROs if you're willing.

@πάνταῥεῖ Was there a problem?

@πάνταῥεῖ I would be honored ;-)

@Mast I've just noticed the mods appearing here. I don't believe there was really a problem.

@πάνταῥεῖ yep, just thought I'd lurk if you don't mind :)

(I lurk in SOCVR too :P)

@ThomasWard Sure, I don't mind.

The mods on CR (which are not necessarily CR mods) keep an eye on everything. They're great company :-)

There was probably something mentioned in TL.

And that's good so

@Mast actually, just saw it going through meta ;)

but otherwise I tend to just 'lurk' in case things get out of hand ever :)

@ThomasWard Should you have suggestions, put them on the meta or drop them here. Advice is usually welcome.

indeed, will do :)

For those who are ROs, I recommend reading A guide to moderating chat.

@ThomasWard We seriously need advice here, since SE CR is fundamentally different from SO. Though as I've mentioned I noticed that the questions quality lowered with the increasing popularity of the CR site.

@πάνταῥεῖ indeed, but in my case my advice is... limited for the time being as I"m on a mission to relearn the CV policies here.

since i have a habit of having... overly cynical analyses of things which lead to poor CVs.

however judging by the chaos that popular sites encounter, and the fact that SECRCQR is a thing I expect it to be... attention-grabbing in a poor way, the room, in a way that might need diamond monitoring for a while

(primary reason for lurking)

holy heck that's a complex acronym :|

@πάνταῥεῖ one of the big problems is no clear quality guidelines

if you provide quality guidelines and 'bare minimum requisite data for a post to be able to be reviewed' it'd help.

my two cents :P

(There's never been a clear policy, though when I write my posts up for reviews I try and give as much data as I can, but that's just my nature as an IT Security guy where details come in handy)

also apologies if I seem a little distracted/busy i'm doing some Ubuntu Server stuff for the Ubuntu Serverteam :)

@ThomasWard Well, so far we've handled a number of Gimme teh codez and lack of concrete context questions here successfully. I think we'll put up more info in the near future with the help of people who are interested.

@ThomasWard Ubuntu is a bit of an awkward linux implementation. I well understand your pains ;-)

@πάνταῥεῖ it's not the linux implementation, it's nginx being screwy between two different versions

SOMETHING in the underlying toolchains fubar'd so i'm digging :|

@ThomasWard Ubuntu always was bad with the underlying toolchains available. Major reason of bad questions appearing at SO :P

heh. well in this case i think it's someone's third party nginx plugin at fault

since the issue wasn't with the same-version of the Ubuntu toolchain but a version bump in the underlying C/C++

(thank you Debian Unstable for taht change >.>)

room topic changed to SE Code Review Close Questions room: We should discuss close worthy / off-topic questions at the SE Code Review site here. For now and for the basics of the protocol and policies please refer to the SOCVR FAQ. We'll probably adapt that for our specific needs here soon. (no tags)

@πάνταῥεῖ Also note as a site moves from "less popular among all, popular with its regulars" to "more popular at large" the quality drop isn't uncommon.

you see it if you look at the 'over time' comparison of site-start to current question posts on {INSERT_ACTIVE_NONBETA_LONGERTERM_SITE_HERE}

@ThomasWard Sure that is, and that's one reason why I think we need this room.

also consider language barriers as well, they're not uncommon :P

@πάνταῥεῖ +1 agreed

(found the pesky nasty FTBFS bug! muahahahah!)

@ThomasWard I wanted to convince you as a diamond mod, we're doing no harm here or anything against the site policies and rules. That's all. Please go easy with us ;-)

@πάνταῥεῖ I'm mostly hands off with Diamond strength ;)

you've gotta be doing evil things to really incite the diamond-powered wrath :p

... or pester Shog, that does it too, but that's something people KNOW not to do :p

I could even add you to the ROs list if you're willing :)

up to you :)

diamonds get all the power :P

@ThomasWard Pinging Shog is like calling beetlejuice ya know :D

but worse

But I am on track at Twitter with them, I could ask them there.

because The Great and Powerful One will destroy you if you pester them :P

cv-pls php Code not implemented or not working as intended: Import CSV file into array - M2Newbie‎ - 2018-11-05 19:16:51Z

y'know we need proforma comments IMO so I don't have to type that out all the time (what I just typed into comments on that one heh)

@ThomasWard Done: twitter.com/GntherMakulik/status/1059526813125435392

@ThomasWard Yup.

@πάνταῥεῖ THAT'S LIKE DIVIDING BY ZERO WHAT HAVE YOU DO- fzzt BOOM

@ThomasWard Been there, done that, still waiting on the t-shirt.

@ThomasWard Y'know we got those, right?

On top of that, there's a couple of regulars (myself included) who keep their own set next to that.

@ThomasWard Well, apologies for my poor attempt to grab attention here. There are certainly better ways to describe the intend and purpose. Believe it or not, I am just a naive kitten regarding that stuff.

@ThomasWard An already generated list is helpful, but you can always just add your own to your list. I routinely add comments to my auto-comments list when I write a new one that I think might be useful later (it can always be removed, if desired).

@Shog9 promptly responded: twitter.com/shog9/status/1059527938658320384

He's a really great guy, and I always wonder how he manages to stay that calm as they are.

obscene amounts of [REDACTED] and [REDACTED], with a pinch of CAFFEINE ADDICTION in there as well.

... whoops how'd that one skip redaction... :P

cv-pls performance Code not implemented or not working as intended: Excel VBA to download from IE Database Stops Responding - TBoulz‎ - 2018-11-05 20:31:27Z

@πάνταῥεῖ I'm not a Code Review mod.

@πάνταῥεῖ Wrong.

that this room obeys policies, etc.

more or less a "cover our butts" action on their part :)

(because whenever diamonds show up, well... :P)