Freyja Development Team

Mahesh

08:02

@jokerdino blame the different spellings and the dirty english.

jokerdino

the code is fine. they want tests and really rigorous ones

Mahesh

and I've no idea how to do that.

though I've a feeling they'll use unit tests python module.

jokerdino

maybe

Mahesh

give me20 min. I'm hungry.

jokerdino

okay

Mahesh

08:07

I see how awesome github is when I start one public repo on bitbucket. :|

jokerdino

totally

Mahesh

bb gives me free unlimited private repos.

take that away, and no reason to look at bb.

Mahesh

08:30

summons @AmithKK and @jokerdino here

jokerdino

sup

Mahesh

why are you using doc strings when not needed?

Amith KK

Nothing much :D

jokerdino

who?

Mahesh

""" something """ and ''' something ''' are strings, that can go multiline

you @jokerdino

jokerdino

08:33

i just want to throw those parts.

Mahesh

then comment them.

jokerdino

bah

Mahesh

wait.. someone says multiline strings are comments? thats ridiculous.

jokerdino

kk

what do you want?

pushed update :P

Mahesh

66

A: Comment out a python code block

No, Python does not have such a mechanism. Block comments are made by prepending each line with a pound sign. For more info, see good ol'-fashioned PEP 8. In any case, almost all Python IDEs support a mechanism to do the block-commenting-with-pound-signs automatically for you. For example, in IDL...

okay. confirmed that doc string style comments are not official.

now, do we have sample tests for rest of unity?

jokerdino

08:37

we have some tests in the unity trunk

Amith KK

@jokerdino \o/ I understood these tests

jokerdino

?

Mahesh

excitement, you call it.

Amith KK

We need to make another function that is verbose

as it is run, you'll get outpul like

Mahesh

so, I bzr branch what? lp:unity?

Amith KK

08:39

succeed: Deleting key

jokerdino

@Mahesh yesw

Amith KK

@Mahesh yeah

jokerdino

@AmithKK my tests are not legit. i just wrote them as i wished

Mahesh

man, its going to take forever...

Amith KK

@Mahesh agrees

this sucks

Mahesh

08:41

whoa.. bzr is not bad at compressing revisions.

Amith KK

bzr is amazing. Well after you know it :P

Mahesh

okay. I'll try bzr for a while then.

Amith KK

Can't we just have manual tests?

jokerdino

no.

Amith KK

documented on a fresh install of 12.10?

jokerdino

08:43

i am not going to compile it. just no

Amith KK

make takes a looong time

Mahesh

we need automated unit tests.

jokerdino

it takes 1 hour +

Amith KK

unless your on an i7

Mahesh

what?

jokerdino

08:44

i am on i3

Mahesh

one hour?????

jokerdino

one hour to compile

Amith KK

@jokerdino did you use -j8 ?

jokerdino

i used -j8

jeez. yes

Mahesh

hmm... looks like I have a reason to ask for a VM on my institute cloud.

Amith KK

08:45

I could have ninjask to compile it

:P

Mahesh

ninjask??

jokerdino

ninja ask

Amith KK

name of my amazon instance :P

Mahesh

oh. okay.

wait.. what do you use that amazon instance for? /just curious/

Amith KK

Still... 1 hour?

Mahesh

08:47

to the release?

Amith KK

@Mahesh amithkk.com

Mahesh

@AmithKK DNS fail

Amith KK

I know

Mahesh

okay.

Amith KK

Apache is down

Mahesh

08:49

what does it cost?

Amith KK

@jokerdino you're not using the unity-test suite

@Mahesh nothing for one year

jokerdino

@AmithKK i am not using anything atm

Mahesh

@AmithKK o.O

Amith KK

@Mahesh yes, it's pretty cool. Not bad for free

Mahesh

How do I get one? :P

Amith KK

08:51

@Mahesh aws.amazon.com

You do need a credit card

jokerdino

@amith, what unity-test are you talking about?

Amith KK

@jokerdino autopilot

jokerdino

ok write some tests thx

Mahesh

using it after one year also doesn't incur much cost. I'll sign up for one.

Amith KK

@Mahesh \o/

<3

I have some work to do :D

jokerdino

09:03

like what?

Amith KK

back

homework :P

Done

jokerdino

okay.

let's figure out what we should be doing :P

Mahesh

trying to do that

Amith KK

@jokerdino am allowed to read a log?

jokerdino

no idea

Mahesh

09:10

@AmithKK log of what?

jokerdino

wiki.ubuntu.com/Unity/QA/Autopilot

Amith KK

log made by our script

Mahesh

Ideally, you should have a lot of output and provide sample output to whatever test module.

it then compares.

Amith KK

@Mahesh that was my idea

but you then need a new verbose parameter

Mahesh

yup that.

Amith KK

09:12

well I can do that

let me finish my packet of lays

jokerdino

so i was trying to add a launcher and i failed

it is stored in a string array and the gio and glib were too messy

who wants to work on the next patch?

adding the ability to toggle the show desktop button in launcher :)

@amith, also, did you fix the if loop in your proposed merge request?

Amith KK

I should remove the merge request right?

or can I just modify the code?

jokerdino

update it.

Amith KK

@jokerdino how do you do that?

Mahesh

@jokerdino /me /me /me

jokerdino

09:19

modify your local bzr branch and push it to your branch

Mahesh

@jokerdino it was there, right?

Amith KK

so, that's it?

jokerdino

@Mahesh not in 12.10 :)

@AmithKK yeah

Mahesh

oh god, why? 12.10 looks like a mess.

jokerdino

once we are done, we can then work on another regression

the mounts right now will show up automatically.

we should add setting to determine if it is mounted and then show, etc

Amith KK

09:21

We should be called the unity patch team :P

2

jokerdino

when we are done with one, then yeah :P

We should be the Unity regression police.

Mahesh

@jokerdino get a list of all unity regressions and dump them in a list.

jokerdino

haha, i would

but most of them are too technical for my taste

Mahesh

I would have never tjought i'd be able to do what we did, if you hadn't pulled me in.

so, why not try the others too?:P

jokerdino

okay, we shall go after them too.

Mahesh

09:25

lets get the unit tests straight for now. :P

jokerdino

yep :P

Amith KK

pushed

Should it just check if the command worked or should it also check where it failed?

jokerdino

i think just the former?

but more info never hurts

@amith, s/favourites/favorites

Amith KK

amith@amith-desktop:~/unity.cmake/unity$ bzr commit
bzr: ERROR: invalid header line: ''

O.o

jokerdino

you sure you are at the right branch?

Amith KK

09:34

yep

jokerdino

okay. try again

make sure you don't have any ~ files

Amith KK

Hmm

my dirstate file is empty

Mahesh

where should I be looking? I'm totally lost.

jokerdino

look what?

Amith KK

@Mahesh ?

jokerdino

09:38

it is inside tests/ folder

Mahesh

its all cpp

jokerdino

inside automake

Mahesh

got it

Amith KK

@Mahesh just add print("ERROR") statements and use subprocess.popen() inside the test to check the output line by line for ERROR

all those examples are for autopilot, which is gui testing AFAIK :P

Mahesh

we can still use autopilot

or I may try unittest.

wait.

jokerdino

09:43

yesterday, by Amith KK

9:28 PM <amithkk> didrocks: can you elaborate a bit on the tests
9:28 PM <didrocks> amithkk: sure, so all code entering unity now needs tests
9:28 PM <didrocks> for testing the wrapper, I would say:
9:29 PM <didrocks> import the unity python file (not sure how it works when you have no .py at the end)
9:29 PM <amithkk> oh, it works
9:29 PM <amithkk> :D
9:29 PM <didrocks> waow, never tried that TBH :p
9:29 PM <didrocks> then change some keys in the unit test module in the Setup() phase
9:30 PM <didrocks> calling each of your functions

jokerdino

09:55

once lost, forever lost.

Mahesh

?

I am writing a unittest.

jokerdino

wrote any tests yet?

oh ok

Mahesh

where's the unity.cmake ?

jokerdino

in tools

Amith KK

@Mahesh /tools/

Mahesh

10:02

I pulled lp:unity

jokerdino

yes.

Mahesh

How do I get amith's branch on top of this?

jokerdino

pull his branch

Mahesh

how exactly?

jokerdino

or get the diff and apply it

Mahesh

10:03

good idea.

not needed.

jokerdino

okay.

Mahesh

bzr merge does the trick

jokerdino

good idea.

Mahesh

@AmithKK what did you import earlier?

in the chat with didrocks?

Amith KK

@Mahesh for?

@Mahesh nothing

Mahesh

10:10

I need to import the unity wrapper as a module.

or find a way to call functions in unity wrapper from another python script.

which actually means the same. :P

jokerdino

heh

Mahesh

and I see that no unit tests exist for unity wrapper yet.

or did I go blind?

jokerdino

they only started implementing mandatory tests a couple of months ago

before the original wrapper was written

Mahesh

then I need to mess with the entire wrapper.

Amith KK

This is mucky

jokerdino

10:14

sure.

Amith KK

@Mahesh import /usr/bin/unity ?

jokerdino

nothing we have changed in that

Mahesh

that should work, but I dont know....

jokerdino

hm, we didn't modify that binary file. ??!?

Mahesh

nope. you need to place the module in the search path and then import.

@jokerdino thats plaintext. no binary

jokerdino

10:17

@Mahesh write a basic one and i'll just follow it.

Mahesh

got it.

I'm dumb.

jokerdino

yep

Mahesh

you need a .py extension to be able to import it.

jokerdino

looks at @amith

Amith KK

O.o

It did work once

Mahesh

10:23

I've been headbanging for halfan hour to import without .py

okay. no probs. lets move ahead.

jokerdino

okay

Amith KK

facepalm that was with imp

Mahesh

?

Amith KK

docs.python.org/library/imp.html

python.org/dev/peps/pep-0302

Mahesh

okay.

subprocess.Popen(["killall", "unity-panel-service"])
subprocess.Popen(["killall", "compiz"])

why dont we just call?

jokerdino

10:31

i was following the existing format in that

Mahesh

ok.

jokerdino

there was another Popen in there

Amith KK

@Mahesh We should

Mahesh

I'm making some changes.

Amith KK

BBL

Good Luck

jokerdino

10:38

cya

Mahesh

should I write unittest fr the final unity wrapper or just our snippet?

jokerdino

just our snippet first

after that, we can consult with didrocks

do you want to talk to didrocks about call and Popen?

Mahesh

yup.

we should use call whenever output is not needed

jokerdino

i see

Mahesh

10:59

any idea whom to contact to get this mess corrected?

developer.ubuntu.com/api/ubuntu-12.10/python/…

@jokerdino ^

jokerdino

11:16

holy

i guess you ping one of the people in ubuntu-devel

Mahesh

11:32

get ready for a surprise.

jokerdino

bang

Mahesh

checkout the repo.

jokerdino

i see a unittest file

Mahesh

look at the unity-reset.py

I changed its shape almost totally completely.

jokerdino

jeez

Mahesh

11:38

:D

test that for me, will ya?

jokerdino

okay @_@

\o/

but there is a significant time lapse

and a bug with the launcher

logging out. brb

Mahesh

two subprocess calls. I expect a Quarter second lapse at max. anymore than that, no idea why.

jokerdino

it takes about 10 seconds.

last time (the old wrapper) it took a couple of seconds.

Mahesh

thats ridiculous.

I haven't changed much, did I?

what getss executed is all the same.

jokerdino

hm not sure

Mahesh

11:47

retry please : |

jokerdino

i don't know why we have such a long time gap

Mahesh

ten seconds is like a lot lot lot of time.

jokerdino

it's much more than that.

ok just slightly less than 10 seconds

do you want to sync the settings?

.sync()

Mahesh

.apply() is ok.

we dont need to sync.

jokerdino

it got removed somewhere

Mahesh

11:49

nope. its still there.

line 56

jokerdino

ok but it is very slow. why not just sync it

Mahesh

comment out 39 and 40 and try again.

I am eaget to blame subprocess.

jokerdino

no diff

Mahesh

:(

actually, we can get a significant speedup.

jokerdino

yeah

Mahesh

11:54

comment 50,51,52.

we got the schemas from Gio. no need to recheck if they are there.

jokerdino

using sync slows down the reset but result is pretty fast

Mahesh

wait.. who added 65? I remember removing it.

jokerdino

o.O

brb. give me 3 minutes

Mahesh

okay.

jokerdino

gsettings.apply() is only if you are also using .delay()

Transcript for