Freyja Development Team

$ git status
# On branch master
# Changes not staged for commit:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#	modified:   reset-gio.py
#
no changes added to commit (use "git add" and/or "git commit -a")

Mahesh

good. git commit -a then git push

jokerdino

done

ok it feels awesome

@mahesh ^^^^

Mahesh

jokerdino

now optimise and add my name to the authors field :P

Mahesh

1:55 PM

Do you want your email address to appear in authors list?

yessir

ubuntu one?

yep

and name? Barneedhar or jokerdino? :P

jokerdino

both with jokerdino in brackets

Barneedhar (jokerdino) <email id>

Mahesh

1:57 PM

and what about @AmithKK ?

email?

jokerdino

one sec

@amith script fixed \o/

Amith KK

Amith KK <amithkumaran@gmail.com>

@jokerdino \o/

jokerdino

bbl :)

Amith KK

Packaging now

@jokerdino Python Gobject version in 12.10 please

ping @Mahesh

room mode changed to Gallery: anyone may enter, but only approved users can talk

oops

lol

room mode changed to Public: anyone may enter and talk

Mahesh

@AmithKK got the ping

no idea about the version. let me check.

Updated the repo.

Amith KK

2:04 PM

Wait a second

Ok, packaged

Now I just need it to build

jokerdino

2:20 PM

python-gobject:
  Installed: 3.4.0-1
  Candidate: 3.4.0-1

@mahesh, purge all the other py files and keep the only one please

Mahesh

I guess I did that long ago.

jokerdino

okies :?

Amith KK

Ok, we all wrote atleast one line of code in python for this

jokerdino

Mahesh

aaarrrrgh....

jokerdino

2:34 PM

what?

Mahesh

cat /usr/bin/unity |pastebinit

I want to look at the changed one.

jokerdino

what am i looking at?

paste.ubuntu.com/1283181

Mahesh

You are looking at the wrapper script that does the magic.

jokerdino

so, what now?

Mahesh

unity --replace and unity are just the same now.

so lets update that in script.

jokerdino

2:39 PM

also, we need to take out the launcher icons reset thing

or copy it and then reset and put it back.

Amith KK

@Mahesh doing that

jokerdino

@mahesh who did you contact?

Mahesh

@jokerdino nope. lets isolate that part.

@jokerdino No one.

jokerdino

ok and ok

jokerdino

2:51 PM

@mahesh are you working on this?

Mahesh

working on what?

jokerdino

isolate etc, and unity instead of --replace

Amith KK

@jokerdino The second one is complete

just pull

jokerdino

okay

did you push it yet?

ah alright. it's done

Amith KK

Yeah

jokerdino

2:54 PM

got it

Mahesh

isolation, later. gotta run. :|

jokerdino

cya

Mahesh

BBL

jokerdino

@amith, so we take out "gsettings get com.canonical.Unity.Launcher"

but how?

Amith KK

@jokerdino I guess you could back it up

and then restore

jokerdino

2:57 PM

or we can remove launcher from dict

Amith KK

or just remove those keys from the dict

jokerdino

grr.

stupid network timing out

Amith KK

3:12 PM

@jokerdino can you print out the contents of the dict?

jokerdino

possibly

i am trying to pop out the launcher item

but not sure how

Amith KK

give me the output

jokerdino

i am making some progress. brb

Amith KK

for key, item in some_dict.items():
    if item is item_to_remove:
        del some_dict[key]

That's how you do it

BBL

jokerdino

@AmithKK thank you

jokerdino

3:50 PM

@amith, @mahesh leaving the review here for you to get cracking - pastebin.ubuntu.com/1283312

btw, i am working overnight and will push in the morning. cya

Amith KK

@jokerdino cya

Mahesh

4:11 PM

@AmithKK @jokerdino we have no dictionaries!!!

all we use are lists here.

Amith KK

@Mahesh I know they are lists

Well.. not to put a blame on someone but jokerdino did confuse me

Mahesh

why hav you people been talking of dicts?

Amith KK

Mahesh

hmm...

@jokerdino .apply() is needed just in case the changes are not written back. the calls are asynchronous. That is, it can, at times, locally keep a track of changes and apply a batch of them at once. Thats a safety precaution and we should keep it.

Amith KK

@Mahesh well said

Mahesh

4:19 PM

two optimisations. get rid of variable match, and get rid of list we are making.

instead of appending and later iterating over the list, lets directly reset as soon as we find it.

Amith KK

@Mahesh That would make it better

and we should implement tests

9:28 PM <amithkk> didrocks: can you elaborate a bit on the tests
9:28 PM <didrocks> amithkk: sure, so all code entering unity now needs tests
9:28 PM <didrocks> for testing the wrapper, I would say:
9:29 PM <didrocks> import the unity python file (not sure how it works when you have no .py at the end)
9:29 PM <amithkk> oh, it works
9:29 PM <amithkk> :D
9:29 PM <didrocks> waow, never tried that TBH :p
9:29 PM <didrocks> then change some keys in the unit test module in the Setup() phase
9:30 PM <didrocks> calling each of your functions

Mahesh

okay. one by one. Optimising it now. getting rid of those variables.

@AmithKK bitbucket.org/jpmahesh/unity-reset/changeset/…

Amith KK

@Mahesh I thought it was a dict

6 hours ago, by jokerdino

you should make a dict out of the regex script and feed it in place of plugin dict in the other script

Ok, I'm sorry :D

Mahesh

ah, then blame dino. :P

okay, end of blame game. no probs. I'm fixing things.

Amith KK