We are tracking down the stability issues on Stack Overflow, please bear with us s we figure out what's stalling out. I have removed the currently angry servers from traffic pools while we dig.
@JeffSchaller Funnily enough I just noticed that I actually have a photo as my background wallpaper, but I usually never see it since I have a terminal running tmux in full-screen mode... :-)
@Kusalananda my other computer used a random slideshow from (the old?) Digital Blasphemy site. I'm in the same boat as you, though -- always full-screening or covering up 90% of the space
Oh wow, it's still up after all these years. fluorescence was one of the first I downloaded.
Yes, the way you wrote your loop, $file_name will contain the path to the file. gzip will create the compressed version of the file in the same directory as the original.
The only thing different between what I and what you wrote is that the uncompressed file will be deleted with my code.
But you wrote: for file_name in "$sDir"/NBC-*; do name=$(basename "$file_name" ); gzip -c $sDir/$name > $sDir/$name.gz; done. In this loop, $file_name is the full path to the file.
That is the same as: for file_name in "$sDir"/NBC-*; do name=$(basename "$file_name" ); gzip -c "$file_name" > "$file_name".gz; done
The old advice used to be to double-quote any expression involving a $VARIABLE, at least if one wanted it to be interpreted by the shell as one single item, otherwise, any spaces in the content of $VARIABLE would throw off the shell.
I understand, however, that in more recent versions of shells,...
But wildcards don't work when quoted, so "$sDir/NBC-*"will leave a literal asterisk. You'll need the wildcard part outside quotes, as in "$sDir/NBC"-*
I don't see any reason why [[ ${?} = 0 ]] shouldn't work, but you could just write if gzip .. ; then mv ... etc. Checking the return status is what if does. But shellcheck does mention both of these points. :)
@overexchange You can drop if [[ ${i} == $file_name_pattern ]]; then. It is guaranteed that $i will be a filename matching the pattern NBC-*. What you could do (at the start of the script) is shopt -s nullglob so that globs against non-existing files returns nothing.
nullglob If set, Bash allows filename patterns which match no files to expand to a null string, rather than themselves.
I have been thru shellcheck, for below script
#!/bin/bash
exec 5> ./debug_file
BASH_XTRACEFD="5"
set -x
sDir=/a/b/c
dDir=/d/e/f
rDir="$dDir/recent"
mkdir -p $sDir
mkdir -p $dDir
mkdir -p $rDir
# I1817157 - start
# Delete existing zip files, if any
shopt -s nullglob
rm "$sDir"/*.gz 2> /dev/null
# I1817157 - end
# regexp="^[A-Z0-9]{3}-[A-Z]{8}-[A-Z]{2}[0-9]{3}-[A-Z]{3}[0-9]{2}-[A-Z0-9]{3}$"
for file_name in "$sDir"/NBC-*
do
i=$(basename "$filename" )
echo "Processing file ${i} ...."
deviceName=`echo $i | cut -d '_' -f1`
I got below errors
Line 27: i=$(basename "$filename" ) ^-- SC2154: filename is referenced but not assigned (did you mean 'file_name'?).
Line 29: deviceName=`echo $i | cut -d '_' -f1` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting.
Line 30: prefix=`echo ${deviceName:0:3}` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2116: Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'. ^-- SC2086: Double quote to prevent globbing and word splitting.
Line 29: deviceName=`echo $i | cut -d '_' -f1` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting.
@overexchange deviceName="$(echo "$i" | cut -d '_' -f1)" probably, though I think the outermost set of quotation marks is optional since its an assignment
for Line 37: rm $rDir/$deviceName* ^-- SC2086: Double quote to prevent globbing and word splitting.
ah github says, When quoting composite arguments, make sure to exclude globs and brace expansions, which lose their special meaning in double quotes: "$HOME/$dir/src/*.c" will not expand, but "$HOME/$dir/src"/*.c will.
yes, without the quotes any wildcards inside the variables would also expand, and that's usually not what people want (and has surprising results because it also results in multiple words). mywiki.wooledge.org/WordSplitting if you already haven't seen that
@Jordan if you need to include a single-quote inside the string, the easiest way is to use a double-quoted string if possible: "includes ' single quote"
I just needed to include that _ specifically because the set that I'm using it for also contains "@, !, $" as beginning of words and I just want the "_'s"
There are two levels of quoting/escaping going on — one of them is to protect the regex from the shell. Then there are escapes inside the regex itself, to e.g., make \$ match a literal $ (instead of end-of-string/line)
@ilkkachu but different than perl, which would want s(foo)(bar) because Perl knows parens (and braces, and brackets) are supposed to open and close :-)
