The Cactus Game Engine

Ethan Bierlein

22:00

No, I'm asking how to update my local copy.

With changes others have made.

Annonomus Penguin

Errr

It's a complicated process

I think you manually have to merge

Locally if it screws something up

Ethan Bierlein

How would I do that?

Annonomus Penguin

You see why I don't want collisions? ^^^^ :D

@EthanBierlein errrrmmm.... it takes like ten minutes to explain

And an hour to master

Ethan Bierlein

Just give me a command, and I'll figure it out.

Annonomus Penguin

Basically, Git spits out a long file with lots of >>>>>> and <<<<s that you have to manually edit out

@EthanBierlein not sure

I think if you just git pull that it will automatically give you the "combined file"

Ethan Bierlein

22:02

With other user's commits in it?

Annonomus Penguin

Yes. Just google it

help.github.com/articles/…

@Ethan I thought you were talking about something else

It's just git pull

Ethan Bierlein

Well, goody then. Nice and simple.

Annonomus Penguin

And git push to upload

Pull only gives you stuff that you don't have, push gives your new commits to the server.

Commit with git commit -m "My message here!"

Ethan Bierlein

Yup, ik.

Damn, Python3 is taking forever to install.

Holy shit. We've had over 400 visits to the project alone today!

And six unique visitors!

Annonomus Penguin

@EthanBierlein most of those are probably us :P

If not all

Ethan Bierlein

22:11

6 unique visitors? I think not. All of us have probalby visited the repo, which means we're not unique. That means that we are getting slightly more attention though...

Annonomus Penguin

def find_by_name(self, name: str):
    for index, map_position in enumerate(self.data):
        if self.game._conditional_lower(name.lower()) == name:
            return index
    return -1  # Element not found

That code always returns 0. Any ideas? (@Ethan)

@EthanBierlein is it new, unique visitors?

Oh nevermind

Ethan Bierlein

Yes

Annonomus Penguin

Oh, yay!

Ethan Bierlein

Well, first off, add a docstring to that. Second off, I have no idea why it returns 0.

Annonomus Penguin

Ah, fixed it

YEAH

It works!

Ack, let me clean a few things up and we'll have a commit

Ethan Bierlein

22:19

W00T! L33T C0D3!

R3ADY T0 C0MM1T?

Annonomus Penguin

D:

Scared penguin

Ethan Bierlein

Is the L33TSP3AK too much for you?

Annonomus Penguin

@EthanBierlein yes

Duga

[ShearOfDoom/Cactus] Annonomus-Penguin created pull request #28: Adds flexible event handler to merge Annonomus-Penguin/Cactus/6-7-15-event-handler into ShearOfDoom/Cactus/master

Ethan Bierlein

Okay

Annonomus Penguin

22:23

@Ethan github.com/ShearOfDoom/Cactus/pull/28 can you review the changes?

Ethan Bierlein

Yup.

Any pull request that you create can be merged as long as they work, are cleanly written, and have docstrings and such.

That's the new "policy" with pull requests. ^^

Annonomus Penguin

I know, I just want a review since it is so big

Duga

[ShearOfDoom/Cactus] ShearOfDoom commented on CactusSource/main_game.py of pull request #28: Adds flexible event handler

> Add a docstring here.

[ShearOfDoom/Cactus] Annonomus-Penguin pushed commit 5228b988 to master: Prevents __pycache__ folder from getting synced

[ShearOfDoom/Cactus] ShearOfDoom commented on CactusSource/main_game.py of pull request #28: Adds flexible event handler

> Add a docstring here.

Ethan Bierlein

@AnnonomusPenguin Oof. Can you explain the event handling to me?

Annonomus Penguin

@EthanBierlein question closed as too broad by Annonomus Penguin ♦ 5 seconds ago

Ethan Bierlein

22:30

Ahm, okay...

Annonomus Penguin

:D

That's a really broad question

Like the naming?

The functions involved?

Tortilla chips and queso?

Ethan Bierlein

No, I'm talking about stuff like self._handle_event("intro_msg.b"). What do the things that look like "something.something" do?

Annonomus Penguin

@EthanBierlein Ooh.

Ethan Bierlein

Yeah

Annonomus Penguin

That's the event that the user "binds" a function to

Ethan Bierlein

22:34

Hmm, okay. Can I have a simple example?

Annonomus Penguin

So, in the context of MainGame

It calls the function game.intro_mesage.b that's defined by the user

The b/a stand for before/after

For example:

Say I want to run a function when the command left is called in start.

Ethan Bierlein

Hmm, okay. Maybe you should change b and a to before and after. After all, we do want clarity here.

Annonomus Penguin

True. I'll do that in a second. Let me finish here

I would, in the main game file, add to the dictionary passed the entry "map_position.command.left.a": myFunction

And then that function will run after the other processing is done when that command is called

Make sense?

Ethan Bierlein

Oooh, so, essentially running functions when the user types a command, right?

Annonomus Penguin

In this case, yes

There's a ton of other ones that we can add

It's more of a framework now so we can just add a "tag" when we would want that function to run (if the user wants) and the user can "bind" to that "tag"

Does that make sense?

Ethan Bierlein

22:38

Okay. I think I sort of get this now, but for just a little more clarity, explain what "map_position.right.enter.a" does in "pseudo-code".

Annonomus Penguin

@EthanBierlein that's a string literal, not a function call

I assume you mean:

Ethan Bierlein

I know it's a string literal, I just want an explanation of what the string represents.

Annonomus Penguin

self._handle_event("map_position.right.enter.a")

@EthanBierlein oh

That's when, in the context of the map position with the name right, the user enters that room

After the native processing is handled

Ethan Bierlein

Wow. You really did a ton. I get it now. Thanks!

Annonomus Penguin

@EthanBierlein are you sure you get it?

It's cool when you understand

@EthanBierlein let me push when I finish the requested modifications

Duga

22:41

[ShearOfDoom/Cactus] ShearOfDoom commented on CactusSource/map_position.py of pull request #28: Adds flexible event handler

> Change event_handlers to event_handlers: dict.

Annonomus Penguin

And then we can merge the PR

Ethan Bierlein

Yup. Gonna make a few more comments on the PR.

Annonomus Penguin

Hmm... I also have another mod I want to make to this

Duga

[ShearOfDoom/Cactus] ShearOfDoom commented on CactusSource/main_game.py of pull request #28: Adds flexible event handler

> Change event_handlers to event_handlers: dict.

Ethan Bierlein

@AnnonomusPenguin I've added some comments to the PR.

Mostly just nit-picky things, but, still somewhat important.

Annonomus Penguin

22:44

@EthanBierlein why I wanted a review

:P

@Ethan I was thinking about just moving all of the event_handlers to the MainGame() instance. Yea or nay?

Ethan Bierlein

@AnnonomusPenguin Yea

You can do that

It'll make it clearer too

Annonomus Penguin

Also: should we rename use_lower → case_sensitive? Also: does that apply to the "location links" or the commands or both?

If yes, please make an issue while I fix the other stuff

@EthanBierlein let me work on that

Ethan Bierlein

@AnnonomusPenguin One last question, I'm going to merge the current PR, and you can make changes in another, is that okay?

Annonomus Penguin

@EthanBierlein wait

Ethan Bierlein

k

Annonomus Penguin

22:49

It's going to be cleaner if I commit now

Ethan Bierlein

alright

Duga

[ShearOfDoom/Cactus] ShearOfDoom assigned ShearOfDoom to issue #19: Using dictionary keys as MapPosition references rather than indexes

Annonomus Penguin

almost finished

Ethan Bierlein

Okay.

@QPaysTaxes I can take over issue #6 for you if it makes life easier.

Annonomus Penguin

Test and then push

Figures. The change broke it :P

Ethan Bierlein

22:57

Yeah. I just did git pull and tried to play the test. Kept giving me input when the function was exit though

Annonomus Penguin

INCOMING

Duga

[ShearOfDoom/Cactus] Annonomus-Penguin synchronized pull request #28: Adds flexible event handler

Ethan Bierlein

Should I sync it now?

Annonomus Penguin

Yeah

Merge first

Duga

[ShearOfDoom/Cactus] Annonomus-Penguin pushed commit 3de1173a to master: Adds flexible event handler

[ShearOfDoom/Cactus] Annonomus-Penguin pushed commit dfda3ce6 to master: Fixes requested things

Annonomus Penguin

23:01

Now git pull

Duga

[ShearOfDoom/Cactus] Annonomus-Penguin pushed commit 3601b43d to master

Merge pull request #28 from Annonomus-Penguin/6-7-15-event-handler

Adds flexible event handler

[ShearOfDoom/Cactus] Annonomus-Penguin merged pull request #28: Adds flexible event handler from Annonomus-Penguin/Cactus/6-7-15-event-handler into ShearOfDoom/Cactus/master

Annonomus Penguin

@Ethan:

Duga

[ShearOfDoom/Cactus] Annonomus-Penguin closed issue #5: Event handler

Annonomus Penguin

14 mins ago, by Annonomus Penguin

Also: should we rename use_lower → case_sensitive? Also: does that apply to the "location links" or the commands or both?

Ethan Bierlein

Yes, and it applies to location links, and commands.

Annonomus Penguin

23:02

OK

Thanks!

Does the event handler make sense now?

Ethan Bierlein

Traceback (most recent call last):
  File "C:\Users\Ethan Micah Sophie\Desktop\Cactus\test.py", line 16, in <module>
    {}
TypeError: __init__() takes 5 positional arguments but 6 were given

@AnnonomusPenguin ^^

And yes, the event hanlder makes sense.

Annonomus Penguin

For some reason the test didn't get committed

One second will be right back

Ethan Bierlein

k

Annonomus Penguin

For now:

from sys import exit
from CactusSource.map_position import MapPosition
from CactusSource.game_map import GameMap
from CactusSource.main_game import MainGame

GAME_MAP = GameMap([
MapPosition(
"Start",
"Welcome to the start!",
"Now leaving the start.",
{
"left": 1,
"right": 2,
}
),
MapPosition(
"Left",
"You took the left path and died.",
"",
{}
),
MapPosition(
"Right",
"You took the right path and lived!",
"",
{}
),
])

MAIN_GAME = MainGame(
"Test Game",
"Welcome to the simple test game.",
"> ",

Ethan Bierlein

Mkay. I fixed test.py. Going to commit now.

Annonomus Penguin

23:08

@EthanBierlein okay, thanks

@EthanBierlein I have the formatting if you want me to do it

Chat stripped leading whitespace

Duga

[ShearOfDoom/Cactus] Annonomus-Penguin commented on issue #25: Add comments to functions

> Fixed in 3601b43d1eec22bd4a011a4da8575a914e6d2150

[ShearOfDoom/Cactus] Annonomus-Penguin closed issue #25: Add comments to functions

[ShearOfDoom/Cactus] Annonomus-Penguin added label bug to issue #21: Single or double quotes?

Ethan Bierlein

Okay. It should have commited now.

Duga

[ShearOfDoom/Cactus] Annonomus-Penguin removed label help wanted from issue #21: Single or double quotes?

Ethan Bierlein

I gotta go too. Time for dinner.

Duga

[ShearOfDoom/Cactus] ShearOfDoom pushed commit e50c997f to master: Fixed issues with test.py

Ethan Bierlein

23:10

brb

Annonomus Penguin

Ok cya

Duga

[ShearOfDoom/Cactus] Annonomus-Penguin added label bug to issue #29: Make test.py conform to PEP 8: variable naming

[ShearOfDoom/Cactus] Annonomus-Penguin opened issue #29: Make test.py conform to PEP 8: variable naming

[ShearOfDoom/Cactus] Annonomus-Penguin assigned Annonomus-Penguin to issue #29: Make test.py conform to PEP 8: variable naming

[ShearOfDoom/Cactus] Annonomus-Penguin removed label feedback/ideas wanted from issue [#18: [Brainstorming] How can we make the syntax easier externally](github.com/ShearOfDoom/Cactus/issues/18)

[ShearOfDoom/Cactus] Annonomus-Penguin opened issue #30: Lower all the things; Rename should_lower_text→ case_sensitive

> - Liberally apply `_conditional_lower()` to functions
- Rename `should_lower_text` to `case_sensitive`

[ShearOfDoom/Cactus] Annonomus-Penguin added label bug to issue #30: Lower all the things; Rename should_lower_text→ case_sensitive

[ShearOfDoom/Cactus] Annonomus-Penguin added label enhancement to issue #30: Lower all the things; Rename should_lower_text→ case_sensitive

[ShearOfDoom/Cactus] Annonomus-Penguin assigned Annonomus-Penguin to issue #30: Lower all the things; Rename should_lower_text→ case_sensitive

[ShearOfDoom/Cactus] Annonomus-Penguin opened issue #31: Are we going to do docs on the wiki or on pages?

> If on pages, we should disable the wiki here (to avoid confusion)

[ShearOfDoom/Cactus] Annonomus-Penguin added label docs to issue #31: Are we going to do docs on the wiki or on pages?

[ShearOfDoom/Cactus] Annonomus-Penguin added label feedback/ideas wanted to issue #31: Are we going to do docs on the wiki or on pages?

[ShearOfDoom/Cactus] Annonomus-Penguin created pull request #32: Now all double quotes; PEP 8 compliant (ish) to merge Annonomus-Penguin/Cactus/6-7-15-double-quotes-and-pep-8 into ShearOfDoom/Cactus/master

[ShearOfDoom/Cactus] Annonomus-Penguin pushed commit a5d00e09 to master: Now all double quotes; PEP 8 compliant (ish)

[ShearOfDoom/Cactus] Annonomus-Penguin pushed commit ea55d984 to master

Merge pull request #32 from Annonomus-Penguin/6-7-15-double-quotes-and-pep-8

Now all double quotes; PEP 8 compliant (ish)

[ShearOfDoom/Cactus] Annonomus-Penguin merged pull request #32: Now all double quotes; PEP 8 compliant (ish) from Annonomus-Penguin/Cactus/6-7-15-double-quotes-and-pep-8 into ShearOfDoom/Cactus/master

[ShearOfDoom/Cactus] Annonomus-Penguin closed issue #29: Make test.py conform to PEP 8: variable naming

[ShearOfDoom/Cactus] Annonomus-Penguin closed issue #21: Single or double quotes?

[ShearOfDoom/Cactus] Annonomus-Penguin assigned Annonomus-Penguin to issue #33: Remove backticks around help text

[ShearOfDoom/Cactus] Annonomus-Penguin opened issue #33: Remove backticks around help text

[ShearOfDoom/Cactus] Annonomus-Penguin added label enhancement to issue #33: Remove backticks around help text

[ShearOfDoom/Cactus] Annonomus-Penguin pushed commit 7292d454 to master: Updated to include double quotes; other small fixes

[ShearOfDoom/Cactus] Annonomus-Penguin opened issue #34: Global commands

> We should have the option for a user to add global commands, like `quit`.

We should have them integrated into the "fabric mesh," so a user can have one for going to a saved home, or to an inventory/other menu.

As usual, they should be able to bind to these commands.

[ShearOfDoom/Cactus] Annonomus-Penguin added label enhancement to issue #34: Global commands

[ShearOfDoom/Cactus] ShearOfDoom unassigned newbiedoodle from issue #6: Game map validator

[ShearOfDoom/Cactus] ShearOfDoom assigned ShearOfDoom to issue #6: Game map validator

Transcript for