RELOAD!

[rubberduck-vba/Rubberduck] 4 issue comments.

[Cardshifter/HTML-Client] Phrancis created branch vanilla-js-rewrite

Here we go... I hope I don't regret this lol X)

[Cardshifter/HTML-Client] Phrancis pushed commit 221ae26d to vanilla-js-rewrite: add NetBeans ignores

[Cardshifter/HTML-Client] Phrancis pushed commit 1906d524 to vanilla-js-rewrite: Delete npm/Angular related config files

Now just gotta go un-Augular all those HTML files >_>

[Cardshifter/HTML-Client] Phrancis pushed commit e3a46b24 to vanilla-js-rewrite: Remove Angular directives from card_template.html

Uh, not sure this is the best approach

Maybe I should just get rid of all this and use the Github master for reference, and "build up" instead of "tear down and see what's left"

[Cardshifter/HTML-Client] Phrancis pushed commit 4e56fd63 to vanilla-js-rewrite: remote console directory because it was not implemented

[Cardshifter/HTML-Client] Phrancis pushed commit d7f6bc23 to vanilla-js-rewrite: Remove Angular directives from deck_builder

[Cardshifter/HTML-Client] Phrancis pushed commit 4f412e15 to vanilla-js-rewrite: Start with a clean slate and build up, referencing the previous code, instead of trying to tear down the old Angular code

[Cardshifter/HTML-Client] Phrancis pushed commit b69e9391 to vanilla-js-rewrite: Copy styles.css from Angular project

[Cardshifter/HTML-Client] Phrancis pushed commit fb54ecb2 to vanilla-js-rewrite: Simple test page to make sure the CSS links right

As feared/expected, CSS is showing up again with this love/hate thing...

[Cardshifter/HTML-Client] Phrancis pushed commit e31f77da to vanilla-js-rewrite: Add top_navbar using <iframe>, values hard-coded into tag for now to make it look acceptable on Chrome/PC

[Cardshifter/HTML-Client] Phrancis pushed commit 5f0c2847 to vanilla-js-rewrite: Move all public HTML to root/www/ instead of root/. Additionally, add jQuery HTML load() in favor of using iframes, appears simpler and more lightweight.

@Duga // TODO commit more often

[Cardshifter/HTML-Client] Phrancis pushed commit 2e87f3b4 to vanilla-js-rewrite: Fix invalid XML.

It's pretty cool that jQuery can dynamically load HTML from another file, far simpler than iframes and all that. I don't want this to become a jQuery mess though, so I'm thinking of only using jQuery for its load() functionality, which AFAICT can't be done with vanilla.

[Cardshifter/HTML-Client] Phrancis pushed commit b9166327 to vanilla-js-rewrite: Replaced jQuery load() with a vanilla solution.

@Phrancis Nevermind, jQuery is gone now.

@Phrancis jQuery != VanillaJS

@SimonForsberg Right, Glad I found a vanilla way of doing it :)

TTGTB() // damn insomnia

hey

hey

[Cardshifter/HTML-Client] Phrancis pushed commit bf6a2e1d to vanilla-js-rewrite: make loadHtml more explicit & rename file using camelCase

Today I want to figure out the WebSocket stuff (at least the basics so I can see it working)

Good old java -jar cardshifter-server-0.6.1.jar interface, I'm a bit nostalgic :)

[Cardshifter/HTML-Client] Phrancis pushed commit da4c464c to vanilla-js-rewrite: add global object along with debug logic

[Cardshifter/HTML-Client] Phrancis pushed commit 90e325ef to vanilla-js-rewrite: fix a name error in global object, and replace hard coded strings with variable names

[Cardshifter/HTML-Client] Phrancis pushed commit a5ab7825 to vanilla-js-rewrite: Changed global object to just variables, seems to make more sense right now

[Cardshifter/HTML-Client] Phrancis pushed commit d27381f3 to vanilla-js-rewrite: copy server_interface.js from previous client

> Weird assignment

@Phrancis Monking!

@Phrancis I'm inclined to agree with that.

@SimonForsberg It's not my code, it's SirPython's, but assigning a thing to its own value doesn't really make sense

Agreed

The comments say it's StackOverflow, so who knows what this is intended to do... guess I'll just have to test with and without and see if it does anything

/*
 * Returns all the keys of an object and its inherited keys.
 * This is used so `JSON.stringify` can get the `.command` of a message.
 *
 * @param {Object} obj - The object to flatten
 * @return {Object} - a new Object, containing obj's keys and inherited keys
 * @source stackoverflow.com/questions/8779249/…
*/
const flatten = function(obj) {
    let result = Object.create(obj);
    for(let key in result) {
        // TODO this assignment is weird, why is `result[key]` being assigned to its own value?

Hey @SimonForsberg if I want to just check that a connection to a server is open via websocket, I could just open a connection and then close it, right?

@Phrancis I'd say so yes

Good, I'll try it out

[Cardshifter/HTML-Client] Phrancis pushed commit ed37f156 to vanilla-js-rewrite: Refactor, cleanup, improve documentation

@Duga That took a while to do, hope there's not too much of this to do for a while

[Cardshifter/HTML-Client] Phrancis pushed commit 388c9e22 to vanilla-js-rewrite: added login form into index.html, to test at first before making modular. Also switched to 4 spaces instead of 2 for HTML formatting.

[Cardshifter/HTML-Client] Phrancis pushed commit b9adbafa to vanilla-js-rewrite: Format HTML with 4 spaces instead of 2.

OMG OMG OMG it just worked @SimonForsberg!!

[2018-03-17 19:34:51,399]  INFO MainServer [      main] (       MainServer.java: 93) - Started
[2018-03-17 19:34:55,494]  INFO  ServerWeb [WebSocketWorker-9] (        ServerWeb.java: 51) - Connection opened: org.java_websocket.WebSocketImpl@1d0233f
[2018-03-17 19:34:55,495]  INFO     Server [WebSocketWorker-9] (           Server.java:133) - New client: 6:  @ connection not open

Of course it did, you made it :)

lol

<script>
    const serverUri = "ws://127.0.0.1:4243";
    const isSecure = false;
    const onReady = function() { console.log("WebSocket ready"); }
    const onError = function() { console.log("WebSocket error"); }
    CardshifterServerAPI.init(serverUri, isSecure, onReady, onError);
</script>

I actually had zero debugging to do, I just typed up the code, ran it in the browser, and it just worked

Yeah, it's called programming ;)

How's the rest of the client look like now?

@SimonForsberg I'm just getting ready to put together the login logic, I just wanted to be sure WS worked before I even started

Looks like SirPython's server_interface is completely re-usable, and he wrote good documentation too

[Cardshifter/HTML-Client] Phrancis pushed commit 941b03f9 to vanilla-js-rewrite: Temporary script to make sure WebSocket connection can be established.

200_success vs. janos: 26988 diff. Year: +1452. Quarter: +1452. Month: +566. Week: +302. Day: -12.

200_success vs. rolfl: 29639 diff. Year: +2081. Quarter: +2081. Month: +630. Week: +352. Day: +8.