« first day (287 days earlier)      last day (3573 days later) » 

00:00
RELOAD!
[Cardshifter/Cardshifter] 5 commits. 3 opened issues. 3 closed issues. 16 issue comments.
[retailcoder/Rubberduck] 19 commits. 3 issue comments.
 
8 hours later…
07:56
hey
@SimonAndréForsberg Oh right, somehow I missed that point totally
08:34
\[[**Vogel612/JavaBot**](https://github.com/Vogel612/JavaBot)\] [**Vogel612**](https://github.com/Vogel612) pushed commit [**52579287**](https://github.com/Vogel612/JavaBot/commit/52579287ad9ec6ca3d9abcd349c370b8db3807b0) to [**master**](https://github.com/Vogel612/JavaBot/tree/master): Cleaned up package structure by moving command related packages from
"com.gmail.inverseconduit"
into "com.gmail.inverseconduit.commands.providers"
 
1 hour later…
09:47
Monking
 
1 hour later…
11:16
hey @SimonAndréForsberg
I finished chapter 1 of the documentation
@skiwi of what documentation?
oh, right. reading the Groovy docs
I don't think I've read it all
I skipped some parts
I eat documentation for breakfast
I smoke documentation for breakfast
11:41
I never said that
 
1 hour later…
13:05
hey
[Cardshifter/Cardshifter] Zomis pushed commit 35ae0150 to groovy: reorganized Groovy modding slightly and added some modding example code that is not yet implemented
[Cardshifter/Cardshifter] build #958 for commit 35ae0150 on branch groovy passed
 
2 hours later…
15:02
[Cardshifter/Cardshifter] Zomis pushed commit 7ce12cfd to groovy: creating some implementation structure for groovy modding
[Cardshifter/Cardshifter] Zomis pushed commit 58cbaf90 to groovy: moving GroovyMod.groovy to resources directory to make it easier to code in IntelliJ idea, and at the same time making it dynamically reloadable (using Ctrl + F9 in IntelliJ)
[Cardshifter/Cardshifter] build #959 for commit 58cbaf90 on branch groovy passed
15:18
@SimonAndréForsberg Is that health = 1 in the Groovy script something that you want to still change to health 1? Or is there a reason for it being that way
And damn, that Groovy DSL looks clean
And for the config, it's exactly what we need to replace the Java config with, as Java is verbose
@skiwi I haven't decided yet which way it should be, I did it that way at the moment because I figured we might want to support both
@skiwi It is clean. It feels really nice.
I think when I'm writing Groovy I want to use @CompileStatic as much as possible, coming from a Java background
but for dynamic parts that's obviously not possible
I totally understand you
It feels a bit weird to have a language that both does static and dynamic compilation though :P
it is a bit weird indeed, but I like it
then you can utilize the powers of both
15:34
true, don't know if good or bad, but at least interesting
good IMO
A huuuuuuuge advantage for Groovy over JS: Muuuuch more detailed error messages!
I love it when something goes wrong, because it's a real pleasure reading these stack traces!
15:55
[Cardshifter/Cardshifter] Zomis pushed commit 106fe0c3 to groovy: added some delegates and closure calls for Groovy modding. fixed some syntax in Cards.groovy
[Cardshifter/Cardshifter] build #960 for commit 106fe0c3 on branch groovy passed
16:24
Adding SecureString support to Lib2GitSharp http://codereview.stackexchange.com/q/90881?atw=1 #csharp
Monking
Hey @Phrancis!
Wait... Is that using... Groovy?
16:25
SWEET
[Cardshifter/Cardshifter] Zomis pushed commit 57426e4c to groovy: import cleanup, catching AssertionErrors and Exceptions in Groovy mods
[Cardshifter/Cardshifter] Zomis pushed commit 2fb3f2ce to groovy: added deck config and player config. All card names now show up for a Groovy mod
@SimonAndréForsberg Groovy > JS, definitely
Evidently
[Cardshifter/Cardshifter] build #961 for commit 2fb3f2ce on branch groovy passed
@skiwi Groovy >>>>>>>>>>> JS
2
def JS = 0
def Groovy = Double.POSITIVE_INFINITY
assert Groovy >>>>>>>>>>>>> JS
16:36
lol
Am I OK to work on the JS branch (at least the cards part) for the time being, i.e. is that JS object format going to "stick" for a while?
16:59
@Phrancis What kind of work do you intend to do?
@Phrancis I think we will switch from JS to Groovy pretty soon, but I can't really promise when. And any changes you make to any cards will be easy to carry over to Groovy, so while waiting for the Groovy implementation to be supported better, you can continue working on the JS branch, sure.
17:19
OK. I guess I would just finish the modding guide for cards (if you intend for the keywords to work the same or very similar) and perhaps start making cards for Mythos, that is all
I think it will be similar, yes.
ah, Mythos cards, I'd love to see that :)
OK
I was thinking of actually creating about 10 cards for a handful of mythologies and letting several people make the 10 cards with their ideas, I know GreyFox and Jay will definitely want in on that, Would you as well @Simon?
@Phrancis In one way, I'd love to. But at the moment, I think there are other things I have to focus on. Maybe in a few weeks I can do that.
OK
I'll save the Norse for you and check again a bit later ;)
17:50
@SimonAndréForsberg Did you mean extra-resources rather than cardshifter-extra?
@Phrancis yes, exactly
OK cool.
Should I try to compile it first before committing to make sure it didn't break things moving the files, or are you confident it will work the same?
I kept all the files in one directory so it doesn't break any paths in the JS load
18:05
@Phrancis I am confident that you will need to make one more change than that, so please compile it and see if you can start a game
I think you need to change this line in ModCollection.java:
    mods.put("NewJS", () -> new JavaScriptMod("JSGame.js", scripts));
I think it needs to be changed to this:
    mods.put("NewJS", () -> new JavaScriptMod("mods/cyborg-chronicles/JSGame.js", scripts));
OK let me try and see what happens
[INFO] cardshifter ....................................... SUCCESS [  0.008 s]
[INFO] cardshifter-api ................................... SUCCESS [ 22.950 s]
[INFO] cardshifter-modapi ................................ SUCCESS [ 15.402 s]
[INFO] cardshifter-test .................................. SUCCESS [  7.712 s]
[INFO] cardshifter-core .................................. FAILURE [  7.197 s]
[INFO] cardshifter-fx .................................... SKIPPED
[INFO] cardshifter-server ................................ SKIPPED
@Simon So the change above you think would resolve this? Or need more details?
@Duga has nothing to remind anyone of today!
Got a bunch of cannot find symbol errors originating from CyborgChroniclesGame.java
@Phrancis details, please!
18:24
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cardshifter-core: Compilation failure: Compilation failure:
[ERROR] /Users/francisveilleux-gaboury/STS/cardshifter/cardshifter-core/src/main/java/net/zomis/cardshifter/ecs/usage/CyborgChroniclesGame.java:[75,96] error: cannot find symbol
[ERROR] } })
[ERROR] location: variable effects of type Effects
[ERROR] /Users/francisveilleux-gaboury/STS/cardshifter/cardshifter-core/src/main/java/net/zomis/cardshifter/ecs/usage/CyborgChroniclesGame.java:[93,38] error: cannot find symbol
[ERROR] /Users/francisveilleux-gaboury/STS/cardshifter/cardshifter-core/src/main/java/net/zomis/cardshifter/ecs/usage/CyborgChroniclesGameWithSpells.java:[31,54] error: incompatible types: net.zomis.cardshifter.ecs.effects.EffectComponent cannot be converted to net.zomis.cardshifter.ecs.usage.EffectComponent
[ERROR] /Users/francisveilleux-gaboury/STS/cardshifter/cardshifter-core/src/main/java/net/zomis/cardshifter/ecs/usage/CyborgChroniclesGameWithSpells.java:[34,54] error: incompatible types: net.zomis.cardshifter.ecs.effects.EffectComponent cannot be converted to net.zomis.cardshifter.ecs
I'm compiling from js with the changes you had made on js-load you asked me to pull, and the moved .js files
There seems to be some import errors, but those should have existed before as well...
it compiled before you made your changes, didn't it?
I didn't try after pulling. I can undo the changes and try again though, if you like
please do. You can do git stash and then later git stash pop to temporarily stash away your changes
Do I need to git checkout or git pull after I stash
18:28
OK
Saved working directory and index state WIP on js: 65a55d1 Moved documentation related files to their own folder
HEAD is now at 65a55d1 Moved documentation related files to their own folder
Alright, compiling again
Same problem happened
Actually, it looks maybe slightly different, perhaps
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project cardshifter-core: Compilation failure: Compilation failure:
[ERROR] /Users/francisveilleux-gaboury/STS/cardshifter/cardshifter-core/src/main/java/net/zomis/cardshifter/ecs/usage/CyborgChroniclesGame.java:[75,96] error: cannot find symbol
[ERROR] } })
[ERROR] location: variable effects of type Effects
[ERROR] /Users/francisveilleux-gaboury/STS/cardshifter/cardshifter-core/src/main/java/net/zomis/cardshifter/ecs/usage/CyborgChroniclesGame.java:[93,38] error: cannot find symbol
But all in all, apparently there are import problems
seems to work on my machine on that branch
Odd... Should I try a git reset?
I don't think I've made any significant change lately on that branch
run git status first
I want to know what that says
18:35
Francis-Veilleux-Gabourys-MacBook:cardshifter francisveilleux-gaboury$ git status
On branch js
Your branch is up-to-date with 'origin/js'.

nothing to commit, working directory clean
and how are you compiling the project?
What does the first couple of lines of git log --branches --decorate --oneline --graph say?
Francis-Veilleux-Gabourys-MacBook:cardshifter francisveilleux-gaboury$ git log --branches --decorate --oneline --graph
* 65a55d1 (HEAD, origin/js, js) Moved documentation related files to their own folder
* c2e837c pulling js-load into js
* 6ea8ea1 a bit more documentation
* 27ecec7 small but meaningful corrections to examples
try Project -> Clean in Eclipse
18:39
Should I pick all CShifter related projects?
Done
try running it even without running the maven build, can you do that?
Maybe? Not sure how
the same way you run it normally? go to the class and click Run in Eclipse
18:42
Like the ServerMain.java class or...?
yes
and GameClient.java
I thought that was fixed already
do the Maven update thingy again (Alt + F5)
Alright
right click on ServerMain.java in the left directory structure and see if there is a 'Run' option
also, click 'Java' in the upper right. You currently seem to have 'JavaScript' selected there.
18:53
For some reason, I can't even find that file through the Package Explorer in the Java perspective. But I'm trying to build again from Java perspective
If that's all it was I'm going to bang my head against the wall (literally)
[INFO] cardshifter ....................................... SUCCESS [  0.004 s]
[INFO] cardshifter-api ................................... SUCCESS [ 15.989 s]
[INFO] cardshifter-modapi ................................ SUCCESS [ 17.680 s]
[INFO] cardshifter-test .................................. SUCCESS [  7.304 s]
[INFO] cardshifter-core .................................. SUCCESS [ 32.825 s]
[INFO] cardshifter-fx .................................... SUCCESS [ 18.638 s]
[INFO] cardshifter-server ................................ SUCCESS [ 44.067 s]
I was just about to say "I don't think that should have been it"
Be careful with your head!
Oh DUH. I was looking with the Package Explorer. I opened the Project Explorer and boom, here is the file.
Definitely having a PICNIC moment right now.
Ugh, when I try to run (after building through Maven) the server file, it keeps starting to build again. I constantly feel like I'm fighting with Eclipse
I need to go shave for the wedding which is in a couple of hours, but I'll check back in now and then
@Phrancis We all do at times.
Suddenly it gets much more interesting to look at Gradle build files now that I know how Groovy works
Hey look! My #first merged pull request! (That I couldn't just merge myself.) Thanks @libgit2sharp! #opensource #git https://github.com/libgit2/libgit2sharp/pull/1050#event-306526276
FINALLY
19:06
try {
    tryHard();
} finally {
    work();
}
So, should I git stash pop and try building again?
[Cardshifter/Cardshifter] Zomis pushed commit 5aa3463b to groovy: added resource support to Groovy
[Cardshifter/Cardshifter] Zomis pushed commit 5098de98 to groovy: added some more Groovy mod implementation, primarily of players zones and starting resources
[Cardshifter/Cardshifter] Zomis pushed commit 8af698cc to groovy: added some 'methodMissing' methods to make Groovy run despite not supporting everything
[Cardshifter/Cardshifter] Zomis pushed commit 2963ea06 to groovy: injecting support for PerformerMustBeCurrentPlayer, and startCards
Building...
[INFO] cardshifter ....................................... SUCCESS [  0.004 s]
[INFO] cardshifter-api ................................... SUCCESS [ 16.182 s]
[INFO] cardshifter-modapi ................................ SUCCESS [ 14.478 s]
[INFO] cardshifter-test .................................. SUCCESS [  7.052 s]
[INFO] cardshifter-core .................................. SUCCESS [ 28.049 s]
[INFO] cardshifter-fx .................................... SUCCESS [ 17.043 s]
[INFO] cardshifter-server ................................ FAILURE [ 22.181 s]
That's all the detail the output shows
19:24
[Cardshifter/Cardshifter] build #962 for commit 2963ea06 on branch groovy passed
@Phrancis really? I'd expect it to be more somewhere. Try mvn test from the commandline in worst case
19:38
I ran the Maven update again, and rebuilding now
Same thing
The really long lines look like this:
Description	Resource	Path	Location	Type
Failed to execute goal on project cardshifter-console: Could not resolve dependencies for project com.cardshifter:cardshifter-console:jar:0.6-SNAPSHOT: Failure to find com.cardshifter:cardshifter-test:jar:0.6-SNAPSHOT in zomis.net/maven was cached in the local repository, resolution will not be reattempted until the update interval of zomisnet has elapsed or updates are forced (org.codehaus.mojo:findbugs-maven-plugin:3.0.0:check:analyze-compile:compile)	pom.xml	/cardshifter-console	line 5	Maven Build Problem
Hm. Cache issue?
@Phrancis when you do Alt + F5 to do the Maven -> Update thingy, you can select 'force update'
19:57
OK trying now
And errors are gone. Building again
Running com.cardshifter.server.messages.ParseJSONMessagesTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.673 sec - in com.cardshifter.server.messages.ParseJSONMessagesTest

Results :

Failed tests:
  ServerConnectionTest.setup:59 Server did not start correctly. Perhaps it is already running?
  ServerConnectionTest.setup:59 Server did not start correctly. Perhaps it is already running?
  ServerConnectionTest.setup:59 Server did not start correctly. Perhaps it is already running?
I shut down Java and trying to build... again lol
@Simon [INFO] BUILD SUCCESS
About freaking time
OK, I guess your feelings were right. I tried starting a game using NewJS and got a run time exception, "Error initializing mod"
I made the change to ModCollection and building now
And it worked :D
You, Mr. Simon, are good at this programming stuff.
Err wait no it didn't...
20:51
[Cardshifter/Cardshifter] Zomis pushed commit e7b2f20f to groovy: significantly restructured Groovy mod to make it less 'code-ish'
@Phrancis oh yeah, that one is a bit annoying... I think that's the most common reason for me why tests fail
@Phrancis what is not working?
btw @Phrancis, I am not really done with this yet, it's not really playable at the moment, but it's getting there... this is how Groovy modding looks: github.com/Cardshifter/Cardshifter/tree/groovy/extra-resources/…
^^ @skiwi @bazola you might also be interested
> I think this can be fixed on the server-side and it shouldn't be too hard so I think 0.6 is reasonable for this.
[Cardshifter/Cardshifter] build #963 for commit e7b2f20f on branch groovy passed
@SimonAndréForsberg I made the changes as you advised:
	public ModCollection() {
		ais.put("Loser", new ScoringAI(AIs.loser()));
		ais.put("Idiot", new ScoringAI(AIs.idiot()));
		ais.put("Medium", new ScoringAI(AIs.medium(), AIs::mediumDeck));
		ais.put("Fighter", new ScoringAI(AIs.fighter(), AIs::fighterDeck));

        ScriptEngineManager scripts = new ScriptEngineManager();
        mods.put("NewJS", () -> new JavaScriptMod("mods/cyborg-chronicles/JSGame.js", scripts));
		mods.put(CardshifterConstants.VANILLA, () -> new CyborgChroniclesGameNewAttackSystem());
@Phrancis and does it work or not after those changes?
and if not, in what way is it not working?
It built but when I started a game using NewJS it gave me a server error in the game screen console
21:01
@Phrancis what does the server console say?
Error initializing mod
show more text
on the server you should see a full stacktrace
I gotta get going to the wedding, I'll revisit that when I get back
21:19
[Cardshifter/Cardshifter] Zomis pushed commit 6ffaf2de to groovy: added PlayerConfigMessage.toString()
[Cardshifter/Cardshifter] Zomis pushed commit 2690dc63 to groovy: Groovy cleanup, moved ZoneDelegate and CardDelegate to another file
[Cardshifter/Cardshifter] build #964 for commit 2690dc63 on branch groovy passed
22:19
[Cardshifter/Cardshifter] Zomis pushed commit 0c025079 to groovy: added support for some more systems in Groovy
[Cardshifter/Cardshifter] Zomis pushed commit 3b602070 to groovy: externalized more delegate classes
[Cardshifter/Cardshifter] build #965 for commit 3b602070 on branch groovy passed
22:47
@Simon I believe your Groovy can be still better, I'll try to look a look and modify it on my own branch soon tm, definitely looking good so far though
@skiwi Oh, I am fully aware that it can be. There's a lot of things to improve.
23:07
It's late and am on my phone so can't help much right now
I thought that you were going to bed earlier again after coming back from Ukraine :D
I was.
Screwed that up a week ago.
Hehe ok
23:25
[Cardshifter/Cardshifter] Zomis pushed commit 7dbbdecb to groovy: created a real ConfigDelegate
[Cardshifter/Cardshifter] Zomis pushed commit 52582409 to groovy: added include feature in Groovy mods. Added some AttackSystem functionality, added creature types and creature actions
[Cardshifter/Cardshifter] build #966 for commit 52582409 on branch groovy passed
23:45
Simon André Forsberg vs. Mat's Mug: 1120 diff. Year: +169. Quarter: -581. Month: -275. Week: -267. Day: -6.
rolfl vs. 200_success: 267 diff. Year: +972. Quarter: +815. Month: +436. Week: +460. Day: -55.
23:57
And back home
[Cardshifter/Cardshifter] Zomis pushed commit a2be1a93 to groovy: added some useCost implementations

« first day (287 days earlier)      last day (3573 days later) »