Coding Projects and Duga Heaven :)

Simon André Forsberg

01:08

TTGTB

Make sure that you pull the changes from github next time @bazola (should be a simple fast-forward)

skiwi

07:07

Monking

skiwi

07:18

@bazola What's that thing? :o

skiwi

07:32

Back in the evening somewhere, busy day

Simon André Forsberg

09:17

Monking @skiwi

skiwi

09:28

Monking @SimonAndréForsberg

Always fun... was supposed to have a meeting, the guy we were supposed to meet doesn't show up

And am now really on my laptop, still have no clue why it is so slow

Simon André Forsberg

that sounds fun ^^

@skiwi Should I try to 'convert' the JavaFX code to use the ECS game instead?

the stand-alone JavaFX code, that is. Not the client/server - yet.

skiwi

10:33

@SimonAndréForsberg Don't know

What did you do so far since yesterday?

Simon André Forsberg

I've started the conversion of JavaFX code to ECS now

on a new branch, of course

yesterday I cleaned up a bit on the JavaFX branch and reviewed bazola's JavaFX question. And moved the ECS branch over to the main repo

skiwi

Okay

I'm trying to picture things

And how to do the branching for the mod-modules

Simon André Forsberg

that won't be a problem I think

git checkout -b mod-hearthstone

skiwi

I want to create a plan for myself

Simon André Forsberg

sure

skiwi

10:38

and off which branch to bracch off

I'm thinking about branching off ecs

Simon André Forsberg

well right now, ecs would be the best branch to branch off, yes

skiwi

and then create my own test mod

It should be simpler as the game we are implementing, yet covering everything

Simon André Forsberg

'covering everything'? what 'everything'?

skiwi

Well, the ECS system is split up in a core and a mod-implementation, right?

Simon André Forsberg

Note that right now, the PhrancisGame.createGame method might be a bit hard to understand and seem complex. It is possible to extract a lot of things to functions, so that you could do AttackYGO.add(game);

Depends on what you mean by core and what you mean by mod.

skiwi

10:42

@SimonAndréForsberg Classes like ECSSystem, etc. are core, and implementations are mod

Could make a separate module for common systems, etc.?

Simon André Forsberg

The core is really the cardshifter.ecs.base package, but cardshifter.ecs.actions, cardshifter.ecs.phase, and cardshifter.ecs.resources can also be considered part of the 'core'

because pretty much every mod will use actions, phases (player turns), and resources (creature stats, mana costs, mana, etc...)

@skiwi yes, that's a bit what I was thinking. Refactoring out Mana feature to it's own package/class(es)

skiwi

@SimonAndréForsberg But mana by itself should be mod specific, turns should be in the core, I think

lol, this made me look twice

Simon André Forsberg

@skiwi Absolutely. A mod can choose which mana style to use, or no of the existing styles.

skiwi

So that is kind of settled then once done

Then the hard part is developing your own mods

Of what files does a Java mod consist?

Simon André Forsberg

hard*est*

Technically, to make a mod all you need is one method. A method to setup the entities and add components to them, and to add the systems that you want to use.

I imagine that there will be many default-implementations of various systems and features

skiwi

10:52

So we have a setup method

Simon André Forsberg

so if you want to gain mana like in Hearthstone, it's a simple method call to Mana.asHearthstone(game);

skiwi

I'm asking this also with Lua in mind, because Lua mods will not use the java build system at all

Simon André Forsberg

yes, it's a setup method

depends on what you mean by 'at all'

skiwi

So the mod may be nothing more than a file (be it a zip for Lua or a jar for Java)

I picture people modding in Lua to not know anything about Java

Simon André Forsberg

they can use Java-Lua method bindings we provided to make what they want

skiwi

10:55

Correct, but still unclear to me (probably also because I didn't have time to look into your code thoroughly yet)

There is only exactly one method in the mod that gets called which loads up the entire mod?

Simon André Forsberg

@skiwi pretty much, yes.

It's pretty much like a configuration

As all the features has been extracted to components + systems

skiwi

Yes, but the mod needs to also be able to specify its own components and systems

Simon André Forsberg

And it will be able to do that

skiwi

good

So we have a single point of entry

Simon André Forsberg

yes

skiwi

10:58

So currently for console and javafx version, we need to specify the directory of the mod, I assume?

Simon André Forsberg

@skiwi we need to make it call a method (that returns an instance of ECSGame). How we do that, that's up to us.

skiwi

@SimonAndréForsberg Well yes, I'm thinking about the most simple implementation we can do at the moment

Simon André Forsberg

Most simple implementation? Dependency injection. Provide it with a Supplier<ECSGame>

skiwi

We cannot require Java there

won't work for Lua

And it's then also hardcoded

I'm thinking we specify the mod (Lua uses a zip, Java uses a jar), and specify whether it is written in Lua and Java

Simon André Forsberg

sure we can require Java, the client is Java. We can provide a Lua-wrapper method. If we want to make a mod with Lua, we pass it a LuaGameLoader(InputStream)

and btw, the client is pretty much hard-coded for our specific mod as it is.

skiwi

11:04

Well yes for testing that would be nice

Then last point for now

You are developing a mod, say a Java one for simplicity's sake

Is there a way you can as modder test the mod via automated tests?

Like taking over the basic startup tests from the core module, and then add your own integration tests?

While being aware that mod repository only has the mod code and nothing else

Simon André Forsberg

@skiwi not at the moment, but there is a way to make that possible yes.

skiwi

What would be required to do so?

I would think publishing at least the core module on mvnrepo and creating tests that have the option to specify a mod

Simon André Forsberg

well, you need to make it possible to access the core..

it's solvable, but I'm not sure if it's meaningful to put it up on mvnrepo. At least not until there are some real players and there's a real client (that can support all kinds of mods)

skiwi

Well, how would you else get the jar?

Simon André Forsberg

the old-fashioned way. Download it.

skiwi

11:15

Do we want to do that inside a Maven build script?

Simon André Forsberg

of course not

skiwi

Then what would be your plan on that?

Simon André Forsberg

I just mean that the initial modders don't have to use Maven

I don't think we should put it on mvnrepo until it's really production-ready, or at least beta-ready

skiwi

They don't have to, but we would

Simon André Forsberg

which is still a loooooooooooong time from now.

bazola

11:16

@SimonAndréForsberg no I am not much of a graphical designer either

@skiwi what is what thing?

skiwi

We still need to get the jar into there somewhee

@bazola Would be more helpful if you used the reply-to feature ;)

Simon André Forsberg

you can install jars into your local maven repository manually

or you can use the old-style 'build-path' to set up a mod-project

skiwi

@SimonAndréForsberg Yes, but it executes on Travis

I do agree though that we may not want to put up things on mvnrepo now already

Simon André Forsberg

you never said that you wanted to use Travis for it!!!

skiwi

@SimonAndréForsberg Well.... That's technically correct

bazola

11:22

@skiwi okay I will start using reply-to :)

skiwi

@bazola But it's the picture I think yo meant?

bazola

yeah

er no

@skiwi what's what thing?

Simon André Forsberg

14 hours ago, by bazola

skiwi

@bazola Ah, the window in front there

Simon André Forsberg

^^ that thing

bazola

11:25

its the github desktop client

mac.github.com

the pc version looks the same though

skiwi

Can you do anything cool with it, or just see fancy stuff?

bazola

you can do everything that you can do with the console

sometimes in mac when I do something in the console, it seems to get stuck, so I have used the GUI to fix it

skiwi

okay

@SimonAndréForsberg I'll leave the discussion at where we are at right now

Will have plenty of things to do ;)

bazola

@SimonAndréForsberg by the way thank you for answering my question. I especially did not know about the java best practices, so I will make sure to follow them from now on

also I didn't know I could do this:

@FXML private Pane opponentHandPane;

I think it looks a whole lot cleaner than using two lines

skiwi

I see it on two lines a lot though

But it's not strictly neccessary indeed

I might change my own code one day

Simon André Forsberg

11:30

@bazola especially for short annotations like @FXML, I think it can be good to only use it on two lines

skiwi

Time for a Business Information Systems test now

Simon André Forsberg

^^ ECS game in JavaFX

bazola

11:45

that was quick simon

why do you think it is better to use it on two lines? just curious

Simon André Forsberg

two lines? what is on two lines?

oh, the @FXML?

for short annotations, it's OK with one line but if you have this:

bazola

yeah I would agree

Simon André Forsberg

@JsonProperty(value = "something", ignorable = true)

then it's a bit much text :)

Duga

[Cardshifter/Cardshifter] Zomis created branch ecs-fx

[Cardshifter/Cardshifter] Zomis pushed commit 6294b2ea to ecs-fx

> Deprecated core non-ECS classes

[Cardshifter/Cardshifter] Zomis pushed commit a4c4f8e5 to ecs-fx

> merged with JavaFX

[Cardshifter/Cardshifter] Zomis pushed commit cb6e044d to ecs-fx

> Converted CompleteIdiot AI to ECS-style

[Cardshifter/Cardshifter] Zomis pushed commit 798653fe to ecs-fx

> Added index to PlayerComponent

[Cardshifter/Cardshifter] Zomis pushed commit 82e2bf1b to ecs-fx

> Because of the view, added getCards method in ZoneComponent

[Cardshifter/Cardshifter] Zomis pushed commit ddf6f7bf to ecs-fx

> utility class for Resources, method to get all resdata in a ResourceMap

Simon André Forsberg

@bazola it was quick because most things have a 1:1 connection

Duga

11:50

[Cardshifter/Cardshifter] Zomis pushed commit 51a2fb1c to ecs-fx

> Added 'required' method in ComponentRetreiver, with a NotNull-assertion

[Cardshifter/Cardshifter] Zomis pushed commit 7737a02a to ecs-fx

> Added EntityRemovedEvent, and a system to clear entities from zones

[Cardshifter/Cardshifter] Zomis pushed commit 2a5fe2d5 to ecs-fx

> Added log4j to JavaFX

[Cardshifter/Cardshifter] Zomis pushed commit 42f812ac to ecs-fx

> Converted JavaFX standalone client to use ECSGame

3

bazola

that is most excellent :)

Simon André Forsberg

@bazola Are you going to work on the JavaFX networking?

If you are, then you may continue to do so a little while longer, I haven't changed the server to use ECS yet.

Just make sure that you pull my cleaning-up I did last night

bazola

you mean continue working on the network client? yeah I was going to play with it a bit today

Simon André Forsberg

ok, nice ^^

Duga

12:31

[Cardshifter/Cardshifter] Zomis pushed commit 4c64a716 to ecs-fx

> Added turn number and phase number to PhaseController

Duga

12:46

[Cardshifter/Cardshifter] Zomis commented on issue #12: Specify all possible events the core can generate

> The ones currently implemented in the ECS are:
ActionAllowedCheckEvent - hook to determine if an action is allowed
ActionPerformEvent - when an action is performed
DrawCardEvent - when a card is drawn by a player
DrawCardFailedEvent - when there was no card left to draw
EntityRemoveEvent - when an entity is removed
PhaseEndEvent - at the end of a phase (turn)
PhaseStartEvent - at the start of a phase (turn)
ResourceValueChange - when a resource value has been changed for an entity ...

(such as losing health, gaining mana)
ResourceViewUpdate - when `get()` on a resource returns a new value (note that this is not the same as ResourceValueChange because of the possibility of using a strategy to fake the actual value, useful with 'All creatures have +1/+1' effects)
StartGameEvent - when game is started
TargetableCheckEvent - hook to determine if an entity can be targeted
ZoneChangeEvent - when a card moves from one zone to another

skiwi

13:18

@SimonAndréForsberg The labels switched to capslock

Nice stuff though

Simon André Forsberg

@skiwi yeah, I know, that's intentional for now. Making it lower-case won't be a problem

skiwi

Figuring out how the Windows Github app works

skiwi

14:15

And finally also I can head home

@SimonAndréForsberg Will you do any of the ECS splitting?

I'm also fine with doing it on my own branch

Splitting in core, commons and mod

Simon André Forsberg

14:43

@skiwi what ECS splitting?

core, commons, mod... hmm...

you can do it if you want to

time to eat now

bazola

15:26

@SimonAndréForsberg working on processing messages from the server, here is what I am working on:

Player Info: Player1 - {scrap=0, mana=1, manaMax=1, battlefield={Zone Battlefield (0) owned by {Player 'Player1'}}, deck={Zone Deck (47) owned by {Player 'Player1'}}, cardType=Player, life=10, hand={Zone Hand (5) owned by {Player 'Player1'}}}
Player Info: Player2 - {scrap=0, mana=0, manaMax=0, battlefield={Zone Battlefield (0) owned by {Player 'Player2'}}, deck={Zone Deck (47) owned by {Player 'Player2'}}, cardType=Player, life=10, hand={Zone Hand (5) owned by {Player 'Player2'}}}
ZoneMessage [id=3, name=Battlefield, owner=0, size=0, known=true]

Simon André Forsberg

ok

bazola

what does the UpdateMessage id mean exactly? player?

and what kind of message is Player Info coming from? PlayerMessage?

Simon André Forsberg

UpdateMessage id can be for a player and it can be for a card. It is for an entity. Both players and cards are entities.

the toString method of PlayerMessage is the following:

	@Override
	public String toString() {
		return String.format("Player Info: %s - %s", this.name, this.properties);
	}

So that is correct, yes.

bazola

so how do you suggest I turn that value of 2 into knowing on screen which value to update? do I hard code 2 to mean a player?

Simon André Forsberg

Hmm... I see there is a value missing here. PlayerMessage should also provide an id for the player. So that you can know what ids are players and what ids are cards

I will add a getId() method to the PlayerMessage, @bazola

the cards and zones have ids though so try focus on them right now @bazola

bazola

15:37

cool

ZoneMessage can get me pretty far because it has an owner value.. however the CardInfo message does not, so somewhere I would have to check that that zone is for a particular player?

Simon André Forsberg

@bazola CardInfo gives you an id for the zone the card is in, use that id to lookup the zone.

bazola

i think that it makes sense, we will see what I come up with :)

Simon André Forsberg

good

skiwi

Hey again

Simon André Forsberg

monking

Duga

15:43

[Cardshifter/Cardshifter] skiwi2 pushed commits e963a4f5 and 8b179621 to client-server

Simon André Forsberg

You're just in time for some @Duga spam...

Duga

[Cardshifter/Cardshifter] skiwi2 pushed commit 9197797e to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 4b1082a7 and 5669664a to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 60194db0 and afc7bd0e to client-server

[Cardshifter/Cardshifter] Zomis pushed commits eb65f940 and de587bfc to client-server

[Cardshifter/Cardshifter] Zomis pushed commits db670c85 and 7c65a389 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits b8bf0680 and 14939c40 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits b6b9d6bf and c391dc1f to client-server

[Cardshifter/Cardshifter] Zomis pushed commits c24eeaf6 and 50887b6f to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 59cb9f57 and f75db0e9 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 040427c9 and 691f38be to client-server

[Cardshifter/Cardshifter] Zomis pushed commits f69b8d63 and 3a342ca2 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits f7d9e878 and 3bb963a1 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 16b52bb8 and ae147151 to client-server

bazola

unfortunately it seems like any time I want to change the JavaFX I need to do Platform.runLater()

Duga

[Cardshifter/Cardshifter] Zomis pushed commits a5cefb5f and 9ef114fe to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 1f96de20 and ee8f350a to client-server

Simon André Forsberg

@bazola yes, that is correct.

Duga

15:46

[Cardshifter/Cardshifter] Zomis pushed commits f3283547 and 8c558a9a to client-server

bazola

I tried putting the whole method behind Platform.runLater() but then I was getting null pointer exceptions

Duga

[Cardshifter/Cardshifter] Zomis pushed commits 0661d423 and 512fb2dc to client-server

Simon André Forsberg

that doesn't sound optimal :)

Duga

[Cardshifter/Cardshifter] Zomis pushed commits 127015fd and dfdfe100 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 89c9bb8b and c2d12d09 to client-server

Simon André Forsberg

or well, it would be a good idea to make a whole method inside runLater, but I mean NPE doesn't sound optimal :)

Duga

15:46

[Cardshifter/Cardshifter] Zomis pushed commits 9a4f0ebf and 001de68b to client-server

[Cardshifter/Cardshifter] Zomis pushed commits db0a91a3 and ee7b75c9 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 0595c6e0 and 647e2aa9 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 7e9239c7 and 6a54ecf1 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 3e03dd43 and a98b0cfe to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 45ec21d8 and 6c17d286 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 974c008c and 63e0e274 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 4ee0a14f and 6fdf1042 to client-server

skiwi

@SimonAndréForsberg Ok I'll do

Duga

[Cardshifter/Cardshifter] Zomis pushed commits d3b51786 and 076c2b09 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 0c8e8e9c and 47fbaa1e to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 8dfe0ad9 and 04a04052 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits da2b15c7 and 4b0c24e9 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits fc755ee5 and c84cfa65 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits fb711aa3 and ac019ec6 to client-server

bazola

to test this stuff I have to turn the server off and on each time

Duga

[Cardshifter/Cardshifter] Zomis pushed commits 87589f37 and ddba4d49 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits e29298ec and 890430ba to client-server

Simon André Forsberg

@bazola Let me fix that for you...

Duga

15:50

[Cardshifter/Cardshifter] Zomis pushed commits a409080a and cac3f08f to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 115a88a1 and 6b3a2088 to client-server

bazola

even just a restart command?

would help a lot

Duga

[Cardshifter/Cardshifter] Zomis pushed commits 21639f22 and ae255530 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits abe1f4f8 and 5e98d14f to client-server

Simon André Forsberg

@bazola How about an ai command that creates a new AI?

Duga

[Cardshifter/Cardshifter] Zomis pushed commits f0b47c38 and 6294b2ea to client-server

[Cardshifter/Cardshifter] Zomis pushed commits a4c4f8e5 and cb6e044d to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 798653fe and 82e2bf1b to client-server

bazola

the trouble is that when I close the client, the server doesn't know, so when I make a new game, it makes the player the first person and never makes an ai

Duga

15:51

[Cardshifter/Cardshifter] Zomis pushed commits ddf6f7bf and 51a2fb1c to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 7737a02a and 2a5fe2d5 to client-server

[Cardshifter/Cardshifter] Zomis pushed commits 42f812ac and 4c64a716 to client-server

[Cardshifter/Cardshifter] bazola pushed commits c9749c01 and 5660f0ea to client-server

[Cardshifter/Cardshifter] bazola pushed commits 9730a6ff and c1401040 to client-server

[Cardshifter/Cardshifter] bazola pushed commits 0a365f5a and ce8f3e32 to client-server

[Cardshifter/Cardshifter] bazola pushed commits 0c19ae75 and e66c3ae7 to client-server

[Cardshifter/Cardshifter] bazola pushed commits d69611cd and 4859b1e6 to client-server

[Cardshifter/Cardshifter] bazola pushed commits 44102829 and 91d84629 to client-server

[Cardshifter/Cardshifter] bazola pushed commits a074639a and 536a002b to client-server

skiwi

We might really need a solution to @Duga-spam

Duga

[Cardshifter/Cardshifter] bazola pushed commits b7219e88 and c005c0f4 to client-server

[Cardshifter/Cardshifter] bazola pushed commit b81cb19a to client-server

[Cardshifter/Cardshifter] Zomis pushed commit c088aee1 to client-server

> To give Zone a unique id, it now creates an entity inside the component

[Cardshifter/Cardshifter] Zomis pushed commit 4807d158 to client-server

> Added a function to get all resource data by name: value

[Cardshifter/Cardshifter] Zomis pushed commit 2cc2cd3b to client-server

> Converted server game to use ECS

skiwi

But neither do we want to really cut out commit messages

Transcript for