00:04
[rubberduck-vba/Rubberduck] retailcoder created comment on issue #6043: False
FunctionReturnValueDiscarded
report on a sub call > > confirming that the issue is being reported within the function itself (and not at its call sites).
The identifier reference to `TemporarySheet` in the `TemporarySheet.Init` statement has to refer to _something_ - and Rubberduck correctly considers it a reference to the function.
The bug here is that without any arguments, that reference should be ignored by the inspection because it isn't a call to that function, even if it does reference it. However, a fix can't simply be looking for
The identifier reference to `TemporarySheet` in the `TemporarySheet.Init` statement has to refer to _something_ - and Rubberduck correctly considers it a reference to the function.
The bug here is that without any arguments, that reference should be ignored by the inspection because it isn't a call to that function, even if it does reference it. However, a fix can't simply be looking for
7 hours later…
07:18
6 hours later…
13:11
[rubberduck-vba/Rubberduck] MDoerner added label resolver to issue #6043: False
FunctionReturnValueDiscarded
report on a sub call
[rubberduck-vba/Rubberduck] MDoerner added label inspection-false-positive to issue #6043: False
FunctionReturnValueDiscarded
report on a sub call
[rubberduck-vba/Rubberduck] MDoerner added label inspection-false-positive to issue #6042: False Positive ConstantNotUsed Inspection
[rubberduck-vba/Rubberduck] MDoerner added label resolver to issue #6042: False Positive ConstantNotUsed Inspection
2 hours later…
15:51
> This PR fixes `ReadOnlyPropertyAssignmentInspection` issue described within #6039.
#6039 eliminates an NRE scenario from the `ParserRuleContextExtension.Contains()` function. This NRE was a common when running the `ReadOnlyPropertyAssignmentInspection`. The NRE's early termination of the inspection masked a false positive result for a very common use case. This PR adds tests for the use case(s) and modifies the inspection to resolve the false positives.
There is another false positive
#6039 eliminates an NRE scenario from the `ParserRuleContextExtension.Contains()` function. This NRE was a common when running the `ReadOnlyPropertyAssignmentInspection`. The NRE's early termination of the inspection masked a false positive result for a very common use case. This PR adds tests for the use case(s) and modifies the inspection to resolve the false positives.
There is another false positive
16:18
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created comment on pull request #6044: Fix ReadOnlyAssignmentInspection false positives
> :white_check_mark: Build Rubberduck 2.5.2.6171 completed (commit github.com/rubberduck-vba/Rubberduck/commit/a43119153c by @BZngr)
Update to handle null arguments
Some functions were not handling null arguments
Add ParserRuleContext constraint to generic functions if missing
Some functions were not handling null arguments
Add ParserRuleContext constraint to generic functions if missing
[rubberduck-vba/Rubberduck] web-flow pushed commit 797bd612 to next: Merge pull request #6039 from BZngr/PRContextExtensionsNRE
16:45
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.2.6172
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.2.6172
6 hours later…
23:00
[rubberduck-vba/Rubberduck] retailcoder added label hacktoberfest-accepted to pull request #6044: Fix ReadOnlyAssignmentInspection false positives
[rubberduck-vba/Rubberduck] retailcoder pushed commit bfc63043 to next: expose document event handlers in declaration finder
[rubberduck-vba/Rubberduck] retailcoder pushed commit 25d49bba to next: validate ordinal parameter types
23:21
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.2.6173
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.2.6173
23:49
« first day (3060 days earlier) ← previous day next day → last day (120 days later) »
Transcript for
Oct21
Oct '2222
Oct23
VBA Rubberducking
This chat has moved to Discord: discord.gg/MYX9RECenJ