« first day (3060 days earlier)      last day (120 days later) » 

00:04
REFRESH!
[Minesweeper] 69 Games Played. 56 Bombs Used. 8602 Moves Performed. 10 New Users
[rubberduck-vba/Rubberduck] 12216 additions. 2 issues opened. 1271 deletions. 5 commits
> > confirming that the issue is being reported within the function itself (and not at its call sites).

The identifier reference to `TemporarySheet` in the `TemporarySheet.Init` statement has to refer to _something_ - and Rubberduck correctly considers it a reference to the function.

The bug here is that without any arguments, that reference should be ignored by the inspection because it isn't a call to that function, even if it does reference it. However, a fix can't simply be looking for
> Again, the simplest mitigation would be to avoid treating the function identifier as a local variable, and only use it to assign a return value.
 
7 hours later…
07:18
> Unfortunately, we cannot simply do that because the function identifier can be used as a local variable inside the function body, as demonstrated in this issue.
 
6 hours later…
If nobody picks up the last two issues for Hacktoberfest, I will probably have a look next week.
14:05
@Duga hm, perhaps we could add a flag on IdentifierReference telling us when a function reference is acting as a local variable?
14:17
We usually deal with this properly. That is why I slapped on the resolver label.
 
2 hours later…
15:51
> This PR fixes `ReadOnlyPropertyAssignmentInspection` issue described within #6039.

#6039 eliminates an NRE scenario from the `ParserRuleContextExtension.Contains()` function. This NRE was a common when running the `ReadOnlyPropertyAssignmentInspection`. The NRE's early termination of the inspection masked a false positive result for a very common use case. This PR adds tests for the use case(s) and modifies the inspection to resolve the false positives.

There is another false positive
16:18
[rubberduck-vba/Rubberduck] build for commit 60fdb145 on unknown branch: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] BZngr pushed commit f6a5e78f to next: Add initial null argument tests
Update to handle null arguments

Some functions were not handling null arguments
Add ParserRuleContext constraint to generic functions if missing
[rubberduck-vba/Rubberduck] web-flow pushed commit 797bd612 to next: Merge pull request #6039 from BZngr/PRContextExtensionsNRE
[rubberduck-vba/Rubberduck] build for commit 6e0834f7 on next: 97.58% (target 0.00%)
 
6 hours later…
23:00
[rubberduck-vba/Rubberduck] retailcoder pushed commit e969bd02 to next: fix test setup
[rubberduck-vba/Rubberduck] retailcoder pushed commit bfc63043 to next: expose document event handlers in declaration finder
[rubberduck-vba/Rubberduck] retailcoder pushed commit 25d49bba to next: validate ordinal parameter types
[rubberduck-vba/Rubberduck] retailcoder pushed commit b8335d94 to next: undo "fix" test setup
Merge pull request #6036 from retailcoder/eventhandlers

Expose document event handlers in declaration finder
[rubberduck-vba/Rubberduck] build for commit b8335d94 on next: 97.58% (target 0.00%)
23:49
[rubberduck-vba/Rubberduck] 1660 stars vs. [decalage2/oletools] 2238 stars

« first day (3060 days earlier)      last day (120 days later) »