Duck check: As part of the resource string refactoring I'm working on I've added a few *.resx files. I've noticed that it doesn't seem to like the use of Rubberduck.Resources.Refactorings.Refactorings.resx file name.
Specifically the Refactorings.Refactorings when I attempt use a using directive using Rubberduck.Resources.Refactorings.Refactorings at the location it would be used Refactorings.Refactorings.FooBarStringit states the Rubberduck.Refactorings namespace doesn't exist.
The same is true if I just use Refactorings.FooBarString.
I have to alias the using using Refactoring = Rubberduck.Resources.Refactorings which enables Refactoring.Refactorings.FooBarString. ¿Why is this the case?
@MathieuGuindon Yes. In fact my understanding was that Resources.Refactorings.Refactorings was created to hold code only resources inserted by refactorings.
A reminder... the only reason Rubberduck.Resources exist is to provide resources that are not specific to a single project. If there's resources that should be project-scoped, they probably should be. That does lead into the problem of avoiding duplicated resources, though. A unified resource file would have avoided creating duplicate Foo keys but it can't prevent Refactoring_Foo and Command_Foo keys being created with same value.
hmm. can a resource key look up another resource key?
Probably not since it's just text
Maybe what we really want is a unit test that asserts that none of values in any resources file in any project are duplicated.
that would then make it easier for us to create Refactorings.Resources .resx that is scoped to the Rubberduck.Refactorings, remove all the Refactoring_ prefix from the keys, and if there are any values that needs to be reused in another project, that can be easily moved to Rubberduck.Resources's .resx.
By the logic above - it would seem to follow that the UI resources in the Resources project would reside in Rubberduck.Core.Resources or Rubberduck.Core.UI.Resources..No?
Yes, provided that the keys are scoped only to the Rubberduck.Core.UI
if the keys need to be re-used outside that, then it's Rubberduck.Resources
and in the process, that should eliminate the prefixes from the keys. I think we still have lot of prefixing in the keys. That should be left to the namespace/resource file name.
Making me wonder. ought there be EncapsulateFieldRefactoring.resx rather than one big Refactoring.resx....
that also implies they don't need to be translated
I really need to load up the resx manager and see how it works. We want to make it fairly easy to find all resources to be translated. Currently "code" resources have comments indicating to not translate
in Templates.resx, we have 4 or 5 keys, but 1 of them shouldn't be. But the keys have prefix to keep the template together. So I don't think it's going to be practical to have a "code-only" resource file and "UI-only" resource.
I guess the comment on every non-translatable resource will have to suffice.
I hope that resx manager has a filter that can be then applied to the comment to exclude them for the translator's ease.
@this Since there are only a few, perhaps any resource targeted for code exclusively (which would include export header resources) could be put into a Rubberduck.Resources.CodeOnly.resx. It is reasonable to expected that they will be re-used by refactorings and quickfixes and other objects.
And, I would imagine header resources would/could be broken out to smaller Format strings that allows setting the various flag values - followed by assembling the header.
hmm, then I have to ask. should we even be using resources file? Resource files are more for storing dumb values with some simple replacement. But we're now talking about building code snippets from smaller block which requires more logic than a simple key/value store?
Yeah...maybe it is not a resource file...Seems that if there is no need for translations, resource files may be overkill. Just want to get everything in one , easily accessible, reusable place. CodeSnippetProvider anyone?
Thanks for all the input. The Access Server team updated the farm last week to 2.5.1.5557 and everything appears to be working correctly. Not sure if this is just from being reinstalled or if you made changes, but thanks for all of your help.
damn MSForms... If there was a way to handle QueryClose dynamically, I could automatically wire it up and handle it whenever a View binds an AcceptCommand or a CancelCommand instance.
kind of like the Control events ...I suppose there's a GUID and a memid attribute value for it, but I'm not sure how the guy went about figuring that out for Control events
I can move the resource files into their own project. The reason I didn't do that was because the first group within RubberduckUI.resx I looked at was used in more than one location.
After I had moved down the path of creating resx files within Rubberduck.Resources did I find others that were solely used within their own project.
Soooo...Oct is rapidly coming to an end. Will PRs that have yet to be Approved, but look generally acceptable, get the "hacktoberfest-accepted" labeled applied to them?... just asking on behalf of a friend
So that leaves us with #5586, #5591, #5602 as PRs that are older than a week. I can't merge the first 2 since they are mine. I have no further work for those PR unless someone want to put in a last minute comment. I'm good to merge @IvenBach's 5602 if he has no further work and nobody else has comments.
I will also try and review the more recent PRs as well. We do not have to merge them by 10/31 but at least approving to help the legit contributors get their shirts, like Brian's good friend.
> Additionally, any pull request with the hacktoberfest-accepted label, submitted to any public GitHub repository, with or without the hacktoberfest topic, will be considered valid for Hacktoberfest.
#TIL
lol they even had pseudo code. I don't think it was there at the start of month
PRs count if:
Submitted during the month of October AND
Submitted in a public repo AND (
The PR is labelled as hacktoberfest-accepted by a maintainer OR
Submitted in a repo with the hacktoberfest topic AND (
The PR is merged OR
The PR has been approved
)
)
On the topic of XAML...Is there are good reference for using WPF/xaml? A recommended book is conspicuously absent from the 'Books on Programming' topic on RD's wiki.
@MathieuGuindon Thanks! - I'll have to take a look. What I have found thus far has left me a bit wanting. (I doubt WPF ever makes into the '...for Dummies' series). And, I find that your MVVM posts are very helpful as well.
No it doesn't. Because as a good programmer, you are going to avoid it (and the next person who reads your code will thank you. :-) Case closed. — BigBen3 mins ago
VBA hast to two ways of reading the value of a TextBox:
result1 = UserForm1.TextBox1.Value
result2 = UserForm1.TextBox1.Text
I assume .Text will always return a string, but what exactly is going on with .Value? Since the content of a textbox is (presumably) a string it would just returns...
VBA hast to two ways of reading the value of a TextBox:
result1 = UserForm1.TextBox1.Value
result2 = UserForm1.TextBox1.Text
I assume .Text will always return a string, but what exactly is going on with .Value? Since the content of a textbox is (presumably) a string it would just returns...
VBA Rubberducking
VBA Rubberducking