12:01 AM
4 hours later…
4:13 AM
[rubberduck-vba/Rubberduck] BZngr created comment on pull request #5531: Redesign of quick fix application
4:30 AM
[rubberduck-vba/Rubberduck] retailcoder closed issue #5519: Annotate Declaration should allow to immediately adjust the attribute for attribute annotations
[rubberduck-vba/Rubberduck] retailcoder merged pull request #5526: Adjust attribute from annotate declaration from MDoerner/Rubberduck/AdjustAttributeFromAnnotateDeclaration into...
[rubberduck-vba/Rubberduck] MDoerner pushed commit 811448b6 to next: Add AddOrUpdateAttribute to AttributesUpdater
Allow to annotate declarations in attributes code
This only applies to components and declarations with attributes contexts.
This only applies to components and declarations with attributes contexts.
Enhance AnnotateDeclarationRefactoringAction to allow adjusting corresponding attributes
The adjustment/addition of an attribute only happens if the corresponding flag is set on the model and the annotation is an IAttributeAnnotation.
The adjustment/addition of an attribute only happens if the corresponding flag is set on the model and the annotation is an IAttributeAnnotation.
[rubberduck-vba/Rubberduck] MDoerner pushed commit 5a211949 to next: Adjust AnnotateDeclarationViewModel for new AdjustAttribute capability
[rubberduck-vba/Rubberduck] MDoerner pushed commit a1e92de9 to next: Add option to add/adjust attribute to AnnotateDeclaration UI
Show AnnotateDeclaration UI from CE command for IAttributeAnnotations
This is an exception to the rule that annotations without parameters are applied immediately. This is necessary since the option to add.adjust the corresponding attribute exists now.
This is an exception to the rule that annotations without parameters are applied immediately. This is necessary since the option to add.adjust the corresponding attribute exists now.
Use correct context when adding annotations via attributes code
This is hard to test since the bug fixed here only materializes when the attributes are removed in the code pane version of the code.
This is hard to test since the bug fixed here only materializes when the attributes are removed in the code pane version of the code.
[rubberduck-vba/Rubberduck] MDoerner pushed commit 66d00b0e to next: Merge branch 'next' into AdjustAttributeFromAnnotateDeclaration
4:44 AM
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.0.5486
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.0.5486
1 hour later…
5:45 AM
10 hours later…
4:25 PM
3 hours later…
7:01 PM
[rubberduck-vba/Rubberduck] retailcoder added label PR-Status: Conflicting to pull request #5529: Option to disable drag and drop
[rubberduck-vba/Rubberduck] retailcoder closed issue #5527: Slightly scrolling horizontally in code inspection window when selecting an item
[rubberduck-vba/Rubberduck] retailcoder merged pull request #5532: Suppress only horizontal scroll in inspection results window and test explorer from MDoerner/Rubberduck/SuppressHorizontalBringIntoViewInGroupinGrids into...
Suppress only horizontal scroll in inspection results and test explorer
To achieve this, a new request from the original source is performed with a rectangle extending to the left into negative space. As a result, vertical scrolling is preserved, but horizontal scrolling suppressed.
To achieve this, a new request from the original source is performed with a rectangle extending to the left into negative space. As a result, vertical scrolling is preserved, but horizontal scrolling suppressed.
[rubberduck-vba/Rubberduck] MDoerner pushed commit 4b01a60d to next: Merge branch 'next' into SuppressHorizontalBringIntoViewInGroupinGrids
Merge pull request #5532 from MDoerner/SuppressHorizontalBringIntoViewInGroupinGrids
Suppress only horizontal scroll in inspection results window and test explorer
Suppress only horizontal scroll in inspection results window and test explorer
[rubberduck-vba/Rubberduck] MDoerner synchronized pull request #5531: Redesign of quick fix application
[rubberduck-vba/Rubberduck] MDoerner synchronized pull request #5529: Option to disable drag and drop
[rubberduck-vba/Rubberduck] MDoerner synchronized pull request #5529: Option to disable drag and drop
[rubberduck-vba/Rubberduck] MDoerner removed label PR-Status: Conflicting from pull request #5529: Option to disable drag and drop
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.0.5487
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.0.5487
7:33 PM
7:47 PM
8:02 PM
[rubberduck-vba/Rubberduck] MDoerner synchronized pull request #5531: Redesign of quick fix application
8:22 PM
9:09 PM
[rubberduck-vba/Rubberduck] retailcoder closed issue #5480: False positive FunctionReturnValueDiscardedInspection with Err.Raise Sub
[rubberduck-vba/Rubberduck] retailcoder merged pull request #5533: Disable FunctionReturnValueDiscardedInspection for built-in functions from MDoerner/Rubberduck/EnhanceFunctionReturnValueDiscardedInspectionForBuiltInFunctions...
Disable FunctionReturnValueDiscardedInspection for built-in functions
This has always been intended, but the corresponding test setup was bad. The reason to ignore results for built-in functions is that there are lots of built-in functions used for their side-effects or those of the members of the return value, e.g. MsgBox and Err.
This has always been intended, but the corresponding test setup was bad. The reason to ignore results for built-in functions is that there are lots of built-in functions used for their side-effects or those of the members of the return value, e.g. MsgBox and Err.
[rubberduck-vba/Rubberduck] MDoerner pushed commit 9fcad5a0 to next: Merge branch 'next' into EnhanceFunctionReturnValueDiscardedInspectionForBuiltInFunctions
Merge pull request #5533 from MDoerner/EnhanceFunctionReturnValueDiscardedInspectionForBuiltInFunctions
Disable FunctionReturnValueDiscardedInspection for functions not defined in user code.
Disable FunctionReturnValueDiscardedInspection for functions not defined in user code.
9:24 PM
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.0.5492
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.0.5492
[rubberduck-vba/Rubberduck] retailcoder closed issue #5510: Disable or improve or undo drag and drop in the code explorer
[rubberduck-vba/Rubberduck] retailcoder merged pull request #5529: Option to disable drag and drop from MDoerner/Rubberduck/OptionToDisableDragAndDrop into rubberduck-vba/Rubberduck/next
Introduce new setting to enable drag and drop in CE
I have put this into the General Settings because there are no CE settings so far and it kind of makes sense.
I have put this into the General Settings because there are no CE settings so far and it kind of makes sense.
Enhance drag and drop to honor the drag and drop setting
It is only enabled if the corresponding general setting is set to true.
It is only enabled if the corresponding general setting is set to true.
[rubberduck-vba/Rubberduck] MDoerner pushed commit d68a0ddd to next: Merge branch 'next' into OptionToDisableDragAndDrop
Merge branch 'next' into OptionToDisableDragAndDrop
# Conflicts:
# Rubberduck.Resources/RubberduckUI.de.resx
# Rubberduck.Resources/RubberduckUI.resx
# Conflicts:
# Rubberduck.Resources/RubberduckUI.de.resx
# Rubberduck.Resources/RubberduckUI.resx
[rubberduck-vba/Rubberduck] MDoerner pushed commit ff73180c to next: Merge branch 'next' into OptionToDisableDragAndDrop
Merge pull request #5529 from MDoerner/OptionToDisableDragAndDrop
Adds an option to disable drag and drop for CE folders.
Adds an option to disable drag and drop for CE folders.
[rubberduck-vba/Rubberduck] retailcoder created comment on pull request #5531: Redesign of quick fix application
[rubberduck-vba/Rubberduck] MDoerner synchronized pull request #5531: Redesign of quick fix application
9:41 PM
[rubberduck-vba/Rubberduck] MDoerner created comment on pull request #5531: Redesign of quick fix application
> New labels:
![QuickFix_updated_labels](https://user-images.githubusercontent.com/22868956/86521346-d1d03b00-be4f-11ea-8db9-d2170a9df33e.jpg)
![QuickFix_updated_labels](https://user-images.githubusercontent.com/22868956/86521346-d1d03b00-be4f-11ea-8db9-d2170a9df33e.jpg)
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.0.5493
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.0.5493
10:01 PM
1 hour later…
[rubberduck-vba/Rubberduck] retailcoder closed issue #5528: Add "Ignore All Occurrences" option to Code Inspections
[rubberduck-vba/Rubberduck] retailcoder closed issue #5464: Unclear what the fix will be using "Fix all occurrences in ..."
[rubberduck-vba/Rubberduck] retailcoder closed issue #5316: Fix multiple selected inspections in one action
[rubberduck-vba/Rubberduck] retailcoder merged pull request #5531: Redesign of quick fix application from MDoerner/Rubberduck/RedesignOfQuickFixApplication into rubberduck-vba/Rubberduck/next
Deactivate all quick fix options except fix selection for multi-selections
Since the user cannot see which one is the main selected result whenever multiple are selected, it seems in order to not allow operations that depend on it.
Since the user cannot see which one is the main selected result whenever multiple are selected, it seems in order to not allow operations that depend on it.
Make quick fix scope options visible on general applicability for the fix
E.g. is a fix does not allow fixing for an entire module, that option will not be shown. However, if the scope is unavailable because of other reasons, e.g. the fix is not applicable to all selected result, it will only be deactivated.
E.g. is a fix does not allow fixing for an entire module, that option will not be shown. However, if the scope is unavailable because of other reasons, e.g. the fix is not applicable to all selected result, it will only be deactivated.
Fix fix menu in inspection results window
The relative source, which works for the context menu, does not for the toolbar menu because the grouping grid is in another branch of the logical tree. Instead, the grouping grid can be referred by name, which does not work for the grouping grid's context menu. Accordingly, a solution with a fallback is employed.
The relative source, which works for the context menu, does not for the toolbar menu because the grouping grid is in another branch of the logical tree. Instead, the grouping grid can be referred by name, which does not work for the grouping grid's context menu. Accordingly, a solution with a fallback is employed.
[rubberduck-vba/Rubberduck] MDoerner pushed commit f536ffad to next: Merge branch 'next' into RedesignOfQuickFixApplication
[rubberduck-vba/Rubberduck] MDoerner pushed commit fc4fe977 to next: Merge branch 'next' into RedesignOfQuickFixApplication
[rubberduck-vba/Rubberduck] MDoerner pushed commit b5d5cb6f to next: Align IgnoreModule test setup to new annotation updater contructor
[rubberduck-vba/Rubberduck] MDoerner pushed commit 69e6de15 to next: Merge branch 'next' into RedesignOfQuickFixApplication
[rubberduck-vba/Rubberduck] MDoerner pushed commit 4e2f8ed4 to next: Simplify quick fix scope labels
11:25 PM
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.0.5495
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.0.5495
« first day (2220 days earlier) ← previous day next day → last day (960 days later) »
Transcript for
Jul3
Jul '204
Jul5
VBA Rubberducking
This chat has moved to Discord: discord.gg/MYX9RECenJ