« first day (1591 days earlier)      last day (1589 days later) » 

Duga
Duga
12:00 AM
RELOAD!
[rubberduck-vba/Rubberduck] 3 issue comments.
[skiwi2/GeneticBrainfuck] 12 commits. 1405 additions. 94 deletions.
 
Duga
Duga
12:51 AM
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=h1) Report
> Merging [#4383](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f38ebf776c9de99883f2e3aca5e2291f0569bded?src=pr&el=desc) will **decrease** coverage by `3.07%`.
> The diff coverage is `n/a`.


```diff
@@ Coverage Diff @@
## next #4383 +/- ##
==========================
 
Duga
Duga
1:02 AM
[rubberduck-vba/Rubberduck] build for commit f9bdf7a0 on unknown branch: AppVeyor build succeeded
 
Vogel612
Vogel612
@Duga I'm surprised that worked..
but I'll take it.
Toodles!
 
 
4 hours later…
Duga
Duga
5:26 AM
> Closes #4212, is WIP pending getting the qualified name for the VB6 version of the function.
[rubberduck-vba/Rubberduck] build for commit 44b3debf on unknown branch: AppVeyor was unable to build non-mergeable pull request
BUILD FAILURE!
 
 
3 hours later…
Duga
Duga
8:31 AM
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=h1) Report
> Merging [#4383](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f38ebf776c9de99883f2e3aca5e2291f0569bded?src=pr&el=desc) will **decrease** coverage by `3.07%`.
> The diff coverage is `n/a`.


```diff
@@ Coverage Diff @@
## next #4383 +/- ##
==========================
 
Vogel612
Vogel612
Still doesn't work. ...
 
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit f87809e6 on unknown branch: AppVeyor build succeeded
 
 
2 hours later…
Duga
Duga
10:21 AM
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=h1) Report
> Merging [#4383](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f38ebf776c9de99883f2e3aca5e2291f0569bded?src=pr&el=desc) will **decrease** coverage by `3.07%`.
> The diff coverage is `n/a`.


```diff
@@ Coverage Diff @@
## next #4383 +/- ##
==========================
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=h1) Report
> Merging [#4383](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f38ebf776c9de99883f2e3aca5e2291f0569bded?src=pr&el=desc) will **decrease** coverage by `3.07%`.
> The diff coverage is `n/a`.


```diff
@@ Coverage Diff @@
## next #4383 +/- ##
==========================
 
Vogel612
Vogel612
yes, I am intentionally triggering multiple appveyor builds here
bleh. okay appveyor does some stuff that makes me unhappy with the version patching...
 
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit f5b2396e on unknown branch: AppVeyor build succeeded
 
Duga
Duga
10:44 AM
[rubberduck-vba/Rubberduck] build for commit dc26ca33 on unknown branch: AppVeyor build succeeded
 
Duga
Duga
11:04 AM
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=h1) Report
> Merging [#4383](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f38ebf776c9de99883f2e3aca5e2291f0569bded?src=pr&el=desc) will **decrease** coverage by `3.07%`.
> The diff coverage is `n/a`.


```diff
@@ Coverage Diff @@
## next #4383 +/- ##
==========================
[rubberduck-vba/Rubberduck] build for commit d63a5efb on unknown branch: AppVeyor build succeeded
 
Duga
Duga
11:32 AM
[rubberduck-vba/Rubberduck] Vogel612 is bored so why not move a project card
 
Vogel612
Vogel612
WAT
 
Duga
Duga
> This clarifies which project is a test project and which is a "proper" project. It also can help resolve the unclarity in the name RubberduckTestsCodeAnalysis
 
Duga
Duga
12:01 PM
[rubberduck-vba/Rubberduck] Vogel612 moved project card
 
 
1 hour later…
Duga
Duga
1:15 PM
> Just to point out that there is also an ambiguity between the `Rubberduck.CodeAnalysis` Project and the `RubberduckCodeAnalysis` project. The name `Tests.RubberduckCodeAnaylsis` is still easy to mistake as tests for the `Rubberduck.CodeAnalysis` project.

Therefore, the `RubberduckCodeAnalysis` project needs to be renamed, too. Maybe RubberduckInternalCodeAnalyzers`?

Note that the dot was omitted only so the internal codebase analyzers and the test projects would sort to the bottom of lis
 
Duga
Duga
1:41 PM
[rubberduck-vba/Rubberduck] Vogel612 is checking what fun stuff @Duga can say about project cards
[rubberduck-vba/Rubberduck] Vogel612 project card. Enough said.
[rubberduck-vba/Rubberduck] Vogel612 did something with some project card
[rubberduck-vba/Rubberduck] Vogel612 is checking what fun stuff @Duga can say about project cards
[rubberduck-vba/Rubberduck] Vogel612 created project card
[rubberduck-vba/Rubberduck] Vogel612 is checking what fun stuff @Duga can say about project cards
[rubberduck-vba/Rubberduck] Vogel612 project card. Enough said.
[rubberduck-vba/Rubberduck] Vogel612 is playing around with a project card
[rubberduck-vba/Rubberduck] Vogel612 is bored so why not move a project card
[rubberduck-vba/Rubberduck] Vogel612 is checking what fun stuff @Duga can say about project cards
[rubberduck-vba/Rubberduck] Vogel612 did something with some project card
 
mansellan
mansellan
@MathieuGuindon I'm working on a VB6 port of Battleship. Could you add the graphics assets for the shapes to the GH repo please?
 
this
this
@Duga @Vogel612 I think Duga is on to you...
 
Vogel612
Vogel612
shhh
yea she is
Just added some more cards to the Automated Progress Bar
Every time I do that, I'm miffed that there is no actual real automation for that stuff built into GH
 
mansellan
mansellan
 
Duga
Duga
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=h1) Report
> Merging [#4383](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f38ebf776c9de99883f2e3aca5e2291f0569bded?src=pr&el=desc) will **decrease** coverage by `3.07%`.
> The diff coverage is `n/a`.


```diff
@@ Coverage Diff @@
## next #4383 +/- ##
==========================
 
Vogel612
Vogel612
1:51 PM
I dropped another almost 200 lines from the csproj files because the new format allows omitting quite a bunch of System.* references that are automatically added
great fun to do that
 
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit 7ace924a on unknown branch: AppVeyor build succeeded
 
this
this
Nice, @Vogel612 --- this might be of interest for suppressing the wanted MSB warning
 
Vogel612
Vogel612
@this that's going to be helpful for both the AssemblyVersion wildcard issue as well as the Sdk reimporting issue. Nice :)
BBIAB, reviews on the PR highly appreciated. I think I'm not going to get to do a lot more development on it the next two weeks
I'll be moving tomorrow (distance: ~2km) and the usual Uni stuff is starting again. Gonna be hectic for a while...
 
this
this
2:07 PM
Cool. Have fun until then!
 
Duga
Duga
2:59 PM
> Okay I think I'm done now. For me locally running the BuildRegistry script still fails from within VisualStudio. I haven't attempted to run it in msbuild alone. If I run the exact command that VS should run in a powershell host it works as expected and correctly registers the build.

As such I'm assuming that VS is somehow at fault.

The problem with XAML has been symptomatically fixed, pending a more in-depth diagnosis of the underlying problem. I unfortunately am not remotely knowledgea
 
Vogel612
Vogel612
^^ I may possibly need to adjust the version patching to also patch the Rubberduck.Core csproj. As it stands 2.2.0 is hardcoded as AssemblyVersion on that one to fix the issue with XAML. As mentioned I'm not able to really add more to the diagnosis there, though.
 
Duga
Duga
3:35 PM
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4426?src=pr&el=h1) Report
> Merging [#4426](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4426?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f44d56561b2784dea3303afbe0a3862a9cb1eeb9?src=pr&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `n/a`.


```diff
@@ Coverage Diff @@
## next #4426 +/- ##
==========================
 
Vogel612
Vogel612
bleh. msbuild warning ignores are just a bit underpowered
 
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit 1d47b077 on unknown branch: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 1d47b077 on unknown branch: 59.92% (target 0%)
> I had realized my original trace implementation was totally boneheaded. As a result, I made the decision to split the logs into 2 files; one for reporting the contents at the instant within the COM Safe and other for tracing the activity within the COM safe.

They can be correlated using Excel, with column `Key`, which is derived from the hash codes, which will enable us to see which GC'd SCWs came from and how long they were in the safe.

I also have overloaded the `Serialize` button to a
 
Vogel612
Vogel612
3:53 PM
hmm ... it seems like Visual Studio is being a prick about how warnings are handled
 
this
this
RE: VS not running the build registry -- what error do you get?
 
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit ade00996 on unknown branch: AppVeyor build succeeded
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4434?src=pr&el=h1) Report
> Merging [#4434](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4434?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f38ebf776c9de99883f2e3aca5e2291f0569bded?src=pr&el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `80.18%`.


```diff
@@ Coverage Diff @@
## next #4434 +/- ##
=======================
 
Vogel612
Vogel612
@this still the same issue.
 
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit ade00996 on unknown branch: 60.05% (target 0%)
 
Vogel612
Vogel612
also VisualStudio of course has it's own csproj build switch to disable / ignore warnings
this is so incredibly annoying
 
Duga
Duga
3:58 PM
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4434?src=pr&el=h1) Report
> Merging [#4434](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4434?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f38ebf776c9de99883f2e3aca5e2291f0569bded?src=pr&el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `80.18%`.


```diff
@@ Coverage Diff @@
## next #4434 +/- ##
=======================
 
this
this
sorry, I don't remember the original issue - did it emit any error or warning in the output when building locally?
 
Vogel612
Vogel612
yea, gimme a sec I can paste you the latest mishap when the build finishes
 
this
this
OK
 
Vogel612
Vogel612
powershell apparently currently holds a lock to the Deployment dll.
and of course the damn NoWarn still doesn't effing work
Alright, here you go: 
16>    WARNUNG: Cannot locate the VsDevCmd.bat to initialize C++ build tools; falling back to
16>    tlbexp.exe....
16>
16>    Processing 'Rubberduck.dll'
16>
16>    Microsoft (R) .NET Framework Assembly to Type Library Converter 4.6.1055.0
16>    Copyright (C) Microsoft Corporation.  All rights reserved.
16>
16>    Assembly exported to 'F:\cleme_000\Desktop\Programming\Rubberduck\Rubberduck.Deployment\bin\Rubberduck.x32.tlb'
16>    Microsoft (R) .NET Framework Assembly to Type Library Converter 4.6.1055.0
 
Duga
Duga
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=h1) Report
> Merging [#4383](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f38ebf776c9de99883f2e3aca5e2291f0569bded?src=pr&el=desc) will **decrease** coverage by `3.07%`.
> The diff coverage is `n/a`.


```diff
@@ Coverage Diff @@
## next #4383 +/- ##
==========================
 
this
this
4:12 PM
@Vogel612 do you see any *.dll.xml files generated in the build directory?
 
Vogel612
Vogel612
yes. one for Rubberduck and one for Rubberduck.API
 
this
this
and they do have their corresponding *.tlb.xml files, right?
 
Vogel612
Vogel612
x32.tlb.xml yes, but not x64.tlb.xmls
 
this
this
welp, interesting.
 
Duga
Duga
 
this
this
4:17 PM
I pulled from the branch; building it now to verify it's fine locally -- I suspect it will succeed because I'll be going down the wrong branch
after that, I'll force the branching and see what really happens when I use tlbexp
 
Vogel612
Vogel612
bleh. 3.8k warnings
 
this
this
why is it that when I pull something the startup project changes to Rubberduck.Parsing?
 
Duga
Duga
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=h1) Report
> Merging [#4383](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f38ebf776c9de99883f2e3aca5e2291f0569bded?src=pr&el=desc) will **decrease** coverage by `3.07%`.
> The diff coverage is `n/a`.


```diff
@@ Coverage Diff @@
## next #4383 +/- ##
==========================
 
Vogel612
Vogel612
@this If I had to guess: because I regularly unload Deployment when building to avoid the error message and the solution for whatever reason defaults to Parsing then.
 
this
this
ah, no wonder
huh. even forcing the tlbexp branch, it builds for me.
 
Vogel612
Vogel612
4:23 PM
probably just my system being wonky then.
I'm not really surprised
 
this
this
1>Rubberduck.Deployment -> C:\GitHub\Rubberduck\Rubberduck2\Rubberduck\Rubberduck.Deployment\bin\Rubberduck.Deployment.dll
1>
1>GAC    Version        Location
1>---    -------        --------
1>False  v4.0.30319     C:\GitHub\Rubberduck\Rubberduck2\Rubberduck\Rubberduck.Deployment\bin\Rubberduck.Deployment.dll
1>
1>Processing 'Rubberduck.dll'
1>
1>Microsoft (R) .NET Framework Assembly to Type Library Converter 4.6.1055.0
1>Copyright (C) Microsoft Corporation.  All rights reserved.
1>
1>Assembly exported to 'C:\GitHub\Rubberduck\Rubberduck2\Rubberduck\Rubberduck.Deployment\bin\Rubberduck.x32…
so I did get the same warning, which I expected to be harmless
on the basis that we should be using Any CPU
 
Vogel612
Vogel612
we still are defaulting to AnyCPU just as before
 
this
this
ok, and I now remember that I don't need to generate the .tlb.xml for the x64.
 
Vogel612
Vogel612
nice
 
this
this
so having only .tlb.xml for x32 is enough
Therefore, the error must be here:
$content = $writer.Write($entries, $dllFile, $tlb32File, $tlb64File);
the line 234
the error handling in the posh script sucks.
 
Vogel612
Vogel612
4:29 PM
open a [tech-debt] issue if you're not going to adress it now/soon, please
 
this
this
ok
 
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit fe3fc7c5 on unknown branch: AppVeyor build succeeded
 
Vogel612
Vogel612
welp. 5.6k warnings/messages
 
Duga
Duga
> As reported by @Vogel612, the script may fail to build with an obscure write error.

It is most likely that the error is on [line 234](https://github.com/rubberduck-vba/Rubberduck/blob/next/Rubberduck.Deployment/BuildRegistryScript.ps1#L234):
```
$content = $writer.Write($entries, $dllFile, $tlb32File, $tlb64File);
```

It has been verified that all the necessary files such as `*.dll.xml` and `*.tlb.xml` has been already generated by the `heat.exe` and the `tlbexp.exe`. This issue is al
[rubberduck-vba/Rubberduck] bclothier created project card
[rubberduck-vba/Rubberduck] build for commit 0986130e on unknown branch: AppVeyor build succeeded
 
Vogel612
Vogel612
^^ alright 660 warnings. Seems much more reasonable
 
this
this
4:42 PM
as long we don't add 6 more warnings.
 
Vogel612
Vogel612
4:53 PM
interestingly I got 566 warnings locally...
oh well
 
IvenBach
IvenBach
5:22 PM
@Vogel612 how much longer till graduation?
 
Vogel612
Vogel612
@IvenBach depends on how fast I want to go
need only a handful of credits, I should be finished with lectures after this semester
and then I also need to write a bachelor's thesis
basically: 6-8 months + the time to grab a thesis topic
and then I'll start doing a Master's degree
which is two years in theory, but I think I'll take that slow as well
 
Duga
Duga
5:39 PM
[rubberduck-vba/Rubberduck] web-flow pushed commit 2106f8c6 to coverage-ignore-designers: Ignore autogenerated Designer-Files in coverage
 
Duga
Duga
5:51 PM
[rubberduck-vba/Rubberduck] build for commit 2106f8c6 on coverage-ignore-designers: AppVeyor build succeeded
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4437?src=pr&el=h1) Report
> Merging [#4437](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4437?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f38ebf776c9de99883f2e3aca5e2291f0569bded?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.


```diff
@@ Coverage Diff @@
## next #4437 +/- ##
==========================
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4437?src=pr&el=h1) Report
> Merging [#4437](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4437?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f38ebf776c9de99883f2e3aca5e2291f0569bded?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.


```diff
@@ Coverage Diff @@
## next #4437 +/- ##
==========================
 
Duga
Duga
6:22 PM
 
Mathieu Guindon
Mathieu Guindon
@mansellan done! :)
 
Duga
Duga
> not true. the panel doesn't tell you any more than you can already infer from the game grid.
 
Duga
Duga
7:05 PM
Merge pull request #4437 from rubberduck-vba/coverage-ignore-designers

Ignore autogenerated Designer-Files in coverage
 
Mathieu Guindon
Mathieu Guindon
@Vogel612 @this should #4072 be closed/rejected then?
 
Vogel612
Vogel612
@MathieuGuindon eh, I'm taking that one over, so not really
not sure why we'd want to reject that one. We need the changes to get the EM refactoring in properly
 
Mathieu Guindon
Mathieu Guindon
just to clean up the conversation history.. it's been open for a while
 
Vogel612
Vogel612
I don't really care either way, actually. I just need to keep the reference to fetch the changes to my machine
 
Mathieu Guindon
Mathieu Guindon
7:20 PM
there's a number of old PRs I'd love to merge, but that are currently conflicted. @IvenBach's #4217 and @ThunderFrame's #4225, mostly
@Vogel612 I'll just leave it alone then
 
Duga
Duga
 
this
this
@MathieuGuindon just a reminder - need that graphic files
 
Duga
Duga
[rubberduck-vba/Rubberduck] comintern pushed commit 6142332d to next: Make string escapes consistant with brackets, fix reuilding. Closes #4431
Merge pull request #4433 from comintern/indenter

Make string escapes consistant with brackets, fixes indenter bug
[rubberduck-vba/Rubberduck] build for commit dd0c31bf on next: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit dd0c31bf on next: 59.93% (target 0%)
 
this
this
@MathieuGuindon I'll keep it current and I hope to work on it until @Vogel612 is ready to take it over.
 
Mathieu Guindon
Mathieu Guindon
@this emailed it
 
this
this
7:25 PM
I got nerdsniped with the desire to knock off the issue RE: ghost in Access process, which was the primary driving reason for the serialize thing
Got it, thanks!
I will make a new PR for that issue later tonight after I do my thing
 
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit 8455e110 on next: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 8455e110 on next: 59.92% (target 0%)
 
Duga
Duga
7:49 PM
[rubberduck-vba/Rubberduck] Vogel612 deleted branch coverage-ignore-designers
 
Duga
Duga
8:16 PM
[rubberduck-vba/Rubberduck] web-flow pushed commit 91cf0d87 to next: fix designer ignoring glob
 
Vogel612
Vogel612
@Duga bleh, that one was my bad ...
 
Duga
Duga
[rubberduck-vba/Rubberduck] build for commit 91cf0d87 on next: AppVeyor build succeeded
[rubberduck-vba/Rubberduck] build for commit 91cf0d87 on next: 63.71% (target 0%)
 
Vogel612
Vogel612
gee... and I efffed up the ignore for ***.xaml.cs files... again
 
Duga
Duga
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4434?src=pr&el=h1) Report
> Merging [#4434](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4434?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f38ebf776c9de99883f2e3aca5e2291f0569bded?src=pr&el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `80.18%`.


```diff
@@ Coverage Diff @@
## next #4434 +/- ##
=======================
 
Duga
Duga
8:40 PM
[rubberduck-vba/Rubberduck] build for commit 60ce8076 on unknown branch: AppVeyor build succeeded
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4434?src=pr&el=h1) Report
> Merging [#4434](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4434?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f38ebf776c9de99883f2e3aca5e2291f0569bded?src=pr&el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `80.18%`.


```diff
@@ Coverage Diff @@
## next #4434 +/- ##
=======================
[rubberduck-vba/Rubberduck] build for commit 60ce8076 on unknown branch: 60.04% (target 0%)
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4434?src=pr&el=h1) Report
> Merging [#4434](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4434?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f38ebf776c9de99883f2e3aca5e2291f0569bded?src=pr&el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `80.18%`.


```diff
@@ Coverage Diff @@
## next #4434 +/- ##
=======================
 
Vogel612
Vogel612
8:58 PM
hmm ... MSBuild is trying to not work the way I want it to, it seems...
> Invalid static method invocation syntax: ".Substring(0, [System.String]::Copy('%(Filename)').LastIndexOf('.'))". Method 'System.String.Substring' not found. Static method invocation should be of the form: $([FullTypeName]::Method()), e.g. $([System.IO.Path]::Combine(a, b)).
 
Blogging Duck
Blogging Duck
9:26 PM
Rubberduck News: Clean VBA Code pt.1: Bad Habits
posted on October 14, 2018 by Rubberduck VBA

We know clean code when we see it. Clean code is a pleasure to read and maintain. Clean code makes its purpose obvious, and is easily extended or modified. I cannot recommend Robert C. Martin’s Clean Code: A Handbook of Agile Software Craftsmanship enough – to me it was an eye opener. Code examples are in Java, but the… Continue reading Clean VBA Code pt.1: Bad Habits …

 
Vogel612
Vogel612
9:57 PM
poke @this. I think the fragile DependentUpon nesting you criticised didn't even work in the first place
I should remember how this worked though...
Something something MSBuild Substring: 
<Resource Update="**\*.*.resx">
  <Generator>PublicResXFileCodeGenerator</Generator>
  <LastGenOutput>$([System.String]::Copy('%(FileName)')).Designer.cs</LastGenOutput>
  <DependentUpon>$([System.String]::new('%(Filename)').Substring(0, [System.String]::new('%(Filename)')'.LastIndexOf(&quot;.&quot;))).resx</DependentUpon>
</Resource>
that [System.String]::new() hack is really weird...
TTGTB...
 
Duga
Duga
 
Vogel612
Vogel612
Toodles!
 
Duga
Duga
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=h1) Report
> Merging [#4383](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/f38ebf776c9de99883f2e3aca5e2291f0569bded?src=pr&el=desc) will **decrease** coverage by `3.07%`.
> The diff coverage is `n/a`.


```diff
@@ Coverage Diff @@
## next #4383 +/- ##
==========================
 
Duga
Duga
10:13 PM
[rubberduck-vba/Rubberduck] build for commit 1715c4ba on unknown branch: AppVeyor build succeeded
 
Tweeting Duck
Tweeting Duck
Clean VBA Code pt.1: Bad Habits https://rubberduckvba.wordpress.com/2018/10/14/clean-vba-code-pt-1-bad-habits/
Tweeted by rubberduckvba on October 14, 2018 at 9:10 PM
 
Duga
Duga
 
Duga
Duga
10:50 PM
> This was closed along with #4364 (duplicate)
[rubberduck-vba/Rubberduck] comintern is bored so why not move a project card
> This was fixed by changes in 3a5e485.
[rubberduck-vba/Rubberduck] comintern is playing around with a project card
 
Duga
Duga
11:30 PM
 
Peter M Taylor
Peter M Taylor
11:42 PM
Thanks @MathieuGuindon for this blog. Added to my bedtime reading. Interesting thoughts to consider...
 
Duga
Duga
11:54 PM
> This seems to have already been resolved in next - the setting is changed to disabled, and results no longer appear in future inspections.
[rubberduck-vba/Rubberduck] comintern is playing around with a project card
 

« first day (1591 days earlier)      last day (1589 days later) »