VBA Rubberducking

Mathieu Guindon

11:02 PM

@Comintern no, but setting the selection to the target site should be

but yeah, must have something to do with the step that involves nuking all content =)

IvenBach

:grumble: It built before without error.

Duga

[rubberduck-vba/Rubberduck] Vogel612 added label enhancement to issue #4382: Cursor position changes to top of module after applying any fix

[rubberduck-vba/Rubberduck] Vogel612 added label feature-refactorings to issue #4382: Cursor position changes to top of module after applying any fix

[rubberduck-vba/Rubberduck] Vogel612 added label feature-inspection-quickfixes to issue #4382: Cursor position changes to top of module after applying any fix

IvenBach

2018-09-20 16:04:35.6196;FATAL-;Rubberduck._Extension;Startup sequence threw an unexpected exception.;Castle.MicroKernel.ComponentActivator.ComponentActivatorException: ComponentActivator: could not instantiate Rubberduck.UI.CodeExplorer.CodeExplorerWindow ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.Windows.Markup.XamlParseException: 'Initialization of 'System.Windows.Media.Imaging.BitmapImage' threw an exception.' Line number '27' and line position '50'. ---> System.IO.IOException: Cannot locate resource 'icons/cus…

Comintern

@MathieuGuindon Oh duh. I was thinking of the CodeModule, not the CodePane.

Why does Travelocity want to send me to Warsaw or Budapest?

Vogel612

@IvenBach check whether the file is present in the solution explorer.

IvenBach

11:06 PM

Nothings coming up.

Vogel612

if it isn't try "add existing item" and reference it from there

IvenBach

Where should it be located at?

Vogel612

aaand the old csproj format strikes again

Rubberduck.Resources/Icons/[...]

IvenBach

I've navigated to the folder that contains it. Just drag-n-drop to add?

Vogel612

nah. use "add existing item" from the Solution Explorer context menu

Duga

11:09 PM

[rubberduck-vba/Rubberduck] build for commit dec571a8 on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4292: Allow resizing of fonts in CodeExplorer

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4292?src=pr&el=h1) Report
> Merging [#4292](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4292?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/6d4087b79e994e25ccdf31be6856ee05e25d2186?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `25%`.

```diff
@@ Coverage Diff @@
## next #4292 +/- ##
==========================

[rubberduck-vba/Rubberduck] build for commit dec571a8 on unknown branch: 56.85% (target 0%)

IvenBach

:sigh: I did drag-n-drop. Lets see if that works if not I'll follow the sage advice of Vogel.

Comintern

Don't you want to move the file into the folder first, then "add existing item".

IvenBach

The file already exists in the folder.

Comintern

I just realized I've never tried to drag and drop into the solution explorer.

Oddly, the thought never occurred to me.

Vogel612

@Comintern It was already in the folder, but apparently the solution item reference used to point to the zombie RetailCoder.VBE folder

IvenBach

11:11 PM

I don't understand anything ya'll discuss about csproj stuff

Vogel612

and I just deleted the file without checking the Solution explorer, because I regularly forget how annoyingly stupid that file format is

Duga

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4292: Allow resizing of fonts in CodeExplorer

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4292?src=pr&el=h1) Report
> Merging [#4292](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4292?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/6d4087b79e994e25ccdf31be6856ee05e25d2186?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `25%`.

```diff
@@ Coverage Diff @@
## next #4292 +/- ##
==========================

Comintern

^

Vogel612

@IvenBach long story short the csproj file just pretends to do anything remotely related to the file system

Comintern

Maybe somebody will make it git friendly for hacktoberfest. Not holding my breath though.

Vogel612

11:13 PM

every solution explorer item has it's own path that's mapped to a physical path

and those are not necessarily the same

which can make for ... annoying crap like the resource being where you'd expect it on the filesystem, but actually pointing to something completely different elsewhere

IvenBach

Still getting error after adding it both ways.

Vogel612

huh.

IvenBach

Added addmdiform.png via drag-n-drop and as Add>Existing Item via context menu.

Vogel612

check the CodeExplorer xaml markdown's "resources" section for where the image is loaded

IvenBach

Is XAML case sensitive?

Vogel612

11:17 PM

I wouldn't be terribly surprised if it was...

neither would I be surprised if it wasn't.

IvenBach

It's pointing to the correct file and casing was edited to be identical. Same error.

Cleaned and rebuilt solution didn't help either.

Vogel612

hrm ....

Comintern

Does the diff of the csproj look reasonable?

IvenBach

Only <Content Include="Icons\Custom\PNG\AddMdiForm.png" /> has been added.

Vogel612

> Line number '27' and line position '50'.

... seems to fit there exactly...

and the diff seems appropriate

IvenBach

11:23 PM

Hrm.... Lemme discard changes and retry.

If nothing else all my floundering in git has given me enough skills to delete and recreate branches without fear.

Comintern

Did you set the build action to resource?

IvenBach

build action?

:thinks: I vaguely recall someone telling me about a build action prior.

Vogel612

build action is available in the solution explorer item properties

IvenBach

Which build action?

It's currently Content

Vogel612

make it "Resource"

Comintern

11:30 PM

Of the icon. Select it and Alt-Enter or right-click -> properties.

IvenBach

@Vogel612 :derp: I should have checked the other resources.

Vogel612

comintern mentioned it above :)

IvenBach

~~Still crashing.~~ Throws error on loading.

Progress. Different error message.

Duga

[rubberduck-vba/Rubberduck] Vogel612 created pull request #4383: Csproj format update, fixes #3944 to merge Vogel612/Rubberduck/csproj-format-update into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] Vogel612 added label PR-Status: WIP to pull request #4383: Csproj format update, fixes #3944

[rubberduck-vba/Rubberduck] Vogel612 added label technical-debt to pull request #4383: Csproj format update, fixes #3944

Vogel612

@Duga if that builds, one of the big issues with the move is safely done

this

11:36 PM

did you get deployment to work?

Vogel612

not locally, but that's not really a criterion for success right now

IvenBach

Is my only recourse right now to add each file, Build Action: Resource, Clean, Build repeat?

Vogel612

possibly...

this

wow, 35K just for csproj changes

Vogel612

you might be able to bulk-change the build actions, though

@this yea and I've only touched like ... three projects

IvenBach

11:39 PM

@Vogel612 Should all the files within that folder be added and be Build Action: Resource?

Vogel612

NLog.Schema added the xml-schema-definition of the NLog-config.xml to every project, which accounts for 6kLoC every project

@IvenBach yes

IvenBach

:whew: Turned out to be only 4 or 5 files that were missing.

Vogel612

@this most of that is in this single commit

IvenBach

@Comintern My inexperience with VS makes the obvious difficult. I should remember next time around when adding resource files.

Comintern

I always forget until I try to build the first time.

IvenBach

11:43 PM

I'm getting there.

Duga

[rubberduck-vba/Rubberduck] IvenBach synchronized pull request #4217: Allow filtering of results in CodeInspections window

[rubberduck-vba/Rubberduck] build for commit 770bd4e3 on unknown branch: AppVeyor was unable to build non-mergeable pull request

BUILD FAILURE!

[rubberduck-vba/Rubberduck] build for commit 555993e5 on unknown branch: AppVeyor build failed

BUILD FAILURE!

Vogel612

@Duga welp.

Comintern

The .resx file? Seriously?

this

@Vogel612 fascinating. it failed the entire code analysis test.

Vogel612

I may or may not have updated the dependencies on that ...

this

11:47 PM

at least it's building.

Duga

[rubberduck-vba/Rubberduck] IvenBach synchronized pull request #4217: Allow filtering of results in CodeInspections window

IvenBach

I'm just trying to keep my open PR up to sorta up to date.

@Duga @MathieuGuindon I think the WIP label is stale on that one. All my PR are resulting in Not Run for TestEngine_* and once those are resolved I think this PR should be good to go.

Home time.

Duga

[rubberduck-vba/Rubberduck] Vogel612 removed label PR-Status: WIP from pull request #4217: Allow filtering of results in CodeInspections window

[rubberduck-vba/Rubberduck] Vogel612 added label PR-Status: Review Requested to pull request #4217: Allow filtering of results in CodeInspections window

IvenBach

Thanks for the help @pond.

this

I wonder what is the function of Deterministic property in the new csproj. I saw the description but not seeing the why.

Vogel612

11:54 PM

@this wildcard / autoincrement assembly versions produce a build warning

unless the Deterministic property is set to false

puzzlepiece87

@Duga Nice work @IvenBach

Duga

[rubberduck-vba/Rubberduck] build for commit 3b946446 on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/marketplace/codecov) edited comment on pull request #4217: Allow filtering of results in CodeInspections window

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4217?src=pr&el=h1) Report
> Merging [#4217](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4217?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/6d4087b79e994e25ccdf31be6856ee05e25d2186?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `7.79%`.

```diff
@@ Coverage Diff @@
## next #4217 +/- ##
========================

[rubberduck-vba/Rubberduck] build for commit 3b946446 on unknown branch: 56.78% (target 0%)

Transcript for