it would be handy if I could s.LinesBetweenProcesures = MaximumVerticalSpacing to not have to rewrite the test, but it would be hard to dynamically adjust the expected to match... :/
Ok, so I've updated VerticalSpacintTests.csand F6'd. Do I need to run all tests now? It seems reasonable to just run the 18 VerticalSpacingTests, or RubberDuckTests.SmartIndenter at the max...
writing tests seems to be somewhat painful, but a not-horrible way of learning one's way around the code. for some totally unknown value of not-horrible
in Computer\HKEY_CLASSES_ROOT\CLSID\{28754D11-10CC-45FD-9F6A-525A65412B7A} I've got a (Default) item. Do I just delete the item or do I need to delete the GUID, too?
Dim oRange As Range
Dim dict As Dictionary
Dim vArray As Variant
Dim vItem As Variant
Dim sKey As String
Dim sValue As String
Dim iCompare_TRUE As Integer
Dim lCnt As Long
Dim lCnt_Rows As Long
public virtual int LinesBetweenProcedures
{
get => _procedureSpacing;
set => _procedureSpacing = value > MaximumVerticalSpacing ? MaximumVerticalSpacing : Math.Max(value, 0);
}
Looks like there's already a getter/setter in IndenterSettingsViewModel
private int _procedureSpacing;
public int LinesBetweenProcedures
{
get => _procedureSpacing;
set
{
if (_procedureSpacing != value)
{
_procedureSpacing = value;
OnPropertyChanged();
}
}
}
> Some note to indicate the status of the PR. Due to changes in how dialogs are set up, unit tests need to be re-written to assert that the behavior is equivalent. That is also a challenge because some of unit tests are in fact testing the UI itself, and some of them may no longer applier or needs to be rewritten (rather than merely updated).
To enable the branch to build, a number of unit tests were excluded from the test project temporarily in order to focus on a specific subset of refactor
@Duga @Vogel612 hopefully that gives enough context to see where I'm at. If there's anything else not clear, just let me know and I'll fill in the gaps. :)
VBA Rubberducking
VBA Rubberducking