Thank you, thank you very much.

Private Sub Class_Initialize()
    Set viewModel = Me
End Sub

^ Gives me RTE28 Out of stack space.

poke @this question: you gonna pick up the refactoring dialog refactor PR?

because it's been bobbing up and down for two months now

I'm kinda tempted to go and do some work on that myself

I understand the issue since every time its accessing either member (Username or Password) it's accessing that member on itself ad-infinitum until stack overflow.

@IvenBach is loginModel predeclared?

@Comintern Nope.

[rubberduck-vba/Rubberduck] Vogel612 pushed commit 117639d4 to next: Kill the RetailCoder.VBE folder ... again

RetailCoder keep coming back.

the folder is dead, long live the folder

the lack of tabcomplete for branchnames on windows is really annoying

Private Sub Class_Initialize()
    Set viewModel = New LoginDialogModel
End Sub

disincentivizes long branchnames

Gives me the same thing of RTE28.

I'm missing the obvious but can't figure it out.

@Duga for the record: I moved over the Icon to where it's been stored since back when the resources were split out and git didn't mark that as a change, soo ...

@Vogel612 this is annoying me to no ends. I have commitments for next 2 or 3 weeks and my work is crazy so I don't see actually getting to it until October. :( That said, if you think you can do better, by all means go wild on it.

Time for a walk. Hopefully that'll clear the fog.

I still need this to be done so I can get back to EM which still needs doing.

aight :)

Sorry about that

then this comes into my somehow ever-growing queue of stuff I'll chew on instead of working for money

hopefully that lands you a great job as it did Hosch

honestly landing a job is not really an issue as of now

landing a job where I'd like to work on the code might be a bit more of an issue :D

this is more of a: Oh I got some time and energy to spend on something I enjoy, how about I examine the PRs currently in the repo that have a Review-Requested on them and check what I can do about that

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Rubberduck-v2.2.0.3795

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Rubberduck-v2.2.0.3795

[rubberduck-vba/Rubberduck] build for commit 117639d4 on next: AppVeyor build succeeded

heh. that's usually the reason why one is paid to do it, some amount of drugedgy is expected, even if you generally like doing it

[rubberduck-vba/Rubberduck] build for commit 117639d4 on next: 57.19% (target 0%)

@this you know how Rubberduck has the Declaration class?

I'm supposed to do the equivalent of completely replacing Declaration and DeclarationFinder with a new single class

oh yeah. that's even more drastic than my refactoring of dialogs would be

the API isn't quite as humungous, but it's still like ... I need to touch basically every codefile in the whole codebase in nontrivial ways

^

and it's not like there's any unit-tests around

you're basically replacing the whole head + spine

my PR is just replacing wings or tail

like... in RD doing that is manageable

because we do have almost 60% coverage

which reminds me... I could exclude xaml files from coverage

That makes sense. We shouldn't measure what can't be tested

that alone will probably get the coverage from 57% to something closer to 70%, if not beyond that

not that we should hunt that metric.

but at least I am not going to write UI tests

@Duga So... I guess I should do that, then, eh?

@FreeMan just updating your fork to be even with next should be quite enough already :)

#TIL VS does have UI tests

@Vogel612 hrm... thought I did that when I checked those icons in.

The necromancer arrives.

@FreeMan Were you going to be going after #4374?

welp ... yay for another 35k deletions to my name

[rubberduck-vba/Rubberduck] IvenBach created comment on issue #4374: Feature Request - Allow indenter more vertical spacing rows

> When Maintain vertical spacing is set to 0 the indented code sample disappears.

@Duga wut?

@Duga 'scuse me?

[rubberduck-vba/Rubberduck] IvenBach edited comment on issue #4374: Feature Request - Allow indenter more vertical spacing rows

Image uploaded.

I pulled off next earlier today.

Screenshot not required, just replicated it.

wow

I found the easter egg.

congrats, you win two internet

That's not the settings, that's the indenter.

> 2018-09-18 17:38:55.4438;ERROR-2.2.6821.38911;Rubberduck.UI.Command.IndentCurrentModuleComm‌​and;System.InvalidOperationException: Sequence contains no elements

Boy oh BOY! Just what I've always wanted.

cue the anchorman bob image

Not Bob from Office Space?

So HTH is VerticalSpacing_RemoveAllExtraLinesWorks() passing... Hmmm...

This is what we get for having software made by amateurs.

^

Apparently I'm one of them. This is pretty bone-headed:

if (_lines.Count <= 1)
{
    return _lines.First().Indent(IndentationLevel, AtProcedureStart);
}

I figured it was worth a duh check to see what would happen if I applied -1.

@IvenBach That shouldn't make it out of the XML file.

welp ... wildcard versions are considered "nondeterministic" by the new csproj format

dis gon be fun

@Comintern I was planning on it.

OK, I'll stay out of the settings then.

@Vogel612 went ahead and did the git clean -xdf nuke from orbit, just to be sure.

[rubberduck-vba/Rubberduck] comintern created comment on issue #4374: Feature Request - Allow indenter more vertical spacing rows

> @IvenBach Unrelated, but don't bother to open an issue - fixed in my next PR.

@Duga @Comintern Did I understand the words incorrectly, again?

Nope. The root issue was tangential to the feature request.

hey @Vogel612 would you happen to have the ducky outline artwork nearby?

not right now, no...

k

try around here

apparently chat allows you to search for images you posted by searching for the message text "image"

fun stuff

oooooh

hey @Hosch250

Since when did CR get this BS about the redesign?

It must've rolled out since between when I left work and now...

IDK I had the beta enabled for a while

@Hosch250 huh? it's no longer beta?

No.

I just noticed it was different on the preview on my home page.

So I opened it, and was like "oh...".

Anyway, hi, @MathieuGuindon. What's up?

@Hosch250 ugh. Not A Fan™

why?

elaborate, make a comment on the meta post

It's the mega tidal flow toward that "material" design concept that's been adopted by Android and MS. There's no fighting it.

Home Time.

@Vogel612 I think there were a few more places than the presenters and the command menu items where the commands get injected. I believe to remember that there was something with the shortcut key hooks as well.

yea, the keyboard hooks are created by a factory

which gets an IEnumerable<CommandBase>. I haven't touched that registration

Hotkeys still worked

@MathieuGuindon In IndenterSettings.cs, I'd take a stab that I need to change the last line here:

namespace Rubberduck.SmartIndenter
{
    [XmlType(AnonymousType = true)]
    public class IndenterSettings : IIndenterSettings, IEquatable<IndenterSettings>
    {
        // These have to be int to allow the settings UI to bind them.
        public const int MaximumAlignDimColumn = 100;
        public const int MaximumEndOfLineCommentColumnSpaceAlignment = 100;
        public const int MaximumIndentSpaces = 32;
        public const int MaximumVerticalSpacing = 2;

FutureProof™

for issue 4374, BTW