VBA Rubberducking

Hosch250

20:00

Oh, wait, I get it.

this

UTs aren't supposed to be stateful

Hosch250

MS Test had an attribute where we could reference the actual compiled stuff.

It would generate the stuff and put it in that directory.

this

[Test]
[DeploymentItem(@"Testfiles\")]
[Category("Inspections")]

Hosch250

NUnit doesn't have that, so I wrote a before action that handles it.

this

so i assume we don't want that Deployment

?

Hosch250

20:00

Yes, the DeploymentItem.

Well, we do.

this

hmm, ok.

Hosch250

Because we have to read stuff at that directory in the test, don't remember the details ATM.

We almost couldn't go to NUnit because of that.

this

unfortunately running it on its own it's OK.

Hosch250

FWIW, it probably should be "fixed" to not use that.

@this Running in parallel, maybe?

this

hmm don't think so - it's not highlighted (the parallel button)

blargh I get more failing UTs when I run all again

slightly different error about access denied to some subfolder in the TestFiles.

Hosch250

20:05

Probably one is still cleaning up when the other tries to write.

this

so now what? I summon an unicorn to make it magically better?

yeah it's unstable now. failing randomly.

not same UTs will fail; it might be all the luck of the draw.

what did change was that I added more nuget packages to the RubberduckTests project...

in order to integrate the code analyzer tests

FreeMan

20:29

@Hosch250 What the heck is "Windows S mode"?

Hosch250

@FreeMan Minimal Windows. For non-admins.

IIRC it's cheaper, and it doesn't have any admin tools.

I think it's a little lighter than Home, even.

Please send moral support. I'm going down the rabbit hole.

FreeMan

ah. and that now seems to be the default install. yeesh... I guess it makes sense for the majority, though.

Hosch250

I'm going to end up rewriting an enormous chunk of the backend of our widget.

this

left side makes you bigger, right side makes you smaller.

good luck!

FreeMan

I thought it was "eat me" that made you smaller and "drink this" that made you bigger...

this

20:38

in movie yes

Vogel612

@this yea I regularly have these. usually they fix themselves with a "rerun failed"

this

in book, there is a part where she has a mushroom; one side makes biger, other smaller

Hosch250

@this What happens if I flip the mushroom over?

this

you go into a negative dimension

@Vogel612 :( it's regularly failing

Vogel612

@this no. it's intermittently failing

nondeterministically at that

this

20:40

sure, on different tests

but i can't just re-run

Vogel612

on AV, you mean?

this

every runs has always resulted in 2-10 tests failing

no local

and I did not have this problem until just now

Vogel612

rerun failed doesn't fix it?

this

wait I didn't actually rerun only the failed

but that's only... cheating.

it shouldn't be non-deterministic....

Vogel612

yea, it shouldn't be

but we know that it's not the unit test that's failing, but the context setup for that unit test

and I haven't seen that behaviour on AV yet

soo ... it's a good enough hack for now.

FreeMan

20:43

@this not sure I've ever read the books

Vogel612

if you want to fix it, I recommend doing so in a separate PR :)

and I wish you the best of luck in that endeavour.

this

it worries me though - if I didn't have to do it until now.... then there's no guarantee whatever is making it not working consistently work consistently in AV

Vogel612

Because you're right: they shouldn't be failing for that

this

@FreeMan ya totally missed out

the movie cut out many of goodies. There's no Bruno and Slyvie... I love those more than any other characters.

Vogel612

@this I'd opt for fixing that when the time comes

FreeMan

20:44

yeah, the books are usually way better than the movies. Unless, of course, the movie came first.

Mathieu Guindon

@this any issues with 4.6?

@Thanatosyletus @KyleLJohnson @dotnet I really hope you're wrong here, we're updating everything to 4.6... would love to hear what issues to expect! Feel free to chip in: https://stackoverflow.com/a/50121885/1188513

Tweeted by rubberduckvba on May 1, 2018 at 8:40 PM in reply to Thanatosyletus

this

i can build the project itself. running the unit tests..... it's not consistent.

FreeMan

BTW- if you want to see the effects of drugs, watch any Disney movie from the '40s to the '80s. You ever see the drunk scene in Dumbo or any of Fantasia?

this

heh.

i thinkt hat's why they haven't bothered to remake those.

FreeMan

or the Heffalumps and Woozles in Winney the Pooh?

Vogel612

20:46

@FreeMan Alice in Wonderland

this

@MathieuGuindon context?

FreeMan

@Vogel612 Yeah. Pretty much all of it...

IvenBach

@FreeMan those were my favorite character as a child.

this

@Vogel612 TBH, the movie is pretty bengin compared to Dumbo or Fantasia.

Mathieu Guindon

Replying to a tweet/reply voicing vague concerns about anything >4.5 having problems on older versions of Windows

this

20:47

and it's nowhere close to the book where if you recall, they accused Lewis of drug use

Vogel612

Sherlock Holmes, the original novels anyone?

this

oh, should have clicked twiiter link

Hosch250

Yep. It's always funny to read about, until you realize what it would be like in real life. Then it's just sad.

this

I think I see why this might be affecting....

Test Name:	ClassContainsComDefaultInterface
Test FullName:	RubberduckCodeAnalysis.Test.MissingComDefaultInterfaceUnitTests.ClassContainsComDefaultInterface
Test Source:	C:\GitHub\Rubberduck\Rubberduck\RubberduckTests\CodeAnalysis\RubberduckCodeAnalysisUnitTests.cs : line 584
Test Outcome:	Failed
Test Duration:	0:00:00.0000001

Result Message:
OneTimeSetUp: System.TypeInitializationException : The type initializer for 'TestHelper.DiagnosticVerifier' threw an exception.
  ----> System.IO.FileLoadException : Could not load file or assembly 'System.Collections.Immutable, Version=1.2.2.0, Cultur…

Hosch250

@this Ohh, update that one.

this

20:49

actually it was updated before

Hosch250

May or may not need to update System.ValueTuple too.

this

that's me downgrading

when I downgrade, all other UTs can pass

but of course, the UTs for the analyzer can't run

FreeMan

TTFN!

this

@FreeMan i hope you didn't take any drugs....

you can't fly, you know?

IvenBach

Dumbo (2019 film)

Dumbo is an upcoming American fantasy adventure film directed by Tim Burton, with a screenplay written by Ehren Kruger. It is based upon a storyline written by Helen Aberson and is loosely inspired by Walt Disney's 1941 animated film of the same name. The film stars Colin Farrell, Eva Green, Michael Keaton, Danny DeVito and Alan Arkin. The film will be released on March 29, 2019. == Plot summary == Holt, a former circus star, finds his life turned upside down when he returns from the war. Circus owner Max Medici enlists him to care for a newborn elephant whose oversized ears make him a la...

I should watch dumbo again. All the drug references would make more sense as an adult.

this

20:57

O_O

and here I thought they'd never dare to pull that film out of the vault

IvenBach

Plus seeing when it was written and the drug usage that came decades later would make more sense.

@this I'd only say that about a few Disney movies.

Mathieu Guindon

IIRC it was alcohol, though that psychedelic scene had more to do with LSD than booze

this

@IvenBach I didn't think it'd be Dumbo due to the drugs and racism references in the movie

Mathieu Guindon

@this they did a few years ago. I have it on blue-ray..

IvenBach

I think he referred to a remake.

this

21:00

the original?

which is even more impressive than the remake

Mathieu Guindon

yeah, original "remastered"

this

unless they edited it all out, lol

mansellan

Fwiw I couldn't get R# to run all tests without hacking some hardcoded paths on my local (I much prefer r# test runner). Didn't check it in of course, but it would be good if we could find a way not to write to the fs.

Mathieu Guindon

haven't been able to run tests in R# since we ditched MS-Tests for NUnit

Hosch250

I should take a look. I might be able to get it to work.

this

21:03

feh i give up. I'll do it Vogel's Way™

Hosch250

IIRC, I got it to work on R# test runner, but it broke AV then.

this

it's very annoying

i swear, I didn't have this problem unitl just now.

Mathieu Guindon

TBH I love R# testing tools, but if getting them to work means failing CI builds, #ScrewIt

this

i might just undo this changes, keep the analyzer tests in their own project.

Mathieu Guindon

that's just as good IMO

you moved the analyzer tests into RubberduckTests?

this

21:05

yeah i'd rather not just assume it'll work in AV

yeah, thought I'd save us one project and also simplify the test setup

the original test project was using MS test

and since I'm changing the analyzer to fx 4.6 might as well port the tests to NUnit

because you know, #Consistency

Mathieu Guindon

right.. although I'm not sure about having meta/analyzer tests in the RD test suite itself

this

lol. the two projects in the explorer was making me twitch just a little bit

Mathieu Guindon

I suppose being in their own namespace works just as good

(provided that it works lol)

this

it's already its own NS

Hosch250

FWIW, you could put the tests in the same project as the feature...

this

21:07

what it did do is bring in a bunch of lot more nuget packages.

Hosch250

Can't say I like that much, but if the project is really small...

this

is it advisable?

Mathieu Guindon

@Hosch250 fetches 2x4...

this

seems wrong

Hosch250

@MathieuGuindon LOL.

Vogel612

21:07

I kinda want to access the DataGrid used for displaying stuff in the ViewModel, but that feels terribly awkward and like I'm making the VM into a Smart View...

this

ok, good glad to know i'm not hte only one to think o

Hosch250

@this If you've got like 10 files, I wouldn't mind having a Tests folder.

But more than that...

Vogel612

do we have any precedent of dynamically building the UI in the codebase?

Mathieu Guindon

@Vogel612 I smell an X-Y problem...

what are you trying to do?

Vogel612

Code Metrics UI

we have code metrics

these metrics have different aggregation levels

not all metrics apply to all aggregation levels

Mathieu Guindon

21:09

right. gets quite complicated, quite fast

Vogel612

each metric belongs to one single declaration

Mathieu Guindon

how about tabs? 1 metric -> 1 tab

Vogel612

now for every "declaration level" the same metrics apply

@MathieuGuindon that feels really stupid

Mathieu Guindon

hmm

Vogel612

I want to be able to compare cyclomatic complexity to line count without switching tabs and expanding the whole hierarchy

Mathieu Guindon

21:10

lol true

your item model could have some bool IsApplicable property that the XAML for the textbox could bind to, and toggle visibility (hidden, not collapsed)

can't recall what the XAML looks like, there's an item template right?

Vogel612

yes there is, but that still requires explicit declaration of column definitions

Mathieu Guindon

oh the columns are dynamic too?

Vogel612

yeap

if they weren't the old UI would've worked just fine

the columns are basically the different metrics

Mathieu Guindon

oh yeah, so we're trying to make the UI not need a tweak when new metrics are added

Vogel612

+ the declaration they apply to ...

exactly

this

21:16

totally seeing how easy to use XAML is.... coughs

Mathieu Guindon

lol

powerful != easy

you'll want to have the grids in code-behind / C# I think.

Vogel612

okay, so far so good... how do I expose that to the VM then?

and how is that different from Smart View?

this

shouldn't it be the VM that manages the columns?

Mathieu Guindon

private MyViewModel ViewModel => DataContext as MyViewModel;

^ the view is allowed to use the VM

from there you can know what ViewModel.Metrics exist and which ones you need a column for

Vogel612

note that these ViewModel.Metrics are dependent on which level of the declaration hierarchy you are on

Mathieu Guindon

21:19

so make it an ObservableCollection

Vogel612

that does not solve my problem, actually...

I need a Dictionary

Mathieu Guindon

...

Vogel612

Dictionary<AggregationLevel, List<Metric>>

Mathieu Guindon

that could work

Vogel612

where AggregationLevel is a rather limited subset of DeclarationType

Mathieu Guindon

21:21

have a CurrentAggregationLevel property that fires OnPropertyChanged and then the view can react to that by pulling the set of metrics and recreating the grid

Vogel612

but that's backwards :/

Hosch250

@Vogel612 A lot of UI is.

Mathieu Guindon

meh.. it's C# code doing XAML's job, that's why it feels wrong

it's not wrong, it's just .. less magic

Vogel612

for the record: in the current state of the PR the ViewModel has the following dictionaries (pasted for your convenience)

        private Dictionary<AggregationLevel, List<CodeMetric>> metricsByLevel;
        private Dictionary<AggregationLevel, List<Declaration>> declarationsByLevel;
        private Dictionary<Declaration, List<Declaration>> declarationsByParent;
        private Dictionary<Declaration, List<ICodeMetricResult>> resultsByDeclaration;

Mathieu Guindon

as long as you don't end up with UIElement stuff (i.e. controls) on the VM, you're doing fine :)

Vogel612

21:23

^^ this is what's needed to theoretically display all results at once

I'm off for now, because everything I thought of seems either bending over backwards or like an antipattern

and I also really need to spend some time with my GF.

note that the declarationsByLevel might actually be removable, if we only want to access the project declarations and do the rest by traversing declarationsByParent

Mathieu Guindon

enjoy the evening!

(or whatever's left of it)

Vogel612

30 minutes, then it's the next day.

:)

this

I love how VS has an elephant memory with some errors.

it's as if it's actually holding a grudge with me

mansellan

thinking that label:vb6-support is not quite right for the issues I opened - that's for questions IIUC. Might add label:vb6-specific instead?

Mathieu Guindon

21:38

sure

mansellan

thinking that label:vb6-support is not quite right for the issues I opened - that's for questions IIUC. Might add label:vb6-specific instead?

Mathieu Guindon

...sure

this

hmm seems that 2 test projects works.

IDK why but whatever nuget packages it needed, it messed up the IO stuff

Mathieu Guindon

@this yay! push! push! push!

Duga

[rubberduck-vba/Rubberduck] mansellan removed label vb6-support from issue #3951: Parsing a VB6 VBForm results in Unexpected Error

this

21:39

can't

i need to pull yours, rmeember?

Mathieu Guindon

eh, we're going to conflict anyway - if you're ready before I am, go ahead

Duga

[rubberduck-vba/Rubberduck] mansellan added label vb6-specific to issue #3951: Parsing a VB6 VBForm results in Unexpected Error

mansellan

@MathieuGuindon lol wifi fail

Mathieu Guindon

ah, happens all the time

Duga

[rubberduck-vba/Rubberduck] mansellan added label vb6-specific to issue #3953: Get unit tests working in VB6

[rubberduck-vba/Rubberduck] mansellan removed label vb6-support from issue #3953: Get unit tests working in VB6

[rubberduck-vba/Rubberduck] mansellan added label vb6-specific to issue #3952: VB6 editor is missing menu and commandbar icons

[rubberduck-vba/Rubberduck] mansellan removed label vb6-support from issue #3952: VB6 editor is missing menu and commandbar icons

[rubberduck-vba/Rubberduck] mansellan added label vb6-specific to issue #3950: Code Explorer needs additional icons for VB6 DeclarationTypes

[rubberduck-vba/Rubberduck] mansellan removed label vb6-support from issue #3950: Code Explorer needs additional icons for VB6 DeclarationTypes

[rubberduck-vba/Rubberduck] mansellan removed label vb6-support from issue #3949: Wrap VB6 CommandBarEvents

[rubberduck-vba/Rubberduck] mansellan synchronized pull request #3965: Add menu and toolbar icons for VB6

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) commented on pull request #3965: Add menu and toolbar icons for VB6

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/3965?src=pr&el=h1) Report
> Merging [#3965](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/3965?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/bcf72dd4c455ac67fa8772c650a7a497135262df?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `0%`.

```diff
@@ Coverage Diff @@
## next #3965 +/- ##
===========================

mansellan

21:47

eek!

Hosch250

TTYL. Taking off.

mansellan

oh, I have a PR open

phew

makes note to PR from branch in future

Mathieu Guindon

is that PR ready?

mansellan

no, I have more to do

might close it for now

just opened it for some review tbh

Mathieu Guindon

did you repro the issues Wayne was having?

mansellan

21:51

no, think I need to install Office 2k3

Mathieu Guindon

hmm

mansellan

prime suspect is the clipboard assistant in that version

Mathieu Guindon

ooooh had forgotten about that stupid "tool"

mansellan

either way, hooking the api (which I need to do anyway) should show what's going on

Duga

[rubberduck-vba/Rubberduck] mansellan commented on issue #3953: Get unit tests working in VB6

> Confirmed resolved by #3958

[rubberduck-vba/Rubberduck] mansellan closed issue #3953: Get unit tests working in VB6

[rubberduck-vba/Rubberduck] mansellan assigned mansellan to issue #3951: Parsing a VB6 VBForm results in Unexpected Error

[rubberduck-vba/Rubberduck] mansellan commented on issue #3951: Parsing a VB6 VBForm results in Unexpected Error

> Further info - exception only results in "Unexpected Error" if VBForms are parsed, but the exception is raised whenever VB6.OLB is referenced. This is reproducible from both VB6 and VBA.

[rubberduck-vba/Rubberduck] build for commit c6b7c3a3 on unknown branch: AppVeyor build succeeded

Pheo

22:06

Am I allowed to ask questions here about code that is not functional?

Vogel612

define "here"?

Pheo

@Vogel612 chat.stackexchange.com/rooms/14929/vba-rubberducking

Vogel612

Asking doesn't really cost anything...

doesn't mean you'll get answers, mind you ;)

Pheo

sigh I'm asking if I'm allowed to ask ... because the related site to this room is CodeReview, which requests that your code be functional. However, since this is VBA Rubberducking it implies that code might not need to be functional.

Vogel612

names are smoke and mirrors. What does the room description say?

IvenBach

22:12

@Pheo Welcome to the pond.

Pheo

@Vogel612 Space for users of the VBA rubberducking project?

IvenBach

This is where we discuss the Rubberduck add-in.

Pheo

@IvenBach Thanks.

IvenBach

rubberduckvba.com

The ducks at this pond can be a bit pedantic.

Pheo

Ack why is the feed like that

mansellan

22:13

2

IvenBach

~~Most~~ VBA is on topic.

mansellan

(sorry, couldn't resist!)

Pheo

Well, I think I'm in the wrong place.

IvenBach

1 min ago, by IvenBach

~~Most~~ VBA is on topic.

What's the code you have?

Pheo

codepen.io/Pheo/pen/deWMdK

Vogel612

22:17

@Pheo one of the two options for feeds. putting all vba questions asked on SO into the chatroom is just a bit too much oneboxing

Pheo

It just awlways says "in" no matter what word I feed it.

@Vogel612 ahh.

IvenBach

That's some odd looking VBA code.

Pheo

Yeh it probably isn't

I should go learn it and re-write my application.

IvenBach

I'm just a lowly wannabe VBA scrub that knows nothing outside of VBA and a bit of C#.

stackoverflow might be a better place to post. I don't believe the code needs to be function.

Vogel612

~mumble mumble unnnecessary self-deprecation mumble mumble

IvenBach

22:20

:quack:

:Grumble: Dim CalcMode as Long is a prime example of #DoingItWrong msdn.microsoft.com/en-us/library/office/…

It should be As XlCalculation

:barf: Case UCase(cell.Value): cell.Value = LCase(cell.Value) why show : like that :tear:

I sometimes wonder if MS is actually trying to sabotage newcomers to VBA with that kind of stuff.

Pheo

I'll go learn VBA and re-write my application

:frowns: I'm not sure tensorflow.js works in VBA though.

IvenBach

@Pheo VBA is the language that Microsoft Office applications (Excel, Word, etc...) use.

This chatroom is for VBA related code.

this

23:05

hmm, should we be including this in the app.config for various projects?<startup><supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.6" /></startup>

docs.microsoft.com/en-us/dotnet/framework/configure-apps/…

Mathieu Guindon

Or C# related to Rubberduck =)

this

it wasn't specified originally.

Mathieu Guindon

Probably a good idea

this

to accept the change?

Ok.

IvenBach

I like how the solution was in this thread from the very first comment on. — Mathieu Guindon 1 hour ago

@MathieuGuindon A true and valid statement. Could appear overly harsh to newcomers.

mansellan

23:13

Making progress on this parsing issue with VB6.OLB. Looks like its not collecting parameter names for some reason.

Deep in ComProject.cs atm

but enough for today, TTGTB

IvenBach

@This thanks for explicit assembly advice. msdn.microsoft.com/en-us/library/… and msdn.microsoft.com/en-us/vba/office-shared-vba/articles/… would have confused me to no end otherwise.

this

you're welcome

the VS is being annoying as hell now. I swear, it's baleful.

IvenBach

Sub AddToShortcut()
    Dim cb As CommandBar
    Set cb = Application.CommandBars("Cell")

    Dim newControl As CommandBarButton
    With cb.Controls.Add(Type:=msoControlButton)
        .Caption = "Toggle &Wrap Text"
        .OnAction = "ToggleWrapText"
        .Picture = Application.CommandBars.GetImageMso("WrapText", 40, 40)
        .Style = msoButtonIconAndCaption
    End With
End Sub

Even enabling Show Hidden Members in the OB there still isn't Picture or Style.

How am I supposed to know that they are actually valid?

this

23:29

run it

if it works, then you're A-OK!

IvenBach

I only know it works because I'm copying it from an example.

this

yeah, seriously sometime they goof and forget to add it to the TLB or something

so it works OK late-bound

but of course you can't see it early-bound.

IvenBach

Tested it and it worked. I'm rubberducking out loud wondering how I'd figure out how to know/infer that it does have Picture

this

we had that happen in one of Access' control.

for that, you need to actually see the implementation. Which you might be able to get from Microsoft.... if you asked really, really, really, REALLY nicely.

IvenBach

In other words: Snowballs chance in hell.

According to msdn.microsoft.com/en-us/vba/office-shared-vba/articles/… I don't see any mention of it.

Is there some kind of super secret MVP access only area that tells you all this stuff the non-MVP mortals dreamt they had?

this

23:44

I'd tell you but then I'd have to kill you.

and I'm not a murdery kind of guy so....

IvenBach

I knew it!

I now need to figure out how to fake it long enough to become an excel MVP.

Duga

23:57

[rubberduck-vba/Rubberduck] bclothier synchronized pull request #3975: Reflection API & COM management

this

@Duga @MathieuGuindon please don't merge this yet. Still few things to do - I pushed primarily to verify that AV building problem is solved.

Mathieu Guindon

:+1:

fingers crossed

toes crossed

this

at least the UTs are consistently passing as they were. I ran it 6 times locally so that's good.

need your advice, though

I want to make the parser non-creatable. It should come from a factory.

the idea i have in my mind is that we'd have two methods CreateStandalone() and GetFromAddIn()

the former's easy. we already have that.

Transcript for