VBA Rubberducking

Duga

12:00 AM

[rubberduck-vba/Rubberduck] build for commit 8974fe98 on unknown branch: AppVeyor build failed

BUILD FAILURE!

this

the latter, I need to grab the reference to the extension.

Poop

Mathieu Guindon

AppVeyor crossed

this

so i guess.... GetFromAddIn(AddInObject) ?

force them to pass in the addin object from Application.VBE.Addins("Rubberduck.Extension")?

Duga

RELOAD!

this

Or, make that expose a separate factory that will also provide the API Parser ( meaning 2 totally different way to instantiate Parser class?

Mathieu Guindon

12:01 AM

I'd just pass the VBE

Duga

[bruglesco/memory-card] 1 commit. 101 additions. 19 deletions.

[Cardshifter/HTML-Client] 3 commits. 27 additions. 21 deletions.

[Hosch250/CheckersWebsite] 3 commits. 396 additions. 106 deletions.

[rubberduck-vba/Rubberduck] 3 opened issues. 3 closed issues. 17 issue comments.

[rubberduck-vba/RubberduckWeb] 2 opened issues. 1 closed issue. 3 issue comments.

this

VBE wouldn't be sufficient to get the RPS from the addin?

Mathieu Guindon

No but then you 1) have a very easy to use API - just pass Application.VBE - and 2) we can get the add-in from the VBE ourselves

this

@Duga hmm. I think you're not being completely honest. You're not faillng because of warnings, are you?

Oh, yeah, that's true.

ok much more nicer; I can then keep the factory self-contained in the API model.

yeah found it

i thought I got that rid of. Stupid VS

mind deleting that, though?

Mathieu Guindon

No idea what that is

What do I delete?

this

12:06 AM

no no i mean the chat message

i'll take care of that in VS

Mathieu Guindon

Ok

this

thanks!

Mathieu Guindon

FWIW it's still up on the AV cloud build history

this

i know. i'll have to live w/ that

chat, however is searched by google

stupid VS. it gave me what I didn't ask for. grumble

Duga

[rubberduck-vba/Rubberduck] bclothier synchronized pull request #3975: Reflection API & COM management

this

12:12 AM

@Duga Appveyor, you better build it for reals or there's going to be pain and misery.

wait, something doesn't add up -- Yes, I have the VBE, but VBE isn't the IVBE and I don't have the IoC

that implies that I still have to go through the AddIns to get to the actual object....

Duga

[rubberduck-vba/Rubberduck] build for commit c7d5d9a4 on unknown branch: AppVeyor build failed

BUILD FAILURE!

this

i hate Vs.

and the most retarded thing s that it lets me add a totally random DLL (which I did not ask for) that is so totally not an analyzer.

Mathieu Guindon

@this getting an AddIn would not be an IAddIn either...

this

and that doesn't show up at all in the Analyzers list. You'd have to read the .csproj to see it was all wrong.

well, no. But my original thought was that I'd provide a factory as the object for AddIn

which has the ties to the IoC

Mathieu Guindon

IDK.. I never really considered hooking into the loaded add-in.. would be awesome, but that could easily be a Phase II

this

12:20 AM

Hmmm.

you might be right. I'll just set up a simple factory, and defer the tie-in for later.

the PR is...*wee bit* little big.

Duga

[rubberduck-vba/Rubberduck] bclothier synchronized pull request #3975: Reflection API & COM management

this

it's building! it's building!

Duga

12:38 AM

[rubberduck-vba/Rubberduck] build for commit 5b9faa0a on unknown branch: AppVeyor build succeeded

IvenBach

It succeeded.

Duga

[rubberduck-vba/Rubberduck] bclothier edited pull request #3975: Reflection API & COM management

Mathieu Guindon

Win!

this

ok, going ot do one more push for negative test

@IvenBach can you be my guinea pig?

you have some books w/ early bound tests yeah?

IvenBach

Yes...

this

12:40 AM

perfect.

Duga

[rubberduck-vba/Rubberduck] bclothier synchronized pull request #3975: Reflection API & COM management

IvenBach

Wait. Workbooks?

this

so i need to verify I didn't break stuff with my COM around

Duga

[rubberduck-vba/Rubberduck] build for commit 5b9faa0a on unknown branch: 53.51% (target 0%)

this

Yes

IvenBach

12:41 AM

Or physical books that I read from about early binding?.

this

excel workbook w/ RD's unit tests using early binding on RD's objects like FakesProvider, etc.

Mathieu Guindon

@MathieuGuindon I can say I contributed to OSS this year then :) glad it works! — Camilo Terevinto 50 secs ago

this

:+1:

IvenBach

I can easily make a couple Workbooks with early binding to Scripting.Dictionary or FileSystemObject.

this

no no

I want early binding to RD's objects

like Rudderduck.FakesProvider or Rubberduck.Assert

IvenBach

12:42 AM

Assert I can do.

this

if you don't have it already, make one

then grab the installer from the build

ci.appveyor.com/api/buildjobs/bs1sp7x8divwxl9i/artifacts/…

Duga

[rubberduck-vba/Rubberduck] build for commit 4fd374db on unknown branch: AppVeyor build failed

BUILD FAILURE!

this

if your machine has debug build, you need to run the reg file to uninstall the keys before you run the installer

> RubberduckTests -> C:\projects\rubberduck\RubberduckTests\bin\Release\RubberduckTests.dll
VBA\Accessibility.cs(11,17): error MissingGuid: COM-visible type 'Accessibility' does not have an explicit Guid attribute that references a RubberduckGuid constant. [C:\projects\rubberduck\Rubberduck.API\Rubberduck.API.csproj]

BEAUTIFUL

Mathieu Guindon

@this wah, make AV sing baby!!

sheds a tear damn this is so awesome

2

this

IKR!

Duga

12:47 AM

[rubberduck-vba/Rubberduck] bclothier synchronized pull request #3975: Reflection API & COM management

this

@IvenBach when you're ready to install, you can find the reg file in this: Rubberduck\Rubberduck.Deployment\LocalRegistryEntries\DebugRegistryEntries.reg

running this will uninstall all the registry keys.

you should then launch the Excel to verify that it can't load RD

close it then install it

then open the Excel and verify that RD loads, and the workbook's unit tests still work.

that's pretty important.

Duga

1:03 AM

[rubberduck-vba/Rubberduck] build for commit 2da65e21 on unknown branch: AppVeyor build succeeded

IvenBach

@this Just confirming that simply building will now do all the registration steps.

this

build what?

you should be installing, not building

we're testing the installer

IvenBach

I got side-tracked by a request to format a travel itinerary. Sorry. Actually reading what you need now.

Seems early binding with unit tests even before trying to uninstall produces an error.

System.ArgumentException: TypeInfosCollection::Get failed. 'TestModule1' component not found.
   at Rubberduck.VBEditor.ComManagement.TypeLibs.TypeLibWrapper.TypeInfosCollection.Get(String searchTypeName) in C:\Users\IvenBach\Source\Repos\Rubberduck\Rubberduck.VBEEditor\ComManagement\TypeLibs\TypeLibs.cs:line 67
   at Rubberduck.VBEditor.ComManagement.TypeLibsAPI.VBETypeLibsAPI.ExecuteCode(TypeLibWrapper projectTypeLib, String standardModuleName, String procName, Object[] args) in C:\Users\IvenBach\Source\Repos\Rubberduck\Rubberduck.VBEEditor\ComManagement\TypeLibs\TypeLibsAPI.cs:line 211

aaaaaand excel crashed on exit.

this

wtf

so this is with your current debug build?

IvenBach

Last build that had the about control, which was syncd. Yes.

wtf

Stack Trace Explorer opened all on its own.

Hey @RubberDuck.

RubberDuck

1:20 AM

I don’t know if anyone here remembers or knows this piece of CR history, but...

So.... just for the record. There is now a working FiM++ interpreter. github.com/avian2/fimpp/blob/master/README.md — RubberDuck 8 mins ago

IvenBach

@this Just created a new branch off upstream\next and getting the same error message.

@RubberDuck Nope. Not showing that to my duckling.

4

RubberDuck

Dear Princess Celestia, today I learned how to say “Hello World.” Your student, Twilight Sparkle.

IvenBach

@this Just tried with upstream\master and getting unregister and register assembly errors.

this

none of that is right.

btw, hi, @RubberDuck

IvenBach

Seems moving around all the stuff is breaking much.

this

1:25 AM

ok - did you clean & rebuild?

RubberDuck

Lol. Hi guys! You’re working, so I’ll leave you to it. Just needed to share.

IvenBach

That probably should have been my first step.

this

@RubberDuck that's quite a lot of noise just to say hello, world.

IvenBach

Still same issue. Even after Clean and Build.

this

something's not right.

if you switch back to your original branch can you then build?

IvenBach

1:38 AM

Something definitely isn't right. Trying to build from Next I got the Stack Track Explorer opening again.

Cleaning feels like it's freezing for 30 seconds at the very end.

Yes. Any branch I try to build with I'm getting that error.

A Spend time with me request has been submitted, and I'v gotta honor it.

Bbl.

this

sorry about and thanks!

Mathieu Guindon

@this any idea why we would have two versions of a nuget package?

Restoring NuGet package EasyHook.2.7.6578.1.
Restoring NuGet package AvalonEdit.5.0.4.
Restoring NuGet package EasyHook.2.7.6270.

I wonder how long it's been there...

this

hmm might been a result of someone mashing the nuget (e.g. me)

most likely, there's 2 projects that references it

but one is using X and other is using Y?

Duga

[rubberduck-vba/Rubberduck] bclothier synchronized pull request #3975: Reflection API & COM management

[rubberduck-vba/Rubberduck] build for commit 2da65e21 on unknown branch: 53.51% (target 0%)

Mathieu Guindon

yup

this

1:48 AM

so mash that nuget some more then.

Mathieu Guindon

go with Latest stable 2.7.6684 :)

Duga

[rubberduck-vba/Rubberduck] bclothier edited pull request #3975: Reflection API & COM management

this

but...

do both really need it?

one'd think only the Core would house the actual hooking stuff....

Mathieu Guindon

maybe Main needs it to wire things up? ...if so, ..we can do better

this

hm, doesn't seem so to me.

i could delete the reference and no error... apparently

except that VS's determine to make me look stupid and shows error after I make that assertion.

looks it's only there for the StubBase

Mathieu Guindon

1:53 AM

this

anyway i'm done for today - I'll have to finish testing the installer tomorrow.

Mathieu Guindon

sounds good! I'm on my PR now :)

Duga

[rubberduck-vba/Rubberduck] build for commit 72bcd946 on unknown branch: AppVeyor build succeeded

IvenBach

3:40 AM

@this Sorry about getting diverted too. Wife’s gone on business trip next week and she invoked family time.

Duga

4:18 AM

[rubberduck-vba/Rubberduck] angelo-rafael starred us

2

Duga

5:54 AM

[rubberduck-vba/Rubberduck] retailcoder synchronized pull request #3976: Introducing Rubberduck.Resources

[rubberduck-vba/Rubberduck] build for commit a916f44c on unknown branch: 57.85% (target 0%)

Mathieu Guindon

^ this build is doomed

TTGTB

Duga

[rubberduck-vba/Rubberduck] build for commit e12428e9 on unknown branch: AppVeyor build cancelled

BUILD FAILURE!

Mathieu Guindon

</mug>

Duga

[rubberduck-vba/Rubberduck] retailcoder synchronized pull request #3976: Introducing Rubberduck.Resources

[rubberduck-vba/Rubberduck] retailcoder commented on Rubberduck.Core/Settings/HotkeySetting.cs of pull request #3976: Introducing Rubberduck.Resources

[rubberduck-vba/Rubberduck] build for commit fd802f49 on unknown branch: AppVeyor build cancelled

BUILD FAILURE!

Son Goku ssj4

7:34 AM

@this Slowly, but I'm doing it. Like 10 rows per day. Except last month because I was on a 2 week trip to Japan and then I was heavilly ill (not from Japan :D) for another two. I'm started again from monday so... :) But I won't tell you when it will be finished though. I didn't create the environment when I can test the language yet so I'm doing many translation on a blind, don't know if it's right for the context.

this

10:11 AM

Cool. Hopefully a new PR won't be too long after, @SonGokussj4 :)

@mansellan IDK if that is of some interest to you...

benf.org/excel/officeclip/index.html

mansellan

10:27 AM

@this thanks @this, I'll check it out. Gonna withdraw the PR for now though, I wanna tackle some of the more pressing issues to get VB6 shippable, will circle back to this one afterwards.

Duga

[rubberduck-vba/Rubberduck] mansellan commented on pull request #3965: Add menu and toolbar icons for VB6

> Closing for now, will resubmit when ready

[rubberduck-vba/Rubberduck] mansellan rejected pull request #3965: Add menu and toolbar icons for VB6

FreeMan

11:48 AM

late to the party, as usual, but, howdy @RubberDuck! It was nice to see you stop by.

Son Goku ssj4

12:33 PM

@this If I understand last changes correctly, I don't have to translate any keys that starts with SourceControl_xxx, is that right? Because SourceControls functionality was let go. (what's the past tense of let go? :D)

this

@SonGokussj4 that's correct.

and it's actually correct the way you said -- "was let go"

Son Goku ssj4

@this Wow. English guru :D Thanks.

this

and FWIW, there's not that many but you can also skip the ExtractMethod_XXX keys, too.

FreeMan

Is Extract Method gone for good, or just on holiday?

this

holiday. Some jerk was supposed to do it

but he keeps sticking his fat big nose in places where it doesn't belong.

FreeMan

12:45 PM

@this - that (or one of those) random LinkedIn invites you got yesterday was from me. :)

jerk.

;)

this

hm. didn't recall seeing it.

FreeMan

maybe I didn't get it sent to the right one... :(

this

so sorry, "jerk" not sticking for that one. You'll need to find another reasons to call me a jerk. :p

lemme see

i guess I jsut didn't get the email

FreeMan

I'm hardly ever on LI anymore, but the thought hit, so I sent it out

also, my profile isn't really up to date there...

this

no worries. I only look at LI once in every blue moon, and it does not help that I get some invitations from some random people

supposed to link with who you know, right? apparently not.

Mathieu Guindon

1:55 PM

@this uhm, there's an extract method refactoring on the release build I'm using at work

Nobody is ever an accountant at heart, only by persuasion. — Bathsheba 16 mins ago

this

@MathieuGuindon hm. thought it was long ago disabled. :\

really need to get back to thiis epic.

FreeMan

2:35 PM

@this Some folk say "done got gone", but that's not really proper grammar...

this

@FreeMan well.... ol'Bill never spoke properly. He had this funny tendency to invent new words....Never mind the fact that of all 6 surviving signatures we have, he couldn't spell his name consistently in any of those.

This isn't French where they have a committee to tell you what to say (and get ignored anyway)

FreeMan

Bihl, you mean?

Yes, my roommate my freshman year of college spelled it "Bihl"...

this

Pretty sure ol'Bill was a mite too old to be a freshman with you.

FreeMan

whew!

Hosch250

TIL, cancelling stars removes pins too. I guess they caught that #EdgeCase.

IvenBach

2:53 PM

@FreeMan I say someone should name their child “<space>”. Yes the space bar character 32. Like that won’t ever cause any problems.

Yep, space does really good at school despite all the ridicule he gets.

Hosch250

@IvenBach null.

this

Uh, how would you pronounce it? Otherwise, they'll think the child's name is "space", not " "

Hosch250

I'll name my kid Null Hosch

IvenBach

Is sister tab also has troubles, but less so because often enough people think her name is square.

this

so ..... like, "Yep, <pause> does really good at school despite all the ridcule he gets"

Meh, I'd give the child name "Don't"

Don't do that right now!

Don't come here!

Don't do your homework!

Quack Exchange

2:55 PM

-1

Q: Want to calculate Time, Date and Shift

I'm trying to Calculate Time, Date and Shift I have Date of Sampling in Column M and Time OF Sampling in Column N and I want to calculate Release Date and Release Shift. Date of Release will be after 27 Hour From the Date of Sampling and Time of Sampling. and Shift Release time will be based ...

this

Don't plays football.

Hosch250

@this Donut for short.

this

Don't eat donuts, please.

FreeMan

Hi, welcome to [codereview]! This site exists to review and improve already working code, not to write it for you. You'd be better served on the sister site Stack Overflow, but they won't like your question, as it stands, there, either. They'll expect you to at least give it a shot and post the code you've tried with a specific issue you're running into. — FreeMan 31 secs ago

da mug beat me to it...

this

3:16 PM

Anyone familiar with GoF patterns - just so I know I'm categorizing it right --- if I provide a object to something and it changes the main object's behavior (because it hooks into the main object's events and/or take over the properties), that's what we'd call "Decorator" ?

Mathieu Guindon

not quite

this

Ok, what would be the pattern name in that case?

Mathieu Guindon

no idea

but I can tell you about a decorator though :)

this

oh dear.

so why isn't above a decorator?

Mathieu Guindon

hmm I might have stumbled on the wording. "hook", "events" threw me off.

FreeMan

3:18 PM

@this because you didn't provide a box of crayons

this

heh

Mathieu Guindon

a decorator is an implementation of an interface that wraps that given interface and implements it by "forwarding" (or not) the call to the wrapped object

this

oh, definitely not that.

Mathieu Guindon

well it kinda does fit what you were saying, assuming "something" implements the same interace as "a object"

this

but i'm not actually wrapping the whole object

M.Doerner

3:19 PM

@this What you have might be a strategy.

this

Let's try a concrete example -- this is a pattern I use a lot in Access because it works well in that context ---

I often extend an Access form's behavior by encapsulating the logic into the class, then at the form's startup, it instantiates that class and tells it about itself (e.g. which controls or properties it should now manage). The class then acts on the events raised by the form.

A common case is providing keyboard behavior (e.g. using up/down to navigate controls or to adjust the dates/numbers).

so it'll be usually Set kn = New KeyNavigator, followed by kn.Init Me

M.Doerner

That is basically the strategy pattern.

this

The Init then wires up all the events that the KeyNavigator needs to listen to the Access form and then control the behavior, without embedding any of its code inside the form; simply instantiating the object is enough.

Ok, Good. Glad to have a name for that. To be honest, the UML doesn't look like it.

since I can have multiple objects used for different responsiblity (e.g. a key navigator, a validator, etc.)

M.Doerner

Well, maybe not.

That is usually used directly in the class.

With the init and passing the main object, I think you actually have a visitor.

this

In the above example, I used keynavigator, where the responsiblity is clearly delegated away from the form to the keynavigator class; it is now managing all the navigation by keyboard on the form's behalf. In another example, I might have a validator that is used to provide some generic validation that might be run in addition to any form's specific validation rules.

Hmm. In most Visitor pattern, there has to be an explicit Accept and Visit.... I can't quite set it up like that because in the class, I'm using event procedures to "visit".

> It should be possible to define a new operation for (some) classes of an object structure without changing the classes.

that does matches the description, though.

M.Doerner

3:29 PM

Thinking about it a moment longer, it is a strategy.

The event stuff and passing the main object through me off for a second.

IvenBach

@Hosch250 A couple days back I got to an article about someone with the last name Null. Must be fun...

Hosch250

@IvenBach Yep.

this

@M.Doerner Hmmm. The thing that throws me off about the strategy is that it implies there are choices to choose. In my case, it is not always so (e.g. I only have one KeyNavigator class).

M.Doerner

That is just because you do not inject it.

this

Also (and this may be a mistake on my part), I haven't had used interfaces; I just directly new up the needed class to provide the extended behavior. Typically just instantiating is enough to get the new behavior.

Yeah...

M.Doerner

3:34 PM

You only potentially need different options.

Yes, you would usually use this with interfaces and then inject some instance or get it from a factory.

this

hmm. and in the examples, they typically have a IStrategy which is a property on the main class. I don't bother with that. Up to now, I've been using a private module-level variable, sometimes with a WithEvents if appropriate.

ah that's the problem - a property can't be WithEvents'd. that's probably why I got into the habit of using module-level variables and just Initing them at the startup

M.Doerner

As long as you do not need multiple options and do not want to invest the work to wire things up in factories, you can just keep newing up the strategy in the class.

this

Yeah, it's those differences that didn't make it look very "Strategy"-like.

Mathieu Guindon

@this you'd need an adapter to route the events, ...the interface buys you decoupling, at the cost of some level of conplexity - IMO an adapter is too much to be worth it

M.Doerner

I generally use private variables for my strategies.

this

3:39 PM

but I'm glad to now know what design pattern I should be referring to.

M.Doerner

And I use them extensively.

this

@MathieuGuindon typically the strategy class will have a number of WithEvents variables that is all wired up from the Init and then the event handlers are located within the strategy class, rather than inside the form where the events originated.

M.Doerner

They are the composition based alternative to the inheritance based template method pattern.

Mathieu Guindon

@this yeah I was thinking if you needed to expose events on an interface :)

18

A: Can we use Interfaces and Events together at the same time?

This is a perfect use-case for an Adapter: internally adapting the semantics for a set of contracts (interfaces) and exposing them as its own external API; possibly according to some other contract. Define class modules IViewEvents: Option Compare Database Option Explicit Private Const mModule...

this

yeah. that's another reason I don't use interfaces if there are events. Those kind of classes has to be basically sealed. ;)

which may very well lead to some anti-patterns.... :\

Mathieu Guindon

3:43 PM

at one point I implemented some kind of command, that worked, but ended up being too much of a pain to extend

11

Q: Down the rabbit hole with MVP

Following-up on this post where I implemented a Repository Pattern in vba to abstract ADODB and enable testing my Excel app without hitting a database backend; curious about how far vba would let me push inversion-of-control and loose coupling, I decided to grab the red pill, and see how deep the...

object-oriented design-patterns vba dependency-injection mvp

> Talking to someone you can't see

IvenBach

@MathieuGuindon In thinking about an example for an article about using the Assert class as either early bound or late what would you consider to be on topic? Anything that sticks to the core ideas of what differences there are?

Mathieu Guindon

the topic is ..whatever you make it

late bound vs early bound isn't tied to Assert class in any way though

IvenBach

I'll write up an article then email it to you for review.

Mathieu Guindon

sounds good

this

@MathieuGuindon read it through, the issue seems to me that is the Command model would end up with a huge Select case and careful handling of hte default case. Not feel so enthused with that approach, sorry. I do like how you sidestep the problem w/ interface inheritance, though.

@IvenBach fwiw, I'd be more interested in all diffferent uses of the assert. If you recall, I totally missed out on sequenceequals and because of that I handrolled what I shouldn't have..

Mathieu Guindon

3:54 PM

@this meh.. that code dates back from the VBA crazyness that led to the birth of RD... mere experimentations. although, that particular thing did allow me to write that database maintenance tool during summer shutdown without accessing the database, so there's that.

I wouldn't recommend that "pattern" anyway

this

nice!

so it's in use still? As-is?

Mathieu Guindon

was ...until I rewrote it in C#/WPF :)

this

still, cool.

Mathieu Guindon

the coolest part was the IUnitOfWork stuff IMO

...although that also ended up a maintenance nightmare

this

Frankly what we can do w/ RD's codebase --- moving around lot of stuff and whatnots is only possible because of tooling around the VS & R#.

Mathieu Guindon

3:58 PM

OTOH the tool was written against a MySQL backend, and literally only the connection string needed to change when that got migrated to SQL Server

this

Try to do the equivalent with a VBA codebase... :(

Mathieu Guindon

39 secs ago, by Mathieu Guindon

OTOH the tool was written against a MySQL backend, and literally only the connection string needed to change when that got migrated to SQL Server

that?

that was 100% VBA

this

No, I was referring to the large-scale modularization we're doing in RD

or more generally refactoring of the codebase

Mathieu Guindon

have you seen what I pushed last night?

without VS/R# I'd be under a bridge right now.

this

not quite - should I be afraid of the 440 files changed? :p

Exactly my point - to do something similar in VBA....

and that's a big part why nobody wants to clean up VBA codebase. it's just a one big WORN hole.

which reminds me.... I really need to get EM going again.

Mathieu Guindon

4:02 PM

I've moved InspectionsUI.resx to Rubberduck.Resources.Inspections namespace, and split it into InspectionNames.resx, Meta.resx (will likely be renamed tonight), QuickFixes.resx, InspectionResults.resx, ...leaving essentially 1 entry per inspection in each file, so I've removed the + "Name" and "+ "Meta" concatenation, and inspection resources are now fetched using only the class name as a resource key

this

ah, hence the 122 errors. But I very much like that.

no more stringifying.

Mathieu Guindon

yeah it was 2AM when I thought "okay, 'nuff for tonight"

the InspectionNames.resx file has 70 keys, can you believe that? Rubberduck has 70 inspections!

this

we went from 68 because of the 2 new inspections but putting the number out there, that's pretty great

Mathieu Guindon

the split also makes it much easier to enforce naming convention on resource keys.. found a few outliers

this

RE: stringified types -- that's another challenge in VBA. How do we not use stringified access? I'm especially looking at Recordset class. :\ In C#, we have nameof() and typeof() to eliminate all the stringified access.

Yeah, and hopefully the keys will be more sane - it's weird to go like Command_ExtractMethod_Dialog or something like that. Too much.

Mathieu Guindon

4:08 PM

best part, InspectionUI.resx has only a dozen keys left, all related to, well, the actual UI

@this I'm hoping to begin tackling RubberduckUI.resx tonight

every feature is getting its resource namespace

keys will shrink

this

That's the granddaddy of them all

Yes, I think that'll be #SoWorthIt.

Mathieu Guindon

so yeah, I think your PR will be ready before mine :)

this

we'll have to see how the tests turn out for the installer

I changed a lot of GUIDs

normally that's a no-no but the installer is supposed to take care of them all.

Mathieu Guindon

we're literally building a rock-solid foundation for the future growth, this is awesome

this

yep. fun times. :)

IvenBach

4:16 PM

@this WORN? Acronym?

this

write once read never

IvenBach

@MathieuGuindon That was something that confused me the first time I saw it. Legacy #GottaStartSomewhere stuff that's getting cleaned up?

this

in contrast to WORM (write once read many [times])

@IvenBach more of modularization.

IvenBach

Is it hard to properly modularize when you're just getting stuff started?

this

at one point it made sense to have them all in one files. But the li'l ducky getting a mite too big for its britches, so it needs more pockets.

more like, #NotWorthIt

if you try to modularize right at the start, you end up getting nowhere

it's just a natural evolution, is all.

IvenBach

4:20 PM

Sounds like it's a good thing.

application.CommandBars.ExecuteMso("FormatCellsDialog") Found it! I've wanted to know how to bring that dialog up for years.

giddyLevel++

IvenBach

4:39 PM

Duck check: Is older functionality that gets superseded by newer usually left in programs for legacy compatibility?

this

I really would prefer not to do that. It only invites potential confusion

But practically, it can be problematic if you still have it in use for some reason.

IN which case you should go to the effort to dissuade the new use.

Hosch250

More moral support pls :)

IvenBach

application.Dialogs(xlDialogFormatFont).Show gives me vague recollections of having used it a very very long time ago. commandbars.ExecuteMso("FormatCellsFontDialog") looks like its successor.

the xlDialogFormatFont also has issues with choosing the color.

It has an extra dropdown next to the sample label.

Hosch250

5:28 PM

@Vogel612 Please refresh my chat profile.

Simon isn't around to play with Duga, so I changed my name/profile temporarily.

NVM, not worth it.