« first day (11 days earlier)    last day (15 days later) » 

6:51 AM
@user21820 I'm just wondering, in Makyen's review-script linked in the info for the CURED room, should the name "CRUDE" be updated to "CURED" in line 30, so that the script only runs in the transcript for the CURED chatroom?
30 if (document.title.indexOf('CRUDE') === -1 &&
I know this isn't about the CDStatus script, but I thought it would be better to ping here rather than in CURED.
I'm also not familiar with Javascript (or any scripting, for that matter), but the logic here seems straightforward enough that I think I know what's going on.
@TheAmplitwist I think I should have said, "…so that the script runs in the transcript of the CURED chatroom". Currently, it checks whether the transcript is of either the "CRUDE Archive" or of "CRUDE", and if it is not, then it does not run. So, it misses running in the "CURED" chatroom.
 
7:19 AM
@TheAmplitwist It doesn't miss running in the chat-room. Have you tried it?
 
@user21820 Yes, I recall trying it out and having some issue with it running in the transcript. I made a mental note to ping someone knowledgeable about it later. Not running it right now, but I'll do that and get back to you. (On second thoughts, I should have done that first, before pinging. My apologies.)
 
It only misses running on permalinked messages that don't have the room id "2165" in the URL, which is probably why nobody really noticed it.
So if you view the transcript at the usual link, it works fine.
@TheAmplitwist But we should ping Makyen to fix it.
 
@user21820 I just checked: it runs when I enter the chatroom, and it runs when I enter through "view transcript", because the room number is present in the URL, but not when I enter via a permalink to a message. Just as you said.
 
@TheAmplitwist Right, that's what the code says; I didn't actually test it on a permalink. =P
 
@TheAmplitwist I think that for such cases the first few lines of the script take care of it by comparing with the browser window title: if it has "CRUDE" or "CRUDE Archive" in it, then it runs, and if it does not, then it does not run. Changing "CRUDE" to "CURED" should allow it to run in the transcript when one clicks on a permalink too, I believe.
 
7:27 AM
@TheAmplitwist No, you're reading the code wrong.
Even though the fix is correct.
 
@user21820 Well, my work is done insofar as I've brought it to your attention :P
 
in Addons & Scripts, 7 secs ago, by user21820
@Makyen I hope this is the right place to ping you, but Amplitwist noticed that your helpful script does not run on a permalinked message transcript because the room name had been changed. I guess a more robust test would be to check the "first day" link. Could you fix it?
@TheAmplitwist: Anyway, if you tried my CDStatus script, did it work as desired?
 
@user21820 Since I have neither close nor delete vote privileges, I haven't tried that out yet.
 
@TheAmplitwist Ah okay I didn't realize. =P
@TheAmplitwist Sorry I misread what you said, due to the negations. You are correct in what those lines of code do.
 
 
4 hours later…
11:07 AM
@TheSimpliFire: Hi, I saw you retracted your close-vote by mistake. If you want to avoid that, you can try my GM/TM userscript! =)
 
@user21820 Thanks
It doesn't seem like it works for me though.
 
@TheSimpliFire Which step failed?
It works for MartinR and me so I'm not sure why it doesn't work for you.
 
@user21820 Nvm, I've got it now, thanks again.
 
@TheSimpliFire Great! Works now? =)
 

« first day (11 days earlier)    last day (15 days later) »