so i want to apologize briefly there for MS and SD outages being stupid
that was my fault, apparently the 10 seconds it takes for the primary pfSense VM to go down and the other to kick in caused some chaos. And then the second time was switching back to Primary
@ThomasWard You've probably seen it, but FYI: PR: Don't forward non-reply chat messages to MS as comments. I'll probably merge it tomorrow, assuming nobody objects. For things which aren't needed immediately, I usually prefer to have the PR open for at least 24 hours. I also did a couple of other things/PRs while I was looking at that section of the code.
I've #whitelist-ed docker.com and tagged it as #notspam too. Chances are spammers promoting Docker images would be using hub.docker.com (where Docker images go) instead of docker.com itself. At 10 FP/0 TP/0 NAA, I don't imagine this being an issue, but if you disagree, feel free to ping me or remove the tags
@SmokeDetector Possibly bad, but it appears to be someone got the URL wrong and messed up the markdown a bit. Needs Debugging Details, but doesn’t appear to be malicious here
@tripleee @cocomac could you have a look at my comment here and consider adjusting your feedback? It was a chance hit by Smokey, but it's perhaps good to have it recorded somewhere ...
@cocomac Is the detection for which you're trying to prevent docker.com being detected by listed in the description for #whitelisted? The #whitelisted affects only the detections which are listed in its description. If the detection you're trying to exclude docker.com from is not listed there, then adding #whitelisted will be ineffective.
sdc report stackoverflow.com/a/73435551/4657412 "flagged because this user is a known recent spammer and the answer is just plagiarised from stackoverflow.com/a/13679448/4657412 so I don't think it's posted in good faith "
@cocomac Yeah, unfortunately, those descriptions don't format with Markdown. The name of the tag is also confusing, given what it actually does (don't just change the name, as there's code in both MS and SD which relies on the name). There's a considerable amount of work that would need to be done to reorganize things, requiring changes in tags on MS, code on MS, and code in SD to resolve the overall situation.
As the the actual issue you're wanting to address, whitelisting docker.com from "potentially bad IP for hostname in {}" and "bad IP for hostname in {}", there's the WHITELISTED_IP_HOSTNAMES list in findspam.py to which you could add "docker.com". I've gone ahead and done that. It's now in the process of running CI testing.
sdc report stackoverflow.com/a/73437327/4657412 "This looks a lot like attempted spam. With that said, it probably isn't actually spam so I don't know if it's useful to report"
@DavidW I flagged it as spam, best case it is a spam seed (which should get flagged as spam). Sometimes they post something like that and edit in a spam link later, so it could totally be that too, especially b/c it is an answer.
[ SmokeDetector | MS ] Few unique characters in body, no whitespace in body, no whitespace in title, potentially bad keyword in body, repeating characters in title, +1 more (401): Kkkkkkkkkkkkjbnjkkkkkk ✏️ by user41913 on islam.SE
