Vyxal

hyper-neutrino

00:25

@lyxal oh yeah i opened that tab and then forgot about it kek

@lyxal does your PR handle multiple issues being closed at once (unless I'm reading it wrong, it doesn't look like it), and should it?

lyxal

It's for getting the labels of the first issue it sees

And since 99% of PRs only close 1, that's fine

Closing more than 1 sounds like it'd need human attention anyway to choose labels

Steffan

!!/prod

hyper-neutrino

00:41

@lyxal fair enough

this looks fine though, i'll just pull to test lol

Vyxal Bot

hyper-neutrino approved on PR #2 (Lyxal/SE-Bot → Vyxal/SE-Bot)

hyper-neutrino merged PR #2 (Lyxal/SE-Bot → Vyxal/SE-Bot) (Lyxal:main → Vyxal:main): Add Automatic PR Labelling Based on Linked Issues

hyper-neutrino

nvm it's not even syntactically correct

lyxal

ah

dang

hyper-neutrino

just a stray await in a non-async func lol

!!/issue test issue bug enhancement

lyxal

In future, how would I be able to test changes locally?

Vyxal Bot

00:47

Vyxal-Bot opened issue #939 in Vyxal/Vyxal: test issue

hyper-neutrino created branch Vyxal/test

lyxal

aw man

hyper-neutrino

repo is not defined

did you mean pr.base.repo.name

const subres = await gitRequest(`/repos/Vyxal/${repo}/issues`, {

lyxal

Ah I forgot that this isn't the other file

it could very well just be without string interpolation

because it only does stuff on Vyxal/Vyxal anyway

hyper-neutrino

true

but in case we change that in the future this could cause strange bugs that might be hard to identify

lyxal

but if you're changing it in the future, you'll be changing the if statement that checks specifically for vyxal/vyxal

so everything will be changed

hyper-neutrino

00:53

right but if we change that we might miss the part where it doesn't interpolate and just assumes that the check exists

lyxal

fair enough

hyper-neutrino

i should just do `/repos/${pr.base.repo.full_name}/issues`

lyxal

:+1:

hyper-neutrino

oh wait reopens won't work

eh what

fetch is not defined???

did I forget to import it???

how would this not have caused infinitely many issues before

Vyxal Bot

hyper-neutrino opened PR #942 (Vyxal/Vyxal) (Vyxal:test → Vyxal:main): oxford comma lol

hyper-neutrino

00:57

TypeError: Request with GET/HEAD method cannot have body
    at new Request (file:///home/hyper-neutrino/workspace/SE-Bot/node_modules/node-fetch/src/request.js:73:10)
    at file:///home/hyper-neutrino/workspace/SE-Bot/node_modules/node-fetch/src/index.js:51:19
    at new Promise (<anonymous>)
    at fetch (file:///home/hyper-neutrino/workspace/SE-Bot/node_modules/node-fetch/src/index.js:49:9)
    at gitRequest (file:///home/hyper-neutrino/workspace/SE-Bot/src/server.js:396:18)
    at file:///home/hyper-neutrino/workspace/SE-Bot/src/server.js:220:30

lyxal

easily fixed

try now

(I made it a POST instead of GET)

hyper-neutrino

ah

lyxal

gosh dang it

hyper-neutrino

well I got no errors...

422 {"message":"Invalid request.\n\n\"title\" wasn't supplied.","documentation_url":"https://docs.github.com/rest/reference/issues#create-an-issue"}

POST to an issue doesn't seem to work

also I don't think JSON.parse(subres.body) is correct

i think it'd just be await subres.json()

i'm not certain though

lyxal

@hyper-neutrino pretty sure that's what copilot gave me

hyper-neutrino

01:05

@lyxal why POST /repos/Vyxal/Vyxal/issues { number: x } and not just GET /repos/Vyxal/Vyxal/issues/x?

lyxal

confusing documentation

that's why

hyper-neutrino

ah

let me give the latter a try

still nothing?

lyxal

suggestion: while testing, make it work on reopens/closure

hyper-neutrino

hm good idea

ok so it's fetching and mapping the labels properly

oh

oh I see

the labels are being added to the issue and not the PR

lyxal

ah

well

I suppose that would happen if the URL is /repos/${pr.base.repo.full_name}/issues/${issue_number}/labels

hyper-neutrino

01:10

lol, yep

damn

it works

poggers

lyxal

:D

Vyxal Bot

Lyxal closed PR #945 (Vyxal/Vyxal) (Vyxal:test → Vyxal:main): oxford comma lol

hyper-neutrino

alright, only works on opens now, and all other debugging code removed

epic

Vyxal Bot

Lyxal closed PR #945 (Vyxal/Vyxal) (Vyxal:test → Vyxal:main): oxford comma lol

hyper-neutrino

rip everyone's email inboxes

lyxal

01:13

ikr

lyxal

03:02

:D autolabels!

Vyxal Bot

03:19

Lyxal approved on PR #947 (Vyxal/Vyxal)

lyxal

@Steffan when making the increment-decrement-until-false-monographs did you base it on main or my ẇ branch?

because if it's based on the ẇ branch then that's why that happened

the branch network graph suggests you did but I don't know if you did or not

Steffan

I thought I checked out main ffirst

What was really strange is that your commit didn't even show up in git log or git rebase

And then I rebased without changing anything in the rebase file and it added a whole line of zillions of ancient commits

Git and github be weird

Branch network graph?

Where's that

nvm, found it

Vyxal Bot

03:48

Steffan153 opened issue #948 in Vyxal/Vyxal: Fix the ACE that has been here since v2.7.2

Lyxal approved on PR #949 (Vyxal/Vyxal): "You should probably get your git base sorted out lol"

lyxal

@hyper-neutrino I added another label mapping to the bot

could you please update the bot

(I was tempted to use cypp as an acronym for "could you please pull" because I used to use that in the TIO room to ask Dennis to update Keg lol)

hyper-neutrino

04:28

done

emanresu A

08:23

v2.11.2 probably @lyxal?

emanresu A

08:37

Oof, thought I could be clever and use xor to check something was a string, but it's levenshtein distance lol

I probably spelt that wrong

lyxal

08:47

@emanresuA I think so

I'd have to check the list of changes but I think it warrants a third number bump

emanresu A

I checked, there's ten

lyxal

But it depends on what the changes are

There could be 100 changes but if they're all small stuff like documentation changes or tiny bug fixes then it'd only be a third number

lyxal

12:04

!!/prod

Vyxal Bot

12:54

Version 2.11.2

4

Vyxal Bot

13:43

deepsource-autofix (bot) created branch SE-Bot/deepsource-transform-86592c54

deepsource-autofix (bot) opened PR #3 (Vyxal/SE-Bot) (Vyxal:deepsource-transform-86592c54 → Vyxal:main): Format code with prettier

lyxal

11:47pm probably isn't the best time to be mucking around with deepsource

but eh

hyper-neutrino