I have the moderator privileges on Code Review.
Even though it's quite rare that flags appear over there, it is still quite annoying that once I have done my job with a flag and therefore cannot do anything else with it, the flag in the top bar remains there. Why do I have to keep seeing that fl...
I am creating a Code Fix that changes this:
if(obj is MyClass)
{
var castedObj = obj as MyClass;
}
into this:
var castedObj = obj as MyClass;
if(castedObj != null)
{
}
This means I have to do 3 things:
Change the condition in the if statement.
Move the casting right above the if state...
I have looked everywhere online. my teacher seems to be weird with how she wants her coding. This is what she has given as the task to the us students.
You are going to write a Tic-Tac-Toe game. I have provided two of the methods you will need to get you started.
DO NOT wait until the day that...
This is my first attempt at writing a SharedMemory container + allocator. The idea is that I store the container into the memory block and also have the container's size stored before the elements.
What I want to know:
Is my allocator okay?
Is there a better design for the allocator?
Is my vec...
Naming
Yes, naming is hard. However, bad naming is going to make your code prone to bugs (what does k stand for again?), hard to maintain, hard to read, and all sorts of other things.
Style
Poor indentation (which scope does this snippet have?):
if(k==0)
{
query = "DELETE FROM `voters`.`v...
I was reading a Java book and I came up with this kind of problem and I tried to solve it. Here it is,
Problem: Write an application that inputs one number consisting of five digits from the user, separates the number into its individual digits and prints the digits separated from one another by...
So tonight I'm trying to create a chessboard model in javascript that will eventually iterate through some moves of a championship game.
I've created a board object (I think) and a piece constructor. I've also created all the pieces with their correct position on a typical chessboard by rank and...
The following code is used to access a shield which converts settings written over I2C to Servo output.
I make use of the MRAA library since that's the default supported by my hardware.
To prevent my I2C commands from being written all at the same time, I use setTimeout to wait a given amount o...
#include<iostream>
using namespace std;
int &fun() //reference of x being returned
{
static int x = 10;
return x;
}
int main()
{
fun() = 30; // not able to get, what does fun()=30 means?
cout << fun();
return 0;
}
I have the doubt that in order to return reference from a function we...
This is a follow on question from one I asked a few days ago here: Single process blocking queue
Using the comments I determined that there probably isn't a pre-built solution for this and so I have had a go at writing my own implementation using a PriorityBlockingQueue.
In order to avoid prop...
After my Dialogue parser has parsed a dialogue, it needs to be validated. To that end, I have several checker classes that go through the lines of the Dialogue.
These checker classes get huge as I add more and more features to them. Eventually they get intertwined with checks that they're not re...
I'm using SQL Server 2014 with Visual Studio 2013. When I add a new record, identity column (seed 1, increment 1) "ID" increases by 1, and record added to database. My Table consist of two raws:
ID, set identity, seed=1, increment=1
Column1, int
Column2, nvarchar(10), Primary Key
ID Column...
I don't think any of the answers so far (at the time of starting this answer!) have really explained where it's worth using which.
Don't do this:
// Bad code - checks type twice for no reason
if (randomObject is TargetType)
{
TargetType foo = (TargetType) randomObject;
// Do something ...
So, this site is called "Code Review"...
What we do here is... ask for and write Code Reviews, naturally.
However, I feel that there are a whole bunch of different thoughts floating around about what a Code Review really is.
On Code Review, what is a Code Review?
(And what is it not?)
This q...
Challenge description is here need to find the first non repeated character from the string. Please let me know can I improve it.
#include <iostream>
#include <fstream>
#include <string>
#include <map>
#include <cstring>
void findNonRepeatedChar( const std::string& record)
{
auto pred= [&...
Your algorithm is O(n^2), and as much as you can optimize, you can't do better with this.
I don't see any particularly slow path.
I found myself looking for some place to point a new user on why his answer wasn't a good answer. I couldn't find anything except the fairly unhelpful Help page's "How do I write a good answer".
So, I'm putting it to the community. What makes for a good code review? What are the essential parts...
This question is intended to be the counterpart of: Checklist for how to write a good Code Review question
Getting started with CodeReview:
New users often seem to have problems to understand, what exactly is expected from a CR-Answer. Many come from Stackoverflow, others maybe from Programmer...
Basically it's an assessment of code. Good assessments that make statements support their statements with arguments and explanations. Bad assessments just make statements and don't support them in any form.
One might say that their assessment is not a Code Review if it doesn't cover all of the c...
Looking back at some of my last few answers (here and especially here), I started wondering if these answers were good enough.
Allow me to expand: in these answers I went through the code almost line by line, and noted everything that jumped at me; by the time I was done, I already had a quite l...
A good answer is whatever the OP can learn the most from. Depending on the skill level of the OP, either a line-by-line critique or a high-level review could be more appropriate.
Line-by-line critiques
A line-by-line critique is often needed for beginners whose code is too confused or buggy. ...
Here is an example from Hadley's advanced R book:
select <- function(df, vars) {
vars <- substitute(vars)
var_pos <- setNames(as.list(seq_along(df)), names(df))
pos <- eval(vars, var_pos)
df[, pos, drop = FALSE]
}
select(mtcars, mpg:disp)
I am trying to merge this function into...
