Stack Exchange
log in

Pimgd

 Discussion on answer by Flater: Ratio…

Imported from a comment discussion on softwareengineering.stac...
Pimgd
Mar 12, 2019 17:13
With the revision I can properly see the logic now - if scope of all variables is minimized, variables with a large scope are possible sign of issues
Pimgd
Mar 12, 2019 17:13
How is "Wantonly declaring variables in an overly wide scope is often indicative of a developer who doesn't quite grasp OOP or how to implement it." a benefit? Is there a way to rewrite it so it fits as a benefit?
 

 The 2nd Monitor

General discussion about codereview.stackexchange.com - Welcom...
2
5
Pimgd
Dec 13, 2018 11:54
ooh clever
Pimgd
Dec 13, 2018 11:44
it's a question with a followup and no answers
Pimgd
Dec 13, 2018 11:44
what use is an obsolete question
Pimgd
Dec 13, 2018 11:43
6
Q: Van Emde Boas tree -based map in Java

coderodde(Follow-up question: Improved Van Emde Boas tree based map in Java) For the experimental part of my MSc thesis I was working on van Emde Boas tree, and I have this: package fi.helsinki.coderodde.searchheapbenchmark.support; import java.util.Collection; import java.util.Collections; import java...

java tree dictionary
Pimgd
Dec 13, 2018 11:35
@Feeds fails for right hand input
Pimgd
Apr 21, 2017 14:57
You just can't find anything in there
Pimgd
Apr 21, 2017 14:57
user image
Pimgd
Apr 21, 2017 14:56
this is what we had before we started rebase-merging pull requests:
Pimgd
Apr 21, 2017 14:55
rebasing is done to get all the commits of one branch together to prevent a mess
Pimgd
Apr 21, 2017 14:54
and the head
Pimgd
Apr 21, 2017 14:54
user image
Pimgd
Apr 21, 2017 14:51
That's history, e.g. previous sprint
Pimgd
Apr 21, 2017 14:50
user image
Pimgd
Apr 21, 2017 14:50
@holroy The result is something like this:
Pimgd
Apr 21, 2017 13:24
but the crap that you have right there, that reminds me of the few weeks we had git before we started using such a workflow
Pimgd
Apr 21, 2017 13:23
the result is a bouncing tree which turns into a candle stick at the top
Pimgd
Apr 21, 2017 13:23
I've gone for some weird version of git-flow where you don't have a master and a release branch, just master and feature branches and bugfixes and tagged releases, and rebase-merging to get stuff into master
Pimgd
Apr 21, 2017 13:22
I've had the joy of having to come up with a git workflow for our team at work
Pimgd
Apr 21, 2017 13:06
I feel like dispassionate rage helps with reviewing. Just gotta be careful to make sure each of your complaints is valid.
Pimgd
Apr 21, 2017 13:05
In this review: I hate your code style but I'm not allowed to say such things so I bash your consistency instead in the hope you switch to a more commonly used style which is better supported by formatting tools — Pimgd 11 mins ago
Pimgd
Apr 9, 2017 17:43
Woo, over 20k rep
8
Pimgd
Apr 9, 2017 13:15
@JudeNiroshan updated answer with a lengthy blah-blah about big O
Pimgd
Apr 9, 2017 13:00
what's off-topic about it
Pimgd
Apr 9, 2017 12:43
I am writing an answer
Pimgd
Apr 9, 2017 12:38
from the description, first factorize N, then for range (A...B) => factorize and check for duplicates with fail fast
Pimgd
Apr 9, 2017 12:12
bronze You've earned the "programming-challenge" tag badge.
Pimgd
Apr 8, 2017 19:59
huzzah
Pimgd
Apr 8, 2017 19:59
I have just cleaned my keyboard and it works because I can type this sentence
Pimgd
Apr 8, 2017 13:59
It has 100 votes! Truly a magic number.
2
Pimgd
Apr 8, 2017 13:59
100
Q: '100' is a magic number

janosMagic numbers are bad... I totally agree. But there's one magic number I find hard to fix: '100' is a magic number. Consider this code: public double getPercent(double rate) { return rate * 100; } public double getRate(double percent) { return percent / 100; } Sonar will raise 2...

java constants
Pimgd
Apr 8, 2017 13:59
I don't know if this was posted in the chat at some point, but...
Pimgd
Apr 7, 2017 23:01
-1
A: Extracting data from database to CSV

user408495Please help my iPhone with these software and help my iPhone using t the AddThis code of conduct

Pimgd
Apr 7, 2017 23:01
nuke-request
Pimgd
Apr 7, 2017 22:24
Yeah, ideally you could just throw some JSON object at a REST API and pizza would show up at your door 15 minutes later
Pimgd
Apr 7, 2017 22:12
Now I want pizza.
Pimgd
Apr 7, 2017 21:57
Specific concern: Is there still enough "code reviewing" left, or am I just rambling about my own theoretical implementation of a PizzaBuilder?
Pimgd
Apr 7, 2017 21:56
0
A: Pizza lover program with Builder Pattern of GoF

PimgdI think you model the domain wrong. A recipe is a list of instructions with a list of ingredients. What kind of recipe it is does not matter. The "cheeseyness" of a recipe does not matter for the class. So I think there should only be a Recipe class, of which there are two instances, namely a m...

Pimgd
Apr 7, 2017 21:56
looking for review-review:
Pimgd
Mar 23, 2017 16:50
Deleted messages?
Pimgd
Mar 23, 2017 15:45
@CaptainObvious Here we are
Pimgd
Mar 23, 2017 15:19
oh wait, you're looking for a parallel algorithm, not a serial one
Pimgd
Mar 23, 2017 15:19
technically speaking, isn't long division that they teach you in school a version of byte-for-byte division?
Pimgd
Mar 23, 2017 13:41
in-b4-my-own-question
Pimgd
Mar 23, 2017 09:02
ITS MY BIRTHDAY
9
 

 2018 Code Review Moderator Election Chat

Open Discussion for codereview.stackexchange.com/election/2
Pimgd
Apr 3, 2018 11:56
where's the vote counter?
 

 The Whiteboard

General Discussion for softwareengineering.stackexchange.com P...
Pimgd
Dec 30, 2016 13:43
which is great, but I'd rather have had new stuff to play
Pimgd
Dec 30, 2016 13:43
I find that somehow I report a ton of bugs and the next releases contain nothing but bugfixes, rather than new content
Pimgd
Dec 30, 2016 13:34
thanks