VBA Rubberducking

12:00 AM

@shadowofsilicon no issue or feature request is too big or too small IMO. Creating an issue doesn't prioritize it. But I'm 99% sure we fix the teardown issues and that one fixes itself automagically.

IvenBach

@Mat'sMug So all businesses want to take over and conquer VBA problems?

Duga

RELOAD!

[rubberduck-vba/Rubberduck] 6 commits. 6 opened issues. 27 issue comments. 6 additions. 6 deletions.

Mat's Mug

Heck, half of @ThunderFrame's issues are crazy edge cases you would never find in real code... right? RIGHT??

Yet they all indicate a problem with X or Y or whatever

ThunderFrame

@Mat'sMug Heck, half the questions on SO are edge cases...

3

Mat's Mug

the other half are dupes..

ThunderFrame

12:03 AM

I wonder how many VBA tagged questions on SO have a comment like "What on Earth are you trying to do?"

Mat's Mug

2.1.2020:

> Rubberduck.Setup.exe (4.58 MiB) - Downloaded 75 times.
Last updated on 2017-07-31

shadowofsilicon

@Mat'sMug OK. FWIW, I have a growing list of "papercuts" in regards to the UI, but none are worth reporting until It Has Been Decided if the toolwindows are going to be rewritten or not (and I would assume that a rewrite would also entail a redesign.)

Mat's Mug

@ThunderFrame just looked at that question I was trying to clarify earlier... OP deleted it

@shadowofsilicon WPF toolwindows are here to stay. SlimDucky can shutdown and unload+reload with a WPF ElementHost toolwindow, so RD's issues are elsewhere.

IOW #BringThemOn!

shadowofsilicon

Awesome! I didn't want to see them go (and the duckys in them lol)

Hosch250

@ThunderFrame #EdgeCasesAreFun

Like I posted at work yesterday.

ThunderFrame

12:21 AM

@Hosch250 There's a reason RD has the best parser...

3

Hosch250

1:27 AM

@IvenBach I'd better watch out or you'll catch up with me.

My team is switching to C# 7, and I'm partially responsible for getting the team up to speed.

The company wants to hire me with a start date of Aug. 14.

TTWTD.

shadowofsilicon

@Hosch250 Congrats!

Duga

[rubberduck-vba/Rubberduck] Stevefb opened issue #3216: Parse Errors seem to be associated with line numbers on IF blocks

> Not sure if this is related to issue #3012

This code Fails to parse:
```vb
Sub TestRubberduckParsing()
100 If True Then
102 Debug.Print "True"
104 Else
106 Debug.Print "False"
108 End If
End Sub
```

Also fails to parse:
```vb
Sub TestRubberduckParsing()
100 If True Then
Debug.Print "True"
102 Else
Debug.Print "False"
106 End If
End Sub
```

This code Does parse:
```vb
Sub TestRubberduckPar

SlowLearner

@Hosch250 congrats mate

Duga

[rubberduck-vba/Rubberduck] ThunderFrame added label parse-tree-processing to issue #3216: Parse Errors seem to be associated with line numbers on IF blocks

[rubberduck-vba/Rubberduck] ThunderFrame added label bug to issue #3216: Parse Errors seem to be associated with line numbers on IF blocks

shadowofsilicon

1:56 AM

@Mat'sMug Can a mock project be setup to be saved? I.e. project.Setup(m => m.SaveAs(@"C:\Users\Rubberduck\Documents\Subfolder\Project.xlsm"));

ThunderFrame

0

A: Public variable returns empty string

You're dynamically adding a sub routine to the same module at run-time. That will trigger a reset of the project - Ending program execution, and clearing all variables. If you try manually adding a procedure to a running module (in debug mode), you'll get this warning: But you don't get that ...

Mat's Mug

@shadowofsilicon a mock can be setup for anything you need it to =)

shadowofsilicon

I figured as much... then I must keep looking

Duga

2:15 AM

[rubberduck-vba/Rubberduck] retailcoder commented on issue #3216: Parse Errors seem to be associated with line numbers on IF blocks

> Looks like it's the Else statement that's somehow breaking things. I think I see what's going on, the loops and other control flow blocks would be affected... Should be an easy fix (#FamousLastWords)

[rubberduck-vba/Rubberduck] retailcoder added label antlr to issue #3216: Parse Errors seem to be associated with line numbers on IF blocks

SlowLearner

2:35 AM

@Duga @Mat'sMug - glad it makes some sense to you... was driving me nuts for a while ;-)

Duga

2:58 AM

[rubberduck-vba/Rubberduck] retailcoder added label edge-case to issue #3193: SmartIndenter applies inconsistent indent, depending upon line number length

[rubberduck-vba/Rubberduck] retailcoder commented on issue #3193: SmartIndenter applies inconsistent indent, depending upon line number length

Mat's Mug

> // 5.4.2.9 Single-line If Statement
singleLineIfStmt : ifWithNonEmptyThen | ifWithEmptyThen;
ifWithNonEmptyThen : IF whiteSpace? booleanExpression whiteSpace? THEN whiteSpace? listOrLabel (whiteSpace singleLineElseClause)?;
ifWithEmptyThen : IF whiteSpace? booleanExpression whiteSpace? THEN endOfStatement? whiteSpace? singleLineElseClause;
singleLineElseClause : ELSE whiteSpace? listOrLabel?;
// lineNumberLabel should actually be "statement-label" according to MS VBAL but they only allow lineNumberLabels:

Duga

3:35 AM

[rubberduck-vba/Rubberduck] retailcoder commented on issue #3216: Parse Errors seem to be associated with line numbers on IF blocks

> Yup:

![image](https://user-images.githubusercontent.com/5751684/28904777-4af8b732-77db-11e7-8542-442fedd02777.png)

Fix on the way!

[rubberduck-vba/Rubberduck] retailcoder assigned retailcoder to issue #3216: Parse Errors seem to be associated with line numbers on IF blocks

[rubberduck-vba/Rubberduck] retailcoder commented on issue #3216: Parse Errors seem to be associated with line numbers on IF blocks

> Yup:

![image](https://user-images.githubusercontent.com/5751684/28904777-4af8b732-77db-11e7-8542-442fedd02777.png)

<s>Fix on the way!</s> now the fun part...

Mat's Mug

> no viable alternative at input '20 Else'

Duga

4:05 AM

[rubberduck-vba/Rubberduck] hkurando starred us

3

Duga

4:18 AM

[rubberduck-vba/Rubberduck] retailcoder commented on issue #3216: Parse Errors seem to be associated with line numbers on IF blocks

> Ok.. *fix on the way* 😃

![image](https://user-images.githubusercontent.com/5751684/28905823-3cd445ee-77e1-11e7-8bd0-5cae8d49d923.png)

[retailcoder/Rubberduck] retailcoder pushed 15 commits to rd-next (only showing some of them below)

[retailcoder/Rubberduck] web-flow pushed commit 533c3079 to rd-next: Merge branch 'next' into 3127_RenameCasing

[retailcoder/Rubberduck] retailcoder pushed commit 5346d3a0 to rd-next: works with SLL prediction mode

[rubberduck-vba/Rubberduck] retailcoder commented on issue #3216: Parse Errors seem to be associated with line numbers on IF blocks

> The grammar needs to account for line numbers in front of specific tokens - it's highly possible I missed a couple of places you might encounter a parser error caused by line numbers; if so, just create a new issue with a little MCVE like you did, we should be able to easily locate the faulty parser rule.

[rubberduck-vba/Rubberduck] retailcoder created pull request #3217: Parser Fix for LineNumberLovers to merge retailcoder/Rubberduck/rd-next into rubberduck-vba/Rubberduck/next

> closes #3216.

[rubberduck-vba/Rubberduck] retailcoder review_requested pull request #3217: Parser Fix for LineNumberLovers

[rubberduck-vba/Rubberduck] retailcoder synchronized pull request #3217: Parser Fix for LineNumberLovers

[retailcoder/Rubberduck] web-flow pushed commit 1119e64b to rd-next: Adding link to GitHub PR in tag descriptions

[retailcoder/Rubberduck] web-flow pushed commit c3525d29 to rd-next

[rubberduck-vba/Rubberduck] Stevefb commented on issue #3216: Parse Errors seem to be associated with line numbers on IF blocks

> While...Wend?

[rubberduck-vba/Rubberduck] build for commit 5346d3a0 on unknown branch: AppVeyor build failed

BUILD FAILURE!

[rubberduck-vba/Rubberduck] retailcoder commented on issue #3216: Parse Errors seem to be associated with line numbers on IF blocks

> @Stevefb already accounted for, forgot to write a test for it - thanks!

[rubberduck-vba/Rubberduck] retailcoder commented on issue #3216: Parse Errors seem to be associated with line numbers on IF blocks

> Also, With statements.

[rubberduck-vba/Rubberduck] build for commit 47da44b1 on unknown branch: AppVeyor build failed

BUILD FAILURE!

Mat's Mug

4:36 AM

@Duga uh-oh

huh

Duga

[rubberduck-vba/Rubberduck] retailcoder commented on issue #3216: Parse Errors seem to be associated with line numbers on IF blocks

ThunderFrame

@Mat'sMug IIRC, End Sub/Function/Property can also have a line number

Duga

> The new tests pass, but I haven't seen them fail, and won't unless I revert the grammar changes... ugh.

Mat's Mug

hmm, I think not

tries

ThunderFrame

^ End Sub/Function/Property

Mat's Mug

4:40 AM

oh you're kidding me

Y U SO STOOPID

4

damn VBE

ThunderFrame

Sub/Function/Property are all module level declarations. Module-level Declarations can't have line-numbers.

Mat's Mug

thought End Sub/Function/Property was also module-level

that's a nice place to hide an easter egg actually

nobody will have a line number on the line End Sub is on.... right?

ThunderFrame

except for those vbWatchdog line-number junkies

Mat's Mug

does vbWatchdog even put line numbers there?

I honestly wouldn't have dared

knowing Sub Foo() couldn't have them

ThunderFrame

@Mat'sMug I'm pretty sure VBE's parser scans all of the declarations sections, and the Sub/Function/Property declarations, and then parses the procedures in each module.

Mat's Mug

4:48 AM

yeah. hand-crafted.

Duga

[rubberduck-vba/Rubberduck] retailcoder synchronized pull request #3217: Parser Fix for LineNumberLovers

[retailcoder/Rubberduck] retailcoder pushed commit a027ec25 to rd-next: added more tests. parses line numbers on End Sub|Function|Property.

[rubberduck-vba/Rubberduck] build for commit 47f3063b on unknown branch: AppVeyor build failed

BUILD FAILURE!

Mat's Mug

#TIL #VBA code can have line numbers in front of "End Sub|Function|Property". Anyone doing that? Why? https://t.co/qRzyRVvHRf

Tweeted by rubberduckvba on August 3, 2017 at 4:58 AM

Duga

5:17 AM

[rubberduck-vba/Rubberduck] retailcoder synchronized pull request #3217: Parser Fix for LineNumberLovers

[retailcoder/Rubberduck] retailcoder pushed commit 2c91340b to rd-next: revert QualifiedContext non-null MemberName for module declarations

[rubberduck-vba/Rubberduck] retailcoder commented on Rubberduck.Parsing/Grammar/VBAParser.g4 of pull request #3217: Parser Fix for LineNumberLovers

[rubberduck-vba/Rubberduck] build for commit 2c91340b on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] retailcoder closed issue #3216: Parse Errors seem to be associated with line numbers on IF blocks

[rubberduck-vba/Rubberduck] retailcoder merged pull request #3217: Parser Fix for LineNumberLovers from retailcoder/Rubberduck/rd-next into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] web-flow pushed commit 7d9584d1 to next

Parser Fix for LineNumberLovers (#3217)

* removed unused ParserState ctor parameter

* updated assembly version

* fixes #3216

* works with SLL prediction mode

* added more tests. parses line numbers on End Sub|Function|Property.

[rubberduck-vba/Rubberduck] retailcoder published prerelease Rubberduck-v2.1.2031

[rubberduck-vba/Rubberduck] retailcoder created tag Rubberduck-v2.1.2031

[rubberduck-vba/Rubberduck] build for commit 7d9584d1 on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] retailcoder commented on issue #3216: Parse Errors seem to be associated with line numbers on IF blocks

> @Stevefb release 2.1.2031 is here!

SlowLearner

@Mat'sMug Windows seems to find Rubberduck to be a threat... keeps trying to protect me from it :-(

Mat's Mug

5:32 AM

@SlowLearner github.com/rubberduck-vba/Rubberduck/issues/1741

?

github.com/rubberduck-vba/Rubberduck/issues/1406

SlowLearner

Yup... didn't think to make an issue out of it...

oh... #1741

Mat's Mug

microsoft.com/en-us/wdsi/filesubmission

@SlowLearner submit the installer there ^

SlowLearner

@Mat'sMug Yup trying to do that but... Gah!!! I hate MS. Detection Name is a mandatory field but I am unable to find the detection name by following the instructions here: docs.microsoft.com/en-us/windows/threat-protection/…

Mat's Mug

what threat is it "finding"?

SlowLearner

Not sure - I clicked through to the run anyway option. Looking at my FULL HISTORY for scans and it is empty...

basically the system does not work

But the good news is that all my line numbers are happy :-)

2

And when I click 'more info' I get this...

OK done - I just used N/A as the detection name... stupid MS

BTW latest release reached 'Ready' status in ~22 seconds

Mat's Mug

5:56 AM

run a scan of your downloads folder

@SlowLearner what was it before?

SlowLearner

@Mat'sMug I'd need to download an old version to check, new PC etc...

Mat's Mug

but is 22 seconds better or worse than before?

SlowLearner

No

Mat's Mug

I bet it's faster without the line numbers

SlowLearner

This seems to include Code Inspections as well? Previously I could wait (I think) more than a minute for that

Mat's Mug

6:00 AM

inspections run on every successful parse, unless you've set them not to

also there are now over 50 inspections

SlowLearner

@Mat'sMug yeah +50 is pretty awesome, no doubt about that :-D Ok... can look at this some more. Reparse takes 22 seconds BUT from the time I open the IDE to I can see the results of code inspections is just under 120 sec. Might be some other stuff going on.. also have MZ-8 running

@Mat'sMug no threats

Mat's Mug

MZ shouldn't be interfering

@SlowLearner dafuq

Duga

[rubberduck-vba/Rubberduck] ThunderFrame commented on issue #3175: Inspection for redundant instruction separators

> It seems 0 is sometimes a token because when used in the statements On Error Goto 0 and Resume 0, the 0 is treated as a keyword, and not as a line-label or integer-literal. Whereas a 0 used in On 2 Goto 2, 0, the 0 is a line-label.

SlowLearner

@Mat'sMug yup... no threats in downloads... it's just blocking you for the fun of it

Mat's Mug

Symantec bribed Microsoft for that. #conspiracy #tinfoilhaton

SlowLearner

6:09 AM

When does the 1st parse take place, sits on pending... is manual?

Mat's Mug

sometimes it starts automatically (as it should), other times it doesn't, for some reason.

SlowLearner

OK... NOT 120 secs... If I hit the pending button as fast as my fat fingers let me it takes ~42 sec from the time I press Alt+F11 until Rubberduck reports ready

It does not seem to be automatic for me 5 out of 5 times I had to start it otherwise it just stays on 'Pending'

Mat's Mug

@SlowLearner an empty project goes from Alt+F11 to 'Ready' (with automatic parsing) in ~10 seconds here

SlowLearner

Hmmm well mine is far from empty - 26.3k lines of code and going down... :-)

Mat's Mug

how many inspection results?

Duga

6:18 AM

[rubberduck-vba/Rubberduck] MDoerner commented on Rubberduck.Parsing/Grammar/VBAParser.g4 of pull request #3217: Parser Fix for LineNumberLovers

[rubberduck-vba/Rubberduck] retailcoder commented on Rubberduck.Parsing/Grammar/VBAParser.g4 of pull request #3217: Parser Fix for LineNumberLovers

[rubberduck-vba/Rubberduck] retailcoder added label edge-case to issue #3185: Parser need to be able to handle negative line numbers, and then inspect for them

SlowLearner

@Mat'sMug Out of the box there are:

- language 179
- Maint & Read 74
- Code Quality 393

But, I am expecting there to be a few false positives... I'll document them soon and let y'all know how to reproduce if I can figure it out.

Duga

[rubberduck-vba/Rubberduck] retailcoder commented on issue #3184: Expressions need type annotations in the parse trees

> The Rubberduck.Parsing.Preprocessing namespace quite possibly includes a lot of reusable stuff, especially for evaluating If conditions.

Mat's Mug

@SlowLearner we're running short on false positives these days ;-) ...IllegalAnnotation has one, and don't run the quick-fix for MissingAnnotation/MissingAttribute inspection results.

ThunderFrame

@Mat'sMug I'm yet to raise an issue, but I got an inspection for a 2 digit line-number the other day - something like use meaningful line-label.

Mat's Mug

@ThunderFrame IMO line numbers should be at least 3 digits

ThunderFrame

6:29 AM

@Mat'sMug I like the 0 digit ones

2

Mat's Mug

LOL

me too!

Duga

[rubberduck-vba/Rubberduck] retailcoder commented on issue #2992: Never assigned / used inspection false positive MCVE

> no repro, 2.1.2020

[rubberduck-vba/Rubberduck] retailcoder closed issue #2992: Never assigned / used inspection false positive MCVE

[rubberduck-vba/Rubberduck] retailcoder closed issue #1387: Resolve: implicit variable creation

[rubberduck-vba/Rubberduck] retailcoder commented on issue #1387: Resolve: implicit variable creation

[rubberduck-vba/Rubberduck] retailcoder commented on issue #2171: False Inspection when procedure scoped variable name matches class member name

> no repro with 2.1.2020, probably resolved well before that.

Mat's Mug

the only known false positive is IllegalAnnotationInspection, if you don't count the DefType issue with VariableTypeNotDeclaredInspection.

@SlowLearner ^

77 closed issues with "false positive" in them.

TTGTB

ThunderFrame

@Mat'sMug I suspect that search returned some false positives

Mat's Mug

@ThunderFrame lol, it did!

Duga

6:47 AM

[rubberduck-vba/Rubberduck] retailcoder commented on Rubberduck.Parsing/Grammar/VBAParser.g4 of pull request #3217: Parser Fix for LineNumberLovers

Mat's Mug

</mug>

Duga

8:41 AM

[rubberduck-vba/Rubberduck] MDoerner commented on Rubberduck.Parsing/Grammar/VBAParser.g4 of pull request #3217: Parser Fix for LineNumberLovers

M.Doerner

8:59 AM

@ThunderFrame Did the line number have a colon following it?

Kaz

10:51 AM

Just a WTF moment today:

Somehow, someone managed to super-position 2 Word tables on top of each other in a document. I was highly confused when I deleted the contents of a cell, only to find them still displaying. Deleted the entire table, and there was an entire other, identical table underneath it.

Vogel612

Ctrl+C,Ctrl+V displaces the tables, right?

Kaz

@Vogel612 It should, or it should put a table-inside-a-cell that displays in a big, weird, obviously-wrong way.

Duga

11:11 AM

[rubberduck-vba/Rubberduck] daFreeMan commented on issue #3213: Add-in Unload Issues: Incomplete Unload, Crash on Exit Possible Cause, Unhandled Exceptions on Reload & Lack of Debug Logging

> @PowerAccess - OK, I came off as (quite) a bit of a jerk there. My apologies.

I've spent quite a bit of time hanging out in [chat](https://chat.stackexchange.com/rooms/14929/vba-rubberducking) with the devs and I know these issues have been a real thorn in their side for quite a while and they're working hard on it. I was feeling rather defensive.

The link to the 2.0.13 release page has the list of known issues right there at the top, so that's why I linked there. The crashing has been

Transcript for