> @daFreeMan I'm not sure what you mean. I was just saying before I appreciated how quickly you responded to the length report of various issues/suggestions/concerns. So thanks again for that 😃
> @daFreeMan I'm not sure what you mean. I was just saying before I appreciated how quickly you responded to the length report of various issues/suggestions/concerns. So thanks again for that 😃
Ah, I see, I thought might have just been wrong link. I didn't find one clear unload-specific issue in cursory search either, so release notes make sense.
> Ah, that would do it! :smile: Can the toolbar be added permanently instead and/or with default placement into existing toolbar row, if no other major reasons preventing that?
@BrandonBarney thank you for understanding the sequence @IvenBach I was attempting to solve an education proble. For I forgot which issue raised by someone who wanted help with access and specified the training expected so I suggested this model to go about it.
@Mat'sMug - While trying to embed a PowerPoint slide in a WinForm, I found this SO answer that grabs an existing PowerPoint application, and reassigns its parent window to the WinForm.
You can just run PowerPoint, get the windows handle, and set a new parent window using the SetParent function.
All you need is the name of the window class of the PowerPoint window, but thanks to Spy++, this is no big deal.
Here's a screenshot of PowerPoint running 'inside' of a custom ap...
made me wonder whether RD could use a trick like that. i.e. ToolWindow content could be a completely different application.
> Here's a list of tokens (in their original order) extracted from an Excel 2013 32-bit memory footprint (using HxD)...
Presumably a 64-bit host would add `LongLong`, `CLngLng` and `DefLngLng` to the list.
IDK why `0` is a token...
**EDIT** This list seems to exclude `Format`, `Debug` and `Print`
```text Enum Object \ . # Module ) Error Integer Long Single Currency Date String Boolean Decimal Array ( , " Me ? 0 Abs Access AddressOf Alias And Any Append
@Mat'sMug If we put a dummy toolbar in the MsoDockBottom window (and set its Left property to the width of the VBE), that forces the bottom dock to be visible...
this is with hard-coded hWnd's, but it gets the job done:
IntPtr bottomDock = new IntPtr(0xE1876);
//Find and Hide the dummy toolbar
IntPtr cmdBar = new IntPtr(0x01D61D96);
Window.ShowWindowAsync(cmdBar, (int)ShowWindowCommands.Hide);
//Create a text box...
TextBox txt = new TextBox();
txt.Enabled = false;
txt.BorderStyle = BorderStyle.None;
txt.Height = 52;
^ and, presto, there's your status bar
2
Actually, make it ReadOnly = true and Enabled = true, and you can then copy the status bar text.
We are basically injecting WPF windows into empty toolwindows. Basically, the DockableWindowPresenter makes the VBE create a window to which we add a UserControl hosting the WPF control.
From debugging the shutdown issue, I get the impression that we have a problem regarding the interaction between GC and COM interop.
At the point of the access violation inside combase.dll, the DockableWindowPresenters have not been finalized. However, the VBE has already been unloaded.
My guess is that something tries to access a something in the VBE via COM interop way too late.
I am converting below excel formula to VBA code and it works as required.
=IFERROR(IF(A2="NULL",B2*C2,A2*B2*C2),0)
Could someone please review and suggest if any changes are required in terms of handling errors.
What the code does : If there is an error it returns '0' else executes the code....
@M.Doerner oh, I thought the WPF was loaded in a document inside the ToolWindow. The SetWindow approach is, I think, different, in that the childWindow isn't a control of the ToolWindow, but is just sharing the ToolWindow as a parent.
@Mat'sMug WTF RD is making my code worse ;-) Yesterday I had 393 code quality issues, now (after fixing many of them based on RD suggestions) I have 405 code quality issues!!!
2
I guess this is the step backward that goes with the 2 steps forward :-D
Yup - I changed a lot of them... It is going to take me a while to test the code and make sure everything is still working. But, I have to say RD has come a long way with inspections :-D Awesome stuff :-D
@ThunderFrame Is what you suggest the following? Let the presenter create the window; get its hWnd; create the WPF window; set the parent of the WPF window.
@SlowLearner We now have conflicting inspections, just as R#. Namely, there is an inspection for implicit ByRef and one for redundant explicit ByRef. In case the ByRef is implicit, the can be ByVal inspection may trigger as well.
@IvenBach theoretically better solutions have been proposed and will be worth considering once they have withstood the test of time (i.e. “5 to 10 years in the field, and not broken yet”). Yeah, don't use this until someone else has used it for 5-10 years and proven it's OK. Who is the first guinea pig?
@M.Doerner Yeah I figured it was something like that, although I had started to get the feeling that RD was smarter than that ;-D
Either way, it's good. Makes me think a little deeper about the code, what is happening, is it the best way - can it be better... so the way I look at it I now have 13 more points of focus!
@SlowLearner You're supposed to make your style choice: I want to allow implicit ByRef, or I want to make it explicit. If you choose to allow implicit ByRef, then you globally ignore the Implicit ByRef inspection. If you want to explicitly declare it, then you globally ignore the Redundant ByRef inspection.
I see that v2.0: 75% there post mentions Autocad and there is an AutoCADApp.cs file, but I can't seem to find a reference for using Rubberduck outside of Office, under some random host application. There is this Adding a new Host Application to Rubberduck but that is already done for Autocad.
Us...
@FreeMan FWIW I tend to always value Explicit over Implicit. For me, it makes my code clearer and easier to understand. If I am debugging and I see an Implicit reference, I immediately now that it could be the cause of the bug, versus having to follow the reference back up the chain to see if the Implicit scope is what I intended.
Using Autocad 2015 here; running the commands and adding the install path to trusted paths does not seem to help, and by that I mean that the menu does not show up in VBA ide. — Nicu Tofan1 min ago
@Mat'sMug At the risk of abusing the terminology, there's no way to recursively join things together in SQL, just recursively union them, right? I get that joins are happening, but what I'm asking is, there's no way to expand your query results horizontally instead of vertically?
I even just taught myself Oracle's connect by prior because it didn't have the word union in it, but it's really just a union, so I'm still looking for something different.
@BrandonBarney I think the idea of explicit, especially in Excel, helps users make the distinction between assumption and surety. Having it brought up that 'hey this is an assumption here' instead of silently doing it for them is critical.
@PeterMTaylor I'd seen and/or heard of the model before. Words give me a difficult time and I understand them differently on occasion.
@IvenBach I think it might be a good idea to default "redundant ByRef" to DoNotShow, so that users can get the behavior they like, without having the contradicting results by default. Thoughts?
@IvenBach Exactly why I prefer Explicit. The implicit features of VBA can be helpful (type conversion for example), but at times they can easily trip up a user. I'm the kind of person where I either do it one way, or another. If I start doing Implicit ByVal/Byref vs Explicit Object scope I get thrown off.
Generally it is there for a specific purpose. It reminds me of something a high school teacher taught us. "You now know enough to be dangerous." Sometimes, just because you can see it is thee, doesnt mean you should assume you know how to properly use it.
click Another bit of the abstraction puzzle just went in. `System.IO.File.WriteAllText takes care of several lines of code for you. You don't care how it's done just that you have the method available to you.
@Mat'sMug I was referring to the OSS comment. But that's pretty funny to know still.
Reminds me of the 'Wheel of morality' from Animaniacs.
@Mat'sMug I don't suppose there's any way to speed up a recursive CTE for 10,000 items that would finish in seconds if I just did the same join 8 times?
I just ran one as a test with 10,000 items and it didn't return results after an hour.
(Which makes sense if it's doing the items one by one through the join process, but I'm hoping there's a way to have it do all the first level joins at once, all the second level, etc. Probably impossible since it forbids outer joins)
What version of AutoCAD are we embedding? RD is not working with 2015
AddIns64 was missing (but AddIns64 was present) and I created by hand that key. It complained that Rubberduck could not be loaded so i run the register routines from a command prompt (admin). Now I have following exception. — Nicu Tofan20 mins ago
So I'm thinking about taking what I have now for a fixed number of generations (2) and putting it inside a Do While loop that checks if another loop returns results and keeps looping until no more results are returned.
Ah, crap. I'm not sure which version of AutoCAD we're using interop assembly for... definitely some progress was made though - at least it's trying to load it. I think you can try overwriting the interop .dll's we're packaging with the one you have installed (might screw up the RD install though). Pretty sure it's just a version thing. We need to figure out a better way to do this. — Mat's Mug15 secs ago
@Hosch250 @IvenBach a bit like RD uses public fields in ParserRuleContext to get child nodes. If a later version of Antlr properly encapsulates its fields, we're kinda F'd
Got it to work by replacing Autodesk.AutoCAD.Interop.dll (18.1.49.0) withthe one in acad folder (20.0.51.0). FYI acad.exe refuses to start and cannot attach to process (unrecognized error occurred in the Window Web Services framework).
We need to figure out a way to get the host app dll at run-time.. Problem is that the Run method isn't specified on the interface, so it's really up to the host to provide a way for RD to run the unit tests... I think we're F'd in that department.
> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.InvalidCastException: Unable to cast COM object of type 'System.__ComObject' to interface type 'Autodesk.AutoCAD.Interop.AcadApplication'. This operation failed because the QueryInterface call on the COM component for the interface with IID '{2959C1CC-8577-4EDB-ADDC-6EBBAB147926}' failed due to the following error: No such interface supported (Exception from HRESULT: 0x80004002 (E_NOINTERFACE)).
RD uses Application.Run (in Excel, at least) to invoke the test methods. in AutoCAD it's RunMacro - basically every host has a different way to allow us to run the tests
that's why we need a host app implementation for every host
public class AutoCADApp : HostApplicationBase<Autodesk.AutoCAD.Interop.AcadApplication>
{
public AutoCADApp() : base("AutoCAD") { }
public override void Run(dynamic declaration)
{
Application.RunMacro(declaration.QualifiedName.ToString());
}
}
^ that's quite literally what we do
but at the end of the day we need to call into the exact method that the host Application class is exposing for that
and that's different for every host
Outlook is pretty damn hacked-up
public override void Run(dynamic declaration)
{
// note: does not work. stackoverflow.com/q/31954364/1188513
//var app = Application.GetType();
//app.InvokeMember(qualifiedMemberName.MemberName, BindingFlags.InvokeMethod | BindingFlags.Default, null, Application, null);
//Application.Run(qualifiedMemberName.ToString());
//note: this will work, but not implemented yet stackoverflow.com/questions/31954364#36889671
What we need for the unit tests is a way to invoke/execute a test method synchronously (return to C# calling code only after the call has completed)
The panacea (or Holy Grail) would be to be able to instantiate a VBA class from C# code, and invoke its members through the VBA runtime rather than from the host. That way we wouldn't need host-specific logic to get tests to run
...and they could work in VB6 as well
Hmm I think the Outlook commandbar OnAction hack might work in VB6
anyway there's still a lot to implement for RD to even load in VB6
starting with that persky crash-on-exit
@NicuTofan is your host app cleanly exiting? Some users are having issues on shutdown in some hosts.
start acad -> open drawing -> VBAIDE -> close seems to be clean; the log contains an exception
Unexpected exception thrown in parsing run. (thread 17).;System.Runtime.InteropServices.COMException (0x80010108): The object invoked has disconnected from its clients. (Exception from HRESULT: 0x80010108 (RPC_E_DISCONNECTED))
at Microsoft.Office.Core.CommandBarControl.set_Enabled(Boolean pvarfEnabled)
at Rubberduck.VBEditor.SafeComWrappers.Office.Core.CommandBarControl.set_IsEnabled(Boolean value) in C:\Users\Nicu\Documents\data\prog\3rdparty\RubberDuck\src\Rubberduck.VBEEditor\SafeComWrappers\Office.Core\CommandBarControl.cs:line 40
at Rubberduck.UI.Command.MenuItems.CommandBars.AppCommandBarBase.EvaluateCanExecute(RubberduckParserState state) in C:\Users\Nicu\Documents\data\prog\3rdparty\RubberDuck\src\RetailCoder.VBE\UI\Command\MenuItems\CommandBars\AppCommandBarBase.cs:line 101
When a medical claim is replaced, it gets a new number. The older version is supposed to get cancelled out, but this doesn't always happen successfully yet at my workplace. I wrote this to try to aid in my research by automatically getting the entire tree of claims and their statuses.
However, i...
@IvenBach I assume this is more of a joke that you assumed it was VBA when it was SQL, but what kind of indenting would you hypothetically like to see...?
@IvenBach Ah, is your workplace more of a butts-in-seats gig?
If you're 3 hours before "close", I probably couldn't get off that early, but I'm super lucky, if it's 2 hours before close and I'm basically done being productive, I can go home :)
My dad worked construction installing acoustical dropdown ceilings (think above office cubicles). Early I learned: Do it once, do it right. Along with stay till the jobs done.
@Mat'sMug @NicuTofan IIRC, I couldn't debug or attach to CorelDRAW either. If RD unit tests aren't enabled in AutoCAD, that suggests that RD doesn't recognize that the HostApp is AutoCAD. If the test menu items are enebaled, but running the tests fails, that suggests that the signature for RunMacro has changed.
@NicuTofan Any chance you have access to other AutoDesk/Dassault VBA hosts? It usually doesn't take much to add the PIA and get unit testing working for new hosts.
You can just run PowerPoint, get the windows handle, and set a new parent window using the SetParent function.
All you need is the name of the window class of the PowerPoint window, but thanks to Spy++, this is no big deal.
Here's a screenshot of PowerPoint running 'inside' of a custom ap...
I am converting below excel formula to VBA code and it works as required.
=IFERROR(IF(A2="NULL",B2*C2,A2*B2*C2),0)
Could someone please review and suggest if any changes are required in terms of handling errors.
What the code does : If there is an error it returns '0' else executes the code....
VBA Rubberducking
VBA Rubberducking